- 01 Oct, 2019 40 commits
-
-
Lukasz Anforowicz authored
Bug: 980641 Change-Id: I6dced7cfeb0532afdf9440989bce3afacc426a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833633Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701607}
-
kdillon authored
The console message should point developers towards the status entry for more context as well as some alternative solutions. Bug: 827324 Change-Id: I5043eea620903089000b4dace14fb62403dda342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832660Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#701606}
-
Anastasiia Nikolaienko authored
Account Manager is enabled by default now. Merge ArcAuthServiceAccountManagerTest to ArcAuthService tests. Bug: 912537 Change-Id: Icfe560f097a449ed2e6b62c16b13c3c39ca6a8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824101Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#701605}
-
Nico Weber authored
TBR=hans Bug: 1010111 Change-Id: Ic6fb5a4a1ff065ff1f6fff3c8c0bdf7d8fbdd50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832498Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#701604}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 849670 Change-Id: Ib3d14f2ea1b6e812e5f57bd30d26953a6dba700c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833901Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701603}
-
arthursonzogni authored
This is intented to be merged into M78. Bug 1003167 is intented to be fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1829350/ but we are not confident enough for merging it into M78 beta. A lot of users are triggering this DumpWithoutCrashing(). To save their resources, this patch remove it temporarily. It will be added back with in M79 after a fix is landed. Bug: 1003167 Change-Id: I17abcaebc3a6177c45a193ad47c4c731b340d12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832816Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701602}
-
Koji Ishii authored
This patch changes |NGLineBreaker| to include empty or space- only trailing spans into the line. Such spans were thought not observable, but it turned out that they are in a few cases; e.g.,: a. The space is wrapped in an inline box with borders; e.g., text<span style="border: 1px solid"> </span>text b. When it is not collapsed (e.g., `pre-wrap`) and is in an inline box with background. Open tags are in most cases not-trailable but sometimes they are. Before this change, |NGLineBreaker| assumed open tags are not-trailable, and handles exceptional cases separately. This patch changes open tags to be trailable. Then non- trailable open tags were removed after the line breaking was determined. With this chagne, the rare logic runs only once for each wrapped line. This patch: 1. Split over-loaded `kTrailing` state to `kOverflow` and `kTrailing`. This simplifies the conditions when each state can transit to other states. 2. Re-implemented negative margins[r674177]. The logic became simpler because open tags are now trailable by default. 3. Re-implemented hanging trailing space fix[r674430]. In addition to the fix, this patch handles trailing spaces in a span. We do not handle multiple space nodes yet as in TODO(crbug.com/1009936) comment, but this change moves one step closer to support it. [r674177]: https://crrev.com/c/1684243 [r674430]: https://crrev.com/c/1662451 Bug: 1001241, 1003184 Change-Id: Ife2f8470a510f6e006da9d2397df5c5153e3abd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826063 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#701601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/563255c6577d..2a383228fbdd Created with: gclient setdep -r src-internal@2a383228fbdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id320ae13e6aedfa00c98a705126f13c90fdf8bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833119Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701600}
-
Matthew Mourgos authored
This change unifies the shelf colors by moving shelf color calculation into ShelfConfig, to be accessed with ShelfConfig::Get()->GetDefaultShelfColor(). The base color for the shelf is calculated using colors from AshColorProvider and wallpaper_controller. Bug: 1008700 Change-Id: If25805e613d4f47ecb834ac5a2912b22688fe5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823603Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701599}
-
Pavel Shmakov authored
This is a quick fix. Generally this class can be made less error-prone e.g. by collecting the code that should run only when mView != null into an inner class, where mView would be non-null and final. Change-Id: I69d5beb01baec7f7e8cbec1b3013d461d45d03f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832216Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701598}
-
Xiaocheng Hu authored
https://github.com/w3c/csswg-drafts/issues/94 made a resolution that "Any math expression of a complex type is treated as auto. Simple typed things continue to work as today." This patch adds new tests and revises existing tests to reflect the resolution. Bug: 382725 Change-Id: I522799b51fdd4a7cfa66e137ae31c68aaf2dea73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832619 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#701597}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic45946b3d2af90edfb65ab60cb68de39f985900f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701596}
-
Yi Gu authored
Since we have supported main-thread AnimationWorklet, there is no need to promote the scroll-source automatically for ScrollTimeline. Changes to make: 1. Attaching / detaching animation to ScrollTimeline no longer need to trigger compositing update nor paint property update. 2. Animations with scroll timeline should fall back to main thread when the scroll source is not composited. 3. Now that the scroller is not composited due to ScrollTimeline, it needs be composited by other means to have the fast path tested. Bug: 1008720 Change-Id: I07dbefeb4e16e8be832b354f0a68bfd7cd0f6ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825720Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701595}
-
Koji Ishii authored
Following tests pass now: css/css-text/white-space/pre-wrap-014.html css/css-text/white-space/white-space-pre-wrap-trailing-spaces-001.html TBR=eae@chromium.org, jfernandez@igalia.com Bug: 972992 Change-Id: I932bfdd45302c304e73f938415e8f4aad29e6d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831727Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701594}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in third_party/zlib/google to the recommended methods/types. Bug: 1007842 Change-Id: I45efc78b9138def0469912e5d733dbaeaa652407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832270 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#701593}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010102 Change-Id: Ifa3e4f721180437cf3a3ab303275b0b53318f4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832696Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701592}
-
Lily Chen authored
Fake Gaia sets several cookies, which must be accessible in a cross-site context. Under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure (crbug.com/1002052), cookies must be "SameSite=None;Secure" in order to be available in a cross-site context. This change adds those attributes so that tests relying on Fake Gaia will continue to work when these SameSite features are launched. Bug: 1006816 Change-Id: Ia4508611f59b048392217c63cdd209297b147d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827183 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#701591}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I46f55b80979520453e7e1a9a79592a85735f98cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831944 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#701590}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: Ib35d542205f85f026a1f6df271dbba4c1b6683e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833291Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701589}
-
Tom McKee authored
Since User Timing L3 is the default and we're deprecating L2 support, we can remove the virtual test suite that checks L2 coformance. Bug: 805566 Change-Id: Ie5af7c8b564a1228972257b219d52f1c75525e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763642Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#701588}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ffc2e453b00..a7914a872657 git log 1ffc2e453b00..a7914a872657 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 halcanary@google.com experimental/tools/pdf-comparison: delete worktree when it gets into a bad state Created with: gclient setdep -r src/third_party/skia@a7914a872657 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Icff3b30c15834465206aa25fec65f7b10a9c8980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701587}
-
Lily Chen authored
This replaces two uses of net::CookieOptions where we used to manually set include_httponly and same_site_cookie_context to "strict", with the recently added CookieOptions::MakeAllInclusive(), which does both of those things automatically (and also sets do_not_update_access_time, which doesn't matter because that field is not read for these two usages). There isn't really any reason for this aside from saving a few lines of code for readability and eliminating a member variable. Bug: None Change-Id: I2311e3cb8ea06301deb3eb72d86edfe986e8cf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832302Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#701586}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: If5db6d009c19b97dff86185d62f4ecc414f2fb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833290Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701585}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: Iac97955e581bfbe5091c7cab8ca453fdd63c1c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832693Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701584}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Bug: 929661 Change-Id: Ife3b8bee26e0da433341b138e7c1837d20cc4a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832623 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701583}
-
Jérôme Lebel authored
Removing SyncSetupService::PreUnityCommitChanges() since pre-unity code should be removed. IsUnifiedConsentFeatureEnabled() always returns true. Bug: 951313 Change-Id: If2bb328da4e2d1073b3b21960eefd18ea58498d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831902 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#701582}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: Ifd0d117a1f5ab110acb1456cad577d9394acaf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833287Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701581}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dba6e775bc2b..fc2b2deb2628 git log dba6e775bc2b..fc2b2deb2628 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org run_tests: turn on more tests for python 3 Created with: gclient setdep -r src/third_party/chromite@fc2b2deb2628 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I34c5cf4a44e67fbe35653e4a8f450897c107f6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701580}
-
Ryan Hamilton authored
Fix a P2PQuic test to correctly grok v99 RST_STREAM semantics. Change-Id: I7c200aa575926396f814d3d9de3ca460b3723b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825657Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#701579}
-
Vasiliy Telezhnikov authored
This CL adds PIXEL_FORMAT_XR30 and PIXEL_FORMAT_XB30 formats to VideoPixelFormat which correspond to BGRX_1010102 and RGBX_1010102 in viz::ResourceFormat. Bug: 1005213 Test: MediaColorTest.Yuv420pHighBitDepth Change-Id: Ie06e09c0079cfc7a8f8a892190d56ab8d9c7b126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826981 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701578}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3bb2040a15c..7c079f650def git log b3bb2040a15c..7c079f650def --date=short --no-merges --format='%ad %ae %s' 2019-10-01 eshr@google.com Reland "Fix minor regression caused by a8336d3" 2019-10-01 saza@webrtc.org AEC3: Analyze multi-channel SubtractorOutput in AecState Created with: gclient setdep -r src/third_party/webrtc@7c079f650def If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I83f6c6b6d2b8fb63cae63cefbb9e117c5e5d150f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701577}
-
Gyuyoung Kim authored
DownloadImage_Allow_FileImage has been flaky after merging "Refactor ImageDownloaderImpl::ContextDestroyed slightly" CL. The flakiness can be caused by multiple callback calls between ImageDownloaderImpl::ContextDestroyed and MultiResolutionImageResourceFetcher::Dispose. And also, we need to avoid doing complex operations in a pre-finalizer because it has a risk of resurrecting dead objects. So, this CL moves the call of |image_fetchers_.clear()| to ImageDownloaderImpl::ContextDestroyed again in order to revert the original CL for now. Bug: 1002755 Change-Id: I1e82aa827f7f536c65df2906001672be1b11524f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833025 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#701576}
-
Nick Diego Yamane authored
Currently Gdk backend is auto-selected in Ozone, which leads to crashes when, for example, ozone platform is set to x11 while the browser is being executed in a Wayland compositor (e.g: Gnome/Wayland for example). CL modifies GtkUi ctor to set allowed gdk backends based on the current ozone plarform. Bug: 1008924 Change-Id: I12163357e4d3d517c4c98672ed9db3c064c2d244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829319 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#701575}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/087f1384f233..e49df747da7e git log 087f1384f233..e49df747da7e --date=short --no-merges --format='%ad %ae %s' 2019-10-01 courtneygo@google.com Update expectations for deqp failure Created with: gclient setdep -r src/third_party/angle@e49df747da7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I9226c8b1854b3f399ebb6c32b0e468ccec7bc095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701574}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010037 Change-Id: I96c92b2adf04e076d8785521610102988c17ddd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832691Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701573}
-
danakj authored
The SwapPromiseMonitor was moved to wrap only the call to WillHandleGestureEvent(), but that optionally handles the input event (it is handled for pepper when the mouse is locked). The event is otherwise handled later in the method in the call to HandleTouchEvent() or by calling out to the WebWidget. The SwapPromiseMonitor should be alive during all of these calls. This is a fix for the scope change in https://chromium-review.googlesource.com/c/chromium/src/+/1812915 R=dtapuska@chromium.org Bug: 994926 Change-Id: I3313415b4c8f90ac1b544d10a7bf68833e3ab872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831453 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#701572}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1001364 Change-Id: I84fc313f4e3467a0583119793568e285e987470c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833284Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701571}
-
Jiawei Shao authored
We create new server Dawn Device for every requestAdapter() but don't create an analogous client Device. The result is that there are multiple dawn_wire::Servers and only one dawn_wire::Client which have completely different namespaces for ObjectIds. Multiple calls to requestAdapter(...) replace the Server device and messes up object lookup. This problem was discovered when rolling tests in the WebGPU CTS into Chromium. Currently we only have very basic tests. This is a temporary fix so that so we can roll a more complete test suite before making further changes. BUG=chromium:996713 TBR=kbr@chromium.org Change-Id: I172bf948a8e61bd7149ac2e5bf6d528db53dd7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832777Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#701570}
-
Stepan Khapugin authored
Adds |window| property to SceneState. It is backed by SceneDelegate's |window| property and by UIWindowScene's |scenes| property on iOS 13 with multiwindow; or with an ivar otherwise. When it's an ivar, SceneController is now responsible for window creation. Note that the getter for AppDelegate's window remains for iOS 12 compat. Note that the window is always a ChromeOverlayWindow. have tested it manually on my machine and it still works) Bug: none Test: verify that the incognito screenshot blocker works as expected (I Change-Id: Ic418ece228854e43aa0e4c9d9e503c1b54bca901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827373 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701569}
-
Evan Stade authored
The passed profile always matches |profile_|, so just remove it. Bug: none Change-Id: I29940c6ab54e9e9dbd7b1ed1833ab8893a2212d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832611Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#701568}
-