- 17 Jul, 2020 40 commits
-
-
Noel Gordon authored
Patch 3 / 3: menu and submenu margin-top in files-ng is handled by menu JS files. These files-ng specific CSS rules are now unused: ditch them. Bug: 1066727 Change-Id: I1f64f5df9b5d336bfb5edc94acf7ac58a042a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301715 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789367}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..0e82586297a8 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I74abe18089392ee45812ce6f2a66537aac6db4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789366}
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: Ib0102bd587f2947f591babe9e1deee4e50c8e6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298786 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789365}
-
Xianzhu Wang authored
When we paint selected text in vertical mode, we need to rotate the selection rect because we are under a rotation transform. Bug: 1106205 Change-Id: I148e2bf7a7b8e2e90a8d48f483d16a73d16200c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303878Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789364}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I647e3bf28628e03138dad0419358d47bd81a76d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304329Reviewed-by:
-
Mansi Awasthi authored
This CL removes the creation of span of page objects for AddRemainingAnnotations() method in PdfAccessibilityTreeBuilder class. Change-Id: I6a70fa70c40503a92be26857cc88bbd7ecd0b7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279424 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#789362}
-
Noel Gordon authored
Patch 2 / 3: next in the code flow that shows a menu, we must position the menu using a getComputedStyle done internally by cu.ui positioning code. Just before that style recalc, set the menu's margin-top: 8px in inline style. The inline style overrides all CSS and all action-bar menu's of files- app have 8px margin-top as a result (to provide tap-target gap). Bug: 1066727 Change-Id: Ie6e7a651d8bb974dc71581d460e04debb60892c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301713 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Maggie Cai authored
To support sharing, we added action condition in the intent filter. However this will be inconsistent with the stored preferred apps (contains intent filters). This will cause filter matching issues when we try to modify or delete preferred apps entry. This CL adds the support to upgrade the preferred apps if the flag is on. BUG=1092784 AppServiceImplTest.PreferredAppsUpgrade. Test: Unit test PreferredAppsConverterTest.UpgradePreferredApp and Change-Id: Ib6fb3e4d6128b7c2f83a63cac73d800993a4b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301549Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#789360}
-
Mingjing Zhang authored
This CL adds CompositorLatency.TotalLatency to replace the pipeline:* breakdowns that are to be removed in the benchmark report. Bug: 1078160 Change-Id: I22241a5903d3b122c3e92cc80a1a019e697444e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211918Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789359}
-
Mohsen Izadi authored
In order to be able to compare new EventLatency metrics with existing LatencyInfo-based metrics (Event.Latency.*) for scroll events, we need to measure latency from when the event is created until when gpu-swap has started. Instead, we were incorrectly measuring that latency up to when gpu-swap has ended which is not what existing scroll latency metrics report. This CL deprecates incorrect metrics and replaces them with correct one. This CL changes both UMA and UKM metrics for this. The UKM privacy doc is updated: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 1079116 Change-Id: I7900e3eca397f863fdba975a2ff7df66f5e08460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280423Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789358}
-
Ben Mason authored
This is a noop since UseDownloadOfflineContentProvider is set as enabled in fieldtrial_testing_config.json, so useDownloadOfflineContentProvider() always returns true and exits the test immediately. Disabling the test to prevent test failure on release testers, where fieldtrial_testing_config.json is not used and causes this test to fail. If this test is needed, can it be fixed up and re-enabled. Bug: 1106460 Change-Id: I0986131275f490ec9e75b26790e9aaaa07f172ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303787Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#789357}
-
Mike Wasserman authored
This single bit exposes whether the device has multiple screens. It informs the value of permission prompts to request more information. This CL adds the IDL, IPC, implementation, and testing. Add a mojo struct for GetDisplays results; reject on failure. Test with the DevTools console (and multiple screens) with: chrome://flags#enable-experimental-web-platform-features Bug: 1098861, 1080710 Test: window.isMultiScreen() works as expected Change-Id: I5d5d86716f1910bfc4ddc5dc70faef252b831a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278529Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#789356}
-
Aleks Totic authored
Does not fix the layout, but it prevents the DCHECK. Prcentage padding can cause negative widths in Legacy table layout. With TablesNG shipping soon, it is not worth investigating root cause. This clamp just prevents the DCHECK, and is not going to make anything look worse. Bug: 1105900 Change-Id: Id68369dbb906fa62238c71f83b7b87ac3743917a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303564Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789355}
-
Dylan Cutler authored
This allows us to instrument navigator.languages using this annotation for the identifiability study on which Chromium APIs leak information about users' cross-origin identity. Bug: 973801 Change-Id: I6d3fcf3b193ce34b799e2312172ee4c9e3908e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297683 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#789354}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3164b4494fba..d72cb4c076b7 2020-07-17 csmartdalton@google.com Mixed samples/conservative raster cleanups for tessellation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I1b043867b13add22d5a1df3dbbb3f047dcc07694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304192Reviewed-by:
-
chrome://media-appTrent Apted authored
Previously it used a return value, but that caused increased coupling. Just move the updated file properties into the AbstractFile which can already represent what's needed. Bug: b/161108779 Change-Id: I6dc4d2e889b8c6d3247af00fa613a8c768f27171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300901Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#789352}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic4578505f7f368f2e4982208de94569de6c240d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304191Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9e0980bb3d0e7f09e97ffb26fad4a37be279c53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303287Reviewed-by:
-
Nate Chapin authored
If PolicyGetter() is not initialized, it can be nullptr. This was regressed in https://chromium-review.googlesource.com/c/chromium/src/+/2293475, which removed a special-case in OriginTrialContext which declined to initialize the TrialTokenValidator if there was no PolicyGetter(). Now, we always create the TrialTokenValidator, but it will early-exit with status kNotSupported if the PolicyGetter() isn't available. Bug: 1106240 Change-Id: I4a1188e3866ba225b380c761bd444225c744b719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303560 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#789349}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4c3be736312..df50009d3ede 2020-07-16 lalitm@google.com test: update diff testing script to Python3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic7c5085e264bf9a900b7efe68553c222971ae183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303867Reviewed-by:
-
Philip Rogers authored
The main idea in this change is to use the layerization algorithm from CompositeAfterPaint to create cc::Layers from the paint chunks within a GraphicsLayer. PaintLayer is a requirement for creating a GraphicsLayer, so this is the first use of the CompositeAfterPaint architecture to composite content without a PaintLayer or GraphicsLayer. This is limited to SVG subtrees by only doing this for SVGRoot GraphicsLayers, which are now created if SVG descendants have compositing reasons. This has been implemented behind an off-by-default runtime flag: CompositeSVG. Changes: * Will-change and animations set direct compositing reasons in SVG. This is used to build property trees that support compositing. * LayoutSVGRoot creates a PaintLayer. It is non-self-painting if there are no compositing descendants, and self-painting otherwise (to composite). This is needed because PaintLayer existence needs to be decided before subtree compositing reasons are known. Code has been added to maintain a bit on LayoutSVGRoot for whether there are composited descendants. * LayoutSVGRoot creates a GraphicsLayer if there are compositing descendants via LayoutSVGRoot::AdditionalCompositingReasons. This limits post-paint layerization to the subtree below SVGRoot. * PaintArtifactCompositor::LayerizeGroup looks inside GraphicsLayers and, if |ShouldCreateLayersAfterPaint()| is true, creates PendingLayers for each paint chunk with compositing reasons. * GraphicsLayers determine if they layerize after paint by looking for direct compositing reasons on chunks within the layer. This is cached. * GraphicsLayers that layerize after paint do not finish their paint controller until after PAC::Update, to ensure raster invalidation data is available in PAC::Update. Bug: 1101002 Change-Id: I029d4d6c39dd89dbfe8f04a9e192fe5dd499e9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250514 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#789347}
-
nohe@chromium.org authored
The read file and copy to clipboard method was moved to a public method so we can utilize this tool in other contexts. We want to implement this method in the files app so we can copy images in the files app directly to the system clipboard. BUG=827333 Change-Id: I11d1429f48b3a087ad7f5251b8ca44dd81c0c75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273298 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#789346}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c15c6eb9d8c3..e8e089ad282e 2020-07-16 enga@chromium.org Add missing headers to BUILD.gn and CMakeLists.txt 2020-07-16 enga@chromium.org Validate 1D texture bindings cannot be multisampled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1104737 Tbr: cwallez@google.com Change-Id: Ie809450969837e05a6c4e46ad75d85f1a9f8983f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304132Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ia672fcc1b00bf20447673c3b4c206e0ec83e5af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303786Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789344}
-
Kent Tamura authored
This CL removes LayoutObject::IsLayoutButton(), which check if |this| is a LayoutButton, and adds LayoutObject::IsButtonOrNGButton(), which check if |this| is a LayoutButton or a LayoutNGButton. Also, this replaces existing callsites of IsLayoutButton() with IsButtonOrNGButton(). This CL has no behavior changes because LayoutNGButton is no used yet. Bug: 1040826 Change-Id: I92f052d50a6467ea2d1c86c4e75d3d68db8a75cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302975 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/820021d24600..0c5f244817c2 2020-07-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 46d8bf63..d8502113 (789115:789218) 2020-07-16 auorion@microsoft.com Implement Source enumeration and selection for WGC capturer 2020-07-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ef63f40c..46d8bf63 (789011:789115) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I986c21f584ba4d8d37b8113a61e9b54ebaaf245a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303864Reviewed-by:
-
Scott Violet authored
Storing thumbnails was removed from this code a long time ago. The only non-rename change is to remove a histogram that was not in histograms.xml, which means it was never really used (History.InvalidFaviconsDBStructure). BUG=1076463 TEST=covered by tests Change-Id: I9dcbbecdfea90e4c8bffa70d6454f9623671a1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302728 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789341}
-
Sara Kato authored
This CL adds a boolean argument to computeAXName(), and it is used when computing the name, when the node is labeled by another node. Without these changes, A11yNodeInfoDatWrapperTest.LabeledByLoop will go through an infinite loop. Also rename "labelled" to "labeled" for consistency. Bug: b:161294907 Test: AccessibilityNodeInfoDataWrapperTest.LabeledByLoop Change-Id: I09f6415064cd0f8a3a159b08c217e4f5784c1528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301555 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#789340}
-
Karandeep Bhatia authored
A lot of the functionality of InfoMap is now unused since we have been moving stuff off of the IO thread. Remove the unused functionality. This also reveals a lot of missing includes. Fix those as well. BUG=980774, 1101364 Change-Id: Ifc668d9cd03887e84d2d82d8578dce1df9bf564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285911Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789339}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I279692f3d85b11268567306c60d3576fead71733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303866Reviewed-by:
-
Ben Mason authored
Test was passing in debug because of fieldtrial config. It's not read in release as per: https://source.chromium.org/chromium/chromium/src/+/master:testing/variations/README.md?originalUrl=https:%2F%2Fcs.chromium.org%2F Enable commandline flag: UseDownloadOfflineContentProvider Change-Id: If712caa1d7655ef8036ef15cc4b9f06373a0b293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303123Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#789337}
-
Yicheng Li authored
This adds a DBus service provider to enable ChromeOS daemons to call into Ash to start the in-session user authentication dialog. The dialog will be implemented in Ash. Currently the only expected client is u2fd, which needs this UI flow in WebAuthn. TEST=Used u2fd to call UserAuthenticationServiceProvider and verified it received the call by logging. Cq-Depend: chromium:2291256 Bug: b:144861739 Change-Id: I47c6b88f2eb4484cef197a009e6ad5bbc4b3e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291258Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#789336}
-
Mansi Awasthi authored
This CL creates choice field nodes using PdfAccessibilityChoiceFieldInfo sent from plugin process and inserts them in the PdfAccessibilityTree. This CL also includes test to validate the creation of choice field nodes in PdfAccessibilityTree. Bug: 1030242 Change-Id: Ia5654344970624b06cd6f352090625dc77007879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287070 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789335} -
Noel Gordon authored
Patch 1 / 3: in the code flow that shows submenu, we must position the submenu using getComputedStyle. Just before that style recalc, set the submenu margin-top to 0 using inline style. The inline style overrides all CSS and all submenu's of files-app have 0 margin-top as a result. In particular, #tasks-menu, #share-menu will no longer accidently get 8px margin-top (issue 1066727#c23). Bug: 1066727 Change-Id: I7620d88b5026a436a94b2d1cdefed5acfa3851f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301610Reviewed-by:
-
Brian Sheedy authored
Follow-up to crrev.com/c/2300801, where it was discovered that the --enable-experimental-web-platform-features flag was no longer necessary in _ContextLost_WorkerRAFAFterGPUCrash* tests. TBR=kbr@chromium.org Bug: 1090480 Change-Id: Iac0c596d83dd9973dfcd71c5777c94e0d188b274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304090Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789333}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I74f0d1fe088c91fd11c8a708baf085ac5436c463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303601Reviewed-by:
-
Noah Rose Ledesma authored
This CL adds a method to the view class called IsRTL that replaces calls to base::i18n::IsRTL() in the view impl. The result of View::IsRTL may be overridden with View::SetIsRTL(). The purpose of this change is to allow views that should always be presented in left-to-right do so with ease. For reference, see the next CL in the relation chain. Bug: 1106037 Change-Id: Ieee3b1667979f9f010ac971bcca3ea4d902f9d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300799 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789331}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None Change-Id: Ia65bacff95aed253d5ef7fd1bb286d0f19723e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302737 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#789330}
-
Jesse Schettler authored
In preparation for updating the API to use a new browser service to interact with connected scanners, move the API to /chrome. Bug: None Test: Perform a scan using the Scan extension No-Presubmit: true Change-Id: Ia19882b349eeec1b33eb14d72337de7849a227ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298043Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Kelvin Jiang authored
Headers enums are borrowed from WebRequest header enums. Bug: 1088103 Change-Id: I1fecac37718a701c2e9e6cf1407505cd203de845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280730Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789328}
-
