- 13 Feb, 2020 40 commits
-
-
Jasmine Chen authored
We need to update 3A states on every result metadata. Previously when the 3A stabilized callback wasn't set, camera 3A controller doesn't update 3A states. This causes the 3A states to be incorrectly cached, which then makes some requests being sent before 3A is actually stabilized. BUG=b:149355851 TEST=Tested on krane by capturing multiple photos and engaged touch-to-focus to ensure it still functions nominally. Change-Id: I43a3ef456a214cefdaf07cfb438c412bf6b5cd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053269 Auto-Submit: Jasmine Chen <lnishan@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#741015}
-
Side Yilmaz authored
WebsitePreference. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates WebsitePreference class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Id29c591cfc6671610b71e4279348968381eb4dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051266 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#741014}
-
Koji Ishii authored
r737232 crrev.com/c/2028876 fixed |PaintTextClipMask|, but it turned out that the fix applies only when |object_has_multiple_boxes| is |true|. To fix when it is |false|, |NGInlineBoxFragmentPainter| needs to pass |descendants| in more cases. To do this, this patch adds a contructor that accepts an |NGInlineCursor| for the current |LayoutInline|. The plan is to pass it around in all cases, but doing so is not included in this patch yet. This fixes paint/background/background-clip-text-inline.html and a few other clip-text failures. Bug: 982194 Change-Id: Id98364d3126660f2bb78c7784aa1a16bc1213640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053633Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741013}
-
Kent Tamura authored
This CL removes all usages of ToLayoutMenuList(), and |LayoutObject:: IsMenuList()|, and introduces blink::IsMenuList(). This CL is a preparation to remove blink::LayoutMenuList. This CL has no behavior changes. Bug: 1040828 Change-Id: I100aabe24298f60bf0dd40c829dce07f60806fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053864 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741012}
-
Mohamed Amir Yosef authored
As explained in the attached bug, this shouldn't have any effect, but this patch improves the readability of the code. Bug: 1051498 Change-Id: I2ed0ba193c10e3225f82fbc5d83aae0876c03ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050472Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#741011}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dd239e7b7edc..3432ad6bc44d git log dd239e7b7edc..3432ad6bc44d --date=short --first-parent --format='%ad %ae %s' 2020-02-13 aerotwist@chromium.org [e2e] Restricts hosted server 2020-02-13 mathias@chromium.org Roll upstream changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@3432ad6bc44d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5dc232df1fd0455ccad6603288ceadeea0a41da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741010}
-
Mohamed Amir Yosef authored
This is to debug to linked issue. Bug: 1044365 Change-Id: I16670f1e2c96bf1ad4832643f496e2eb44202305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050502 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741009}
-
Zinovy Nis authored
Change-Id: I78f1987c4f1ad1c793eafad34f995ea6d01e6e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044280 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#741008}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/974547616075..5499024e2831 Created with: gclient setdep -r src-internal@5499024e2831 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifc9ab910a4c5c8aaf5327ad896c3483c152e920c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054066Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741007}
-
sandromaggi authored
If we catch a navigation while starting, we delay showing the message until after the navigation is over. Before this change, the delayed start was gated behind the |kAutofillAssistantChromeEntry|. With other features relying on this behaviour as well, the requirement has been lifted. Bug: b/148844097 Change-Id: I34ac12b7f2d4ff9bd71f6e2145846634fbb6fbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050275Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#741006}
-
Dominik Röttsches authored
Include /product/fonts directory for scanning for local fonts. Since this is a change in what directories we are indexing, add a suffix to the Android build fingerprint so that a reindexing is triggered. Because after this change the previous build fingerprint that was persisted to the cache file does not match, a reindexing is triggered and the newly read font metadata is written to the same cache file, overwriting the old data, and storing it under the suffixed fingerprint. Manually tested using a page that includes "Google Sans" font using Google Fonts' CSS and confirming that the local font is used via DevTools chrome://inspect. Bug: 939729 Change-Id: Ic190b116c1395aa573382c33d9266af8a75d6535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050370Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#741005}
-
Fergal Daly authored
https://crrev.com/c/2006890 parameterized a bunch of tests but the filters were not updated. TBR=rakina@chromium.org Bug: 981339 Change-Id: I2fab73269e3e175afac1a6d1f48f560e8c633016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053945Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#741004}
-
Hitoshi Yoshida authored
We had an issue in generating code for a typedef'ed type contains a typedef'ed member type. For example, we couldn't generate code for typedef (DOMString or BufferSource or NDEFMessageInit) NDEFMessageSource; because BufferSource is defined as another typedef typedef (ArrayBuffer or ArrayBufferView) BufferSource; The example is for a union type, but some other types, i.e. record, promise, sequence, etc. could have the same issue. This CL works for the issue. Bug: 1019126, 1050918 Change-Id: I9f5315f1e1b769bfbd175af8a41e47151ba38297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053653 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741003}
-
Hirokazu Honda authored
The video stream dumped in webrtc scenario may contain video frames whose visible rectangles are empty. VideoFrameProcessors shall ignore the frames, but VideoDecoderClient should count the frames. Therefore, TestVdaVideoDecoder needs to return media::VideoFrame even if PictureReady() returns the empty visible rectangle frame. Since VideoFrame::Create* fails if visible rectangle is empty unless the format is UNKNOWN, we create a temporary dummy frame by CreateFrame() with format=UNKNOWN. Bug: 1044816 Test: video.DecodeAccel.vp9_ksvc Change-Id: I435abd308e0f189989b7dbfbaf1aeab6e58f623b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046623Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741002}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74ab0bffb526..d4be305efbdd git log 74ab0bffb526..d4be305efbdd --date=short --first-parent --format='%ad %ae %s' 2020-02-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6cbb02e0dc93..ac4e1d236088 (2 commits) Created with: gclient setdep -r src/third_party/angle@d4be305efbdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ia53658517dad56f61f08f00053fadb88fe7d2d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741001}
-
Alex Danilo authored
Bug: 992823 Change-Id: I7002df4a6c8d65e0b57ebe8dad9c6e475dbd2adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053676 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741000}
-
Alex Danilo authored
Bug: 992823 Change-Id: I7094e9bbbff566788bc95b618511b55284cd28a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053643Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740999}
-
btolsch authored
Change-Id: I0ffe49f994a3f2094f36544028854b3dcd1e8634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038174 Auto-Submit: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#740998}
-
Henrik Boström authored
This reverts commit a4cdec69. Reason for revert: Speculatively reverting: FullscreenControllerTests are failing after this CL on Linux ASAN (e.g. [1] and [2]) and this CL is changing fullscreen related stuff. [1] https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36919 [2] https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36920 Original change's description: > Fix orientation change test full-screen-orientation-change.html > > There are two ways to trigger fullscreen, either by user activation or by > a user generated orientation change. When we enter the fullscreen mode, > we should not consume the user activation in the browser side when the > fullscreen is triggered by a user generated orientation change, so we > need to set the orientation change flag in the browser side when we are > calling the mock function setMockScreenOrientation through a mojo > message. > > The CL that consumes the user activation on both the browser and > renderer sides when entering fullscreen: > https://chromium-review.googlesource.com/c/chromium/src/+/1903675 > > > Bug: 1046933 > Change-Id: I1eb86205bc82ac237bc12d63bbdb0c8985c06090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026170 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740812} TBR=kenrb@chromium.org,alexmos@chromium.org,lanwei@chromium.org Change-Id: I76212e8f7633537774323776091f16795bc6d46c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054184Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740997}
-
Naoki Fukino authored
Filling the missing comment on the new parameter. This also makes the paramater camelCase to be consistent. Bug: 1040049 Test: Run existing tests Change-Id: Icc3907675d57bb87bd55dfffe02d3e76d6460ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053906Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740996}
-
Colin Blundell authored
This CL moves the special-casing of the legacy Symantec error to have a special support URL from ChromeSecurityBlockingPageFactory to be internalized within the //components-level SSLErrorHandler. The motivation and behavioral impact is two-fold: 1. The support URL should actually *not* be overridden for dynamic interstitials, which have their own custom support URL. By moving this overriding into SSLErrorHandler::ShowSSLInterstitial() this desired behavior is now obtained, as the showing of dynamic interstitials does not go through that code path. 2. Any consumer of SSLErrorHandler should inherit this functionality rather than it being localized in //chrome. Notably, WebLayer will now get this functionality. Bug: 1030692 Change-Id: I5415f90809a88984fa5551490e3ff34d21f92cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044100Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#740995}
-
Eriko Kurimoto authored
This CL adds names to each shared workers in shared-worker-options-type.html. to make the test work correctly. Without this change, 'module' shared workers tests don't actually run. This test would fail without this change when #5258 is implemented: https://github.com/whatwg/html/pull/5258 Bug: 1051779 Change-Id: I7b5ea901b07cfb9f5b73e8948e1e7757ab7c5c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050051 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#740994}
-
Yutaka Hirano authored
In order to deprecate Platform::CreateDefaultURLLoaderFactory, this change removes its call from SVGImageLocalFrameClient. Only data: URL loading needs to be supported by SVGClient, so the WebURLLoaderFactoy doesn't need to load anything at all. Define FailingLoader which fails every request, and returns a factory which creates FailingLoaders. This is based on lukasza@'s work: https://crrev.com/c/1372559 Bug: 1049618 Change-Id: I70beb55830501e5a05b9ae8b604c3f56a0f90601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043259Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#740993}
-
Eriko Kurimoto authored
This CL fixes addressspace-sharedworker-basic.html by giving unique names for each shared workers. Bug: 1051412, 1051779 Change-Id: I7442198738dda6615a6da5d344e9ea9c653790d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050416Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#740992}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so the goal is to delete the Blink-specific histogram helpers and standardize on //base. Bug: 1047547 Change-Id: I6a796dde4437d58b67875edc9b535b761394b509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053966 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740991}
-
matterchen authored
As part of the port forwarding work, when user's interact with the UI the profile preferences for port forwarding should be updated. This CL includes the changes to update the preferences when a user activates or deactivates an existing port as well as unit tests to support. Bug: 848127 Test: crostini_port_forwarder_unittest.cc Change-Id: I42e563056dccd486929f76e757e87429ee8b4847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049149 Commit-Queue: Matthew Chen <matterchen@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#740990}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - use the standardized count helpers where possible instead of using custom counts Bug: 1047547 Change-Id: I4dfd32d321c6afa900fec5506d85c7a94cbfa682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043945 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740989}
-
Nick Diego Yamane authored
After PlatformEvent migration CL has landed (crrev.com/c/2022280), building ui::Events out of XEvents has been moved exclusively to x11_event_translation.{h,cc} helper code. With this change the bogus timestamp correction has been mistakenly lost. This CL restores it as well as adds a unit test to prevent future similar regressions. R=sadrul@chromium.org Bug: 965991 Test: events_unittests --gtest_filter=XEventTranslationTest.BogusTimestampCorrection Change-Id: I238d7dba7586be0dd7cf70475c0705b2303ca225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040563 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#740988}
-
Isabella Scalzi authored
Change Quick View test |openQuickViewDeleteEntireCheckSelection| to check that the next file to be shown in Quick View has loaded in its <webview> before attempting to delete it. This will hopefully fix the "Cannot read property 'contentWindow' of null" error that was seen when running this test on RELEASE bot. Bug: 803259 Change-Id: I950d37f5df045e0f9058e22b26b9a6abe8b7a8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053224 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740987}
-
Julien Isorce authored
There is currently a GetSurface() api but it only gives access to the plane 0. This new api GetPlaneSurface allows to get access to any planes to support YUV formats. Bug: 1043007 Test: ./out/ozone_build/ozone_unittests Change-Id: I4116affcf168cdaeebf3b405234aa3e5f55cc30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032060Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#740986}
-
Yoshisato Yanagisawa authored
Since Chromium officially stopped MSVC support, we do not need to keep these builders any more. Bug: b/78251210 Change-Id: I7d80c1f8c1b107db5b6791603fe750a5f1a71a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053652 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#740985}
-
Henrique Ferreiro authored
//ui/base/cursor/cursor.h has an unused //ui/base/cursor/cursor_size.h include. Bug: 1040499 Change-Id: I26ee59be9b67b2ea07da5efac4aa6b0f6923cc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983168Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#740984}
-
Alexey Baskakov authored
Disable it on Win ASAN only. TBR=groby@chromium.org Bug: 1051777 Change-Id: I950c3301391d3c34c611eb40f768a5aae9f4c1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053265Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#740983}
-
Yuki Shiino authored
Only minor changes. Bug: 839389 Change-Id: Iee8ff27ff2ee0b9066950b36429c5839b4880dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053903Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740982}
-
Kenichi Ishibashi authored
Once ServiceWorkerStorage is moved to the Storage Service, NewVersionId() will become an async operation. This CL is a preparation for the move. ServiceWorkerRegistry::CreateNewVersion() becomes async as well because it depends on NewVersionId(). Bug: 1046335 Change-Id: I223fddffa2a83e2e0f5fdac3335cc937b3bbdbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035824 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740981}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c4a5eb705f5..e9ed65aa1904 git log 0c4a5eb705f5..e9ed65aa1904 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 sque@google.com Add tikuta, <user>@chromium.org to GOMA_OWNERS Created with: gclient setdep -r src/third_party/depot_tools@e9ed65aa1904 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I09a7bf58cf02864cbe0349b161b51daa203e4ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740980}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6e714d975619ce318f1434aeb0be03f6af0c3501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053525Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a733b5b760a..1d1333fcedf8 git log 1a733b5b760a..1d1333fcedf8 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e1ccac7ff9f0..74ab0bffb526 (10 commits) 2020-02-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6cbb02e0dc93..ac4e1d236088 (2 commits) Created with: gclient setdep -r src/third_party/skia@1d1333fcedf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I5e69d41a0d7a920c9076bc34919f2c453f5d4e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740978}
-
Eric Willigers authored
Various tests are moved from hosted_app_browsertest.cc to web_app_browsertest.cc and now also run with the BMO flag enabled. Bug: 1026080 Change-Id: Ie4165aa97b4beac92a62ef0912d2d7c76fbf4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046664 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#740977}
-
Miyoung Shin authored
This CL converts FrameHostMsg_Are3DAPIsBlocked to a sync blink::mojom::LocalFrameHost API call and fetches the top origin from the browser side frame tree instead of untrusted renderer content. Bug: 1041088 Change-Id: Id456ea5aa1743d6b05f51675b97266cf774f4049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049151 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740976}
-