- 19 Jul, 2017 40 commits
-
-
Eric Stevenson authored
This reverts commit c2fadc96. Reason for revert: Added static initializer to MonochromePublic.apk. Original change's description: > Enable bounded mode logging on chrome://net-export. > > There is an option to configure the maximum size of the NetLog. The > default is 100MiB. > > Bug: 679030 > Change-Id: I9260d7ee895d589c4789a350ca4fe1dfc8617b65 > Reviewed-on: https://chromium-review.googlesource.com/571514 > Commit-Queue: Eric Roman <eroman@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487602} TBR=eroman@chromium.org,xunjieli@chromium.org Change-Id: I7d8fb8daee69e381097b441f3ed42bd24ae252d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679030, 746430 Reviewed-on: https://chromium-review.googlesource.com/577197 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487900}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/23c93ef6e3b9..4442d453f570 $ git log 23c93ef6e..4442d453f --date=short --no-merges --format='%ad %ae %s' 2017-07-19 janeliulwq Added testing flag --save-attachments that saves embedded attachments 2017-07-18 janeliulwq Removed public/ in include 2017-07-18 janeliulwq Basic APIs and tests for extracting attachments 2017-07-18 npm Remove JBig2_GsidProc class Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ib054d6b6f2f2f6b3945803e3275752af5ac95939 Reviewed-on: https://chromium-review.googlesource.com/577787 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487899}
-
Donn Denman authored
Updates Contextual Search to correctly handle words in alphabets with unreliable word-break characters. The Android method Character.isIdeographic does not do what I thought it did! Instead we now use a regular expression to scan a string for non latin_basic characters. Also updates the short/long word suppression to be less confusing when applied to non-latin languages. Since these characters in CJKV alphabets are data-dense the shortness rule should not apply. BUG=745970, 746097 Change-Id: I65527c614a2ae3a1e74df90a01f00f5e60fea197 Reviewed-on: https://chromium-review.googlesource.com/576909 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#487898}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5e433d5a..67c78739 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iadbd8c3a56bd580a256c48a0fcb7aa0c3dae86be Reviewed-on: https://chromium-review.googlesource.com/577196Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487897}
-
Justin Cohen authored
Revert this after M61 branches. Bug: 737589 Change-Id: Icdd293b970b2577d785a6454d2bb14070457229e Reviewed-on: https://chromium-review.googlesource.com/577848Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487896}
-
Florin Malita authored
(remove SK_SUPPORT_LEGACY_HQ_SCALER) Change-Id: If5430b136027c50d01c9f832907b3cc7a518dea4 Reviewed-on: https://chromium-review.googlesource.com/568363 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#487895}
-
James Cook authored
Windows Ash support was removed in 2016, so remove Windows code from this test. Also remove the ash::test namespace, since we don't use that anymore. Bug: 373238 Test: chrome unit_tests Change-Id: I7dba77222fc36b7b8a5a372e7ed883eb20077332 Reviewed-on: https://chromium-review.googlesource.com/576871Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#487894}
-
Jay Civelli authored
Adding more unit-test coverage to ChildProcessConnection. Bug: 702316 Change-Id: I8ffee3636f944db7fa0e36fcc9a825aa1bd1766f Reviewed-on: https://chromium-review.googlesource.com/569403 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487893}
-
Yuly Novikov authored
BUG=670879 Change-Id: Ie108aa5a070020782cc304d5fdcbd1d51a7795ad Reviewed-on: https://chromium-review.googlesource.com/576394Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#487892}
-
Helen Li authored
This CL adds a build flag include_transport_security_state_preload_list=false on Cronet bots. For more details please see the linked bug. Bug: 603597 Change-Id: I0b0a85a6c7d296bf5b94e4f17c38ed10ca38f9b0 Reviewed-on: https://chromium-review.googlesource.com/577592Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487891}
-
Yipeng Wang authored
1. Use apk_operations.py as a python module rather than executing it so that stack traces & argparse errors refer to the generated script as the main script. 2. Don't force --incremental selection for commands where it makes no difference. 3. Log the adb_gdb command & forward the --verbose flag. Bug: 674250 Change-Id: I1260f282c79eed7acf9e27343f8c4e3d74566e6c Reviewed-on: https://chromium-review.googlesource.com/576769Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#487890}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5af44defbd5f..925f52d03b73 $ git log 5af44defb..925f52d03 --date=short --no-merges --format='%ad %ae %s' 2017-07-19 ethannicholas fixed SPIR-V int->uint conversion 2017-07-14 bsalomon Remove GrAnalyticRectOp, the last legacy GrMeshDrawOp 2017-07-19 reed experimental: draw into unpremul 2017-07-19 reed remove google3 colortable flag 2017-07-19 fmalita Singleton SRGB color filters 2017-07-19 egdaniel Add blacklist to vk win intel for skp 2017-07-19 halcanary SkPDF: Fix color glyphs with absolute positioning 2017-07-18 scroggo Report first GIF frame after knowing its meta data 2017-07-19 rmistry Download material design SVGs from Google Storage 2017-07-18 brianosman Some basic Flutter/Fuchsia docs 2017-07-18 jshin Add aliases mapping Windows CJ fonts to Noto Serif CJK 2017-07-18 bsalomon Revert "Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp"" Created with: roll-dep src/third_party/skia BUG=617403,722470 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I75eac4d2db0d0c21b05c5561ad44556fb25dcf8f Reviewed-on: https://chromium-review.googlesource.com/577769Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487889}
-
Luke Zielinski authored
Trigger is using a copy of the ad detection code from ads_page_load_metrics, to be refactored later when that code is shared. Trigger is currently not plugged into the TriggerManager (next CL), so this change is a no-op. Bug: 744869 Change-Id: Idff7d23df6aaa53c3b564c6daf16c96fe5a95c9b Reviewed-on: https://chromium-review.googlesource.com/574831 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487888}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8641322e4a40..1195fa0a2590 $ git log 8641322e4..1195fa0a2 --date=short --no-merges --format='%ad %ae %s' 2017-07-19 ashleymarie Changing version from "3" to 3 in json test results format Created with: roll-dep src/third_party/catapult BUG=717394 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I37876d87e72f59c4e0eff02dbf6291bca41e6138 Reviewed-on: https://chromium-review.googlesource.com/577727 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487887}
-
Alexander Timin authored
Do not run observers on main thread default queue and always run OnTaskCompleted regardless of ShouldNotifyObservers setting, in order to record task duration metrics for all queues. R=alexclarke@chromium.org Change-Id: I5223a9d704af98d02088557f27a5c32733c8b577 Reviewed-on: https://chromium-review.googlesource.com/577535 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487886}
-
Hajime Hoshi authored
base::AlignedAlloc uses memalign, which goes through the malloc zone, and the result size might be different from the resident size of the region in Mach virtual memory on macOS. This CL replaces base::AlignedAlloc usages with mmap to get accurate resident size. This is a preparation for crbug.com/742042 to use mach_vm_region instead of mincore on macOS for performance. Bug: 742042 Change-Id: I2b0dbdfd13ab895645b4d420a91a53a3b5307b6b Reviewed-on: https://chromium-review.googlesource.com/577494Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487885}
-
Nicolas Dossou-gbete authored
The remote suggestions provider is null when the feature is completely disabled. (via NTPArticleSuggestions) Bug: 742056 Change-Id: I6ae85b9583767fb85cea4d32aa655106d355b813 Reviewed-on: https://chromium-review.googlesource.com/576029Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#487884}
-
Yash Malik authored
Bug: 738037 Change-Id: Iae0012c53291453131a0d1ab94e8036259fb4d27 Reviewed-on: https://chromium-review.googlesource.com/575207Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#487883}
-
Hajime Hoshi authored
Bug: 742042 Change-Id: I5ff8f3b7be14be1b79bb43ebd349aded5aa818b9 Reviewed-on: https://chromium-review.googlesource.com/575304Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487882}
-
Olivier Robin authored
When creating a new tab from the NC extension, commands can be executed on it (focus Omnibox, launch QR Code search, launch Voice Search). The current process relies on async call to launch the command after the tab is created. For some scenarios (focus Omnibox while creating a new tab), this is not enough, and the search is cancelled by the new tab animation. Add a completion handler in the tab creation to execute the command the tab is created. Bug: 744596 Change-Id: I3e4688ff858e4ed70e7df62ac10e541a7375cbf1 Reviewed-on: https://chromium-review.googlesource.com/574537 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#487881}
-
Theresa Wellington authored
A toolbar #onLayoutChange() causes the bottom sheet state to get reset when the user fullscreens a video. If they immediately tap the omnibox or otherwise trigger the sheet to open while fullscreen video mode is activated, the sheet previously ended up open over the video. Prevent this by setting the sheet state to peek if overlay video mode is active. Also exits fullscreen mode when an NTP is created; this ensures the toolbar is visible if the user enters fullscreen mode, uses a hardware menu button to open the menu then selects "New tab". BUG=740499 Change-Id: Ie1743df3dabcf6de344af03d2232b3806a133d36 Reviewed-on: https://chromium-review.googlesource.com/576143 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#487880}
-
Lambros Lambrou authored
Don't present a sign-in screen if the user has only just cancelled one. This moves account-reloading from onStart() to onResume(), so it's guaranteed to happen after an onActivityResult() notification which informs the Activity that the user has just cancelled sign-in. In that case, onActivityResult() sets a flag which then prevents reloadHostList() from being triggered again. The user can retry sign-in either by switching to a different (or same) account, or by switching away from the app and back again. Bug: 740231 Change-Id: I40a5c31c89c66e36be31ae6fc1574ddbf1989f07 Reviewed-on: https://chromium-review.googlesource.com/571568Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#487879}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/19817af6f201..23c93ef6e3b9 $ git log 19817af6f..23c93ef6e --date=short --no-merges --format='%ad %ae %s' 2017-07-18 tsepez Avoid unterminated string segment in cfx_saxreaderhandler.cpp 2017-07-18 thestig Prevent more crashes in wcsftime. Created with: roll-dep src/third_party/pdfium BUG=738303 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I32dd5ef3587cbe13fe9dc877dca240b51c12e8be Reviewed-on: https://chromium-review.googlesource.com/577633 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487878}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I5211d3e9c7ab4002e2d39024eb8857157591c23d Reviewed-on: https://chromium-review.googlesource.com/576647 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487877}
-
Xi Han authored
Change-Id: I27bf102d779df17702edb36429d4151fee909bc1 Reviewed-on: https://chromium-review.googlesource.com/577636Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487876}
-
Aaron Gable authored
This was a typo, I accidentally removed the RUN_POST_UPLOAD_HOOKS line (which still has a function) when I meant to remove the TRY_ON_UPLOAD line (which doesn't). I blame them both containing the word 'UPLOAD'. Bug: 746079 Change-Id: I007ed90443680a7f3741367b368c55e5056e3252 Reviewed-on: https://chromium-review.googlesource.com/576530Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487875}
-
Chris Pickel authored
I used these flags to check the server's new behavior for zh_{TW,HK}. Change-Id: I8a53bfe04fdb0361714d034e2b7e673bbfeae2c2 Reviewed-on: https://chromium-review.googlesource.com/576095Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#487874}
-
jdoerrie authored
TBR=jochen@chromium.org Bug: 746407 Change-Id: I91caa2f48a47c8225d764f76355828dfa636ec2e Reviewed-on: https://chromium-review.googlesource.com/575246Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#487873}
-
Chris Pickel authored
Change-Id: Ia6cbb48983ea0dd6b7e955f6c9dfc388fb102a02 Reviewed-on: https://chromium-review.googlesource.com/577688Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#487872}
-
Vaclav Brozek authored
While passwords_settings_egtest.mm already uses scrolling to find some elements, it is not applied consistently. This CL ensures that scrolling is applied everywhere where needed, including tapping the "Settings" button, so that the tests also pass on iPhone SE in landscape mode. Bug: 717163,744058 Change-Id: Ifbc3438c78d47441c67a0d538a3895e2ed4a39b5 Reviewed-on: https://chromium-review.googlesource.com/573041Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487871}
-
Daniel Bratell authored
If a class named Function is created and the header platform/wtf/Functional.h included, any attempt at using WTF::Function will fail with a lot of strange template instantiation errors. This can happen unexpectedly in jumbo builds so to avoid that error this patch renames a testing class that used to be named Function, ReaderFunction. R=fs@opera.com Bug: 746343 Change-Id: I498ecf4f8cb293de634c40060a2df34c78a23e09 Reviewed-on: https://chromium-review.googlesource.com/574864 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#487870}
-
Vitalii Iarko authored
Previously, TestMockTimeTaskRunner(start_time, start_ticks) constructor initialized now to unix time instead of start_time. Bug: Change-Id: I712e02ea6d89d39326f24320d1741c68d0320114 Reviewed-on: https://chromium-review.googlesource.com/576039Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487869}
-
Florin Malita authored
As suggested in https://chromium-review.googlesource.com/c/574867#message-89440ecc78d9ff018913080020a956295fa5d14a, refactor SerializedScriptValue to avoid extra/unneeded copies. Change the constructor to take ownership of a pre-allocated buffer, and update the factories to skip intermediate string buffers. Change-Id: I8d4351af16f3404cc463a9388a0af958c9e1f483 Reviewed-on: https://chromium-review.googlesource.com/576214 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487868}
-
Dominic Battre authored
This CL introduces a metric that records how users interact with forms and password manager UI. In contrast to User.ActionSimplified, this metric will grow with new interactions. Bug: 732846 Change-Id: I97d02d5f5afa4a5e68e214c1bc1e20d1580e0e25 Reviewed-on: https://chromium-review.googlesource.com/574712 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#487867}
-
John Bauman authored
This was accidentally disabled in r368450, so it was causing issues when the window was minimized and its size doesn't match what chrome is expecting. Bug: 728717 Change-Id: Ie88148b76d6391c55bf10b70cd0be481b972eb9d Reviewed-on: https://chromium-review.googlesource.com/566382 Commit-Queue: John Bauman <jbauman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#487866}
-
Andrew Grieve authored
Setting: emma_coverage = true emma_filter = "org.chromium.chrome.browser.*" Would result in: ERROR at //build/config/android/rules.gni:1837:9: Undefined identifier. possible_config_deps += ^------------------- BUG=743156 Change-Id: I15cf38a8ef955a312cbb7c968fafd4efa046bfd3 Reviewed-on: https://chromium-review.googlesource.com/576476Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#487865}
-
Andrew Grieve authored
The script didn't work for me, so I compared it with the one at: //third_party/android_tools/ndk/prebuilt/linux-x86_64/bin/ndk-gdb.py Changes ported from ndk-gdb.py: * Use a retry & timeout when connecting * Detect app data dir rather than hardcode it * Use a domain socket on-device rather than tcp Other changes: * Remove setenforce logic (it was broken and unnecessary) * Randomize host port (other numbers were randomized). * Detect when CWD=$CHROMIUM_OUTPUT_DIR and fail when this is the case, as it causes stripped .so files to be loaded rather than unstripped ones. Change-Id: I64cb941ad502c05a5b8577c6f67dea56ccf9448a Reviewed-on: https://chromium-review.googlesource.com/575683Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#487864}
-
Gabriel Charette authored
Adresses content/public/test/download_test_observer.cc : GetBlockingPool() entry of https://docs.google.com/spreadsheets/d/18x9PGMlfgWcBr4fDz2SEEtIwTpSjcBFT2Puib47ZF1w/edit#gid=0 Bug: 667892 Change-Id: I74311b46bdf7e3ddda94bd868fbf4472b5a39609 Reviewed-on: https://chromium-review.googlesource.com/576372Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#487863}
-
Ben Goodger authored
Eliminate required BindSourceInfo parameter for BinderRegistry callbacks. Make users of it use variadic BinderArgs instead. R=rockot@chromium.org Change-Id: Ibd8e3186d6aeff5cf0510eefce6427617fc31bd0 Reviewed-on: https://chromium-review.googlesource.com/575596 Commit-Queue: Ben Goodger <ben@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#487862}
-
Randall Raymond authored
The previous reland of this CL did not include the command line arguments for one of the build bots. This reland adds the command line argument for that build bot. TBR=lpromero@chromium.org,michaeldo@google.com Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734571 Change-Id: If9fd7b6d2741178b307c3c51763cc89fdcb44073 Reviewed-on: https://chromium-review.googlesource.com/574690Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Commit-Queue: Randall Raymond <rayraymond@google.com> Cr-Commit-Position: refs/heads/master@{#487861}
-