- 04 Dec, 2020 40 commits
-
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/d637672ffd93..330a1eec8132 $ git log d637672ff..330a1eec8 --date=short --no-merges --format='%ad %ae %s' 2020-12-04 dschinazi Fix QuicOneBlockArena for Windows 2020-12-04 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-04 fayang Deprecate gfe2_reloadable_flag_quic_fix_out_of_order_sending2. 2020-12-04 wub Add QUIC connection option B2RC to disable reno coexistence for BBR2. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 mattm Deprecate --gfe2_reloadable_flag_quic_enable_aead_limits. 2020-12-03 mattm QUIC+TLS server should temporarily retain 0-RTT keys so that re-ordered packets can be decoded. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 mattm Deprecate --gfe2_reloadable_flag_quic_key_update_supported. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 renjietang Fix typo in QuicPathValidator. 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 vasilvv Replace QuicheStrCat() with absl::StrCat() 2020-12-03 wub Add a flag count for --gfe2_reloadable_flag_quic_tls_use_early_select_cert. 2020-12-03 fayang Deprecate gfe2_reloadable_flag_quic_fix_arm_pto_for_application_data. 2020-12-03 fayang Deprecate gfe2_reloadable_flag_quic_fix_address_validation. 2020-12-03 bnc Add HttpEncoder method to serialize ACCEPT_CH frame. 2020-12-02 dschinazi Clean up QuicTransportVersion use 2020-12-02 quiche-dev Refactor Http2Dispatcher (et al.) to prepare for --shinkansen_trace_logging. 2020-12-02 bnc Add ACCEPT_CH HTTP/3 frame type struct; add HttpFramesTest. 2020-12-02 fayang Enable QUIC Retransmittable-On-Wire-PING experiment on server side. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I948bfd352da6ef165ae0ffd22a6bc440cdb51b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575330 Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833899}
-
Trent Begin authored
This change adds the framework for network health cr_component tests and adds a test for the routine-group element. Bug: chromium:1142857 Change-Id: I8299749f0ed3c5a77271919db211f46cb4d7d621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572996Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833898}
-
Ryan Hansberry authored
If Nearby Share is actively broadcasting itself as able to receive content (by making the device discoverable over Bluetooth), do not display the "Your device is discoverable..." notification. This change requires the addition of a new method, NearbyShareDelegateImpl::IsEnableHighVisibilityRequestActive(). Using the existing method NearbyShareDelegateImpl::IsHighVisibilityOn() is not sufficient because BluetoothNotificationController::AdapterDiscoverableChanged() is triggered before NearbyShareDelegateImpl::IsHighVisibilityOn() becomes true. Making generic Bluetooth UI logic (BluetoothNotificationController) aware of the inner workings of Nearby is not ideal, but is the quickest solution we have available before launch. We will clean up this behavior leak in crbug.com/1155669. Bug: 1155668 Change-Id: I3174d9e1af777b97ef6e5daed9a80f75831ca41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566407 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833897}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/browser_ui/share. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=sebsg@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ib051ef18efe0d07dfdf5361537d038d95d3dea3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575331 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833896}
-
Sorin Jianu authored
This CL is not expected to address the test flakiness issue but it is cleaning the test code a bit for style and functional issues. The following has been done: - renamed the file to .cc so that it can be linted - moved the type aliases into an anonymous namespace and used :: because we aliased names in namespaces we did not own. - replaced a static base::FilePath - used the test server handle to guarantee the shutdown of the test server, as suggested by the documentation - cleaned up the request handler - inlined some local variables - removed a UT for creating the fetcher, since that code was already tried in other tests. Bug: 1153304 Change-Id: I01ef5d21ea354a6fcc7a08d0acd1e744f19e816c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575383 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#833895}
-
Chris Mumford authored
Bug: None Change-Id: Ifc00e3ac28743ed78d504d5ffe69f6d6ef5e07c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575036 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833894}
-
Akihiro Ota authored
This change adds a base class for panel tests and makes ChromeVoxPanelTest and ChromeVoxTutorialTest inherit from it. Bug: 1127967 Change-Id: I68131a5d12e79910779cd41ad0ae51a923d6f214 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568685 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833893}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/external. Bug: 1113033 Change-Id: I23683087348b268c9bd13a06a509ffc119d3811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573127Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#833892}
-
Gavin Williams authored
Opening Scan app from OS Settings does not need to pass an extra value to recordSettingChangeWithDetails() so underlying C++ function should be able to handle this case. Fixed: 1155694 Change-Id: Iff2cafaf12c5294ebfb52d16ed3dc42858171c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575386Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#833891}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff8800deaa33..b37eb4854762 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sergeyu@google.com,mmentovai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144858 Tbr: sergeyu@google.com,mmentovai@google.com Change-Id: I796c8cf004aed22c354952a6b0baad76ae8a53b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574831Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833890}
-
adamta authored
Creates a view controller for the NTP, the NewTabPageViewController. This VC is managed by the NewTabPageCoordinator and contains all the content that is presented on the regular NTP. First step of the refactoring effort; more content will be added to it in later CLs. Bug: 1114792 Change-Id: I38ce3fc3b386f9d93deed4ca28c9ec879b47a781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555662Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#833889}
-
Nate Fischer authored
Android: inline deprecated BuildInfo methods (/content/public/android/java/src/org/chromium/content/browser/selection) No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /content/public/android/java/src/org/chromium/content/browser/selection. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=ctzsm@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ia6d519d756b84bc8b116bfc0b9bf1dabd025cc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575385 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#833888}
-
Elly Fong-Jones authored
They will be re-enabled as part of fixing the linked bug. Bug: 1154345 Change-Id: I313ae9f360acbf5680245ad8934f0c91c9dc5d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575222Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833887}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b28382109909..fab6700b9188 2020-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I87c8cf4c9067e798d4d2822089727c0131ba30c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833886}
-
Thomas Lukaszewicz authored
This CL updates tab search to correctly announce list items when navigating with arrow keys from the input field. Bug: 1152579 Change-Id: I6a13b688c01d7d7df8ceaca47001de2ad539d62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570452Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833885}
-
Justin Cohen authored
There's some speculation that MainThreadFreezeDetector is catching too many hangs that eventually recover, especially on change from foreground to background. If a hang report is generated, but the app recovers, return early before |reportGenerated| can be set. Change-Id: Ib4a4f9b1db44eeb42ce15da7f312f4df0033e401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536386 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833884}
-
Meilin Wang authored
Bug: 1150634 Change-Id: I84ad38c9eb8af368c0c34ba56305da0088d121ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568364 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833883}
-
Etienne Bergeron authored
The tasks on shutdown are not scheduled if not mark as "BLOCK_SHUTDOWN". This behavior leads FileTraceDataEndpoint object into an inconsistant state since its assumes tasks are executed to close the endpoint. The following stackframe shows the problem: [26692:22732:1204/131653.908:ERROR:tracing_controller_impl_data_endpoint.cc(68)] FileTraceDataEndpoint: c:\src\chromium\startup.json [26692:21808:1204/131719.958:ERROR:tracing_controller_impl_data_endpoint.cc(102)] OpenFileIfNeededOnBlockingThread! [26692:22732:1204/131735.498:FATAL:tracing_controller_impl_data_endpoint.cc(86)] Check failed: file_ == nullptr. Backtrace: base::debug::CollectStackTrace [0x00007FF87DAE24B2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:303) base::debug::StackTrace::StackTrace [0x00007FF87D9D6AE2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:195) logging::LogMessage::~LogMessage [0x00007FF87D9F2C94+148] (C:\src\chromium\src\base\logging.cc:566) logging::LogMessage::~LogMessage [0x00007FF87D9F3B80+16] (C:\src\chromium\src\base\logging.cc:559) content::`anonymous namespace'::FileTraceDataEndpoint::~FileTraceDataEndpoint [0x00007FF8603C5A50+96] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl_data_endpoint.cc:86) content::TracingControllerImpl::~TracingControllerImpl [0x00007FF8603C1B88+114] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl.cc:206) content::TracingControllerImpl::~TracingControllerImpl [0x00007FF8603C3F20+16] (C:\src\chromium\src\content\browser\tracing\tracing_controller_impl.cc:206) content::BrowserMainLoop::~BrowserMainLoop [0x00007FF85FD41EA7+295] (C:\src\chromium\src\content\browser\browser_main_loop.cc:549) content::BrowserMainLoop::~BrowserMainLoop [0x00007FF85FD46480+16] (C:\src\chromium\src\content\browser\browser_main_loop.cc:545) content::BrowserMainRunnerImpl::Shutdown [0x00007FF85FD476B8+312] (C:\src\chromium\src\content\browser\browser_main_runner_impl.cc:193) content::BrowserMain [0x00007FF85FD41935+213] (C:\src\chromium\src\content\browser\browser_main.cc:52) content::RunBrowserProcessMain [0x00007FF8609437C8+104] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:520) content::ContentMainRunnerImpl::RunBrowser [0x00007FF86094469D+1005] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:1008) content::ContentMainRunnerImpl::Run [0x00007FF860944289+457] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:888) content::RunContentProcess [0x00007FF860943295+1573] (C:\src\chromium\src\content\app\content_main.cc:372) content::ContentMain [0x00007FF86094338D+61] (C:\src\chromium\src\content\app\content_main.cc:398) ChromeMain [0x00007FF84BD11225+389] (C:\src\chromium\src\chrome\app\chrome_main.cc:133) MainDllLoader::Launch [0x00007FF749A926B5+391] (C:\src\chromium\src\chrome\app\main_dll_loader_win.cc:169) wWinMain [0x00007FF749A91ADF+2783] (C:\src\chromium\src\chrome\app\chrome_exe_main_win.cc:345) __scrt_common_main_seh [0x00007FF749B89926+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) BaseThreadInitThunk [0x00007FF8BF304034+20] RtlUserThreadStart [0x00007FF8C0913691+33] R=gab@chromium.org, eseckler@chromium.org, fdoray@chromium.org Bug: 1082916 Change-Id: I715d13e47de44c974a80ee80bec0f44639691786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575257Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#833882}
-
Jeffrey Young authored
Dead code will be removed in follow-up CL. https://chromium-review.googlesource.com/c/chromium/src/+/2567093 BUG=b:174506130 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I60505ad3ceb2bec51486b28271bcf96811c1c3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567255Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#833881}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/db873dd600c3..bc3c41b8742a 2020-12-04 johnstiles@google.com Enforce that layout(binding=...) is set on interface blocks in Metal. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Id4c5b1d11db9c94b116c86b6dcea09241394e7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833880}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /android_webview. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: I7c772186e1d54f5e4e6e2b36aaa08ca350124bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575326 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833879}
-
Chris Hamilton authored
Recent changes made it so these fixture methods must be called, even from derived test fixtures. This adds logic that ensures they are called and fixes the various derived test fixtures that weren't calling the superclass methods. Change-Id: If85d104427b86087c13111a08fcce8578512138b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563701 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#833878}
-
Mike Jackson authored
This change extends support for running a PWA at OS login to linux. ChromeOS is not supported with this change. The change adds Linux to the support about:flags page, allowing users to control at both installation time, and from chrome://apps page if an application can run at login. To run an app at login, a '.desktop' file needs to be created in the autostart folder. This change extends the existing code to support the 'ShortcutLocations.in_startup' field. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: I7e82c4971018a2fb9d92210f96273bc43282ccc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524536Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833877}
-
Alexei Svitkine authored
This reverts commit 9b53f52e. Reason for revert: Causing server pipeline breakage Original change's description: > Migrate U-Z histograms to patterned histogram syntax > > This is part of a migration that replaces the old > <histogram-suffixes> syntax that was used to denote groups > of histogram to the new patterned histogram syntax. > > Bug: 758782 > Change-Id: I6cde5e15fb8d43b58006569ca01cab5765fb79e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552631 > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Karthika Pai <karthikapai@google.com> > Cr-Commit-Position: refs/heads/master@{#832494} TBR=isherman@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,karthikapai@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758782 Change-Id: I1e6f202496d6bf30f18828ddb8a1ba2647f2eec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574779Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#833876}
-
Bruce Dawson authored
The View destructor ends up in an impossible state which means that execution must have branched to the middle of it, but it is not clear how this could happen. This change adds an array of line numbers that is filled in as the destructor runs to leave us some bread crumbs. It also records the vtable of the about-to-be-deleted child object so that we can investigate if this is a type-related bug. Bug: 1152152 Change-Id: I386507974a8b6ccd1914e0ec62151456411f0c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572793 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#833875}
-
James Hollyer authored
Pointer Lock Options are launching in 88. The flag should stay for many more cycles to allow users and developers to turn it off for any reason. Bug: 982379 Change-Id: I6751b3a400a723540d773e682436890986596e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575052 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833874}
-
Andre Le authored
This change fix the Linux build crash caused by a DCHECK in MetricsRecorder::OnConnectionStatusChanged() Bug: 1106937 Change-Id: Id8b1f7f5c0bd414fa55b44234994e9c815e77750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574622Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#833873}
-
Elly Fong-Jones authored
This test broke on mac-arm64 between r833059 and r833159. It will be re-enabled as part of fixing the linked bug. Bug: 1154345 Change-Id: I17ffe033b1e1541a62b0ba5d0b4c5ae4670522e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572998Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833872}
-
Bill Budge authored
Change-Id: I65a4017b1b810d9deb0594e6fc63fdf3d89d30fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575050Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#833871}
-
Ethan Jimenez authored
1. Refactoring `NGGridLayoutAlgorithmTrackCollection::SetIterator` to allow callers access to the iterator from a const reference/pointer to the collection; this change improves the `NGGridLayoutAlgorithm` implementation since previously we were not able to pass const references to an algorithm track collection as an input parameter (because of the non-const restriction imposed by `SetIterator`). 2. Refactoring use of `GridTrackSizingDirection` into track collections; several methods in `NGGridLayoutAlgorithm` received both, track collection and its respective direction, as parameters. Since the direction is already tied to the specified collection, this change moves the `GridTrackSizingDirection` into the collection class. Bug: 1045599 Change-Id: Ibbc7d2d93c5947106b0fe627d67dce2fb24916f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573889Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833870}
-
Nikita Podguzov authored
Bug: 1154655 Change-Id: I1ef25adf8a1211599ff856444af43e2a22683db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566944Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#833869}
-
Łukasz Anforowicz authored
This reverts commit becee7ed. Reason for revert: Spike on M88 - most likely caused by https://crbug.com/1151008 and https://crbug.com/1151438 Original change's description: > Enable |request_initiator_site_lock| enforcement on Android. > > The "RequestInitiatorSiteLockEnfocement" feature is enabled on desktop > platforms in M87, because we want to be more careful on Android, since a > mojo::ReportBadMessage might lead there to renderer kills (if > NetworkService is hosted in the Browser process, something that never > happens on desktop platforms). > > Since the M87 data so far looks good so far [1], this CL enables the > enforcement on all platforms for M88. > > [1] https://docs.google.com/document/d/132ZPqDZdH-rcvBvHEAd-m86P2udVCi07ccnI0DXmJgE/edit# > > Bug: 920634 > Change-Id: I5f27d9402b3e60668305312aa437252554890bc8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465803 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816410} TBR=yhirano@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920634, 1151008, 1151438 Change-Id: I7b2157914d8a091d21ce55bfc108c3029a4ff4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575358 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#833868}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d21a8fb4dbe..d5886280043b 2020-12-04 kimanh@chromium.org [LMI] Add keyboard navigation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ff8b952e24706d02013581a642f57b258db7b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833867}
-
Norman Rosas authored
metadata from OWNERS files in the next repos: //components/cast... //components/certificate.. //components/chrome_cleaner //components/client... Bug: 1113033 Change-Id: I67561c5b8a8796ca6307fd088855d24ac089e317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564389 Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#833866}
-
Fabrice de Gans-Riberi authored
Open Screen does not end the Cast Streaming session on MessagePort disconnect. This change ends the session on the receiver end when the Cast Streaming MessagePort disconnects. This is a necessary change to unit test the Cast Streaming Receiver. Bug: 1110490 Change-Id: I272da7bad03c5f7efa31d3a8eb30f3ebdfe49f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572167 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833865}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4fd38346d19724d48a07aa5e9f87749f775bc4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833864}
-
Jeffrey Kardatzke authored
When the VaapiVideoDecoder was released, if it was using the CdmContext it would have a callback associated with the CDM. Upon destruction of the decoder, that callback would be destroyed automatically which makes a call into the CDM. The CDM is being destructed on another thread, so there was a race and this could cause a crash. The fix is to maintain a CdmContextRef in the decoder which keeps the CDM alive until the decoder is destroyed. BUG=b:153111783 TEST=Page refresh 10 times in a row w/ CDM did not crash Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833863}
-
Victor Costan authored
This CL fixes issues I missed while reviewing https://crrev.com/c/2467899. * Use base::SequenceChecker instead of making thread-hostile checks. The quota client doesn't need to run on the IO thread, it just needs to run on the same sequence as NativeIOContext. * Replace the deprecated DISALLOW_COPY_AND_ASSIGN() macro with deleted copy constructor and assignment operator. * Remove qualifier (storage::QuotaClient::) from QuotaClient callback types. This reduces churn when QuotaClient becomes a mojo interface. * Remove unused GetClientTypeFromOwner() declaration. * Remove self-#include in header. No functional changes are introduced. Bug: 1137788, 1016065 Change-Id: I34f59e128e877358d16f197bc6e6f0ac79de5df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570318 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833862}
-
Nasko Oskov authored
Interstitial pages no longer work as overlays, they are just regular error pages. This makes the PAGE_TYPE_INTERSTITIAL value in PageType obsolete, therefore this CL removes it from the codebase. Bug: 1077074 Change-Id: I9487bc97018b0f832f6d5b70cda04ea217bc8031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570126Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833861}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/46df5d14ee80..30f45a6f043f 2020-12-04 vmiklos@collabora.co.uk Add FPDFAnnot_GetLine() API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I61ab716e018bcbe36948826e03a1f6596e575e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833860}
-