GitLab

use a "randomly generated device ID" scheme, like that employed by
the desktop capture API.

Bug: 163100, 831722
Change-Id: Idcf46dad59bc822c2a5115418420e22775269068
Reviewed-on: https://chromium-review.googlesource.com/1093439Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577009}

Change-Id: Icae076f5703922c087ba4da030e5ed7350981e50
Reviewed-on: https://chromium-review.googlesource.com/1145704Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577008}

Bug: 865898
Change-Id: I4c25a2900927b979f697f426eb92da2d68ecff7b
Reviewed-on: https://chromium-review.googlesource.com/1145722Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577007}

This patch ensures that we don't reschedule an image loading microtask
if there is one pending already. This is important to ensure that image
decode microtasks see the image data (ie the image loading microtask
runs first) if there are no other changes only insertion into a
document.

The existing tests that were added for this still pass (from crrev.com/cdd15633)
  http/tests/misc/image-blocked-src-change.html
  http/tests/misc/image-blocked-src-no-change.html
  http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
  http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html

The new test fails without the change and passes with.

R=chrishtr@chromium.org

Bug: 864306
Change-Id: I1d3d2ed4c12b53fab931e55a85c4f5cd18fe1cc4
Reviewed-on: https://chromium-review.googlesource.com/1141121Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577006}

Patch from dansnyder@.

Negative times are being seen on certain platforms (the Android P
preview and some Cast devices, in particular). Handle them gracefully
rather than asserting.

Bug: 856858
Tbr: jochen@chromium.org
Change-Id: Ib05cb8534bec9e6a95df2f989a9d65fedfeece0b
Reviewed-on: https://chromium-review.googlesource.com/1142238
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577005}

Three files had their own logging glCompileShader wrapper named
CompileShader and in jumbo build experiments those clashed. This
makes that helper function shared, makes the logging a little more
accepting of long error messages, but loses a little bit of
information about where the code was called from.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If7e518cc993e165c2f51c4b32a7f1df96d31ad5d
Reviewed-on: https://chromium-review.googlesource.com/1143266Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#577004}

TextItemColorBlack was being used as the default color even if
textColor was not being set. This was causing the item label
to skip the styler textColor for the label. This CL fixes that
problem and introduces some unit_tests to check this.

Bug: 865808
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic9e7d368d4acb5cab8f2585762c69363c1143749
Reviewed-on: https://chromium-review.googlesource.com/1145584Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577003}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/807abf149a5d..60b9b6fb9147


git log 807abf149a5d..60b9b6fb9147 --date=short --no-merges --format='%ad %ae %s'
2018-07-20 ehmaldonado@chromium.org git_hyper_blame_test: Fix pylint issue.
2018-07-20 vapier@chromium.org pylint: reland upgrade to 1.5.6
2018-07-20 ehmaldonado@chromium.org gclient: Report project url if it's a known project.


Created with:
  gclient setdep -r src/third_party/depot_tools@60b9b6fb9147

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:863669,chromium:863669,chromium:832386
TBR=agable@chromium.org

Change-Id: I822581246815ddb4c1c4a6a8edd0b93a97dac033
Reviewed-on: https://chromium-review.googlesource.com/1145407Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577002}

The refactoring aspect re-landed earlier; this is a re-land of the core logic in [1]
with a bugfix for the case when a lifecycle update to PrePaintClean intervened
after property tree dirty bit mutation.

[1] https://chromium.googlesource.com/chromium/src/+/cdea59c0db145f8e85ea00e9f6d31642929e2397

Bug: 831762

Change-Id: I3cea18ee7b6ef8865e8db6733de90197451f9589
Reviewed-on: https://chromium-review.googlesource.com/1144630
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577001}

Some tests which were in general failing for Viz have been fixed.
However it was missed re-enabling them on the Android filter.
This updates the filter accordingly.

TBR=fsamuel@chromium.org
TEST=viz_content_browsertests
SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest*
SitePerProcessHitTestBrowserTest.CrossProcessMouseCapture*
SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView*
SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture*
Bug:849746

Change-Id: I9b487e0699284b5b61265ffcfb3b6a664a2f5f08
Reviewed-on: https://chromium-review.googlesource.com/1145410Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577000}

Bug: 703703
Change-Id: I4ab576d16835e13ad618e4e2794132be1a80f845
Reviewed-on: https://chromium-review.googlesource.com/1144274Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576999}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d7b61abe..8766d3dd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id0a466229f294e8afa3e887d9814926b592815b7
Reviewed-on: https://chromium-review.googlesource.com/1145698Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576998}

Bug: 833482
Change-Id: Ied9bce9cef4cf2f2a842df578040125b77793a43
Reviewed-on: https://chromium-review.googlesource.com/1145677Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576997}

This change updates Value::BlobStorage to be a std::vector<uint8_t>
instead of std::vector<char>. In order to minimize code-breakage, a
converting constructor is added.

TBR=fukino@chromium.org, boliu@chromium.org, rockot@chromium.org, chcunningham@chromium.org, bbudge@chromium.org

Bug: 646113, 864676
Change-Id: Ifbb0ecd116a95135ac7218d2accc8ac841e59db9
Reviewed-on: https://chromium-review.googlesource.com/1137819
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576996}

And add missing html import.

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1135730

This reverts commit e051dd64.

Bug: 863216
Change-Id: I04a4868e1c7b911dade228ba2216667f38ce5de9
Reviewed-on: https://chromium-review.googlesource.com/1145541
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576995}

The value of these attributes was changed to be unsigned in
https://github.com/w3c/reporting/pull/112. This change makes the
implementation match the spec.

BUG=596846
TBR=japhet@chromium.org

Change-Id: I0bfd7e395a9a2c74ea1980afe90338316ab84120
Reviewed-on: https://chromium-review.googlesource.com/1145594
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576994}

Bug: 866092,866053
Change-Id: Ia9b8feee9625151b7880b92747dcfd038327de9a
TBR: dougarnett@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1145681
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576993}

This reverts commit 277b7985.

Reason for revert: Causing test failure on debug builds:
PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility

See bug for details.

BUG=866138

Original change's description:
> Display warning when PDF signals an attempt to save
> 
> This CL adds a warning dialogue that is shown when a
> signal via SaveCalled is received. Currently this
> signal is only wired up for app.execMenuItem("SaveAs")
> in XFA JS, but will be added in other locations where
> saving is attempted.
> 
> Once saving of PDFs is fully implemented this warning
> can be removed.
> 
> BUG=pdfium:953,chromium:61248
> 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Ib89c394a07459692ee1302ea97f7b0b291b42b92
> Reviewed-on: https://chromium-review.googlesource.com/1115205
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576920}

TBR=rharrison@chromium.org,thestig@chromium.org,dsinclair@chromium.org,tsepez@chromium.org,jochen@chromium.org,rbpotter@chromium.org

Change-Id: I883ec9bc7d3c4140996c12c3fc6524c4314f109d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: pdfium:953, chromium:61248
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1145203Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576992}

TBR=jbudorick

Bug: 840967
Change-Id: Ib42d22e7d7c461ceef4684e40973c27b6fac68d0
Reviewed-on: https://chromium-review.googlesource.com/1145559Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576991}

When the SwitchAccess extension has been successfully unloaded,
clear the focus ring.

Bug: 831969
Change-Id: I33e4580db15463d502d5d2273c7285cf3dad0154
Reviewed-on: https://chromium-review.googlesource.com/1141336Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576990}

Changes:
 - Adding an overflow view, which holds extra notifications.
 - Make the NotificationItemView::Delegate a
   NotificationMenuView::Delegate, this makes testing much easier.

Bug: 843763
Change-Id: I42371d59015eb76212a9ee9624320ccf0b5cb0d1
Reviewed-on: https://chromium-review.googlesource.com/1136655
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576989}

TBR=xiaohuic@chromium.org

Change-Id: I61ca7fc31d82645e0b49d0083438a6a53531ed39
Reviewed-on: https://chromium-review.googlesource.com/1145731Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576988}

This patch creates a new color_utils function that moves the foreground
color darker or lighter until it meets the minimum contrast ratio
defined by accessibility guidelines. This new function is used for
inactive tab text, the new-tab button, and text on the bookmark bar,
which can all appear on top of user-defined colors.

Bug: 856812
Change-Id: If0f43da5852056bc0c55c96f79bf20b9c07b9046
Reviewed-on: https://chromium-review.googlesource.com/1141103Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576987}

Bug: 850590
Change-Id: Ie8ffd68b139dabc358502c041a6c628c6b4598b6
Reviewed-on: https://chromium-review.googlesource.com/1141214
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576986}

One major change is that UrlBarData now typically has editing text when
generated by the ToolbarModel.  The displayText is a stylized version
of the URL that will be replaced with the plain text version when
editing.

BUG=800825

Change-Id: Ia6f3a9a1b87195f1d7ab98c2b567f843fe783a61
Reviewed-on: https://chromium-review.googlesource.com/1142535
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576985}

Bug: None
Change-Id: Iede1a96f8371f487ecba148aa79287e455c78396
Reviewed-on: https://chromium-review.googlesource.com/1145551Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576984}

Change-Id: I5f84b1436b0cbecb4d545d0cd66de6304b40a1f0
Reviewed-on: https://chromium-review.googlesource.com/1145603
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576983}

This reverts commit 41066e83.

Reason for revert: This CL broke an internal app.  See crbug.com/865958

Original change's description:
> Convert Extensions TCP & TLS Socket APIs to mojo sockets
>
> This CL converts extensions TCP and TLS socket apis to network service's mojo
> socket.
>
> - Remove combined_socket_unittest.cc because the test cases no longer apply. I
> tried to write equivalent ones in tcp_socket_unittest.cc and
> tls_socket_unittest.cc
> - Add a ContentUtilityClient implementation for extensions_browsertests, so we
> can inject a NetworkServiceTestHelper to the utility process in which network
> service runs.
>
> Bug: 721401
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
> Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
> Reviewed-on: https://chromium-review.googlesource.com/1070434
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563390}

TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 721401, 865958
Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1145340
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576982}

This replaces usages of content::PresentationConnectionMessage with
blink::mojom::PresentationConnectionMessagePtr, and removes the
presentation.mojom typemap and traits which are no longer needed.

This is the last step before we can move presentation.mojom to
third_party/blink/public/mojom.

It also updates relevant unittests to mock methods with move
parameters directly, instead of using helper methods.

Bug: 817903,851567
Change-Id: Ifc50db81108f78089e7f19a7a394069bb2b82b37
Reviewed-on: https://chromium-review.googlesource.com/1123175
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576981}

This patch unskips 6 more directories for blink gen property trees:
virtual/scroll_customization
virtual/threaded
intersection-observer
overflow
scrollingcoordinator
touchadjustment

Bug=836886

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iee8de29abd66832f3548f38a63d7d6d2f82cc133
Reviewed-on: https://chromium-review.googlesource.com/1145540Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576980}

Change-Id: I38e1e14457f706566797fa89eff18641e1fd7105
Reviewed-on: https://chromium-review.googlesource.com/1145593Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576979}

Bug: 860691
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ic6cf61b88733c176423ce309571d28b502114234
Reviewed-on: https://chromium-review.googlesource.com/1140376Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#576978}

Change-Id: I44e86df2e87e014b5b4477c894fafa2bd5f9c457
Reviewed-on: https://chromium-review.googlesource.com/1145488
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576977}

Using wpt-import in Chromium b78ad257.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21626

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bajones@chromium.org:
  external/wpt/gamepad
garykac@chromium.org:
  external/wpt/keyboard-map
garykac@chromium.org, joedow@chromium.org:
  external/wpt/keyboard-lock
jsbell@chromium.org:
  external/wpt/encoding
kojii@chromium.org, ksakamoto@chromium.org:
  external/wpt/css/css-font-loading
mlamouri@chromium.org:
  external/wpt/mediasession
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
panicker@chromium.org:
  external/wpt/user-timing
timvolodine@chromium.org:
  external/wpt/battery-status

TBR=foolip

No-Export: true
Change-Id: Ibae77dc140a4a82a10fbc974f15e587c25eb6c25
Reviewed-on: https://chromium-review.googlesource.com/1145464
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576976}

On Safari, when there is text selected and not just a cursor in text,
the NSCandidateListTouchBarItem collapses.

This change checks if the selection range has a non-zero length, and
if it does, collapses the created NSCandidateListTouchBarItem. The
text suggestions are still accessible by clicking on the collapsed
NSTouchBarItem.

A unit test, CollapsedCandidateListTest, was written to test that
the NSTouchBarItem properly collapses according to the length of the
selection range.

Bug: 717553
Change-Id: I25671450f43b4ba14197f76e431f9212d5494187
Reviewed-on: https://chromium-review.googlesource.com/1144300
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576975}

This reverts commit 34854861.

Reason for reland: Crash fixed.

Original change's description:
> Revert "Create crostini app folder and add all Crostini apps to it"
> 
> This reverts commit b5e1688a.
> 
> Reason for revert: This CL seems to cause a crash when installing Terminal on Eve.
> 
> Original change's description:
> > Create crostini app folder and add all Crostini apps to it
> > 
> > Bug: 822488
> > Test: Manually, simulate crositini app environment.
> > Change-Id: I278a6ddfc709b5b48f923368aad07f047788bf40
> > Reviewed-on: https://chromium-review.googlesource.com/1143883
> > Commit-Queue: Renée Wright <rjwright@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#576703}
> 
> TBR=stevenjb@chromium.org,rjwright@chromium.org,khmel@google.com
> 
> Change-Id: I3104b7d7abbf885f100aedb223d31a4d73bed47c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 822488
> Reviewed-on: https://chromium-review.googlesource.com/1144500
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576714}

TBR=stevenjb@chromium.org,rjwright@chromium.org,khmel@google.com,nverne@chromium.org

Change-Id: I000b4ddbba75f11947570f4c2470332db3d80a11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822488
Reviewed-on: https://chromium-review.googlesource.com/1145563Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576974}

The corner case of nested cr-dialog instances had not been accounted. Which
resulted in 'close' events being caught and re-fired unnecessarily, which
messes up the event's target.

A potential future cleanup would be to use cr-dialog-close for the re-fired event,
similarly to cr-dialog-open, but that would cause quite a bit of churn.

Bug: None
Change-Id: I7873439ac7e69d45065ec1ee5336406c67473256
Reviewed-on: https://chromium-review.googlesource.com/1144436Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576973}

The bug was marked as fixed but the test is still disabled.

Bug: 799106

Change-Id: I7d483a811a6edfad0db6150fd5e0faef895d1b56
Reviewed-on: https://chromium-review.googlesource.com/1143602
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576972}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b6704082f43c..c3bfa61aedfb


git log b6704082f43c..c3bfa61aedfb --date=short --no-merges --format='%ad %ae %s'
2018-07-20 dgarrett@google.com config_lib: Revamp config_lib.isTryjobConfig.
2018-07-20 dgarrett@google.com cros tryjob: Stop verifying branched config names.
2018-07-20 dgarrett@google.com workspace_stages: Add clean/sync implementations.
2018-07-20 derat@chromium.org chromeos_config: Add bvt-tast HWTest suite.


Created with:
  gclient setdep -r src/third_party/chromite@c3bfa61aedfb

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I61bf5c41ba9ebf5ebe4a38f9f77f4380f723e109
Reviewed-on: https://chromium-review.googlesource.com/1145601Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576971}

Add extensions-runtime-hosts-dialog to allow the user to enter a new
host that the extension is allowed to run on, and wire it up in the
chrome://extensions page.

Add tests for the same.

Note: this only allows for adding new hosts; a followup will allow for
editing and removing current hosts.

Bug: 844128

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib42d1c461700fcb2aa4a7b360f26619a6dcd65d3
Reviewed-on: https://chromium-review.googlesource.com/1136868
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576970}