Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 12 Mar, 2018 11 commits
    • Luciano Pacheco's avatar
      Replace WTF::WrapUnique with base::WrapUnique or std::make_unique · 560c8dc5
      Luciano Pacheco authored 
      CL #3 out of 5.

Convert the remaining directories of third_party/WebKit/Source/core/.
When the class ctor is private use base::WrapUnique(), otherwise use
std::make_unique().

Remove includes of wtf/PtrUtil.h, and add missing #includes detected
by the 'git cl lint' command.

Bug: 781645
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie8367d0c6913a8cfccb37b57335b5d9ae2c46f81
Reviewed-on: https://chromium-review.googlesource.com/950623Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542418}
      560c8dc5
    • Kent Tamura's avatar
      Apply snake_case to generated CSSProperty.* and CSSUnresolvedProeprty.* · cf548f33
      Kent Tamura authored 
      Bug: 770603
Change-Id: Iaa7d740585bd2635aefac260cc416b3002e2b667
Reviewed-on: https://chromium-review.googlesource.com/958701Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542417}
      cf548f33
    • Kunihiko Sakamoto's avatar
      Use the new signed exchange format parser in SignedExchangeHandler · 3e9d9d60
      Kunihiko Sakamoto authored 
      The new format tells how many bytes to read before starting the parser,
and it can be parsed without buffering the entire signed exchange. So
after this patch, SignedExchangeHandler no longer uses string
accumulation.

This patch also updates the test htxg files to the new format.

Test: all existing tests should pass.
Bug: 803774
Change-Id: Id463bd74330392619c2a7b334b0a359a6b742be0
Reviewed-on: https://chromium-review.googlesource.com/945092
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542416}
      3e9d9d60
    • Dominick Ng's avatar
      Add tests for modal app install banners on Android. · 425c5cf7
      Dominick Ng authored 
      BUG=811578

Change-Id: I89e36faf196520ecc05dea024204792f54caea1b
Reviewed-on: https://chromium-review.googlesource.com/939063Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542415}
      425c5cf7
    • Trent Apted's avatar
      Revert "Break up NestedURLNavigationsToExtensionBlocked into two tests." · 412a0d5d
      Trent Apted authored 
      This reverts commit b213e00a.

Reason for revert: ProcessManagerBrowserTest.NestedURLDownloadsToExtensionAllowed fails on Win7 (32) since

https://ci.chromium.org/buildbot/chromium.win/Win7%20%2832%29%20Tests/31089

errors like

[2768:3776:0309/113129.955:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[2768:7568:0309/113130.435:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico

Original change's description:
> Break up NestedURLNavigationsToExtensionBlocked into two tests.
> 
> The test recently starting timing out on the bots, most likely because
> it was taking too long.  It might've become too slow after r529904 added
> more code to it (coverage for downloads).
> 
> This CL breaks up the latter addition into its own test.
> 
> Bug: 806684
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ie1d8fb7278387147e6f781c3163ea5fc89cbf183
> Reviewed-on: https://chromium-review.googlesource.com/944570
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542177}

TBR=rdevlin.cronin@chromium.org,alexmos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 806684
Change-Id: I75d971eb328af97f4f4aa98efb36628993ce9c96
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/958661Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542414}
      412a0d5d
    • Trent Apted's avatar
      Revert "[OOPIF] Move IsLocalRoot() helper from Frame to LocalFrame." · f9c4d490
      Trent Apted authored 
      This reverts commit 4233662f.

Reason for revert: suspected for browser_tests memory leak reported for SiteDetailsBrowserTest.ManyIframes

starting in link - https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/26536

example stack like

Indirect leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x9c5602 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92:3
    #1 0x12a5445c in make_unique<ukm::mojom::UkmRecorderInterfaceProxy, mojo::InterfaceEndpointClient *> buildtools/third_party/libc++/trunk/include/memory:3079:28
    #2 0x12a5445c in mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigureProxyIfNecessary() mojo/public/cpp/bindings/lib/interface_ptr_state.h:214
    #3 0x12a5375b in instance mojo/public/cpp/bindings/lib/interface_ptr_state.h:113:5
    #4 0x12a5375b in get mojo/public/cpp/bindings/interface_ptr.h:97
    #5 0x12a5375b in operator-> mojo/public/cpp/bindings/interface_ptr.h:100
    #6 0x12a5375b in ukm::MojoUkmRecorder::UpdateSourceURL(long, GURL const&) services/metrics/public/cpp/mojo_ukm_recorder.cc:32
    #7 0x1bd46a10 in blink::Document::UkmRecorder() third_party/WebKit/Source/core/dom/Document.cpp:5978:20
    #8 0x1c741e81 in blink::LocalFrameView::EnsureUkmTimeAggregator() third_party/WebKit/Source/core/frame/LocalFrameView.cpp:5862:32

Original change's description:
> [OOPIF] Move IsLocalRoot() helper from Frame to LocalFrame.
> 
> This method doesn't really make sense on Frame, as it is a property of
> a LocalFrame. Putting it on Frame implies that there are situations
> where it would return true for RemoteFrame, but that acn never happen.
> 
> There are a few places that walk all frames in the frame tree looking
> for local roots and thus need to do an extra IsLocalFrame() check now:
> - PropagateZoomFactorToLocalFrameRoots: visits all the local roots in a
>   frame tree to update the zoom factor.
> - DidExitFullscreen: this one is slightly unusual in that it only
>   notifies the *topmost* local root.
> - FocusedOrMainFrame: arguably wrong and should be removed.
> 
> If there are a more instances in the future of needing to walk the frame
> tree for all local roots, it might be worth adding a helper.
> 
> Change-Id: Ib91a813c16d5a9b4393962f0053f14447989053f
> Reviewed-on: https://chromium-review.googlesource.com/958232
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542403}

TBR=dcheng@chromium.org,haraken@chromium.org

Change-Id: I189d52af812f6e3d4cdaf8ab40bd22197f14fcc6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/958622Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542413}
      f9c4d490
    • Trent Apted's avatar
      Revert "generate_breakpad_symbols: ensure otool path exists on Mac" · df5de247
      Trent Apted authored 
      This reverts commit 29607010.

Reason for revert: causes telemetry_perf_tests to fail on mac 10.12 since https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/10960

error like

Failed to execute "/b/s/w/ir/.swarming_module_cache/vpython/aa03a4/bin/python /b/s/w/ir/components/crash/content/tools/generate_breakpad_symbols.py --binary=/b/s/w/ir/out/Release/Chromium.app/Contents/Versions/67.0.3365.0/Chromium Helper.app/Contents/MacOS/Chromium Helper --symbols-dir=/b/s/w/itcCWvow/tmpsqdLGL/symbols --build-dir=/b/s/w/ir/out/Release"

causing

Unexpected Failures:
* core.stacktrace_unittest.TabStackTraceTest.testCrashMinimalSymbols
* core.stacktrace_unittest.TabStackTraceTest.testCrashSymbols

Original change's description:
> generate_breakpad_symbols: ensure otool path exists on Mac
> 
> BUG=813163
> TBR=jochen@chromium.org
> 
> Change-Id: I1fb5565b978fb38b39fb2ddf9f726f9a3c5bd794
> Reviewed-on: https://chromium-review.googlesource.com/953591
> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541636}

TBR=sergeyberezin@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813163
Change-Id: If21d6769c514e5a037fb3e1d8ed2a20c43f01482
Reviewed-on: https://chromium-review.googlesource.com/958363Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542412}
      df5de247
    • Dominick Ng's avatar
      Resolve userChoice promise when cancelling an app banner on desktop. · 533a7829
      Dominick Ng authored 
      The result of creating a bookmark app is a pointer to an extension.
When this pointer is null, either the extension failed to be created, or
the user did not accept the installation prompt.

This CL assumes that the user declined the prompt, which is the expected
outcome of a nullptr. It means that the userChoice promise will be
resolved with 'dismissed' when the ExperimentalAppBanners feature is
active on desktop.

BUG=805744

Change-Id: Ibafe6478e665169194da930ab4d210e62b07b759
Reviewed-on: https://chromium-review.googlesource.com/942582
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarMatt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542411}
      533a7829
    • Kent Tamura's avatar
      check-webkit-style: Check snake_case.{cc,h} files. · eaca7426
      Kent Tamura authored 
      This is a preparation for the Great Blink mv.

* PRESUBMIT.py doesn't exclude snake_case.{cc,h} files.
* check-webkit-style assumes *.cc as a C++ source.
* check-webkit-style suggests the standard include guard macro for
  snake_case files.

Bug: 622551
Change-Id: I7c94f07c67718033d89714417a4f797e87090e39
Reviewed-on: https://chromium-review.googlesource.com/954622Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542410}
      eaca7426
    • Trent Apted's avatar
      Make it easier to use aura::WindowTargeter::SetInsets(..) · 274b2a0c
      Trent Apted authored 
       - Makes SetInsets public: rather than protected:, and
 - Adds an overload that uses the same insets for touch and mouse.

Bug: None
Change-Id: I59d570d7b3e4417f7861400baff7e17c6992f35c
Reviewed-on: https://chromium-review.googlesource.com/923224Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542409}
      274b2a0c
    • Luciano Pacheco's avatar
      Replace WTF::WrapUnique with base::WrapUnique or std::make_unique · 4010bf57
      Luciano Pacheco authored 
      CL #5 out of 5.

Converted remaining sub-directories of third_party/WebKit/Source/platform/.

When the ctor is private replaced to base::WrapUnique, otherwise used
std::make_unique.

Removed include of wtf/PtrUtil.h.

Fixed missing includes pointed by git cl lint.

Bug: 781645
Change-Id: I8c6a85c0490b0e615e3d41e96821559aa6aa4e26
Reviewed-on: https://chromium-review.googlesource.com/952505Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542408}
      4010bf57
  3. 11 Mar, 2018 18 commits
  5. 10 Mar, 2018 11 commits