- 25 Sep, 2019 40 commits
-
-
Chris Palmer authored
This reverts commit 8ee0e773. Reason for revert: Performance regression (Bugs: 1006176, 1005678, 1005677, 1005248, 1005068, 1005066, 1006178, 1006071) Original change's description: > [Partition Alloc] Probabilistically poison memory on free. > > We do it unconditionally in DCHECK builds to catch bugs, but let's occasionally > do it in release builds too. Frequency is tunable. > > This is a re-land of > https://chromium-review.googlesource.com/c/chromium/src/+/1761578, which was > reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1797642. > > Bug: 984742 > TBR: haraken > Change-Id: I8f9a36389b2d58f6a11b324b59dd47727e4b91fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808181 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697013} TBR=palmer@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 984742 Change-Id: Ica990f0b07ac74034e049bcd507cc7d515429057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824074Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699590}
-
Nick Burris authored
Implement the newly proposed fragment directive delimiter :~:. This delimiter behaves the same as the previously implemented ## delimiter, but is valid by URL spec and thus should be a better option. For now, both delimiters are supported, but the ## delimiter will be removed for M79 once we confirm we want to use :~:. Bug: 1007016 Change-Id: Icd732d27ccc3a7591617735afee9d14d5d1c68f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822512 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699589}
-
Manu Cornet authored
See the spec at https://guidelines.googleplex.com/crosux-spec/feature-specs/shelf-tablet.html#shelf-tablet-home ("in-app shelf"). Bug: 982512 Change-Id: Ie152168d734457ba735b73b4c1514c975ea15a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824358 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699588}
-
Luciano Pacheco authored
This reverts commit 589d0717. Reason for revert: We believe this is fixed on crbug.com/1004639. We'll monitor the bots. Original change's description: > Disable flaky PlatformUtil tests. > > When these two tests are run together, one always fails. MSAN reveals > that there is some use-after-free in these tests. Disable them for now. > > Recent flakiness: https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/384207 > Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=PlatformUtilPosixTest. > > TBR=avi@chromium.org > BUG=1007240 > > Change-Id: I961d3ed160821bd82299944cba2e827887fad7bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821700 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699316} TBR=avi@chromium.org,dominickn@chromium.org Change-Id: I4c11f5b55fbded03a1d2f1af4f3e0a4ed3fab590 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824518Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#699587}
-
Gavin Williams authored
-New public method for checking users in UsersPrivate API -Add a new private method just for checking if a user is part of the user list since two methods need the same functionality. -New test includes a negative test for not finding a user + a positive test after a user is added and searched for. Bug: 768798 Change-Id: I8ec2ca524549fbd8dd9a0813a7bf7777fe7ed2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786862 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#699586}
-
Xida Chen authored
This CL make the frame sequence tracker reports an aggregated metric for both compositor + main thread. At this moment, it reports the worse throughput between the compositor vs main thread. Unit tests are added. Bug: 1002994 Change-Id: I777c68ea04929e287a91cf82160818be34e36f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801921Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699585}
-
Peter Kasting authored
As with ScrollBarViews, this can just size the thumb extra-large and rely on ScrollBar::Update() to do the real sizing. To facilitate this, override GetInsets() to convert GetContentsBounds() into the same thing as GetTrackBounds(), then use a FillLayout. Also reorders functions to match superclass order and access level. Bug: 1005568 Change-Id: Iad7fed5501adcf301ac66f9390c2545a6e00c827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824028 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699584}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88f927df3528..6bb573380e0c git log 88f927df3528..6bb573380e0c --date=short --no-merges --format='%ad %ae %s' 2019-09-25 dberris@chromium.org Pinpoint: Handle all Datastore errors in migration Created with: gclient setdep -r src/third_party/catapult@6bb573380e0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006888 Change-Id: I8bacd1f6f6cb65ad9a229a0762ffd1f3b969b5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699583}
-
Yuwei Huang authored
This CL implements a notification client for mobile clients to fetch notification from gstatic. Currently it only has logic to match rules and select a notification. It isn't connected to gstatic or any UI component yet. Bug: 1001291 Change-Id: I2d58b53363b1db0b9bb836dfcfb5ec2a36126d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812398 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699582}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10cf66556532..cc3f09861685 git log 10cf66556532..cc3f09861685 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 nicolascapens@google.com Merge changes Ic33110f9,I538566c6 Created with: gclient setdep -r src/third_party/swiftshader@cc3f09861685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: If09574b2664315f727afda70dd2acb06e788a723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824183Reviewed-by:
-
Ryo Hashimoto authored
WeakPtr must be dereferenced on the same thread/sequence. BUG=1003950 Change-Id: Ic6f69b3974ea3bca0f3af1ca0bb3cc051c7156fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821497Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699580}
-
chrome://media-app-guestTrent Apted authored
https://crbug.com/1005726 requires us to use a GIT repo to host compiled assets rather than a CIPD package. The CIPD is installed to a subfolder of that GIT repo, so update the .grdp paths to point at this subfolder instead of the repo root. https://crrev.com/i/1835288 adds the DEPS change. Tested with MediaAppUIBrowserTest.GuestCanLoad and enable_cros_media_app = true. Bug: 996088 Change-Id: I2ab0395ed5b76faa47c23273d903d8dc68bf1761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824301Reviewed-by:
-
Dana Fried authored
WebContents are not immediate aware they're being deleted, so can still send updates for a short window between removal from the tabstrip and deletion. We need to not process updates on stale WebContents objects, however, and in fact that can cause a crash in TabStripModel. After some discussion (see attached bug) we have decided to apply this spot fix and create a longer-term issue to address the underlying cause (see crbug.com/1007379). Bug: 993739 Change-Id: Ia16a065edc7bba19f6b1314037e464a43e931c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774959 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#699578}
-
Ella Ge authored
This CL adds support for pointerlock unadjusted movement on Windows behind flag. The api is added at crrev.com/c/1764943 behind flag. (design doc: https://docs.google.com/document/d/1vvnthXjzfZXiAx7ih-mVhGc_YJ8-_rtlAhIn8i6_6nM/) When entering pointer lock, if is requesting unadjusted movement, use |RegisterRawInputDevices| to listen to WM_INPUT messages, and set the |use_wm_input_| to true. When unlock, remove mouse as raw input device are reset the bit. When |use_wm_input_| is true(in lock and unadjusted movement mode), convert WM_INPUT messages into ET_MOUSE_MOVED events as they are representing mouse movements. The move/drag events from WM_MOUSE are suppressed. Since WM_INPUT messages do not have coordinates, use current mouse positions as the event coordinates so that there is no jump when switching between normal events and raw movement events. This CL adds a field movement_ in ui::MouseEvent to store the raw mouse movement info from the mouse raw input event. This field only valid if the event has EF_RAW_MOVEMENT flag set. Bug: 982379 Change-Id: Ia6e5969717917bbefc0579b5ed587a68df4b26ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769518 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699577}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4fc8f1f8fe0e..8b16ac056b1a git log 4fc8f1f8fe0e..8b16ac056b1a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 mikenichols@chromium.org chromeos_config: Move stable boards back to important Created with: gclient setdep -r src/third_party/chromite@8b16ac056b1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I27bcdc2193d1c44604ff183d28a532babc987147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824003Reviewed-by:
-
John Budorick authored
Tbr: agrieve@chromium.org Bug: 1007403a Change-Id: I07cf5852dfcebbe2b0615cf361141ab2f4ea7eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822507 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#699575}
-
Mohsen Izadi authored
VideoTestEnviroment sets up ozone for ui and gpu in the same process/thread. So, it should set InitParams::single_process to true. BUG=998113 TEST=./video_decode_accelerator_tests on eve Change-Id: Iad080267aa471c986721c471f2f5a1dd5b2f34d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822662 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#699574}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01f7e545a37e..273175cdf44e git log 01f7e545a37e..273175cdf44e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 jmadill@chromium.org Fix Regex in DebugShaderPrecisionTest. 2019-09-24 jmadill@chromium.org Add SwiftShader to command line arguments. 2019-09-24 ianelliott@google.com Vulkan: Enable many GLES 3.1 Debug API tests to run/pass. 2019-09-24 jmadill@chromium.org Reduce logging in feature_support_util. 2019-09-24 jonahr@google.com Update GL state tracking on VertexArrayGL::streamAttributes 2019-09-24 jmadill@chromium.org Vulkan: Use ResourceUse to track object lifetime. Created with: gclient setdep -r src/third_party/angle@273175cdf44e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I4a62486b376b7bac4f303cc5e19fc91f77c4bba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823665Reviewed-by:
-
Avery Musbach authored
Change-Id: I56ee473cd6e317f19d76dbbb17dc66473aaca987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822865 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699572}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL changes the return type of GetOverflowStringName() from WebLocalizedString::Name to int. In addition, this CL renames GetOverflowStringName() with GetOverflowStringId() according to the return type is changed. As changing the return type, this CL replaces below ones with matched IDS_FOO. - kAXAMPMFieldText - kOverflowMenuCaptions, - kOverflowMenuCast, - kOverflowMenuEnterFullscreen, - kOverflowMenuExitFullscreen, - kOverflowMenuMute, - kOverflowMenuPlay, - kOverflowMenuPause, - kOverflowMenuDownload, - kOverflowMenuEnterPictureInPicture, - kOverflowMenuExitPictureInPicture, Bug: 995644 Change-Id: I0347751c8df31fb18e88f65e0024f1e4ec94b217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819285 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#699571}
-
Manu Cornet authored
Bug: 982512 Change-Id: Icedebc7c56989e5448f077251f3b6099f83e57ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824357Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#699570}
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change existing behavior. Before this CL, WebEmbeddedWorkerStartData was kept as a member of WebEmbeddedWorkerImpl, and passed when a new service worker thread starts. After this CL, the data is directly passed through WebEmbeddedWorkerImpl as a function argument. Keeping the data as a member was needed when asynchronous script fetch was done on the initiator thread. Now, script fetch is done on the worker thread, and operations on the initiator thread are synchronous. It's no longer necessary to keep it as a member. In addition, this CL... - passes the data as std::unique_ptr not const-reference because it's modified during being passed through WebEmbeddedWorkerImpl. - also makes |devtools_worker_token_| and |wait_for_debuffer_mode_| non-member. Bug: n/a Change-Id: I30b606c5543c4a8776561a10da9972bb29eff83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813798Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699569}
-
Miyoung Shin authored
This change converts PermissionService mojom interface client in blink to use BrowserInterfaceBroker. RenderProcessHost now has a CreatePermissionService() method, which is called by handlers for frames and workers. Bug: 936482 Change-Id: Ie6b86b2f2c0dede87b605ccffe0346560174238a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813124Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#699568}
-
Mason Freed authored
In the case that the element with backdrop-filter also has opacity set to zero, there is no need to perform the backdrop filtering operation. This also avoids degradation of the painted output when backdrop_filter_quality is < 1 and opacity is 0, as in crbug.com/1002225. Bug: 1002225 Change-Id: I0da0d0f952c1b1324ef2d17e61837518dd355f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822317 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699567}
-
Ionel Popescu authored
This CL plumbs the forced_colors_ state to the popup document when the popup is initialized (WebPagePopupImpl::Initialize). The UI for the date, month and week popups is updated to support high contrast by using the forced-colors media query. The in-page UI is also updated to correctly support the highlight color and the icon is also changed. Bug: 994219 Change-Id: Ia1460a20d77d4d30e93d81092ab232f84e9edf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819569 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I319682c259c5889c4f3f98ee62ffa8231c6f563a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823759Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#699565}
-
Matt Simmons authored
This reverts commit 0ea248ac. Reason for revert: Relanding this change without a flaky test. Original change's description: > Revert "Do not display the tab switcher until the tab models are restored." > > This reverts commit c0efe30a. > > Reason for revert: Introduced flaky test > org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testIncognitoEnterGts > > Original change's description: > > Do not display the tab switcher until the tab models are restored. > > > > If tab models are restored while the overview is visible, update the > > tab switcher with the updated list. > > > > R=wychen@chromium.org > > > > Bug: 990982, 955436 > > Change-Id: Ia7c63e35624dd37cd7ff0063727ba64d040fe3ee > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769298 > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Mei Liang <meiliang@chromium.org> > > Commit-Queue: Matt Simmons <mattsimmons@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#697858} > > TBR=yusufo@chromium.org,wychen@chromium.org,meiliang@chromium.org,mattsimmons@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 990982, 955436, 1005865 > Change-Id: Id0ff4c49173023fa5897435d552f6e8b8aac6c19 > No-Presubmit: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816564 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699344} TBR=yusufo@chromium.org Change-Id: Ic502f6a7fa51be0c5679875a9bf090392859e770 Bug: 990982, 955436, 1005865, 1007148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822457 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699564}
-
Christian Biesinger authored
This is a bit safer than the manual calling of clear and set. This also adds the test from https://crrev.com/c/1808498 to trunk/wpt. Bug: 1002899 Change-Id: I2a4963fc08f1b66a0d9cdaf63f1d263715f97178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810238 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699563}
-
David Staessens authored
This CL adds additional metadata to video frames being output by the new media::VideoDecoders to mark the frames as POWER_EFFICIENT. TEST=./video_decode_accelerator_tests BUG=998547 Change-Id: I7b6c1c91c4ff43fbfc6f4f49fe9d2ffb8e2e401e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792206Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#699562}
-
Junbo Ke authored
Origional CL: chromium/1818460 Bug: b/141260084 Test: content_unittests Change-Id: I3ab645e0e45184e65e3ff07bd71ce17c2d3d1b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823558Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c707a2c53fd..d48cbf934536 git log 4c707a2c53fd..d48cbf934536 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ehmaldonado@chromium.org Revert "depot_tools: Use vpython to execute fetch." 2019-09-24 ehmaldonado@chromium.org depot_tools: Use vpython to execute fetch. Created with: gclient setdep -r src/third_party/depot_tools@d48cbf934536 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153,chromium:1002153 Change-Id: Ia39a96187e34dbdad0a85101a522766df53ff548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824182Reviewed-by:
-
Yuly Novikov authored
conformance/canvas/viewport-unchanged-upon-resize.html on Win NVIDIA Vulkan passthrough. Sort Win NVIDIA Vulkan passthrough suppressions by test name. TBR=jmadill Bug: angleproject:3935 Change-Id: Ia2159714fa94163a3dc3ba2d2030f1dfa2dd2444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823999Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699559}
-
Andrew Xu authored
This CL enables the scrollable shelf to handle the mouse wheel event. Bug: 1005002 Change-Id: I25914f3591f40e560a681cc41bedcfaa0ee35f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822357Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699558}
-
Lijin Shen authored
Though no idea the cause of failure, this cl tries to add some if checks on the parent bookmark item to prevent the potential failure. It will also log some common info for the sake of future debug. Bug: 986978 Change-Id: I7466cb49bdf8bf04d683dac86cf4ab670f1984a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811797Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#699557}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5037ca88923..f050422f3285 git log b5037ca88923..f050422f3285 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-24 robertphillips@google.com Add check_mipmaps subtest to BackendAllocation test 2019-09-24 brianosman@google.com SkSL: Support bitwise negation on unsigned integers 2019-09-24 brianosman@google.com When precompiling SkSL, avoid the need to re-link 2019-09-24 nihohit@gmail.com Compile CanvasKit without -fPIC, for latest emscripten compatibility. Created with: gclient setdep -r src/third_party/skia@f050422f3285 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:b/140174804 Change-Id: I169b239ab5127f27aea149f528c18dfbfe4a0612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824097Reviewed-by:
-
Ben Joyce authored
We are migrating to androidx slowly. This CL migrates the test filters and just the test filters to androidx. Future update will migrate the InstrumentationRegistry once the test_runners are migrated. Bug: 1005891 Change-Id: I1222d29d7725075733c83c670827e6a112b6debd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814690Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#699555}
-
Min Qin authored
The test was failing because a failed DCHECK. When should_terminate is true, we should never set the potential download file length as should_terminate means the SourceStream has found its data block has been overwritten by others. As a result, there is no way that this source stream is reaching the end of the file. BUG=810982 Change-Id: I91534436a7bebfc195d81d049f917bb685cc5281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817153 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699554}
-
Kuznetsov Alexey authored
Now, mail.ru has a new tab is customied like Yandex, Bing and DuckDuckGo. Mail.ru NTP is third-party content (as described here: https://cs.chromium.org/chromium/src/chrome/browser/search/README.md) Bug: 934816 Change-Id: Ib4ff70f13b21d73322112658c7dfced1f80fb7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821079Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699553}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8bbe3b252a5..88f927df3528 git log a8bbe3b252a5..88f927df3528 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 oysteine@chromium.org Speculatively change tracing mode to ring-buffer mode Created with: gclient setdep -r src/third_party/catapult@88f927df3528 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:996866 Change-Id: I11e711e013252b58b591aad13f31f42339e6636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823723Reviewed-by:
-
John Rummell authored
Now that only 1 read or write operation should be in progress at any given time, add tests to verify that a second operation fails. Bug: 958294 Test: new content_unittests pass Change-Id: If34f667acd8094755bdc21027c966a61b783c90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822499 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699551}
-
