GitLab

BUG=637460

Review-Url: https://codereview.chromium.org/2849383002
Cr-Commit-Position: refs/heads/master@{#468588}

BUG=637460

Review-Url: https://codereview.chromium.org/2849403002
Cr-Commit-Position: refs/heads/master@{#468587}

This documentation captures insights we've gained during initial
servicifications; hopefully it will be useful for future servicifications.

Review-Url: https://codereview.chromium.org/2849463006
Cr-Commit-Position: refs/heads/master@{#468586}

This change removes two unnecessary copies in CredentialsContainer::get
when federations are present in the CredentialRequestOptions.

BUG=400674

Review-Url: https://codereview.chromium.org/2848743003
Cr-Commit-Position: refs/heads/master@{#468585}

Back out the problem diagnosis CHECKs() added in r463124; condition not
triggered.

R=haraken
BUG=699269

Review-Url: https://codereview.chromium.org/2857503002
Cr-Commit-Position: refs/heads/master@{#468584}

BUG=

Review-Url: https://codereview.chromium.org/2850153004
Cr-Commit-Position: refs/heads/master@{#468583}

Fix compilation errors (rebased).

Original description:

Use TraceWrapperV8Reference instead. This CL doesn't remove
custom getter of PopStateEvent.state as more work will be
needed to remove custom bindings.

BUG=501866

Review-Url: https://codereview.chromium.org/2850383002
Cr-Commit-Position: refs/heads/master@{#468582}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9300a23423c0..01ea3803d6f5

$ git log 9300a2342..01ea3803d --date=short --no-merges --format='%ad %ae %s'
2017-05-01 ashleymarie [Telemetry] Removing multi-tab tests from LegacyPageTest

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6e67648fb68732412d8d737a779a4b01433b82e3
Reviewed-on: https://chromium-review.googlesource.com/492788
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468581}

This CL is a continuation of removing dependencies in the code on WebViewImpl, by
introducing the pure virtual class WebViewBase and moving methods from WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a direct
static cast to WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2854783003
Cr-Commit-Position: refs/heads/master@{#468580}

Team Drive files are loaded to /team_drives directory. This change will
show it in the UI.

Google Drive(volume)
 - My Drive
 - "Team Drives"
   - "ABC team drive"

Before the change, only the root entries and fake entries were shown
with special icon (as opposed to the folder icon) and label (from
localized string resource, as opposed to filename of each entry).

Now we are showing "Team Drives" and "ABC team drive" with the special
icon just like such root/fake entries.
However, the label of "ABC team drive" should be the name of the entry
(which comes from the name of a Team Drive). hasIndividualName property
is introduced for this reason.

TEST=tested manually with --team-drive
TEST=browser_tests --gtest_filter=FileManagerJsTest.*:GalleryBrowserTest*
BUG=684275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839863002
Cr-Commit-Position: refs/heads/master@{#468579}

This CL fixes a misnamed member in the drag and drop manager.

BUG=716257
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2853973002
Cr-Commit-Position: refs/heads/master@{#468578}

Everywhere else access to webcontents via tab_strip->GetWebContentsAt(i)
is checked. Missing check here may lead to crash in rare cases.

R=benwells@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2839403005
Cr-Commit-Position: refs/heads/master@{#468577}

The new icon is used in the new infobar only.
The icon in the old translate infobar and "main menu -> settings -> site settings" will remain unchanged at the moment.

BUG=703887

Review-Url: https://codereview.chromium.org/2846183002
Cr-Commit-Position: refs/heads/master@{#468576}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/14e9286b..1bddf126

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2855833002
Cr-Commit-Position: refs/heads/master@{#468575}

This completes one TODO (adding an error message to StoreClient),
and removes another obsolete TODO.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2858483002
Cr-Commit-Position: refs/heads/master@{#468574}

Recently imported test
external/wpt/media-source/mediasource-avtracks.html is occasionally
failing instead of crashing on WebKit Mac 10.9, so expanding the
test expectation to accommodate.

BUG=626703
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2856823002
Cr-Commit-Position: refs/heads/master@{#468573}

This is split from https://codereview.chromium.org/2840523002/

Before this CL, PaintWorklet is tightly coupled with PaintWorkletGlobalScope,
and that is an obstacle to unifying MainThreadWorklet and ThreadedWorklet.

This CL introduces PaintWorkletGlobalScopeProxy to separate
PaintWorkletGlobalScope from PaintWorklet and makes it easier to abstract
communication between Worklet and WorkletGlobalScope in future CLs.

BUG=627945

Review-Url: https://codereview.chromium.org/2853743002
Cr-Commit-Position: refs/heads/master@{#468572}

BUG=

Review-Url: https://codereview.chromium.org/2855773003
Cr-Commit-Position: refs/heads/master@{#468571}

This hack was introduced in crrev.com/2767253005 because accessibility
actions generated by automation API were not propagated to the targeted
View before crrev.com/2767143007.
After crrev.com/2767143007, any accessibility actions are propagated to
the targeted View via |HandleAccessibileAction|.

BUG=None
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2800373002
Cr-Commit-Position: refs/heads/master@{#468570}

When attempting second translation keeping the WiFi/Data OFF, Chrome
shows "Translated to <desired language>" message though web page remains
untranslated.

Current fix is to check whether user is online before showing up the
translate UI in OnPageTranslated callback.

BUG=653499

Review-Url: https://codereview.chromium.org/2822383002
Cr-Commit-Position: refs/heads/master@{#468569}

Support RTL for permission decision strings, wrapping strings that may be too
long to fit.

See
https://drive.google.com/file/d/0BzEa5HU1aAqBUEl4THZuSkd5Tms/view?usp=sharing
for before / after screenshots.

BUG=714859

Review-Url: https://codereview.chromium.org/2841013002
Cr-Commit-Position: refs/heads/master@{#468568}

Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ )

Reason for revert:
Caused https://bugs.chromium.org/p/chromium/issues/detail?id=717395

Got the go ahead to revert over email.  Will continue investigating what's going on in the bug as a follow up.

Original issue's description:
> Fix omnibox suggestions being overdrawn with the nav bar.
>
> getLocationInWindow adjusts for the Android nav bar, while the
> positioning of the parent is exclusive of the nav bar.  This causes
> the suggestions be too bar left aligned and cut off.
>
> Only visible if you have the nav bar aligned with the start of
> the text (i.e. on the left with LTR text).
>
> BUG=669150
>
> Review-Url: https://codereview.chromium.org/2849283002
> Cr-Commit-Position: refs/heads/master@{#468466}
> Committed: https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23beadaf6ea984

TBR=mdjones@chromium.org,tedchoc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=669150

Review-Url: https://codereview.chromium.org/2853993002
Cr-Commit-Position: refs/heads/master@{#468567}

Revert of Use trace wrapper in PopStateEvent (patchset #1 id:1 of https://codereview.chromium.org/2850133002/ )

Reason for revert:
Broke builds

Original issue's description:
> Don't store ScriptValue in PopStateEvent
>
> Use TraceWrapperV8Reference instead. This CL doesn't remove
> custom getter of PopStateEvent.state as more work will be
> needed to remove custom bindings.
>
> BUG=501866
>
> Review-Url: https://codereview.chromium.org/2850133002
> Cr-Commit-Position: refs/heads/master@{#468565}
> Committed: https://chromium.googlesource.com/chromium/src/+/77301cfe98de369b7d72659d4a95014f1d4dc4b6

TBR=haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501866

Review-Url: https://codereview.chromium.org/2856683003
Cr-Commit-Position: refs/heads/master@{#468566}

Use TraceWrapperV8Reference instead. This CL doesn't remove
custom getter of PopStateEvent.state as more work will be
needed to remove custom bindings.

BUG=501866

Review-Url: https://codereview.chromium.org/2850133002
Cr-Commit-Position: refs/heads/master@{#468565}

Previously CdmHostFiles::InitVerification() was called within the
sandbox which doesn't work well on Windows. Move the call up so it's
called out of the sandbox on Windows. On other platforms this is still
called within the sandbox.

Also rename VerifyFiles() to InitVerification() to better reflect
what the call does.

See http://shortn/_lAkREmcQYG and http://shortn/_o4p8OPylLu on how
init verification is implemented in the CDM.

BUG=709614
TEST=Manually tested on Windows; Existing browser_tests still works.

Review-Url: https://codereview.chromium.org/2849163003
Cr-Commit-Position: refs/heads/master@{#468564}

components::RemoteDatabaseManager keeps a set of ResourceTypes which it is
applied to. The members of the set are integers and there can be at most 18
members, so it is more efficient to use a base::flat_set here.

BUG=

Review-Url: https://codereview.chromium.org/2838163002
Cr-Commit-Position: refs/heads/master@{#468563}

This fixes disallowed inclusion of content/common/content_export.h
in WebKit/public:mojo_bindings. Missing headers in some typemap files
are amended.

This is the prerequisite of whitelisting //third_party/WebKit/public
for header checking in GN.

BUG=716359

Review-Url: https://codereview.chromium.org/2858453002
Cr-Commit-Position: refs/heads/master@{#468562}

I'm guessing this shouldn't happen, but apparently it did anyways.
Let's have a max number of retries...

BUG=715707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846343002
Cr-Commit-Position: refs/heads/master@{#468561}

This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h
in WebKit/public:blink_headers.

This is a prerequisite of whitelisting //third_party/WebKit/public
for header checking in GN.

BUG=716359

Review-Url: https://codereview.chromium.org/2853173002
Cr-Commit-Position: refs/heads/master@{#468560}

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a temporary fix introduced in CL[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993

Review-Url: https://codereview.chromium.org/2852883003
Cr-Commit-Position: refs/heads/master@{#468559}

This CL wires the EncodingInfo() response param |smooth| to the
result of a new method in VideoTrackRecorder, namely
IsEncodingLikelyAccelerated() that simply surfaces the previously
somewhat internal information.  A couple of extra lines come from
refactoring similar code in either of the classes.

Testing it with https://codepen.io/miguelao/full/bWNwej.

BUG=709181

Review-Url: https://codereview.chromium.org/2832273002
Cr-Commit-Position: refs/heads/master@{#468558}

Revert of Generate StyleBackgroundData in ComputedStyleBase. (patchset #2 id:20001 of https://codereview.chromium.org/2841433002/ )

Reason for revert:
testing

Original issue's description:
> Generate StyleBackgroundData in ComputedStyleBase.
>
> This patch generates the following fields as part of a group:
> - background ('storage_only' of type FillLayer)
> - background_color ('storage_only' of type Color)
>
> Since both fields correspond to shorthands, we specify them in
> ComputedStyleExtraFields.json5.
>
> Diff of generated files:
> https://gist.github.com/darrnshn/48a62d4ef7efe9f7a8c2b707eb57644f/revisions
>
> BUG=628043
>
> Review-Url: https://codereview.chromium.org/2841433002
> Cr-Commit-Position: refs/heads/master@{#467561}
> Committed: https://chromium.googlesource.com/chromium/src/+/9cd2845fb2b733d9d3852839d47f4dc93bdec090

TBR=nainar@chromium.org,rune@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628043

Review-Url: https://codereview.chromium.org/2849123002
Cr-Commit-Position: refs/heads/master@{#468557}

Update the TestDeviceExpires test case with a slightly more complicated
scenario.

Also, to make the tests more robust, we will use a testing clock to
generate the base::Time for various objects. DialRegistry::Now() is
replaced with a clock that can be swapped out in tests.

BUG=661457

Review-Url: https://codereview.chromium.org/2843653002
Cr-Commit-Position: refs/heads/master@{#468556}

Before this CL, ScriptModuleResolverImpl::Resolve wrongly assumed that
resolved module script's instantiation state is always "instantiated".
However, this isn't always the case when instantiating module graph w/
cycles.

This CL removes the CHECK.

Corresponding spec PR: https://github.com/whatwg/html/pull/2603

BUG=594639, https://github.com/whatwg/html/issues/2596
TEST=external/wpt/html/semantics/scripting-1/the-script-element/module/imports.html shouldn't crash

Review-Url: https://codereview.chromium.org/2848213002
Cr-Commit-Position: refs/heads/master@{#468555}

Before this CL, we assumed "urls" in ModuleTreeLinker::FetchDescendants() to be non-empty
if record.[[RequestedModules]] is not empty.

However, this isn't always the case, as the resolved url may be in the ancestor list.
This CL removes the DCHECK based on this assumption, and complete the algorithm in that case.

TEST=ModuleTreeLinkerTest.FetchDependencyOfCyclicGraph
BUG=594639

Review-Url: https://codereview.chromium.org/2852963002
Cr-Commit-Position: refs/heads/master@{#468554}

ServiceInfo used to carry manifest capability data. We don't need to pass this to clients now that enforcement is done in the service manager, so I'd like to remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is the remote identity + an array of capability names. This array is populated with the names of all the capabilities that the remote requires of the target. The target can use this to modify behavior based on the presence of one of these bits. No one uses this yet except for the service manager itself (e.g. all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850743004
Cr-Commit-Position: refs/heads/master@{#468553}

This change reverts the previous additions of this unusual check
calls.

BUG=672313

Review-Url: https://codereview.chromium.org/2858443002
Cr-Commit-Position: refs/heads/master@{#468552}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/447fde34..14e9286b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2857463002
Cr-Commit-Position: refs/heads/master@{#468551}

BUG=114548

Review-Url: https://codereview.chromium.org/2837873007
Cr-Commit-Position: refs/heads/master@{#468550}

https://skia.googlesource.com/skia.git/+log/1fa986c95a93..d271ba268876

$ git log 1fa986c95..d271ba268 --date=short --no-merges --format='%ad %ae %s'
2017-05-02 benjaminwagner Revert "Remove copyTo() legacy API flag from bzl"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I233da80c94bb14567dacf5b79c48724d341d2e64
Reviewed-on: https://chromium-review.googlesource.com/492686Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468549}