GitLab

WindowTreeHostPlatform supported bounds changes where the source of
the LocalSurfaceIdAllocation was external. This was to support Mus,
where the Window Service would allocate new ids when triggering resizes.

On other Aura platforms there were DCHECKs that no other source was
setting these ids. As WindowTreeHostPlatform is intended to be the
root allocator.

With the removal of Mus this is no longer needed.

TEST=aura_unittests, manual testing of unified mode
Bug: 958239

Change-Id: I595a147cb38c454e3199e9cab9d180719adc9711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625801Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663847}

This CL adds a check in the popup menu click handling to only assume an
item was selected when the click target is not the popup menu itself.
This fixes an issue where the popup would close when a user clicked and
dragged between two items (since this sends a "click" event with the
parent as the target).

Bug: 934225
Change-Id: I67b7079b0a8a0d1d6405953808f805cfed0c83ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632421Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663846}

IWYU rather than relying on it being included implicitly by other headers.
This fixes the libstdc++ build:

In file included from ../../third_party/blink/renderer/modules/push_messaging/push_subscription_callbacks.cc:5:
In file included from ../../third_party/blink/renderer/modules/push_messaging/push_subscription_callbacks.h:9:
../../third_party/blink/public/platform/modules/push_messaging/web_push_subscription.h:19:23: error: no member named 'unique_ptr' in namespace 'std'
    WebCallbacks<std::unique_ptr<WebPushSubscription>, const WebPushError&>;
                 ~~~~~^
../../third_party/blink/public/platform/modules/push_messaging/web_push_subscription.h:19:34: error: 'WebPushSubscription' does not refer to a value
    WebCallbacks<std::unique_ptr<WebPushSubscription>, const WebPushError&>;
                                 ^
../../third_party/blink/public/platform/modules/push_messaging/web_push_subscription.h:16:8: note: declared here
struct WebPushSubscription;
       ^

Bug: 957519
Change-Id: I0394ebe989e62545f5ca0b440204c66b2292c763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631411
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663845}

It is not actually used yet - just laying some groundwork.

Bug: 965277
Change-Id: If453ba2be84c96af1130a83a36eba7fc0c3a7f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628025
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663844}

This CL prevent fullscreen button and mute button in overflow menu from
swallowing event which causes the issue.

Bug: 941451
Change-Id: I0e0dc1203df86b0979110da0d78f24d391ae8efb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626398
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663843}

We want to be able to test the eligibility fetch separately from
the Supervision Onboarding flow itself.

Bug: 958995
Change-Id: I2ba41fab2446980c2ccd554d6da1492447136250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630983Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663842}

We already separated child and enterprise reporting, by having different
implementations for each: respectively ChildStatusCollector and
DeviceStatusCollector. Now we are separating the ActivityStorage class,
which currently has mixed internals.

Notice that there are some side effect refactorings, as with this change
the DeviceStatusCollector no longer counts child time (since it is now
using the EnterpriseActivityStorage), so we had to remove child related
tests from DeviceStatusCollector browser tests. We can also remove child
related code from DeviceStatusCollector itself, but since that is a long
change by itself, it will be a follow up.

Bug: 827386
Change-Id: Ice81fefdabb49a63365af313feb9501272358870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612042
Commit-Queue: Marcelo Almeida <marcelocra@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663841}

This CL moves web_kit_constants.* into //ios/web/navigation.

Bug: 956511
Change-Id: If4f9e93f7a138577c9719443e7a953beb1b84410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631372Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663840}

Bug: 967600
Change-Id: I312ccfd2e11cb1c2290ae05a1c32270035dff7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632157Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663839}

Without this, the compiler emits ctor/dtor code to convert constant
strings to std::string making the call about 100x larger in size and
almost 2x the size of a caching macro instantiation.

According to the Android binary-size try-bot, saves about 4K...

Specifics:
-4,096 bytes main lib size
-4,738 bytes normalized apk size
InstallSize:
-4,122 bytes APK size
-4,122 bytes Estimated installed size (Android Go)
-4,122 bytes Estimated installed size
InstallBreakdown (-4,066 bytes):
+28 bytes unwind_cfi (dev and canary only) size
-4,096 bytes Native code size
+2 bytes Package metadata size


Bug: 944842
Change-Id: I4b9bdff28acfa7b0e5146de74fd922a5c8245b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630968Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663838}

Bug: 607350
Change-Id: I5f936eec76511e5f9956aad1917eb823f79120fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630031Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663837}

- Remove app_list_view.mojom and its reference;
- mffr mojom::AppListViewState AppListViewState;

Bug: 958134
Change-Id: I2c4855b40a5b060fd82231cf3e99abf10fbccdaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628876Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663836}

Previously in many geometry functions, kApplyContainerFlip controlled
whether the input (when mapping from local to ancestor) or the output
(when mapping from ancestor to local) is in flipped blocks direction
for now boxes. Many geometry mapping functions forced the flag by
default, while others allowed the caller to specify the flag, which was
inconsistent.

Now remove the flag and let the functions always deal with physical
coordinates, and let the callers to meet this requirement.

Change-Id: I02c0da9d27fca1a0e2849bde3213c69791e2ad2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614448Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663835}

Except for the video tests, the rest of the tests now pass with Vulkan.

Bug: 960795
Change-Id: Ie27b7228934c5540aaf0e670f55e77da96c1f0c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629692Reviewed-by: Jonathan Backer <backer@chromium.org>
Auto-Submit: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663834}

Change-Id: Ie6e60da92860bc8fdee7e10a2e90b563ea7bec7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632242Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663833}

This change is the first step towards enabling Blink to interface with
V8's [Synthetic Module Records](https://heycam.github.io/webidl/#synthetic-module-records),
a building block for Blink-defined module types like JSON modules and
CSS modules.

This change moves down all code in ModuleScript that is
specific to JavaScript modules (rather than ES modules in
general) down to a new JSModuleScript subclass.

Subsequent changes will introduce another subclass of ModuleScript
that will use Synthetic Modules.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=967018
Change-Id: I76dfd5adf5c37b5526619f4203f36a505775b8bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628994
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663832}

Move StackRow out of AFM into a new AudioFocusRequest
interface.

BUG=914427

Change-Id: I52e36de5a7e5fd5a42649a55baa040ce0b46ba95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629430Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663831}

- Hooked NotificationBackgroundTaskScheduler onStart and onStop
callback from native to Java side
- Injected SchedulerTaskTime bundle to scheduler TaskInfo
- Marked "internal_types" as public

- TODO in next CLs:
1. Create SchedulerTaskTime enum counter part in Java side
2. Remove file "intenal_types" and move the enum to the public

TBR=peter@chromium.org

Bug: 963287
Change-Id: I20cdcc7d7149ac92885e6a5810dfea7664416e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625911
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663830}

https://android.googlesource.com/platform/external/perfetto.git/+log/5ca8b4622a59..caa10d3db92b


git log 5ca8b4622a59..caa10d3db92b --date=short --no-merges --format='%ad %ae %s'
2019-05-28 ilkos@google.com Merge "Add heap profile metric output"


Created with:
  gclient setdep -r src/third_party/perfetto@caa10d3db92b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I9ad4c915ef884af69c973e422e5e2f34054c4fcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663829}

If the user disables sync, accesses some tabs locally, then re-enables
sync, the client has no authorization to share these tabs with an
external endpoint, so FaviconRequestHandler should not emit requests
to the favicon server for those. We solve this by blocking Google
server requests for any local tabs.

Bug: 967746
Change-Id: If7f8c1a84d087701b0de6aa19bf27a710bd6069f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632469Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#663828}

If an online login through Gaia is forced at the Chrome OS login screen,
we should be able to debug the reason behind it.

Fix this by adding logs for the case when an online login is forced.

Bug: 964691
Change-Id: I31db5ed4e280108bf5234c1e9ecd89fcee2ecba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617448Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663827}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33d3be2b8bdb..0210991491ea


Created with:
  gclient setdep -r src-internal@0210991491ea

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com

Change-Id: Idc5d9b691f309f45e79c20b128b54ab3d4bf852f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631145Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663826}

Call AuthenticatorEnvironment::DisableVirtualAuthenticator() when
RenderFrameHostImpl is destroyed. This prevents leaking memory if the
virtual environment is enabled for a frame host that is later destroyed,
and prevents an indirect use-after-free when a new render frame host is
assigned to the same memory position as a previous one.

This bug was discovered by findit:

https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWNmNDAzZjliMzcxMGVjYTVkYmM1YjJiY2U5MmYyYTY1YzdiN2M1Mgw

Bug: 967032
Change-Id: Iae241c72904be46526bcaf1aa533749e66a34d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629069Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663825}

This CL adds CORB coverage for:

1) text/event-stream, application/x-www-form-urlencoded, based on the
code review discussion in a previous CL here:
https://chromium-review.googlesource.com/c/chromium/src/+/1604244/4/services/network/cross_origin_read_blocking.cc#227

2) application/gzip, which wasn't mentioned explicitly in the CR
discussion above, but which is ranked #212 in the spreadsheet
mentioned in https://github.com/whatwg/fetch/issues/860#issuecomment-457330454
and therefore probably should have been included in r659671 together
with x-gzip (ranked #54) and zip (ranked #71).

Bug: 802836
Change-Id: I8c10f900110a2cb471437a19425bfd5e38aed2fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628809Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663824}

Bug: 943242
Change-Id: I5674869d925a8345cb314020f76a71bfd20f9d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628827Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Auto-Submit: Lucas Tenório <ltenorio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663823}

A bunch of interactive_ui_tests from AutofillInteractiveTests.* are flakily
timing out on the win7 builders. This CL enables pixel outputs. Hopefully that
reveals why the tests time out.

Bug: 967588
Change-Id: Icc6296fbb324fe0e2920807afa6a6ceea121b691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632330
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Auto-Submit: Dominic Battré <battre@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663822}

There are slightly different code paths to handle the disconnect for
immersive and non-immersive sessions. There can only be one immersive
session, but there can be multiple non-immersive sessions and they all
use the same magic window provider as their data provider.

Bug: 937906
Change-Id: I71f05fa2d854c2654744e818d407e4b94a2fd95e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628269Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663821}

Bug: chromium:947743
Test: unit tests
Change-Id: I3041651936dea5e6080f0a1fb15f80b5c65b361d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631896
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663820}

The address controller will be asked to provide addresses only once when
it is initialized. After that, it needs to push any changes made to
profiles whenever they change.
For that purpose, observe the PersonalDataManager as soon as it was used
for the first time.

Bug: 967380
Change-Id: Ia6b1ad02edce92b31e5d4951f06ae8933be3fed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631594
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663819}

A more robust way of making sure the features are set back to its
original state for other tests.

Change-Id: I4187c7eba820006736c8f49bc8ac85aaa359dc58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632189Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663818}

CookieStore on workers uses the default task runner to handle the async
IPC completion, which is deprecated.

This CL updates the IPC endpoint set up to use per-frame task runner
for finer priority control.

Bug: 961186
Change-Id: I45db9728d1315b31d0b570578bff34fe6be9cdd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626923
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663817}

The Protected Content menu should always be visible now. Remove checks
that are no longer necessary now that we've ended JB support.

Bug: 923477
Change-Id: If9ef76e1399dbc754f31dbd9ceb23447b4cfcc97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628995Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663816}

TBR=meacer@chromium.org

Change-Id: I98b470753bd88c50a616bc4454fc1585083c6ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629691
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663815}

No change is being made to functionality. TabRendererData currently gets the visible url, this change updates the variable name to reflect this.

Bug: 910739
Change-Id: I7a0bf0e07dc05b5a6f42c20da04c64fe614bc2c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632554
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663814}

We recently updated four Chrome GPU bots to 16.04, in order to debug a bad
Vulkan state. We pinned linux_nvidia_quadro_p400_experimental to this in:

https://chromium-review.googlesource.com/c/chromium/src/+/1626338

However some angle_perftests and angle_end2end_tests crash with this
configuration. We suspect that 16.04 is not a good choice for these bots. We
have plans in crbug.com/966502 to update the bots to 19.04.

In the interim I am pinning this configuration back on 14.04 which was working

Bug: 967039
Change-Id: I749cd57a8d5907de40f9db968201633af22017c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631638Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663813}

It's unused.

BUG=none
TEST=none

Change-Id: I4314c2f987b1511254a7cdddbe2ae7cecd23431b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632301Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663812}

\\?\VIRTUAL_DIGITIZER was detected as a gamepad on some machines.

Bug: 961774
Change-Id: If16d122572ba1aec5f6978b10a69b3b0f9049511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628333
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663811}

My fix aosp/943625 didn't make the new release, it only reached dev
repo, we need to disable this test until next release.

Bug: 967173
Test: android_webview/tools/run_cts.py -f=android.webkit.cts.WebViewTest#testGetContentHeight --cts-release O, test didn't run.
Test: android_webview/tools/run_cts.py -f=android.webkit.cts.WebViewTest#testGetContentHeight --cts-release N, test didn't run.
Change-Id: Iff6be933a264361ca430e6b9ba70430bbaa1602c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631897Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663810}

This CL only adds a flag for a previously added feature: group
suggestions by search vs URL.

Bug: 966462
Change-Id: I37d956baadad1a2bb5ea9968f4959933c0c61b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631299
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663809}

Instead of taking a pointer as an argument and returning whether the
fetch was successful, we can just return the pointer directly, yielding
nullptr in case of failure.

Change-Id: I9710b832a6e51eb5112a62af81d54906d5c1cc1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626000
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#663808}