- 23 Apr, 2012 40 commits
-
-
rvargas@google.com authored
BUG=122005 TEST=none TBR=gavinp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10204005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133564 0039d316-1c4b-4281-b951-d872f2087c98
-
dennisjeffrey@chromium.org authored
Some of the functions used by perf.py changed names in this CL: http://codereview.chromium.org/10143008/. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10199006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133563 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
this prevents jiggle during load because the profile info is available from when the page first loads, instead of a split second later. BUG=none TEST=manual Review URL: http://codereview.chromium.org/10139019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133562 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
mismatched keepalive count, caused by network requests from other views being attributed to the transient page. BUG=124502 TEST=no Review URL: http://codereview.chromium.org/10141003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133561 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Add a "--silent" flag to our test suite to disable gtest output. This clears up the test logs when running the ChromeMain browsertests. BUG=124645 Review URL: https://chromiumcodereview.appspot.com/10199007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133560 0039d316-1c4b-4281-b951-d872f2087c98
-
varunjain@chromium.org authored
Plumb drag image offset WebContentsViewAura. This was somehow left out in the TabContentsViewAura renaming. BUG=118024 TEST=none Review URL: http://codereview.chromium.org/10174009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133559 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
This is part of simplifying URLRequestThrottler* now that it is specific to extensions. It also appears that nobody is using this header. BUG=119760 Review URL: http://codereview.chromium.org/10190002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133558 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
Platform apps must now have a background page. For the handling of launches, the background page registers an onLaunched event handler, and creates UI as appropriate via the chrome.windows.* API. Updates all tests to use the new window model. Also makes created shell window respect the bounds that were passed into the chrome.windows.create() call. Also fixes bug by resizing windows in PlatformAppBrowserTest.WindowsApi to a size that matches the Aura grid. This CL was originally written by mihaip@chromium.org - the original is: http://codereview.chromium.org/9969087/ TBR=mihaip@chromium.org BUG=119410 TEST=Platform apps should now require a background page. Review URL: https://chromiumcodereview.appspot.com/10080017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133555 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
R=jsbell@chromium.org BUG=123045 TEST= Review URL: https://chromiumcodereview.appspot.com/10199008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133554 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
I think that the Google crawler might be fine with a purely AJAX-based doc system now. TBR=rafaelw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10162023 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10198002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133553 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133552 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10196002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133550 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
This is part of a test to see whether Google will index AJAX- generated docs. TBR=rafaelw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10200004 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10196005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133549 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
local prerender predictions. At this point, the class itself is just a dummy, and the focus for now is on the interface with the history service. I added everything I need added in history, and PrerenderLocalPredictor performs the basic interface functionality it needs with the History. In a later CL, I will actually add the prerender semantics. R=brettw@chromium.org, cbentzel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10067018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133548 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
This allows us to build a single set of normal / hot / pushed images, then overlay a back arrow, forward arrow, etc. on top of them, which reduces the number of new assets we need for the toolbar. Also added unit tests for ImageButton and added ImageButton to the views examples window. BUG=124708 TEST=views_unittest, manually checked ash_shell "Views example widgets" for image and behavior Review URL: https://chromiumcodereview.appspot.com/10174014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133546 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
TBR=cmp,nduca BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10155017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133545 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
In favor of less indirection. Along the way, remove an unsed parameter gdata_file_path from some places. BUG=chromium-os:29813 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10182012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133544 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=122815 TEST=no Review URL: https://chromiumcodereview.appspot.com/10152008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133543 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Review URL: http://codereview.chromium.org/10187006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133542 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
Change-Id: Iadd9a6202f0b09e7d3f4171ae7341b2cd8e6e63a BUG=chromium-os:28616, chromium-os:19569 TEST=Will be tested with implementation of chromium-os:19569 Review URL: http://codereview.chromium.org/10169014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133541 0039d316-1c4b-4281-b951-d872f2087c98
-
asanka@chromium.org authored
This is no longer in use since ChromeOS is now always building USE_AURA. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10073017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133540 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
This is part of a test to see whether Google will index AJAX- generated docs. TBR=rafaelw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10200004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133539 0039d316-1c4b-4281-b951-d872f2087c98
-
tturchetto@google.com authored
BUG=chromium-os:27964 TEST=This is a test Review URL: https://chromiumcodereview.appspot.com/10105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133537 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10180006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133536 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
The selection infrastructure in about:tracing was grown organically and in a hurry. This refactors the organic selection logic around the concept of a TimelineSelection, which represents an array of TimelineSelectionHit objects. A selection hit is created by a track and contains enough information to uniquely identify the selection both in the track and in the overall TimelineModel. Counter tracks are then updated to support this new picking infrastructure, generating TimelineSelectionHits. Whereas TimelineSelectionSliceHit stores its selected state inside the timeline model, TimelineSelectionCounterHit stores its selected state inside the track. The counter hits follow the new intended model; a followon refactoring will be needed to clean up the TimelineSlice selection state. As part of this refactoring, the analysis code for traces is pulled from the timeline view into a standalone analysis class. This allows cleanup and unit testing of that once-monolithic system. In doing this, the help dialog is moved up to a custom button in the UI instead of being shown in the analysis area as was done previously. Review URL: https://chromiumcodereview.appspot.com/10161025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133535 0039d316-1c4b-4281-b951-d872f2087c98
-
gauravsh@chromium.org authored
BUG=chromium-os:28353 TEST=Verify google api is correctly loaded Review URL: http://codereview.chromium.org/10165017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133533 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Remove DOMView. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10171006 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133529 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none TBR=sky Review URL: https://chromiumcodereview.appspot.com/10183007 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10199003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133528 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Specifically, animate when a view in the tray hides/shows itself. For now, the tray does not animate when the size of a view changes (e.g. date-view changes size because it's 10:00). BUG=117209 TEST=none Review URL: https://chromiumcodereview.appspot.com/9969068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133526 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
a more intricate fix is on the way, see http://codereview.chromium.org/10154004/ for now this fixes the vast majority of crashes and is easy to merge to m19. BUG=123705 TEST=manual Review URL: http://codereview.chromium.org/10169024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133524 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
The process handle is not used since we switched NaCl to using Chromium's BrokerDuplicateHandle() function. I have changed NaCl's SelLdrLauncher to not use the process ID or process handle in this context, so returning dummy values of 0 and -1 will be OK: they will not get passed to kill(), waitpid() or TerminateProcess(). BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719 TEST=nacl_integration etc. Review URL: http://codereview.chromium.org/10134029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133523 0039d316-1c4b-4281-b951-d872f2087c98
-
dubroy@chromium.org authored
BUG=123033 TEST=In a signed-in profile, open a new tab page. Then open chrome://settings/syncSetup in another tab. Toggle the "Open Tabs" sync option, then observe that the "Other devices" menu appears or disappears from the NTP as appropriate. Review URL: https://chromiumcodereview.appspot.com/10167001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133522 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
BUG=122302 TEST=Manually checked the images are updated Review URL: https://chromiumcodereview.appspot.com/10171010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133521 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/10115017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133520 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
ppapi_proxy_untrusted.gyp should now build with a single link error for main. BUG=116317 TEST=builds with a single link error for main(). Review URL: https://chromiumcodereview.appspot.com/10167024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133519 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Convert the last remaining find bar ui test to a browser test. Also convert all the find bar tests to just use file urls instead of the http server, which is faster (I didn't see a reason to use http). BUG=121574, 45753 Review URL: https://chromiumcodereview.appspot.com/10188003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133518 0039d316-1c4b-4281-b951-d872f2087c98
-
alecflett@chromium.org authored
This is purely removing code that is no longer called, since https://bugs.webkit.org/show_bug.cgi?id=83638 has been fixed. BUG=124650 Review URL: http://codereview.chromium.org/10179003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133517 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@chromium.org authored
mmap returns -1 on failure and in the posix implementation of SharedMemory, this was setting memory_ to -1. However the interface for SharedMemory specifies that memory_ should be NULL if it is unmapped. Furthermore there was DCHECK included to check the success of mmap, but I feel this is incorrect because we are returning the success (e.g. other platform implementations don't do this). The caller can DCHECK if they need. We could change this to a LOG call. BUG=None TEST=out/Debug/base_unittests Review URL: http://codereview.chromium.org/10174007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133516 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
BUG=117303 TEST=None Review URL: https://chromiumcodereview.appspot.com/10139025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133515 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@google.com authored
This CL fix the wallpaper fade animation problem. The problem was when user switched to a new wallpaper, it seems there is a white flashing before new wallpaper fade in. The reason was I started the hide animation before loading new wallpaper. And it took around 300ms to load while the animation finished around 200ms. So there is 100ms period where the background color (white) showed up. I delayed the hide animation, but then another problem showed up. Now the show and hide animation happened at the same time. At some point in the animation, the background color will have 25% opacity and it also cause a flashing. To fix all, this CL only animate on Show new wallpaper and delete the old widget after the Show animation completed. BUG=118651 TEST=Change wallpaper in chromeos, and verify if the animation is smooth. Review URL: http://codereview.chromium.org/10146016 TBR=bshe@chromium.org Review URL: https://chromiumcodereview.appspot.com/10184012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133514 0039d316-1c4b-4281-b951-d872f2087c98
-