GitLab

If an API is called without a callback, that API may still result in
an error. For instance:
chrome.foo.doBar();  // May fail asynchronously!

In this case, we should log the error to the console, in the same way
we would for an unchecked error in the callback.

This implements this for APIs invoked and resolved through the
APIRequestHandler, and adds a ReportUncheckedError() to the
APILastError object. This requires adding a pending request for
all requests through APIRequestHandler, instead of just those with
an associated callback.

Also add unittests for both the new APILastError method and the full
flow of logging the last error from the APIRequestHandler when a
callback isn't provided.

Bug: 839528
Change-Id: I42418bb968e06d27e34e3f8981468229343dc5c9
Reviewed-on: https://chromium-review.googlesource.com/1028357
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555868}

Move the rewriter files to ash, keep the delegate impl in chrome.
Add a mojo interface for the delegate to receive and return events.
Ash's controller creates the rewriter, Chrome sets the delegate.

Move, expand, and refine the existing unit tests.

Add TODOs to refine the rewriter/delegate/ChromeVox pattern.
(the rewriter shouldn't pass events that will need to be reposted)

This should allow Mash to support this rewriter in the future.
(for now, Ash doesn't get Window Service events sent to Chrome)

Bug: 647781
Test: No regressions with ChromeVox spoken feedback on Chrome OS.
Change-Id: I4f7805298156ab9463ca3110a1e957f922c6d82b
Reviewed-on: https://chromium-review.googlesource.com/1038819
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555867}

Bug: 809635
Change-Id: Ifd6e73c24c0994f551442ce2d21355829e5454dd
Reviewed-on: https://chromium-review.googlesource.com/1022257
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555866}

Bug: 838609
Change-Id: I990017ba66d3be60d86204b7e216999caaf2c25b
Reviewed-on: https://chromium-review.googlesource.com/1041071
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555865}

This CL implements the new GM2 styles for the non-
client frames caption buttons:
- Use circular inkdrop flood fill and highlight.
- Use the new colors and opacities for the caption icons.
- Use a height of 32dp for the non-browser frames.

TODO: Implement the same styles for PWAs' frame buttons

BUG=831872
TEST=manual

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id2c2603b67b290b5eba1970d78d5d0c395df7fe4
Reviewed-on: https://chromium-review.googlesource.com/1041144
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555864}

Implement function to extract U2F check only sign command from
CtapMakeCredentialRequest. This is used to iterate through key handles
in the exclude list to prevent duplicate registration.

Bug: 798573
Change-Id: I51ab3dc21c6a7229e99dd513dae4ec9322014a75
Reviewed-on: https://chromium-review.googlesource.com/1032257Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555863}

This reverts commit 210545ea.

Reason for revert: Causes ModuleEventSinkImplTest.CallsForwardedAsExpected to fail. 

Original change's description:
> Reporting: Include include-subdomains in net log
> 
> We weren't including the `include-subdomains` field of each endpoint
> group in the data we were handing over to the net-internals page.  (The
> net-internals code that reads this field is already there; we just
> weren't filling in a value.)
> 
> Bug: 829353
> Change-Id: Ifdff1d6e0baf802eb7f094571060b93c761936af
> Reviewed-on: https://chromium-review.googlesource.com/1019661
> Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
> Commit-Queue: Douglas Creager <dcreager@google.com>
> Cr-Commit-Position: refs/heads/master@{#555755}

TBR=juliatuttle@chromium.org,dcreager@google.com

Change-Id: I720f83c34a1df94a9f3193c6dc453ab80bb98c8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829353
Reviewed-on: https://chromium-review.googlesource.com/1042623Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555862}

There are good reasons for displaying the Android Secret on this page,
but we need to make sure that users don't include it by accident when
making a screenshot for other reasons.

Following this CL, they can type "secret" to display the Android Secret
that's associated with the already included Android ID.

Bug: 833949
Change-Id: I20131dbf0f113738cd1f9acd2ece0763db032921
Reviewed-on: https://chromium-review.googlesource.com/1034803
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555861}

The callee runs in a sandbox and the caller can handle the termination
of the process as an error condition.

Bug: 826743
Change-Id: I9c0cddf9319c6db8dc2a9bf825c787a890976e0c
Reviewed-on: https://chromium-review.googlesource.com/1038141Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555860}

In particular the permenent node creation moves to
BookmarkLoadDetails, and LoadBookmarks() becomes a bare function.

BUG=680698
TEST=covered by existing tests

Change-Id: Ifdc7ef84ee73ac7b59c122976a37cb85d5d27b4f
Reviewed-on: https://chromium-review.googlesource.com/1041575
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555859}

Bug: 773295
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic37eb92d81b0f0f16f997fad635d22933b3ce098
Reviewed-on: https://chromium-review.googlesource.com/1040445
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555858}

Also replace the LazyInstance with NoDestructor.

Change-Id: I057bc873f2ebd0a331fed1298e2e38e7f9f1265e
Reviewed-on: https://chromium-review.googlesource.com/1038893
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555857}

Adjust the flags so that the FullscreenOptions object is read and the
system ui visibility flags are set appropriately.

BUG=829937

Change-Id: I698f0dabd4ca9acfad27f1efc4ffb75361e7df69
Reviewed-on: https://chromium-review.googlesource.com/1034600
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555856}

When selecting a tab in the tab switcher the animation that brought
the selected tab to full-screen placed offset the tab down and this
led to janky looking animation. This happened because the tab switcher
animation code assumed that the browser controls only contained the top
bar. This CL fixes that assumption.

Bug: 839181
Change-Id: Ide349b8bcd5290acd8a8d9cde80b6f10886ac177
Reviewed-on: https://chromium-review.googlesource.com/1041162Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555855}

MediaSinkServiceBase changes:

- Move the Observer interface currently in CMSSImpl to
MediaSinkServiceBase and generalizes it so it can be used for other
MediaSinkServiceBase implementations.
- Standardizes add/update/remove/get sink operations in
MediaSinkServiceBase.
Both of these make the code using MediaSinkServiceBase more testable as
additional code in MRP depend on them.

Also cleaned up logic related to the discovery timer by combining
Start/RestartTimer().

-----

DialMediaSinkSevice changes:
- DMSSImpl now pools sinks discovered in the latest round and is used
to merge with the |MSSBase::sinks_| when the discovery timer fires.
Before this patch, the current set is removed on the start of a discovery
round (because unlike Cast, there is no active connection to a device to
tell that it is still alive or gone), which makes the sink list unstable.
With this patch, the current set is only modified at the end of a discovery
round.
- TODOs in future patches:
-- move app discovery service out of DMSSImpl, similar to Cast.
-- get rid of DMSS and move UI thread dependencies (if any) into part
   of DMSSImpl. Then rename DMSSImpl -> DMSS.

-----

CastMediaSinkService changes;
- No longer keep track of sinks by ip endpoint. Instead uses
|MSSBase::sinks_| to maintain sink list.
- CastAppDiscoveryService no longer need to maintain its own map of
sinks, and instead uses |MSSBase::GetSinks()/GetSinkById()|.
- The callback used for dual disovery is converted to use
MediaSinkServiceBase::Observer.
- TODOs in future patches:
-- get rid of CMSS and move UI thread dependencies into CMSSImpl.
Rename CMSSImpl -> CMSS.
-----

Notes:
- The MediaRouteDesktop ProvideSinks callback is not converted to use
Observers. This is because the callback is expected to be temporary (until
we can turn off the extension MRPs), so we treat it as a special case.

Bug: 816628,698940
Change-Id: I11fd13f7ebf743d78c9499ad24f98cf72f571ee5
Reviewed-on: https://chromium-review.googlesource.com/1033727
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555854}

This reverts commit a6889a09.

Reason for revert: Seeing multiple failures that might be caused by this change: 839362, 838785, 838858, 839327

Original change's description:
> [CFI] Enable cfi-icall for official Linux x64 builds
> 
> The measured size impact is 1.5% and perf impact is ~1%.
> 
> Bug: 701919
> Change-Id: I541242711bc85cc124ff3a2680171577e75475bd
> Reviewed-on: https://chromium-review.googlesource.com/1033918
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554828}

TBR=dpranke@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 701919
Change-Id: Ia73c2508483576a16fbc00749f081f013e6fd813
Reviewed-on: https://chromium-review.googlesource.com/1042765Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555853}

Bug: 839172
Change-Id: I9881db40caa593819cfaaf686a8e24ab0dc8bc4e
Reviewed-on: https://chromium-review.googlesource.com/1041158Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555852}

Relanding the move zygote to the service manager. It was breaking the
non NaCl build.

Original description:

"This CL moves the zygote code from content/ to
services/service_manager/zygote. This involves moving some switches from
content_switches.h to services/service_manager/embedder/switches.h and
moving some codes from content/public/common/result_codes.h to the new
services/service_manager/embedder/result_codes.h."

Tbr: avi@chromium.org
Tbr: sky@chromium.org
Tbr: scottmg@chromium.org
Tbr: rockot@chromium.org
Tbr: slan@chromium.org
Tbr: eseckler@chromium.org
Tbr: rsesek@chromium.org
Bug: 831846
Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578
Reviewed-on: https://chromium-review.googlesource.com/1037633Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555851}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1f462965..a2f0a25c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7a0b82711b1c390e774c32507f460f716d204f61
Reviewed-on: https://chromium-review.googlesource.com/1042217Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555850}

Ensure that we use upload tasks for uploading bitmaps in the Gpu image
cache. This allows the image to be locked across multiple tasks.

R=ericrk@chromium.org

Bug: 791828
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7f82f2001846df02469e9976d12581706c1673b7
Reviewed-on: https://chromium-review.googlesource.com/1041525
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555849}

Previously, if a test was retried (because of unexpected failures), the
results from all retry attempts would show up in the "actual" field in
the summary; but if a test ran multiple times because of --iterations or
--repeat-each, only the last result would be included in the summary.

This CL makes iterations and repeats behave the same as retries in terms
of the result summary. All results from all iterations and repeats from
all retries are now included in the "actual" result field in summary.
This will make it easier for other tools (e.g. FindIt) and users to
debug flaky tests, and won't affect existing bots as they don't use
--iterations or --repeat-each.

Some code-health improvements are done along the way (e.g.
expectation_to_string).

There are some questions regarding the existing behaviours. In order to
minimize the risk, this CL strives to ensure backward compatibility. We
will revisit some of the behaviours later.

Bug: 828605
Change-Id: Ibb5a329eb8dc60fd0ae857083ebddc3b1c86f5f0
Reviewed-on: https://chromium-review.googlesource.com/1029430
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555848}

This CL moves the data tables used to test the zip parsing code
into its own source file.

Also modify generate_zip_test_tables.sh to also generate data for
a zip archive that contains two mock uncompressed shared libraries.
These will be used in a future CL that changes the way the crazy
linker loads files from zip archives.

BUG=802068
R=agrieve@chromium.org, lizeb@chromium.org, pasko@chromium.org

Change-Id: Ifb440eb3c050227bb3e9354f4ead859824362c76
Reviewed-on: https://chromium-review.googlesource.com/1042245
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555847}

https://pdfium.googlesource.com/pdfium.git/+log/ccd942158992..525147a1f6d6

$ git log ccd942158..525147a1f --date=short --no-merges --format='%ad %ae %s'
2018-05-03 tsepez Use strict types in FPDF API, try #3

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3f93264c762d93f5ff66abd9544d977d19c7a1b2
Reviewed-on: https://chromium-review.googlesource.com/1042272
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555846}

Change-Id: Iee154e8ecf72ab6be0cb40feed764ffbbeab803e
Reviewed-on: https://chromium-review.googlesource.com/1038889Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555845}

Bug: 755840
Change-Id: I96af63e817abe9bdefb0916da4d652e97c620a2c
Reviewed-on: https://chromium-review.googlesource.com/1037631
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555844}

Aura synthesizes a mouse event at certain times, including when the
window comes back from being minimized. Currently it uses the last known
mouse position, which works in most cases. However, the window doesn't
get mouse events when minimized, so the last known position isn't
updated. When the window comes back, if the user's mouse is not over the
window it can cause buttons to get stuck in the hovered state until the
user moves the mouse back into the window.

To fix this, this patch uses the real mouse position.

This patch also updates content_shell to move the mouse to 0,0 in
headless mode, to avoid any queries to the real mouse position from
interfering with blink tests. This patch also adds an implementation
for MoveCursorTo on Windows.

Bug: 828591, 834166
Change-Id: I81354c77805c1928eb0cbccb900856a8c523709d
Reviewed-on: https://chromium-review.googlesource.com/1022959Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555843}

 video-controls-focus-movement-on-hide.html is still flaking heavily on Mac.

 So I'm re-updating the expectations.

Bug: 833658
Change-Id: I80627456e327797b31725970ba3a8438d990f416
Reviewed-on: https://chromium-review.googlesource.com/1042790Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555842}

This cl makes use of the previously added omnibox-new-answer-layout flag.
It separates the omnibox-rich-entity-suggestion flag from answer layout
so that the two changes can be tested together or individually.

Bug: 838733
Change-Id: I30d9acc5d32fd603010f0dea6b9c8f38df29cf10
Reviewed-on: https://chromium-review.googlesource.com/1038744Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555841}

The button will allow touch and stylus users to activate Select-to-Speak
without a keyboard, but is also able to be used with a mouse.

This adds a button to the tray that is notified and updates its appearence when
Select-to-Speak state changes. In a following change, the Select-to-Speak
extension will listen to state change requests from the button.

Bug: 753018
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3a1ab08c579696cf199c32deec368473952b57fc
Reviewed-on: https://chromium-review.googlesource.com/1040268
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555840}

Test: manual
Bug: 839290
Change-Id: Ib72e5b43a1a8a0e7dd429dbef90de9b6b1b820c6
Reviewed-on: https://chromium-review.googlesource.com/1042809Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555839}

Bug: 824568, 752273
Change-Id: Ia5a814ef83e1869e4d3065f5c0afa402f1ec7d61
Reviewed-on: https://chromium-review.googlesource.com/1041222
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555838}

Add implementation to create OFFER message and handle ANSWER response.
Add the MirrorSettings which hold a set of default settings.

Bug: 734672
Change-Id: Ia6b9af5ac66e1f8f9496c0afaa335a22f40bb535
Reviewed-on: https://chromium-review.googlesource.com/1017235
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555837}

A function used to not remove from the secondary table when deleting.
This CL adds a one-time per device clean-up of the rows in the
secondary tables that were left behind.

Bug: 836737
Change-Id: Icfe70b8ee98deb5a3de1fc1f3b08b197e9760132
Reviewed-on: https://chromium-review.googlesource.com/1038582
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555836}

This CL names the base::ScopedClosureRunner object in the XmlParsingDone
function. Previously, a temporary object was created, so the closure
would be called at the end of the expression. Naming the object ensures
it won't be called until the function ends.

Change-Id: I80805f85d15e75f287d169b381144c7fabbea1e7
Reviewed-on: https://chromium-review.googlesource.com/1037704Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555835}

The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is
unpredictable and can return surprising values in certain circumstances.
It is deprecated and should be removed to ensure that callers are using
the WebContents they expect.

Update the webstore APIs (dashboardPrivate, inlineInstallPrivate,
webstorePrivate, and webstoreWidgetPrivate) to use
GetSenderWebContents() instead.

Bug: 461394

Change-Id: I0c42797004c62218ab8de139ce58a175f796a50a
Reviewed-on: https://chromium-review.googlesource.com/1019567Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555834}

FeedHostServiceFactory will create FeedImageManager when creates
FeedHostService.

Bug: 807359
Change-Id: Ibe4718c382972d16de6081ce8b84309e5308557f
Reviewed-on: https://chromium-review.googlesource.com/1041074
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555833}

Changes related to libsync caused a build failure on MacOS when EGL is enabled.

Credit to zmo@ for this fix, which I cherry picked from:
https://chromium-review.googlesource.com/c/chromium/src/+/1005017/19..20

Bug: chromium:757974
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie4b38b3d0c782fea4e12f5d99e2f50add94ebf84
Reviewed-on: https://chromium-review.googlesource.com/1042488Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555832}

Bug: b/77279478
Test: cast_media_unittests
Change-Id: I45ede6c40cbe7fca9dc7273e1ee1e179184a43d5
Reviewed-on: https://chromium-review.googlesource.com/1040662Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555831}

R=mmoroz@chromium.org

Change-Id: Ia83a10d1e5c5cb2d81c4bcea2b6839b0e47e1012
Reviewed-on: https://chromium-review.googlesource.com/1042808Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555830}

Fixes a regression in Linux handling of omnibox text like dict:word.
Regression caused omnibox to default to treating it as a url. This
CL makes Linux default to treating it as search text.

Regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/966896

Bug: 838570
Change-Id: I26be4279605ded6e3aed4e631f503e2b60551283
Reviewed-on: https://chromium-review.googlesource.com/1040881Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555829}