GitLab

Position the ripple container relative to the element instead of the
viewport. This will allow the ripple effect to transition with the
element instead of floating in place.

https://screencast.googleplex.com/cast/NDg3NjY2Njc1Mjk5MTIzMnxlNzNlODU3My1jOQ

Bug: 864823
Change-Id: I4352ff9792d16aaa59f610634d71bb46362141b0
Reviewed-on: https://chromium-review.googlesource.com/1184035
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585240}

Currently, the blink v8 initialization code uses a stack address-taken
variable to read the stack position. This fails with SafeStack because
it reads an address on the unsafe stack. Make it match the code in v8 to
read the stack position safely with either ASAN or SafeStack [1] by
using a compiler intrinsic.

[1] https://crrev.com/c/1162669

Bug: 864705
Change-Id: Ib972540eb0264d9f737eb8bc40c601b8b2cf1ab0
Reviewed-on: https://chromium-review.googlesource.com/1179265Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585239}

Having the content dependency creates various problems for builds and
unit tests.

Bug: internal b/111732331
Bug: internal b/112417856
Bug: internal b/112328895
Test: cast_test_lists for Android
Change-Id: I17ef19c77a8062225e9124d6eef58189dcfc504d
Reviewed-on: https://chromium-review.googlesource.com/1180426Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585238}

This method uses the NavigationController API to query the committed
navigational state on a Frame.

Bug: 852145
Change-Id: I49f9122753c393ef33d67905353b5ba1afad157a
Reviewed-on: https://chromium-review.googlesource.com/1182507Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585237}

Refactor the MaybeAllowImagePlaceholder() and MaybeAllowLazyLoadingImage()
functions to checks and enable the placeholder request bit separately.

This will help with lazyloading of CSS background images.

This is reland of below CL which had some formatting issues in local_frame.cc
https://chromium-review.googlesource.com/c/chromium/src/+/1178637

Bug: 846170
Change-Id: I9cf76d6e938a798d91b42d265964ad0c981054a1
Reviewed-on: https://chromium-review.googlesource.com/1180597
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585236}

Bug: 862425
Change-Id: I317be9b1cd25e921c04712fe0e04cdd0d77bd27b
Reviewed-on: https://chromium-review.googlesource.com/1185377Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585235}

When we start processing a gesture event, the
OnHasTouchEventHandler(false) IPC message may not yet
be received which means the |scrolling_touch_action_|
has no value and that results a crash.

This CL fixes the problem by call ResetTouchAction()
in TouchActionFilter's constructor. At that moment, the
|has_touch_event_handler_| is default to false which
will set both |allowed_touch_action_| and
|scrolling_touch_action_| to Auto.

Bug: 850238, 851644
Change-Id: I36f3edf2b9292347f184458aa059904af1a2f597
Reviewed-on: https://chromium-review.googlesource.com/1180592
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585234}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ic888995f3a49848ecfe96c2aea55c1d2d365924c
Reviewed-on: https://chromium-review.googlesource.com/1126328Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585233}

Bug: 857266
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I58c2cb9e7b2ddf90dc9609945e418b27047f1e34
Reviewed-on: https://chromium-review.googlesource.com/1184043
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585232}

Bug: 875936
Change-Id: I27b4e463c128d3dc36fe8e72b47d18db99699410
Reviewed-on: https://chromium-review.googlesource.com/1181778Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585231}

Bug: 876044
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3c37686f609acdcc479edb18c764e981c32c873c
Reviewed-on: https://chromium-review.googlesource.com/1184147Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585230}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I890952c728f084d643ac05a83b2eba4817fad699
Reviewed-on: https://chromium-review.googlesource.com/1185640
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585229}

Add a unit test that attempts to dynamically set an invisible icon in the toolbar.

Bug: 805600
Change-Id: I7ec07eb6bb3c205a69df0c4afd3b549370d1ef11
Reviewed-on: https://chromium-review.googlesource.com/1157127
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585228}

https://chromium.googlesource.com/catapult.git/+log/bbb04a38bbdb..c67a80df2679


git log bbb04a38bbdb..c67a80df2679 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 anthonyalridge@google.com Fix bug in key selectors.


Created with:
  gclient setdep -r src/third_party/catapult@c67a80df2679

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866423
TBR=sullivan@chromium.org

Change-Id: I6240d90f1786833df42567cc90901557a8ba1e2f
Reviewed-on: https://chromium-review.googlesource.com/1184869Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585227}

We want to push people to use the Launcher as the modifier everywhere.
This particular Delete shortcut was missing as Launcher+Backspace is
already wired up to be Delete.

Bug: 876774
Change-Id: Ibf1569a5094f819451ce32fe2178ed68fca9e830
Reviewed-on: https://chromium-review.googlesource.com/1185213Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585226}

Bug: 775415
Change-Id: Iceffd5b34d5fdecf3c72486b96e77f4ece2a423d
Reviewed-on: https://chromium-review.googlesource.com/1183907Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585225}

Before this CL, an ad-hoc implementation of FormatBytesWithUnits
was used, rather than call ui::FormatBytesWithUnits().

Bug: 775415
Change-Id: Ieb125023ef50943ef164b3d97246ba7e6fc8ad27
Reviewed-on: https://chromium-review.googlesource.com/1179667
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585224}

//content doesn't expose RefCounted-ness of ServiceWorkerContexts.
This means there's no safe way to run IO thread tasks on a
ServiceWorkerContext that was obtained on UI thread, typically
through StoragePartition::GetServiceWorkerContext.

This CL exposes a static method that takes in a ServiceWorkerContext*
and a OnceCallback and then it add ref-count to the underlying
ServiceWorkerContextWrapper until the OnceCallback is called.

Bug: 875376
Change-Id: I2d5c3bfa605679623e7558f507e31cf425c2804d
Reviewed-on: https://chromium-review.googlesource.com/1176734
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585223}

Bug: 814405
Change-Id: Ia123c66f60e0e941d1a2ccf8e3ae7e5262eebba4
Reviewed-on: https://chromium-review.googlesource.com/1170236
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585222}

If the URLRequest has reported headers to the URLLoader, but there's no
pending body read, URLRequest will report a read error. URLLoader didn't
expect this, since there was no pending read.

This CL adds handling for this case. Ideally, we'd wait until there was
a pending URLRequest read before failing the request, to keep the state
machine of higher levels sane, but that's an issue for another day.

Bug: 875258
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I1ad1eddf590914e8b48379f4da7b3597f5b5158a
Reviewed-on: https://chromium-review.googlesource.com/1185214Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585221}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4cc579e9d288..ded74c1409ac


git log 4cc579e9d288..ded74c1409ac --date=short --no-merges --format='%ad %ae %s'
2018-08-22 xixuan@chromium.org cbuildbot: Add passed_mins for skylab suites.


Created with:
  gclient setdep -r src/third_party/chromite@ded74c1409ac

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I3895b75e50df0f2e50efb88ff3d6e8cf57724d2b
Reviewed-on: https://chromium-review.googlesource.com/1184866Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585220}

Bug: 766082
Change-Id: Idd4a607177f0bbe44fac8dd9e7cd9fe357dbf4ef
Reviewed-on: https://chromium-review.googlesource.com/1170906Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585219}

This simplifies many conditions around the code.

Bug: 561800
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I133a9bde31fa93538f890a3d66dce6652cbd34ca
Reviewed-on: https://chromium-review.googlesource.com/1180837Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#585218}

Looks like most of the work on this bug was already done. ThreatDetails
is only on the UI thread, and a callback is used after
FinishCollection. These mitigated the immediate problems with
ThreatDetails lifetime. This CL just does the final switch to owning
ThreatDetails with a unique_ptr.

Bug: 777915
Change-Id: Id89b34bb1ee2dbb7a5305822751780ee4ac2e862
Reviewed-on: https://chromium-review.googlesource.com/1183782Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585217}

Using wpt-import in Chromium f18439bd.
With Chromium commits locally applied on WPT:
2160c22c "Modify source path for wpt test of Accept-CH"
f4c510e1 "Move XR LayoutTests over to be WPTs"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23130

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ib4f0f04f5a3f1164f161d00949818f62aa127423
Reviewed-on: https://chromium-review.googlesource.com/1185286
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585216}

This removes the mojom interfaces DevDisplayController and DisplayController which
are unused. OutputProtection is still necessary. As OutputProtection is now provided
by ash, OutputProtection has been moved to ash. Additionally, OutputProtection has
been renamed to DisplayOutputProtection. OutputProtection was previously in the
display namespace, so that renaming to DisplayOutputProtection makes it more
obvious what the class is for.

BUG=842365
TEST=none


Change-Id: I1f469032fc991139964b04b9740da64abafa89e0
Reviewed-on: https://chromium-review.googlesource.com/1183892Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585215}

The video recording in Android has violet the assumption of
SharedQuadState which states that the union of DrawQuads in a given
SharedQuadState is defined in |ShareQuadState::quad_layer_rect|.
This bug reveals that the VideoDrawQuad is not contained in its
SharedQuadState.

Bug: 869704

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I158275fbb321de84f7808e82b770d2f0b3cec8bc
Reviewed-on: https://chromium-review.googlesource.com/1184503Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585214}

https://chromium-review.googlesource.com/c/chromium/src/+/1183991 added
an early exit for drags without drag images to prevent a crash on Mojave.

DragDropClientMacTest.ReleaseCapture posts a task to end a drag before
starting the drag. Since the drag data it was providing had no image,
the drag was exiting before the task could post, making the EndDrag()
posted by the task a UAF.

This change adds an image to the drag data to prevent this.

Bug: 876201,876758
Change-Id: Icbdd38ff65a690fdb7f7512a8686c2e3d4344286
Reviewed-on: https://chromium-review.googlesource.com/1185219Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585213}

This CL should not change any behavior. It's removing some old code
no longer used.

R=oysteine@chromium.org

Change-Id: Icfdbdcc5a5e40d740401ecb9b25536425c4c5e61
Reviewed-on: https://chromium-review.googlesource.com/1178383Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585212}

VrAssetsComponentInstaller is used at Chrome startup to check wether we
want to install the VR assets component. However, the
VrAssetsComponentInstaller was part of the VR DFM, which is not part of
the Chrome bundle. Therefore, move VrAssetsComponentInstaller to the
base module so that it is always available.

Bug: 876053
Change-Id: I43b3215a0ffaf9d29f8c45edf094257f987db431
Reviewed-on: https://chromium-review.googlesource.com/1182300Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585211}

This reverts commit 42e740f0.

Reason for revert: linux-chromeos-rel is failing device_unittests,
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/12315, speculativly reverting this CL.

BUG: 876841

Original change's description:
> Move call to GetInfo command after AuthenticatorAdded()
> 
> In order to prevent system UI dialogs for BLE/Touch ID from appearing
> prior to WebAuthN UI, we hold off on dispatching request to
> authenticators until user consents on using the specified transport
> type. However, in current implementation, we send GetInfo command to
> external BLE authenticators as soon as we discover the device. This
> would trigger OS UI dialog on Mac for unpaired devices and potentially
> cause BLE connection failures on other platforms. As so, move call to
> GetInfo command after FidoRequestHandlerBase::AuthenticatorAdded().
> 
> Bug: 847985
> Change-Id: I37b7cd8118c3edb799fa29c36700febbb2b3d08e
> Reviewed-on: https://chromium-review.googlesource.com/1182946
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585130}

TBR=martinkr@google.com,jdoerrie@chromium.org,hongjunchoi@chromium.org

Change-Id: I6ba8d08a85a3e9319257d11e0b2b5e5e01cfc7b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847985
Reviewed-on: https://chromium-review.googlesource.com/1185683Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585210}

Bug: 831327
Change-Id: I97741f8ae23337907ba05bb1de2285f9737ab6cc
Reviewed-on: https://chromium-review.googlesource.com/1184380Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585209}

https://crbug.com/873999 shows that placeholder text in <input> could
be selected by long press below it.

This is because for this code path we passed a corrected click point.
y-coordinate was adjusted to 0, which will lead
|LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel()| give a
incorrect result, then in
|SelectionController::SelectClosestWordFromHitTestResult()|, it gets
the placeholder <div> in the <input> Shadow DOM as the hit test result
position.

We now pass the normal point so it could figure out the position is
at <input>, which is more reasonable.

Bug: 873999
Change-Id: I6d9ee4d03778ad65493eff8735d58cf271d07a57
Reviewed-on: https://chromium-review.googlesource.com/1174963
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585208}

This is only used for ANGLE, and geofflang suggests that this doesn't
apply to ANGLE any more, as it does mostly the same thing in both cases.

Bug: 829614
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I25371dcef4043edd0abbdf4e943778771246918e
Reviewed-on: https://chromium-review.googlesource.com/1185283Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585207}

Renaming this class to remove "Install" because it will also be
used to actually launch the app after installation. The change to
add the launching capability is separated from this one to keep
things clean.

Bug: 870093
Change-Id: I78798632084670feef64dadfb119ff9ed8f0960b
Reviewed-on: https://chromium-review.googlesource.com/1183693
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585206}

Change-Id: I89e4c117c81c0990a9fba071d8e09656545facb6
TBR: nhiroki
Reviewed-on: https://chromium-review.googlesource.com/1184134Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585205}

This patch does a few things to hopefully speed up the viewport update
during pre-paint:

- Only process overlay scrollbars if we're on a platform that uses
them.
- Cache the element id on the visual viewport rather than creating it
each time the getter is used.
- Use passed in node pointers for the current context, rather than
assuming we should use the root nodes.

With these changes, we also reenable running this viewport update in
!enable-blink-gen-property-trees mode.

Bug: 868927
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I161b8b1901cb2183f060130ecec058ca5f693170
Reviewed-on: https://chromium-review.googlesource.com/1183983
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585204}

The "TODO: Deprecate" was ambiguous. I think the intent is that new code
shouldn't use it and the TODO is to migrate existing code.

Bug: 796799
Change-Id: I73b135b937d65649ff2f0c5fc99723353065e9bb
Reviewed-on: https://chromium-review.googlesource.com/1184136Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585203}

The observer model was a source of crashes since it had tricky lifetime
as the ServiceWorkerRegisterJob keeps a reference to
ServiceWorkerVersion but tries to observe its EmbeddedWorkerInstance
which can be reset to another instance at any time. We tried to mitigate
it before with OnWillBeDestroyed() but it wasn't sufficient.

Just use a callback instead.

Bug: 876541, 855852
Change-Id: Ic3546716108fa0e7af1e3fada8ca79ec32846a8a
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/1184133Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585202}

First some background (true both before and after this CL).
NavigationURLLoaderImpl roughly operates like this:
1. Ask interceptors whether they want to handle a request until
   one says yes (call MaybeCreateLoader).
2. Apply URLLoaderThrottles to the request, possibly rewriting it.
3. Have the interceptor handle the request (invoke its RequestHandler).

But before this CL, the interceptor could not observe the rewritten
request. Therefore, this CL:
1. Adds |resource_request| to RequestHandler signature.
2. Renames the request passed to MaybeCreateLoader to
   |tentative_resource_request| to make more clear that it is not
   necessarily the final request.

Of course, in the current code, interceptors are treating
|tentative_resource_request| as the final request, so this CL adds TODOs
to those interceptors.

The motivation of this CL is service worker interception. Before this
CL, service worker interception would dispatch the fetch event and get a
response before calling the LoaderCallback indicating whether the
service worker wants to handle the request. This was convenient for
network fallback in case the service worker fetch event did not provide
a response.

This CL changes service worker interception to operate after throttling.
This has several motivations:
1. The service worker fetch event may provide an inappropriate response
   for the request if it sees the pre-throttled request rather than the
   post-throttled request.
2. If throttling changes the URL, it would result in a simulated
   redirect, so the service worker interception would have been
   wasteful.
3. This also fixes the missing variation header for navigation preload
   requests, since the throttles will add the header before the fetch
   event.

Change-Id: If13ff956e46de91abb43f3919f869dc5e1eba3e6
Bug: 873061, 873575, 876531, 876527
Reviewed-on: https://chromium-review.googlesource.com/1174204Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585201}