GitLab

BUG=

Review URL: https://codereview.chromium.org/897903003

Cr-Commit-Position: refs/heads/master@{#314579}

InspectorNetworkTabTest.testHTTPResponseTimelineRecorder is flaky on
Win 7 Tests, it fails 11 out of the last 14 runs.  Disabling for now.

BUG=455269
TBR=bolian
NOTRY=true

Review URL: https://codereview.chromium.org/898903003

Cr-Commit-Position: refs/heads/master@{#314578}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4dce32c..1a481fe

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899913002

Cr-Commit-Position: refs/heads/master@{#314577}

Add a class to deal with the streaming/digesting, and hook it up.  File streams are usable in a wider range of scenarios (like over MTP) so this enables hashing in those situations.

BUG=453880

Review URL: https://codereview.chromium.org/875513006

Cr-Commit-Position: refs/heads/master@{#314576}

On Windows, this moves it to chrome_child.dll. Overall binary sizes is 4.5 MB smaller (chrome_child.dll gets 3.6 MB larger while we drop the 8.1 MB pdf.dll). On Mac, the binary is 6.6 MB smaller. On Linux, it's 7MB smaller. This is from official release builds, after stripping on Linux.

The size savings are because we don't ship duplicate versions of V8, and also the PDF plugin uses some of base and net.

This depends on OOP PDF, since otherwise the V8 isolates for the plugin and Blink interact badly. That got turned on a few weeks ago.

BUG=453844

Review URL: https://codereview.chromium.org/799643004

Cr-Commit-Position: refs/heads/master@{#314575}

Add a unit test for DeviceMotionEventPump to ensure that events are not delivered to Blink at a rate faster than 60 Hz.

TEST=DeviceMotionEventPumpTest.PumpThrottlesEventRate
BUG=421691

Review URL: https://codereview.chromium.org/870053009

Cr-Commit-Position: refs/heads/master@{#314574}

Since https://codereview.chromium.org/899663003, child accounts would get both the "supervised user" and the "child" icons. This CL fixes that.

Review URL: https://codereview.chromium.org/897903002

Cr-Commit-Position: refs/heads/master@{#314573}

Review URL: https://codereview.chromium.org/900513005

Cr-Commit-Position: refs/heads/master@{#314572}

This removes plumbing for InstrumentWillBeginFrame(),  InstrumentDidBeginFrame(),
InstrumentDidCancelFrame() and InstrumentWillComposite() between CC and
WebDevToolsAgent and replaces it with trace events emitted directly from CC.
Note all related methods of LayerTreeHostClient still remain, as they're used
in tests.

TBR=jamesr
(for mojo/)
BUG=

Review URL: https://codereview.chromium.org/892203002

Cr-Commit-Position: refs/heads/master@{#314571}

Introduce a local typedef for the DownloadIdCallback type since it
is really simple.

Remove obsolete #includes.

BUG=453790

Review URL: https://codereview.chromium.org/888983003

Cr-Commit-Position: refs/heads/master@{#314570}

Revert of scheduler: Increase work batch size to 4 (patchset #3 id:40001 of https://codereview.chromium.org/873313006/)

Reason for revert:
Reverting because of layout test failure:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/dom/MutationObserver/end-of-task-delivery.html,inspector/sources/debugger/live-edit-no-reveal.html

Original issue's description:
> scheduler: Increase work batch size to 4
>
> BUG=444764
>
> Committed: https://crrev.com/6ef9302baebb894ced09f28741f86bbb626ed82a
> Cr-Commit-Position: refs/heads/master@{#314546}

TBR=rmcilroy@chromium.org,alexclarke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444764

Review URL: https://codereview.chromium.org/877043004

Cr-Commit-Position: refs/heads/master@{#314569}

At present, a change in the default zoom level does not immediately
update the zoom icon in the location bar. E.g. if we change the zoom
level of chrome://settings to 90% (causing the zoom icon to display a
'-' symbol), then change the default zoom level to be 75%, the icon
should switch to show '+'.

This CL adds an event subscription to the ZoomEventManager in order
to receive notifications about default zoom level changes.

BUG=451349

Review URL: https://codereview.chromium.org/897513003

Cr-Commit-Position: refs/heads/master@{#314568}

https://codereview.chromium.org/884993003 broke gdb debugging
on Release buils. This commit makes sure it works to debug
Debug and Release (only on rooted device) builds.

BUG=453379

Review URL: https://codereview.chromium.org/891743003

Cr-Commit-Position: refs/heads/master@{#314567}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d3780c5..4dce32c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/898663004

Cr-Commit-Position: refs/heads/master@{#314566}

ChromeVox uses Google closure-style dependencies (goog.provide and
goog.require) and this script gives a quick view of the dependency tree for
a module.

R=dtseng@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/894853006

Cr-Commit-Position: refs/heads/master@{#314565}

BUG=454800
DIFFBASE=869073006

Review URL: https://codereview.chromium.org/900663002

Cr-Commit-Position: refs/heads/master@{#314564}

BUG=

Review URL: https://codereview.chromium.org/886613002

Cr-Commit-Position: refs/heads/master@{#314563}

This CL implements policy pushing for device-local accounts. The
Tango connection comes from AffiliatedInvalidationServiceProvider,
which manages a single shared connection for device policy pushing
and device-local account policy pushing, conserving server resources.

BUG=442800
TEST=New unit test

TBR=dcheng (profile_invalidation_provider_factory.h)

Review URL: https://codereview.chromium.org/822523003

Cr-Commit-Position: refs/heads/master@{#314562}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/874293007

Cr-Commit-Position: refs/heads/master@{#314561}

. Remove ThreadLocalState::id_, since it is the same as the thread-id.
  (http://crrev.com/3f8178ae)
. Remove WorkerThreadTaskRunner::current(), since it's no longer used.
  (http://crrev.com/3a4b2d1a)

BUG=none
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/898803003

Cr-Commit-Position: refs/heads/master@{#314560}

Reland of: 862103002 at patchset 120001
Reverted here: https://codereview.chromium.org/875983008/

BUG=454553, 433180
R=jww@chromium.org, bcwhite@chromium.org, jwd@chromium.org, sky@chromium.org
TBR=mlerman@chromium.org

Review URL: https://codereview.chromium.org/900583003

Cr-Commit-Position: refs/heads/master@{#314559}

In addition to that the patch restores the unique key in the LoginDatabase which was incorrectly abolished in https://codereview.chromium.org/818443004. The former key was (origin, signon_realm, username_element, username_value password_element, submit_element). The correct one used by Sync is without submit_element.

BUG=400674,368075

Review URL: https://codereview.chromium.org/894583003

Cr-Commit-Position: refs/heads/master@{#314558}

This CL is an iteration of http://crrev.com/766713004, that got reverted
after http://crbug.com/445265 because it could not cope correctly
with structures of the type:

<histogram_suffixes name="SafeBrowsingStores.SBWhiteLists" separator=".">
  <suffix name="CSD" label="CSD"/>
  <suffix name="DownloadWhitelist" label="DownloadWhitelist"/>
  <affected-histogram name="SB2.DatabaseKilobytes"/>
</histogram_suffixes>

(in particular: affected-histogram-suffixes).

Limitation that should be solved now.

Original description ---------------------------------------------------

Add PRESUBMIT check if modified UMA histogram name can be found

This Presubmit checks if some diffs affect any UMA_HISTOGRAM_*
macro and, if so, checks if the histogram name is to be found
in either tools/metrics/histograms/histograms.xml or in the
CL diffs.

Addresses the problem of someone modifying code and
inadvertently forgetting a corresponding histograms.xml
adaptation, that has happened in the past.

BUG=434420, 445265

Review URL: https://codereview.chromium.org/885783007

Cr-Commit-Position: refs/heads/master@{#314557}

Move the task of managing the task-runners for the worker-thread/main-thread in
a common implementation in WorkerThreadMessageFilter, and use that from the rest
of the message filters.

BUG=none
R=jochen@chromium.org, kinuko@chromium.org

Review URL: https://codereview.chromium.org/892543002

Cr-Commit-Position: refs/heads/master@{#314556}

Cr-Commit-Position: refs/heads/master@{#314555}

The error log is as follows:
../../third_party/skia/include/core/SkImageInfo.h:109: error: undefined reference to 'SkDebugf_FileLine(char const*, int, bool, char const*, ...)'
collect2: error: ld returned 1 exit status

If any modules are going to use any Skia header no matter whether directly or
indirectly, the module must link Skia. src/media/blink doesn't depend on skia
directly but src/media, on which src/media/blink depends, depends on Skia. So
src/media/blink must link to Skia.

Review URL: https://codereview.chromium.org/885373003

Cr-Commit-Position: refs/heads/master@{#314554}

BUG=450050

Review URL: https://codereview.chromium.org/899673003

Cr-Commit-Position: refs/heads/master@{#314553}

This is one of the steps needed to move ContextProviderInProcess to
android_webview.

BUG=338338
R=jamesr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/890873007

Cr-Commit-Position: refs/heads/master@{#314552}

BUG=454799

Review URL: https://codereview.chromium.org/869073006

Cr-Commit-Position: refs/heads/master@{#314551}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/901493002

Cr-Commit-Position: refs/heads/master@{#314550}

After https://codereview.chromium.org/874833003/, every mixed-content requests from the ServiceWorker are blocked.
So we can show the HTTPS padlock because every responses from the ServiceWorker to the page are created using the resources which are served through the secure protocol.

To show the padlock we fill the SSLInfo of the response from the ServiceWorker using the SSLInfo of the ServiceWorker script.

When we support fetching mixed-content requests from the ServiceWorker in the future, we have to check the security level of the responses.

BUG=392409

Review URL: https://codereview.chromium.org/877623002

Cr-Commit-Position: refs/heads/master@{#314549}

This patch change VideoCaptureController to ignore buffers that cant be converted to I420.
This is mostly important for failures in MJPG decoding.

BUG=453761

Review URL: https://codereview.chromium.org/882883004

Cr-Commit-Position: refs/heads/master@{#314548}

BUG=338837

Review URL: https://codereview.chromium.org/829583002

Cr-Commit-Position: refs/heads/master@{#314547}

BUG=444764

Review URL: https://codereview.chromium.org/873313006

Cr-Commit-Position: refs/heads/master@{#314546}

BUG=437865

Review URL: https://codereview.chromium.org/898553002

Cr-Commit-Position: refs/heads/master@{#314545}

BUG=346797
TBR=plundblad@chromium.org

Review URL: https://codereview.chromium.org/900623005

Cr-Commit-Position: refs/heads/master@{#314544}

To fix a few tests the current behavior when navigating from a non-live RFH was changed so that the new, speculative one is immediately set as active matching what is done in RenderFrameHostManager::UpdateStateForNavigate. This replaced the behavior of simply bringing the current RFH back to life.

With this change 6 tests are fixed for PlzNavigate:

    RenderFrameHostManagerTest.WebUI
    WebContentsImplTest.NTPViewSource
    RenderFrameHostManagerTest.NewTabPageProcesses
    WebContentsImplTest.CrossSiteBoundariesAfterCrash
    WebContentsImplTest.CrossSiteComparesAgainstCurrentPage
    WebContentsImplTest.ShowInterstitialFromBrowserNewNavigationProceed

BUG=439423

Review URL: https://codereview.chromium.org/892123002

Cr-Commit-Position: refs/heads/master@{#314543}

They weren't being properly reported before (the report happened later than it
should) but now there's two different reporting points for current navigation
and for when PlzNavigate is enabled.

BUG=416877

Review URL: https://codereview.chromium.org/874353003

Cr-Commit-Position: refs/heads/master@{#314542}

This makes the geolocation permission tests run for both infobars and
permission bubbles. The tests now run as parameterized tests.

Supercedes parts of:
https://codereview.chromium.org/411503005/
https://codereview.chromium.org/341833004/

BUG=438758

Review URL: https://codereview.chromium.org/787033004

Cr-Commit-Position: refs/heads/master@{#314541}

Revert of Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #1 id:1 of https://codereview.chromium.org/830393004/)

Reason for revert:
The bug is not reproducible anymore. Some fixes to shelf were done earlier, may be that prevents that one problem

Original issue's description:
> Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #3 id:40001 of https://codereview.chromium.org/783663003/)
>
> Reason for revert:
> Appears to have caused bug 446212
>
> Original issue's description:
> > Special check on Supervised User creation flow added to prevent misleading shelf alignment.
> >
> > BUG=405361
> >
> > Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee
> > Cr-Commit-Position: refs/heads/master@{#309555}
>
> TBR=dzhioev@chromium.org,skuhne@chromium.org,merkulova@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405361
>
> Committed: https://crrev.com/e2e8ff56d1937bb635884032534def9fc42b7809
> Cr-Commit-Position: refs/heads/master@{#310145}

TBR=dzhioev@chromium.org,skuhne@chromium.org,abodenha@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=405361

Review URL: https://codereview.chromium.org/871353003

Cr-Commit-Position: refs/heads/master@{#314540}