GitLab

Make sure the monitor does not collect the proxy's address if one was used.
(In the process, refactor RequestInfo to contain the whole HttpResponseInfo,
tighten up OnRequestLegComplete, and poke at unittests a bit.)

Also, count network errors as well as HTTP errors as failures (!).

BUG=356791

Review URL: https://codereview.chromium.org/267633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269657 0039d316-1c4b-4281-b951-d872f2087c98

Suppress uninitialized reads in IPC::Channel::ChannelImpl::ProcessOutgoingMessages while we analyze them.

BUG=371991
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/274193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269656 0039d316-1c4b-4281-b951-d872f2087c98

Will be used by chromium_trybot_arm recipe.

R=mseaborn@chromium.org, phajdan.jr@chromium.org
BUG=359338

Review URL: https://codereview.chromium.org/246623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367366

Review URL: https://codereview.chromium.org/277083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269654 0039d316-1c4b-4281-b951-d872f2087c98

To avoid stack allocation of Skia effects we made their constructors non-public
and provide factory methods instead. This patch updates the remaining uses of
the constructors in Chrome.

BUG=skia:2187

Review URL: https://codereview.chromium.org/271073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269653 0039d316-1c4b-4281-b951-d872f2087c98

It was just an alias for chromium_builder_asan and it was removed from
the buildbot scripts at https://codereview.chromium.org/257903004 (
svn://svn.chromium.org/chrome/trunk/tools/build@266374)

BUG=None
TEST=green trybots
R=dpranke@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/270623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269652 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/279623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269651 0039d316-1c4b-4281-b951-d872f2087c98

The position returned from last_mouse_position() is in screen
co-ordinates but the calculation steps for the composition expect that
the cursor position be relative to the desktop dimentions.

This change transforms the screen relative position into a position
relative to the desktop window and hence relative to the secondary
display.

BUG=371761
TEST=Under ChromeOS capture a secondary screen and observe that the
pointer is now composed into the video steam in the correct place

Review URL: https://codereview.chromium.org/278873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371881

Review URL: https://codereview.chromium.org/273123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269649 0039d316-1c4b-4281-b951-d872f2087c98

Remove NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from image_writer_private and signed_in_devices API.

Use ExtensionRegistryObserver instead.

R=kalman@chromium.org
BUG=354458

Review URL: https://codereview.chromium.org/263393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269648 0039d316-1c4b-4281-b951-d872f2087c98

This code path is disable by default, and is also tested in GestureProviderTest.

The test suite is currently running into some memory leaks, see
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/32287/steps/memory%20test%3A%20aura/logs/stdio
for an example.

BUG=371990

NOTRY=true

Review URL: https://codereview.chromium.org/271283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269647 0039d316-1c4b-4281-b951-d872f2087c98

Import C++11 headers for unordered map and set when using libc++ in protobuf's config header to avoid warnings.
    
BUG=366218
TBR=brettw

Review URL: https://codereview.chromium.org/246633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269646 0039d316-1c4b-4281-b951-d872f2087c98

Other bookmarks observer might make their own changes on add, triggering updates
before the add call arrives. Be resilient against this.

BUG=369728

Review URL: https://codereview.chromium.org/277033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269645 0039d316-1c4b-4281-b951-d872f2087c98

Chromium started to use glib to parse .desktop file:
https://codereview.chromium.org/7000018

However, use_glib is not added when use_ozone is defined,
which causes a build error.
https://codereview.chromium.org/249583003

BUG=none

Review URL: https://codereview.chromium.org/276673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362288

Review URL: https://codereview.chromium.org/270763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269643 0039d316-1c4b-4281-b951-d872f2087c98

If tab capture is enabled, but the window that is being displayed is
occluded, then the quality of the broadcast may be negatively impacted
by throttling of its presentation.

To avoid this, disable throttling the presentation of the windows that
are occluded but may be being captured.

Do not disable throttling for non-occluded windows, because that will
result in the renderer overloading the browser, and frames being dropped
by the browser, resulting in unsmooth animation.

BUG=350410

Review URL: https://codereview.chromium.org/279523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361761
TEST=no visible change

Review URL: https://codereview.chromium.org/274883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269641 0039d316-1c4b-4281-b951-d872f2087c98

This limits the address space used for discardable memory on MacOSX
by using the DiscardableMemoryManager for userspace eviction.

Includes some minor refactoring to keep all code using
DiscardableMemoryManager consistent.

BUG=369246

Review URL: https://codereview.chromium.org/261993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269640 0039d316-1c4b-4281-b951-d872f2087c98

The tests affected are:
    PolicyTest.ExtensionInstallSources
    PrefsFunctionalTest.TestDownloadDirPref
    WebNavigationApiTest.Download

BUG=372017
R=bauerb@chromium.org
TBR=jam, joaodasilva

Review URL: https://codereview.chromium.org/273233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269639 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Some refactorings to facilitate a larger change to TemplateURLService. (https://codereview.chromium.org/270533007/)

Reason for revert:
See memory failure: bot: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759/steps/unit_tests/logs/stdio

Original issue's description:
> Some refactorings to facilitate a larger change to TemplateURLService.
> 
> BUG=365762
> R=pkasting@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269310

TBR=pkasting@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365762

Review URL: https://codereview.chromium.org/279063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269638 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne… (https://codereview.chromium.org/272573004/)

Reason for revert:
Seems to be causing use after free on Mac: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759

Original issue's description:
> Handle TemplateURLService load failure better, and make some test correctness fixes that will be needed later.
> 
> This also does a variety of miscellaneous cleanups to the modified files.
> 
> BUG=364183
> TEST=none
> R=jered@chromium.org, pkasting@chromium.org
> TBR=engedy
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269329

TBR=pkasting@chromium.org,zea@chromium.org,jered@chromium.org,engedy@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364183

Review URL: https://codereview.chromium.org/273153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269637 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)

Reason for revert:
Suspected of being responsible for ash_unittests failing on Linux ChromiumOS Tests(1):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/43114


Original issue's description:
> Linux Aura Task Manager Frame Buttons Misaligned
> 
> The task manager is a CustomFrameView. This had the logic for its button
> placement hardcoded. The view now adds itself as a listener for button
> configuration changes on linux. For other systems it falls back on a
> default set that matches the current (minimize, maximize, close) order.
> 
> The layout of the buttons has changed to consult this order definition.
> 
> Loading the assets for the close button has been moved out of layout.
> ResourceBundle only loads the asset once, so this can be done during
> initialization.
> 
> The top padding for the buttons has been updated to provide more spacing. It now fits the rest of the padding in the class.
> 
> TEST=CustomFrameViewTest
> BUG=351917
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269597

NOTREECHECKS=true
NOTRY=true
BUG=351917

Review URL: https://codereview.chromium.org/276173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269636 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data. (https://codereview.chromium.org/268643002/)

Reason for revert:
Unfortunately I have to revert this change because this is in the way of reverting https://codereview.chromium.org/270533007/.

The above change is causing some use after free failures on Mac. Please see this: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759/steps/unit_tests/logs/stdio

Original issue's description:
> Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data.
> 
> BUG=365762
> R=engedy@chromium.org, jochen@chromium.org, pkasting@chromium.org, zea@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269396

TBR=pkasting@chromium.org,zea@chromium.org,engedy@chromium.org,jochen@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365762

Review URL: https://codereview.chromium.org/280113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/277563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269634 0039d316-1c4b-4281-b951-d872f2087c98

-Added classes for fetching/reading file hashes (.cc details are still
  mostly stubs in this CL though)
-Added a delegate class for ContentVerifier to rework how clients interact
  with it
-Added code in ContentVerifyJob that uses the hash reader class

BUG=369895
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/280013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269633 0039d316-1c4b-4281-b951-d872f2087c98

Removing mcs_hostname and mcs_secure_port from GServicesSettings.
Adding mcs_main_endpoint and mcs_fallback_enpoint.
Constructing the main endpoint based on g-settings from the checkin.
Constructing the fallback endpoint based on mcs hostname and default
fallback port.

R=jianli@chromium.org,zea@chromium.org
BUG=359254

Review URL: https://codereview.chromium.org/270403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269632 0039d316-1c4b-4281-b951-d872f2087c98

This is a small patch that adds a trace event instant whenever we draw
checkerboards. This is useful for debugging or figuring out exactly
when we checkerboarded.

R=enne

Review URL: https://codereview.chromium.org/275173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347720

Review URL: https://codereview.chromium.org/267103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269630 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Avoids releasing capture in EndMoveLoop if capture was switched to another window while dragging (https://codereview.chromium.org/265843004/)

Reason for revert:
Appears to be responsible for ash_unittests failing on Linux ChromiumOS Tests(1): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/43114

Original issue's description:
> Avoids releasing capture in EndMoveLoop if capture was switched to another window while dragging.
> This variant relies on checking if a drag input window still has capture before releasing the grab.
> A better alternative is in CL https://codereview.chromium.org/262893002/.
> 
> BUG=363503
> TEST=Follow the exact steps in the bug description.
> TEST=interactive_ui_tests --gtest_filter=*TabDragging*
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269593

TBR=sadrul@chromium.org,varkha@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=363503

Review URL: https://codereview.chromium.org/276163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269629 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Memory leak detected: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1239/steps/aura_unittests/logs/stdio

Original issue's description:
> Unified Gesture Recognizer
>
> This adds the unified GR for Aura behind the --use-unified-gesture-detector flag.
>
> BUG=332418
> TEST=GestureRecognizer/GestureRecognizerTest.*
>   MotionEventUITest.*
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269325

Review URL: https://codereview.chromium.org/278183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269628 0039d316-1c4b-4281-b951-d872f2087c98

It emits NCN.NetworkOperatorMCCMNC_NewMetricsLog on new metric log creation with the network operator MCC_MNC code 

BUG=355604

Review URL: https://codereview.chromium.org/253203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269627 0039d316-1c4b-4281-b951-d872f2087c98

Also add an explicit check for whitelisting pepper/nacl
permissions based on importing a shared module, so a shared
module can potentially limit allowing import of its resources
and permissions its allowed.

You can still use nonsfi mode for Linux or ChromeOS by
passing in --enable-nacl-nonsfi-mode, but it is on for a
whitelisted set of extensions for ChromeOS without flags.

BUG=355141
TEST=deploy_chrome to daisy, test app which includes whitelisted module

Review URL: https://codereview.chromium.org/264923011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269626 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/275683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:369679
TEST=Tested manually on daisy

Review URL: https://codereview.chromium.org/276023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269624 0039d316-1c4b-4281-b951-d872f2087c98

This has been broken since https://src.chromium.org/viewvc/blink?revision=172846&view=revision landed.

Review URL: https://codereview.chromium.org/276983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269623 0039d316-1c4b-4281-b951-d872f2087c98

Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded, and fix a bug that previously causes this cl to crash the browser upon signin.

Basically GCMStatsRecorder::RecordRegistrationResponse() method did not check whether is_recording_ is true or not, so it always records. When the user signs in, a registration event is automatically triggered, but since the gcm-internals page has not been loaded yet, a callback object is still NULL. Therefore recorder calling this callback will crash the browser. I have added the check as well as test case for this scenario.

BUG=341256, 371259

Review URL: https://codereview.chromium.org/277743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269622 0039d316-1c4b-4281-b951-d872f2087c98

If the process is unable to create a new thread we've got bigger issues
to deal with than reporting an error. A CHECK() will also give us
a sense for how often this happens in the wild.

BUG=110814

Review URL: https://codereview.chromium.org/276593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269621 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371897
R=rockot@chromium.org
TEST=ran UsbApiTest.TransferEvent under Dr. Memory

Review URL: https://codereview.chromium.org/275993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269620 0039d316-1c4b-4281-b951-d872f2087c98

HttpServer: Handling of multiple header fields with the same name and multiple values of "Connection".

BUG=370437

Review URL: https://codereview.chromium.org/274813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269619 0039d316-1c4b-4281-b951-d872f2087c98

Separate out context creation that does not need surface or service
into separate CreateOffscreenContext call.

Do not create GLSurfaceStubs on client side, and pass in NULL window
so the context creates GLSurfaceStubs on service side.

Clean up share context code since compositor does not need an offscreen
context anymore.

BUG=370566

Review URL: https://codereview.chromium.org/271763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269618 0039d316-1c4b-4281-b951-d872f2087c98