GitLab

While, at the moment, I don't believe we will end up asking for the
authenticator's ECDH key twice, when we support the PRF extension we
could. Thus add a cache and skip asking an authenticator for it twice.

Change-Id: I73ecaa38447cbbe04f34c12d83f9c79bca553c90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255208
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781110}

Adding the option for homepage promo to suppress the sign in promo when
user is not signed in.

Bug: 1068831
Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781109}

This is a reland of 676d0cb1.

TBR=fdoray@chromium.org
Bug: 1032250

Original change's description:
> Use default icons for PE files lacking their own.
>
> PrivateExtractIcon (underlying the icon loading service) may fail to
> supply an icon for PE files that do not have one embedded and would
> display as a blank area when downloaded. This change fetches the
> default for the file extension prior to fetching the file's embedded
> icon. It is difficult to do this only on failure as the ownership of
> IconLoader means it has already been deleted when we learn about the
> failure. It should be relatively cheap to fetch the default icons as
> these will be cached by the OS, and this occurs in the main process.
>
> Tests: Added LoadDefaultIcon in icon_loader_browser_test
> Bug: 1032250
> Change-Id: Ifad1c9f013d0e4fe87aaec5ec0cdeae08d06799e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242371
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779542}

Change-Id: Ie7f5e57dbbfb1ebf5d9fc588e15b1a2687212bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254823Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781108}

If a WebAuthn request is pending and another call to
CreditCardFIDOAuthenticator is made, then cancel that request.

Bug: 949269
Change-Id: I7061809ff873ceaf77b5cfc6f8e7e02f5c1535f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255743Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#781107}

Speeds up android-binary-size trybot by not having to link
libwebviewchromium.so in order to build monochrome's .pak files.
Each link is about 8 minutes on the bot.

On my speedy machine, extracting the whitelist takes < 2 seconds even
without any concurrency.

Tested that the whitelist matches what it was before (and the
android-binary-size trybot shows this as well).

Bug: 1078460
Change-Id: Idac3ba2cb64842539e2f1e2319f35d2495172a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254533Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781106}

We are using ChromeDriver to simulate user inputs in tests, and when we
are doing selecting all text by pressing cmd+a on Mac and ctrl+a on
other platforms, copying text by pressing cmd+c on Mac and ctrl+c on
other platforms, cutting text by pressing cmd+x on Mac and ctrl+x on
other platforms, and pasting text by pressing cmd+v on Mac and ctrl+v on
other platforms. We are setting the edit commands in blink side in
third_party/blink/renderer/core/editing/editing_behavior.cc.

Bug: chromedriver:3462
Change-Id: I26ac3aa0c1b7ce518c9e977a51ca2eead369c94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218393Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781105}

Roll Chrome Win64 PGO profile from chrome-win64-master-1592848702-1e1967415d9c07114dc1aabb08c26a82150dd920.profdata to chrome-win64-master-1592859555-f08c66ddf994e8777f6044c180c36d7bb50b914d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I5db58da92c9bef6ed55b3872e3f190b0d24e9ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781104}

This CL fix the issue by 2 step
1. Resizing image for search should keep the original ratio.
2. The Thumbnail need to use rich entity size instead of favicon size.

Bug: 1095702
Change-Id: I65f27ee5f485d6bad03fc0cb97c37fc1f0d6d2b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250784Reviewed-by: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781103}

This CL introduces a method PDFiumPage::PopulateChoiceFields() which
reads choice form fields from the PDF document and stores relevant
information in a vector within PDFiumPage.

The CL also includes a new test file with sample choice fields and a
unit test to validate the new method.

Bug: 1030242
Change-Id: Ie8dc9da6c694747d8fef7721625f7690dda64124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249244Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781102}

Thread priority should not be modified after a test.
If that is happening, it needs to be fixed in the code.

This CL remove the code that disable the priority checks.

NOTE TO SHERIFF:
 * please paste failure logs when reverting, the goal is
   to remove flaky tests related to thread priority.
 * assigned flaky test to etienneb@

Bug: 1097092
Change-Id: I7046cfa59b5269c00cdbda5ec27189e5367fa264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254522Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781101}

Removes the old per directive CSP methods and replaces them with a
generic one that supports easy expansion in the future.

Fixed: 1087443

Change-Id: I4e8dfe391a0ff73a032f6b7cc41525981f0048dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246839
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781100}

This CL fixes the problem that GetCharacterIndexAtPoint or
GetFirstRectForRange from TextInputClientMac couldn't handle a child
widget. When TextInputClientMac requests mojo calls for them, it
tries to find the focused frame but it couldn't handle a child widget
since it uses RenderViewHostImpl and RenderViewHostImpl is nullptr
when the widget's owner_delegate is empty. So, it introduces
GetFrameTree to RenderWidgetHostDelegate, gets FrameTree* through
the method, and finds the focused RenderFrameHostImpl using FrameTree.

Bug: 1094841, 1007365
Change-Id: I8da969886ef8d99347c09ae226bcbdeefc84ec0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245450Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781099}

[Controls Refresh] Fix virtual/dark-color-scheme/datetimelocal-picker/datetimelocal-open.html Flaky Test

Inconsistent load times on datetimelocal-open.html caused for flaky results. This CL normalizes the load time for the elements on this test page, fixing the flaky test.

Bug: 1092091
Change-Id: I98899884cec85cd693aa4f465b758c8c65220452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256154Reviewed-by: Yu Han <yuzhehan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781098}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ecf4348..03a7835c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie87597d31ac114f763c07ffecb734321bccd6e88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258195Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781097}

https://chromium.googlesource.com/catapult.git/+log/fc7f25ba95db..80948d0b7803

2020-06-22 hypan@google.com devil: Fallback to '0' for Fastboot.GatVar('slot-count')

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1090485
Tbr: nuskos@google.com
Change-Id: Ibfdd8377d458715a283f66403ee0f8ad5f9f6307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258660Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781096}

CL:2222068 modified ARC++ focusability and accessibility name
computation.
In that change, we introduced concepts of ScrollableContainer and
ToplevelScrollIem. For ToplevelScrollItems, we compute its a11y name
from descendants if necessary. So we shouldn't do it for
ScrollableContainers, but we're not checking it.

This CL fixes the bug.

Bug: b:152930082
Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*"
Test: manual. Open PlayStore, and open "About this app" dialog from app detail page. Each text nodes gets focus from ChromeVox.
Change-Id: Idb84b30c2461e73d6be5f929546c3af712cf2a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253681
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781095}

Anecdotally, GATT connection reliability on Windows is higher if the
Bluetooth adapter is not scanning while the connection attempt occurs.
Hence, make FidoCableDiscovery invoke BluetoothDiscoverySession::Stop()
before connecting to a device. Obviously, there is a possibility of
scans occurring for other reasons. But that's unlikely to happen and we
can't do anything about it.

Note that stopping the scan probably means a single FidoCableDiscovery
instance can at most connect a single device. However, caBLEv1
currently only really supports a single authenticator anyway.

Change-Id: Ibaac6bc1563e4429dad0df9570f77c594ed1469c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211281
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781094}

Added fyi builders and the corresponding try builders. Mirroring
corresponding iOS 13 configs and tests.

Bug: 1096857
Change-Id: Iba47cf1d8b6a6e445f13b73bb62d8b1d0efa390a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253247Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781093}

Change-Id: I2a63b67d71b7cd73cb7843a653b9cec67d94cd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255201
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781092}

Moving importance computation from AXTreeSourceArc into DataInfoWrapper
makes clear the responsibilities of each classes, where the former is
managing the entire tree and the latter computes properties of each
node.

This will allow us to make unit tests of each DataInfoWrapper classes
easier.

Bug: b:152930082
Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*"
Test: tast tests still passes.
Change-Id: Ia2f03af1788908560fdb92748df7d702b11dada5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249432Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Sara Kato <sarakato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781091}

Changes the use of same/cross-origin to same/cross-site to reflect the
change in the approach. Accordingly, names helper files more
appropriately. Also makes the ordering of tests more natural and adds
descriptive names to each test.

Bug: 1092991
Change-Id: If9bebebea8b0b51db2d4f8c1c3ab1ddf1e2fb233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248867
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781090}

To support app item drag operation for items for which a context
menu has been show, the shelf app button context menu is set up to
redirect gesture events to the menu owner - i.e. the hotseat widget.
While this works in the cases where the user keeps the touch over the
app icon while the context menu is shown, in certain situations the
gesture event would not reach the app button view, leaving the button in
drag state even after the gesture completion:
1.  it the touch moved just outside the button bounds as the context
    menu was being shown, the redirected gestures could get consumed
    by the shelf view
2.  if another touch point was added, the combined gesture may end
    up falling outside the hotseat widget, in which case the redirected
    gesture event would not reach the shelf at all.

To address 1. the HotseatWidgetDelegate view overrides the view targeter
logic to return the app button for which a context menu is shown (if
such button exists).
To address 2. the HotseatWidget clears the drag state for the app button
for which the a context menu is shown when it receives a gesture end
event directly (without relying on Widget::OnGestureEvent to deliver the
event to the app button view).

BUG= 1087539

Change-Id: I4a4b8b7cad16e0b00daedd8f8e2073cea6f1a82d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255315
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781089}

In OOBE, during enrollment into Demo Mode, the user selects a locale
variant. That selection is stored both in the locale state and the
profile preferences. However, the profile is discarded and a new profile is
always used when a Demo Mode session starts. For this reason, the locale
selected by the user is lost and only the fallback browser locale is
kept. This means that "fr-CA" becomes "fr" for Demo Mode.

This change allows Demo Mode to check for the local state locale after
a new session has started, which is set as the application locale of the
profile for the remained of the session.

Bug: b:158695273
Change-Id: I6c7d3f0508ee1a6bd4078309bb9e6110e8968c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251138
Commit-Queue: Claudio M <claudiomagni@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781088}

This is to unblock a Chromium roll into WebRTC which complains that the
arg can't be recognized.

The task to add back the arg to some builder configs is tracked at:
crbug/1092583.

Bug: 1097093
Change-Id: Ia006723d85630f2b07c8e8207bfe436ac7a37cfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258415Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781087}

Change-Id: I2ae2cb55b9fd0f48e7af1a5f8c77983840a42d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256919
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781086}

I mistakenly removed the logic in crrev.com/701823 when I removed
inner viewport clip layer/node. I thought with the inner viewport clip
node removed, the outer viewport clip node was the only clip node to
expand, but missed the case of root scroller replacing the original
outer viewport scroller.

Bug: 1095769
Change-Id: Ica0cb86fec43a79fbf2fa5dca48641f19f28458f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255525
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781085}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: If8e894fbbe301e48d0a71eda43410d2e9eeebae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258361Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781084}

This reverts commit 7a90fb2e.

Reason for revert: 

Test fails on iphone-device builder. 
https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9322
https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9323
https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9324

Original change's description:
> [iOS] Single screen screenshot metric action.
> 
> Creation of the 'MobileSingleScreenScreenshot' metric and its collection when a user takes a screenshot of a single screen.
> 
> Change-Id: Ib95e031a36f922450f602e6fdfb7ccf14928cf76
> Bug: 1065909
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218552
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
> Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com>
> Cr-Commit-Position: refs/heads/master@{#780918}

TBR=rkaplow@chromium.org,marq@chromium.org,seblalancette@chromium.org,jmentasti@google.com

Change-Id: I4813e9434c61f00c31401e902778fddcfbad5517
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1065909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258898Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781083}

Create two elements, one for Print Preview, and one for the normal
viewer.

Bug: 1048812
Change-Id: I391d3d8b2a6a45d23fd0f1b7012e430d7d132153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236897Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781082}

Use is for drag to (un)maximize as it uses a customized cross fade
animation which is predicted to be less performant. This will prevent
that particular animation from bringing down the regular cross fade
numbers.

Tast-test change: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2253047

Test: manual, updated tast test
Bug: 1081986
Change-Id: I3650480845a6a98765a45232c5acc4e0f8fb4636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242591
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781081}

We want to keep the text fragment runtime enabled feature for a bit
longer since there's some holdback experiments we may want to run.
However, to unblock https://crrev.com/c/2255552 we can remove the REF
check inside the Document constructor.

This check guards the behavior where we remove the `:~:` and all
following characters from the URL's fragment on the Document and store
it in the Document's fragment_directive_ member instead. This alone will
not affect text-fragment behavior when the REF is off (text fragments
still won't work) because the fragment_directive_ is only read in
TextFragmentAnchor::TryCreateFragmentDirective which is still guarded by
the REF.

This does mean that when the REF is off that URLs will now lose the
directive part of the fragment (the :~: and after). This should be ok
for the purposes of the holdback experiment. This also affects the
TextFragmentAnchor.ElementIdFragmentFound metric which measures how
often an element id in a fragment is matched. Before this CL, if the REF
is off we would try to search for an element id like
`elementid:~:directive` which will almost certainly fail. Since we'll now
strip the directive we may find the element id in these cases. This is
consistent with what the metric is measuring and this was last used when
making changes to the API so there shouldn't be issues comparing numbers
across this change.

Bug: 919204,987027
Change-Id: I35d4df9d9c707f2d507c117d65739d3c41dca821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258792Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781080}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7748094578e1..b7db183f0206

2020-06-22 ehmaldonado@google.com git-cl: Use shell=True when running yapf using vpython on Windows.
2020-06-22 vadimsh@chromium.org [lucicfg] Update it to v1.17.0.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1096936,chromium:1097215
Tbr: agable@chromium.org
Change-Id: I2251f675789cfa1cbadc2619735be7e2f2d35cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258657Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781079}

This removes TypedNavigationTimingThrottle now that we no longer need
to track the Omnibox.URLNavigationTimeTORedirectToHTTPS metric, and
marks the histogram entry as obsolete.

Bug: 1089192
Change-Id: I7d79132d15019dae2114b017bfdb53674ca976f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258422Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781078}

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: I25ffc1d6e46a86ba0b491f74deee234510541658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254663
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781077}

Currently fps reflects how many frames are shown on the screen per
seconds. This isn't really helpful because we don't know how many
frames are we expecting to show on screen.

In this CL, we add a DroppedFrameCounter class, which keeps track
of how many frames are expected to show on screen, and how many
of them are dropped. With that, fps graph is different. When a
compositor frame is dropped, it shows a red vertical line. When
a main-frame that misses its commit deadline, it shows a
yellow vertical line. Otherwise, it means a frame is successfully
presented on screen, then we show a green vertical line.

With the new graph, we deprecate the throughput meter that is
beneath the fps graph. Also, instead of showing how many fps,
we show percentage representing throughput.

Bug: 1064290
Change-Id: I04ac95a07cd795c9b33c3c1ec5bfe6fa0529f6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244002
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781076}

TBR: anthonyvd@chromium.org
Bug: 1098067
Change-Id: I8efe101a662483f2aa49e4d1af80f62c93462f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258641Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781075}

Text fragments listen for scrolling so that they can stop trying to keep
a fragment in view during load and to record metrics about users'
scrolling behavior related to text fragments.

However, the condition used to filter non-user scrolls is
IsExplicitScrollType which includes programmtic scrolls. This is carried
over from regular fragments but means our metrics above will include
programmatic scrolls.

This CL fixes the condition and updates tests to check all scroll types.

Some tests are moved around, for ease of review PS1 makes changes to the
test, PS2 is just the code move.

Bug: 1097426
Change-Id: Ib86690d1af0303299edde8007786df2d81af6518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255779
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781074}

Removing can_be_default parameter because all callers specify true for
it. This parameter was used for the isolated app effort
(https://crbug.com/69335), and is no longer being used outside
of extensions.

Bug: 1085275 159932
Change-Id: I880eaf5aa956b707eea3fc33ae190104e40335ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250220
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781073}

Currently the hidden/extended shelf does not update the hotseat density
after screen rotation. This CL fixes the issue by calculating the
hotseat density based on the shelf target bounds in home launcher state.
In order to achieve it, code to calculate the hotseat target bounds is
refactored and the function to return the target bounds size for the
given hotseat state is created.

Bug: 1097504
Change-Id: If1bf3c677d997e2aabc1e7333fff101dbf625dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256155
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781072}

We want to continue monitoring these metrics, as touch scrolling of
scrollbars is moving to the compositor thread when possible, and then
always as part of scroll unification.
Consolidate these to expire after M89 at which point we can probably
narrow down the set of these to keep collecting going forward (e.g.
we'll probably always want to track TimeToScrollUpdateSwapBegin4).

Bug: 1088762, 1088761, 1088760, 1088759, 1088758

Change-Id: Ia8d1c2643684c79dee38689c18174d3aaa2784c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253370Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781071}