- 05 Mar, 2020 40 commits
-
-
Viktor Semeniuk authored
This change adds UI for visualizing compromised credentials list in password check page. Also, it uses passwordsPrivate extension API to obtain required data. Bug: 1047726 Change-Id: Ia80ffd5d52447722d175aa5d66f10c2eb7dd3500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078257 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747221}
-
Marian Fechete authored
This CL adds a separate dropout reason for browse mode compared to regular mode in prompt action. Bug: b/147412447 Change-Id: I87a99c862011c20c0ad02ff1bc32e91cd47d7ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087621 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#747220}
-
Youkichi Hosoi authored
This constitutes a part of change to enable NDK translation on ARCVM. We identify the binary translation type (None/Houdini/NDK translation) by seeing USE flags passed from Chrome OS. This information on the binary translation type is passed to Android via the property androidboot.native_bridge, which can be accessed as ro.boot.native_bridge. BUG=b:139480143 TEST=components_unittests TEST=Edit /etc/ui_use_flags.txt, and run getprop after restarting ui Change-Id: Id5810369f3c4e82fda54ed9d2b32be3ad168723e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071675Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Auto-Submit: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747219}
-
Jan Wilken Dörrie authored
This change implements the resolution of LWG3255 in base::span. Following this change base::span allows conversions from std::array that add const or volatile qualifications. References: - https://cplusplus.github.io/LWG/issue3255 - https://github.com/cplusplus/draft/commit/2ae381 Bug: 828324 Change-Id: Ib58e769b841f58778a547109f654cceda3a75cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087720 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747218}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e5534c4419d5..2de34c1791f3 git log e5534c4419d5..2de34c1791f3 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 brandon1.jones@intel.com Residency 1: Add Chromium's LinkedList to /common/ Created with: gclient setdep -r src/third_party/dawn@2de34c1791f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib935788a480d48bdc3cc36810a316e1c76e5eb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747217}
-
Jan Wilken Dörrie authored
This change implements the resolution of LWG issue 3320 by removing the members cbegin(), cend(), crbegin() and crend() from base::span. This was done because std::cbegin(std::span<T>()) and std::span<T>().cbegin() returned different results if T was non-const. Note that the nested const_iterator type is not yet removed from base::span, as this breaks using it in gMock matchers like ElementsAre. This will be addressed once gMock no longer requires the presence of this nested type. References: * https://wg21.link/LWG3320 * https://github.com/cplusplus/draft/commit/6faa9c TBR=dcheng Bug: 828324 Change-Id: I21f8ffaa0c7183d6e63a087b73f271b677d13f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086231 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Increment the version UrlBarController is available from. Bug: 1025607 Change-Id: I1331921c937883e265b2f6cdf1520039f8f350cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081416Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#747215}
-
Edward Lin authored
Add the CPU cache routine and the CPU stress routine to cros_healthd. The CPU cache routine and the CPU stress routine runs the stressapptest to diagnose the CPU. Bug: b:146513388 Test: unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest.* Change-Id: I7189344dbce41f09c18debbfe3ca5415526647a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041981 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#747214}
-
Anastasiia Nikolaienko authored
Record the service type received with the mirror response header. Change-Id: I7b1e37ac00bcce3472aeee81f4a28547488c52fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037676Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#747213}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74dd93df. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I41bfce9a2d94070a8df6c3fdd35010038efa0073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089391Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747212}
-
Artem Sumaneev authored
User must not be able to run ARC applications and Crostini VM when following conditions are true: 1. User is not affiliated 2. DeviceRebootOnUserSignout policy is set and is not NEVER 3. Cryptohome state requires powerwash If all the above is true then when user attempts to run ARC application or Crostini VM, notification is shown instead of actual run. BUG=b:146418942 TEST=Manual and unit tests Cq-Depend: chromium:2033344 Change-Id: I3d1a78750d098302c642b44343ab53c6983e80e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992081Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/master@{#747211}
-
Michael Lippautz authored
Adds the following abstractions: - MemoryRegion: Simple Address and size pair. - PageMemory: Abstraction holding an overall reservation and some writeable area. - PageMemoryRegion: Either a contiguous area of normal pages or an area for a single large page. Creates guard pages around writable regions. Guard regions are always added, independently of whether the provided allocator can actually commit them properly and capped at a maximum of 16KiB. In practice this will result in all platforms except PPC getting protected regions and PPC only getting an unprotected region. Drive-by: - Remove multi-threaded handling of PageMemoryRegion as all data structures are thread local and no regions are shared across threads. Change-Id: I1232216b13ce51482676b16a467dd97d141ac4c7 Bug: 1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083304 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747210}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f1aee3cbb9f..99eb20b513da git log 3f1aee3cbb9f..99eb20b513da --date=short --first-parent --format='%ad %ae %s' 2020-03-05 asapersson@webrtc.org StatsEndToEndTest: Configure bitrate via VideoEncoderConfig. 2020-03-05 mbonadei@webrtc.org Fix links in docs/native-code/index.md. Created with: gclient setdep -r src/third_party/webrtc@99eb20b513da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id8cac51597437cae5da675340aebe7c15a1061a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089375Reviewed-by:
-
Michael Lippautz authored
Adds a public/platform.h that is required to be implemented by embedders to provide certain features. Page-level allocation goes through this interface. This is used to allow e.g. Blink to provide their own OOM callbacks and page tags. Provide a basic implementation of the PageAllocator using base primitives that can be used for testing. Bug: 1056170 Change-Id: Ib25269d6f8ed793d2b111dd750cef9d4a6d772a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083022Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The metric is supposed to compute time spent per marked bytes and not allocated heap size which includes garbage as well. Bug: 986235 Change-Id: Ifdc1eedb276f8ce6a324774e233c132fefa1c747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087726 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Eric Willigers authored
PWA and web app files have been removed from the extensions ui directories. The OWNERS files were referencing files no longer present. Change-Id: I74b944bb4a0a601759886f435bf76e406ea45140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087235Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747206}
-
Jose Lopes authored
This is a repeating callback because it's called from a call chain that links to a loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/mp2t_stream_parser.cc?rcl=385d1322d09f871a327371f0ded2b2d70714bde2&l=873 * https://cs.chromium.org/chromium/src/media/formats/mp2t/mp2t_stream_parser.cc?rcl=385d1322d09f871a327371f0ded2b2d70714bde2&l=139 * https://cs.chromium.org/chromium/src/media/formats/mp2t/mp2t_stream_parser.cc?rcl=385d1322d09f871a327371f0ded2b2d70714bde2&l=345 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: I51a2e7a5b0fe87b114cbedabe2040961d3bb6215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080417 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747205}
-
Vidhan authored
[Autofill] Rename GetElidedValueAt to GetSuggestionValueAt and GetElidedLabelAt to GetSuggestionLabelAt Bug: 1045401 Change-Id: I746756c64e4c9a7e528c6a9441d6b0a777600f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087624 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747204}
-
Anastasiia Nikolaienko authored
Add Polymer template for the views in login flow, component for buttons and CSS. See http://doc/1WVGl7i7uWTnMEa3MPPVALegDM-7RabDv6z3JrAw53Sg Bug: 1043108 Change-Id: I70d4a1e75e3cdf8889ce211eacb7946db09cba9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007455 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
The activity indicator is created when needed. It should not be added in -[UserSigninViewController viewDidLoad]. The constraints are correctly created when the indicator is created, in -[UserSigninViewController addActivityIndicatorToView]. Bug introduced with: crrev.com/c/2087214 Related to: crrev.com/c/2079111 Bug: 971989 Change-Id: Id0e08b6884c6c05e15516d987c062eaf691345b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087922 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747202}
-
Adrienne Walker authored
IndexedDBContext access is going away, and so these tests need to use public mojo interfaces instead of private indexeddb interfaces. This converts some easier browser tests over to using the new interface. Bug: 1015214 Change-Id: I68bb1cd46ff6ae13d8b113d37886a499e0d97276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088337Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#747201}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/97a3ce0918a0..da7fe17f810a git log 97a3ce0918a0..da7fe17f810a --date=short --first-parent --format='%ad %ae %s' 2020-03-05 primiano@google.com Merge "UI: restrict non-ready features to internal users only" Created with: gclient setdep -r src/third_party/perfetto@da7fe17f810a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6fb51c1a49093c8bca072cf30ba5b6019e055f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089029Reviewed-by:
-
Clemens Arbesser authored
This CL also adds support for user actions (e.g., Chips) to the UI framework. User actions now have an optional identifier to properly tie them together with interactions. Bug: b/145043394 Change-Id: Ia72807525063362750eeaca55c455a594c084b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080267 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#747199}
-
Omer Katz authored
This CL also adds tests to catch this data race and re-enables the incremental marking test that was disabled because of it (CL 2087957). Bug: 986235, 1058622 Change-Id: Icfb06fb08aaede2b20ef89ebcf8406d314577128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088514Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Eric Willigers authored
TabbedHostedAndBookmarkApps and WindowedHostedAndBookmarkApps tests are replaced with TabbedHostedAndWebApps and WindowedHostedAndWebApps tests that use no Extensions APIs to create or inspect web apps. Bug: 1054116 Change-Id: Ib3713f63cc9e0708cca7dbebc674ba610ec439b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087309Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747197}
-
Anna Malova authored
Bug: 1007815 Change-Id: I8074e7e9cb2c59ceb9f06b25259170e1d1bb47ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087348Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747196}
-
Jose Lopes authored
This is a repeating callback because it's called from a for loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/ts_section_pmt.cc?rcl=2072c031d444a367084f6fc8f766b264316b451c&l=111 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: I45c07133eed8afd6894c22caa7ef4ff0a4f6167a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080363 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Mark Cogan authored
Removes the final call site for the NTP uma function that used TabModelList to get the active web state. Bug: 1032550 Change-Id: Id4630e2691efd7d60febea20e15bd7fcfe3ff1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085271Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747194}
-
Gauthier Ambard authored
The protocol is no longer used as a protocol. The only used in test was looking for a ViewController and it is now only implemented in a Coordinator. Bug: 1038034 Change-Id: Id6ba52f59c484f3b769cee7204c797aef6fc88ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083329 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747193}
-
Mikel Astiz authored
Change-Id: I71239f7e49bd6b2c19a6a526a2a800108154e3cc Bug: 978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077717 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.31-1583145468-benchmark-82.0.4072.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9aa67a7dbe78e71d7d30c801fcda4cee7515c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089372Reviewed-by:
-
Antonio Gomes authored
This CL ends up also converting ViewHostMsg_DidContentsPreferredSizeChange to mojo as well. The reason is because it happens that blink.mojom.LocalMainFrame.EnablePreferredSizeChangedMode() can trigger the invocation of blink.mojom.LocalMainFrameHost.ContentsPreferredSizeChanged(), but the later can also be invoked independently of the former, hence it is not a "completion callback" like mojo message. Target mojo interfaces are LocalMainFrame/LocalMainFrameHost, respectively. Some of the methods and class variable in RenderViewImpl got moved as-is to WebViewImpl, including: - RenderViewImpl::OnEnablePreferredSizeChangedMode() - RenderViewImpl::UpdatePreferredSize() - RenderViewImpl::send_preferred_size_changes_ - RenderViewImpl::needs_preferred_size_update_ - RenderViewImpl::preferred_size_ The call flow now for mojo.EnablePreferredSizeChangedMode() is browser -> mojo EnablePreferredSizeChangedMode -> blink::LocalFrame -> blink::ChromeClient -> blink::WebViewImpl. BUG=1051155 R=dtapuska@chromium.org Change-Id: I3c6fdc73f9d41b30aeee1f6214ee8a0db6abc76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068699Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583147204-benchmark-82.0.4075.0-r1 to 82-4044.31-1583147204-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I42d38cddcd00319575213c10a0483130fd483d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089373Reviewed-by:
-
Finnur Thorarinsson authored
The test selects the first photo, scrolls to the bottom and back up to the top to make sure the selection border is active and of correct size (old bug I encountered once). This should also function as a regression test for bugs like the one seen in issue 1051523 (where a white circle got overlaid on top of all photos). Bug: 1051523, 656015 Change-Id: Ifb119c5e9450be5ef06b303eb3549315c0e4a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083178 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#747188}
-
Rushan Suleymanov authored
Add checks during initial update to investigate some crashes. Some checkers guarantee that index will never be out of range for children nodes. It might lead to creating of null bookmark nodes. Bug: 1050776 Change-Id: I2ae5662620ea2b6c9cf8880c205af5f6ec818784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082383Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#747187}
-
Francois Beaufort authored
This CL makes sure a message is shown to the user when NFC is not supported on the device while Web NFC access has been granted to a website. Messages show up in page info popup and site settings UI. Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1058217#c2 Bug: 1035048, 1055216, 1058217 Change-Id: I4687a353feedd92e233ae1741738aef9bb774ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077685 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747186}
-
Mark Cogan authored
This straightforwardly replaces the use of TabModelList to use BrowserList. Technically this is a functional change because it will check if the passed URL is open in any tab in any window, but that was presumably the desired behavior in the first place. Bug: 1058332 Change-Id: I52075acd0b6e3fa0ccd3bad69ee810769f1031f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087333Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c55fbc4064aa..343ee4e801b1 git log c55fbc4064aa..343ee4e801b1 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 8985fc91089f..c6a4c6d3d8b5 (2 commits) Created with: gclient setdep -r src/third_party/angle@343ee4e801b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I863f19d29a2dab725901a17fb74c188412f83ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089023Reviewed-by:
-
David Roger authored
The feature using this histogram was not launched yet, and this histogram is still needed for a couple months. This CL extends the lifetime to match Profile.Menu.OpenedAfterAvatarAnimation. These two histograms can then be deprecated after the butter status chip is launched. Fixed: 1043731 Change-Id: I5c0cb055baaf46a45c7d71a13d3c5946a2880f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087680Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#747183}
-
Noel Gordon authored
This reverts commit e909f808. Reason for revert: I believe this change broke the breadcrumb elider button drop-down menu. No manual test of this change it seems. Original change's description: > Use SVG icon for files-ng elider button > > Bug: 1035691 > Change-Id: I4aac6e02a90dd7e466f937e7f77a928480fb14e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087860 > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747113} TBR=noel@chromium.org,adanilo@chromium.org Change-Id: I8764d88a5cfaf1565abfb14762983a21254b8c41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089431Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747182}
-
