- 21 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f930e7d1a60..00532126b42d git log 7f930e7d1a60..00532126b42d --date=short --no-merges --format='%ad %ae %s' 2019-09-21 vapier@chromium.org git: handle empty diffs Created with: gclient setdep -r src/third_party/chromite@00532126b42d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I882e4db8f3fb7139be2cbcd9e0b6cf8e242d1ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698734}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bd67d0035a80..edd92eed5bff git log bd67d0035a80..edd92eed5bff --date=short --no-merges --format='%ad %ae %s' 2019-09-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@edd92eed5bff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I24ed1ce40b46e0d7c8bfa99dc1298d3a2805bf8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817274Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2249fef21954..341482072a19 git log 2249fef21954..341482072a19 --date=short --no-merges --format='%ad %ae %s' 2019-09-21 jmadill@chromium.org Capture/Replay: Encapsulate cpp replay. 2019-09-21 jmadill@chromium.org Reland "Refactor built-in symbol table." 2019-09-21 zmo@chromium.org Revert "Refactor built-in symbol table." Created with: gclient setdep -r src/third_party/angle@341482072a19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:998535,chromium:998535,chromium:1006501 Change-Id: Ie3212e3b40aed86a2db7e4b3e35970459d4e980b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817273Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4d1ba4971aa..dcfe55f13f15 git log d4d1ba4971aa..dcfe55f13f15 --date=short --no-merges --format='%ad %ae %s' 2019-09-21 tandrii@google.com git-cache: add --gc-aggressive support. Created with: gclient setdep -r src/third_party/depot_tools@dcfe55f13f15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ie4a07439c9aca17db98b539c8502f47aa7bbeb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817271Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ea0e7864b0ec..7f930e7d1a60 git log ea0e7864b0ec..7f930e7d1a60 --date=short --no-merges --format='%ad %ae %s' 2019-09-21 vapier@chromium.org attrs_freezer: split helpers out of cros_build_lib Created with: gclient setdep -r src/third_party/chromite@7f930e7d1a60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9b5a4b2113b9ae67520223115b0cc698979c4086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817272Reviewed-by:
-
Dan Beam authored
Currently implemented behind the DismissNtpPromos feature flag. Bug: 1003508 Change-Id: Id5006584890d8684ce8c2f1502a367d31f8d7473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810009 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#698729}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b43e50bae25..7db90eab89b7 Created with: gclient setdep -r src-internal@7db90eab89b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibd702f87a8f10552067cfc869fae6977c1c8110b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698728}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0d99db46c9b6f863f079e818e3d719481b9bdabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817270Reviewed-by:
-
Zhenyao Mo authored
BUG=1005971 TEST=bots TBR=kbr@chromium.org Change-Id: I7fa855164374230c6846336c1d3d33f0160546e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817287Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698726}
-
Xiaohan Wang authored
Also updates the corresponding buildflag. Currently this flag controls not only the demuxing, but the platform support in some cases. Rename the flag so it becomes a generic flag controlling platform HEVC support. Tbr: seantopping@chromium.org Test: No functionality change. Change-Id: I6d72c26ba590ce22fa65715609faffe9d6f9a714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816800 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698725}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ia6e3546c76e7a7b276c175226b0664030b6b6c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815946Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698724}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8a3575e04c8..6b43e50bae25 Created with: gclient setdep -r src-internal@6b43e50bae25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I05cea8adb51449ddd263166072cf7e12e5ae3a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817359Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/857bb7ff07a3..2249fef21954 git log 857bb7ff07a3..2249fef21954 --date=short --no-merges --format='%ad %ae %s' 2019-09-21 jmadill@chromium.org Capture/Replay: Move stub implementation to new file. Created with: gclient setdep -r src/third_party/angle@2249fef21954 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Id1dd1cb6fb614ad02e8503329528f372729805b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/11b57f8d09f5..ea0e7864b0ec git log 11b57f8d09f5..ea0e7864b0ec --date=short --no-merges --format='%ad %ae %s' 2019-09-21 vapier@chromium.org cros_build_lib: drop GetCommonPathPrefix helper Created with: gclient setdep -r src/third_party/chromite@ea0e7864b0ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia76f7bdba06a9d6d754f054d37b2971faca246d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817360Reviewed-by:
-
Erik Chen authored
This CL is primarily a code move. It sets the stage for making screen metrics emulator a RenderView concept rather than a RenderWidget concept. The main behavior change is that screen metrics emulation now only applies to main frame render widgets. The changes will propagate to child render widgets via the SynchronizeVisualProperties dance. It doesn't make sense to set screen metrics emulation on a child render widget, since that will create racy conflicts with the actual page properties. Bug: 1006052 Change-Id: I5b4a62bf6fd6cc03ace8cdc546ac90ed2d6f0e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815771 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#698720}
-
Sunny Sachanandani authored
When copying drawing buffer texture to canvas resource provider flip vertically based on whether the resource provider's coordinate system matches with the drawing buffer's. Tested manually by simulating the ChromeOS vertical flip state by overriding the flags in code. Added a pixel test to simulate "save as image" functionality by using toDataURL() which creates a snapshot of the canvas in a similar way. Change-Id: I6e42ed6cf25ba0256294eb2859bbec8f93f94eca Bug: 998661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810023Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#698719}
-
Zhenyao Mo authored
This reverts commit e475b274. Reason for revert: crbug.com/1006453 Original change's description: > Update WMR display info when starting session > > I3491d43245bb53100212fd2d0ab38d8f1222e7c9 addresses the issue where the > render width/height is not initially sent back to the render process. > This is accomlpished by updating the display info when the session starts > instead of on the first render frame. > > A subsequent change, I4cf2ab2ed6455963b1f43f8717941e7a0368416a, wraps > this update around the visibility state. Since the visibility state is > initially hidden, the display info isn't updated resulting in > WebVR/WebXR pages using the wrong resolution > > This change explicitly updates the display info and sends it back to the > MixedRealityDevice when the session starts. > > Change-Id: Ifb4516b36203139038aa943d68e8c3ba717003f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810303 > Commit-Queue: Patrick To <patrto@microsoft.com> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698172} TBR=patrto@microsoft.com,alcooper@chromium.org BUG=1006453 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I07f54396d2835532b305955c7531490d2cae4ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817294Reviewed-by:
-
Peter Kasting authored
This is really a bounds change handler. Bug: 1005568 Change-Id: I1e33f4e44ae517257e52b44a9cfcaa4abe5a487e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817292 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698717}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I11656971483df642b7e6deb6cc8f13e28ee3d8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808194Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698716}
-
Erik Chen authored
RenderWidgets were unnecessarily jumping through RenderViewImpl. This CL presents a slight behavior change: Previously, this method would only be invoked on main frame RenderWidgets. Now it's invoked on all RenderWidgets. Change-Id: I542e1dd5ca0b8376e875594768d23595d78eb8c8 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815223 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698715}
-
Peter Kasting authored
FindBarView was already using a LayoutManager, but also overrode Layout() to do two things: position an invisible FocusForwarderView atop some children, and set highlight paths on the buttons. Each of these tasks is better achieved via another route: buttons can set their own highlight paths, and setting textfield focus can be done by FindBarView itself as long as we exclude the relevant children from processing events. Bug: 1005568 Change-Id: I32c102abeea7fbedf7dbfc57a22ce01e2c976904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817290 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1006424 Change-Id: Ie4f79a8f9f8549da86e6ff803351fbf108d6e26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817328Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#698713}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/0c4d75931a0f..d46cabd73fb4 $ git log 0c4d75931..d46cabd73 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 cwallez Fix the orientation of CubeReflection 2019-09-20 cwallez Remove indirection for colorStates 2019-09-20 cwallez Make ComboRenderPipelineDescriptor non copyable. 2019-09-20 yunchao.he Set y-axis up in normalized coordinate system. 2019-09-20 cwallez Remove indirection for colorAttachments Created with: roll-dep src/third_party/dawn TBR=kbr@chromium.org Bug: dawn:22 Change-Id: I06d6a7904e136381489968898a4279dbb58515d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817285Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#698712}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If866de2f5590eada52b2198c751d0ecdc8e271e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808308 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698711}
-
Yun Liu authored
Bug: 1006397 Change-Id: Ia7565680f4f1507fd6fbd60bc6cd600753a89310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817297Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#698710}
-
Xinghui Lu authored
We would like to enable saved password detection on Android, while keep warning disabled. To achieve this, a new flag SYNC_PASSWORD_REUSE_WARNING_ENABLED is introduced to work along side with SYNC_PASSWORD_REUSE_DETECTION_ENABLED. The next step would be including Android to SYNC_PASSWORD_REUSE_DETECTION_ENABLED. The reason we want to keep warning disabled is that GAIA passwords are not captured on Chrome Android. And for saved passwords, we don't show a warning, so warning is not needed on Android for now. Bug: 1004842 Change-Id: Ic5456b67bf4902ecb7d5d8369a32343b0c4eae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815088Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#698709}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c07ddc63030..f8a3575e04c8 Created with: gclient setdep -r src-internal@f8a3575e04c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If3f4defa694fea0cbbd74f0fb833fd27a2e3f25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817280Reviewed-by:
-
Alex Moshchuk authored
This is in preparation for requiring WARN_UNUSED_RESULT on NavigateToURL() usage in tests. Bug: 425335 Change-Id: Idd45267c1faad0ae1128dbbbd34bf3796d51cea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808174 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#698707}
-
Xianzhu Wang authored
There was a typo in the original code. Bug: 979369 Change-Id: I373a13bd62db9b959f770bc344e8783c173e6a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815762 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#698706}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/03bbef5e1f40..4854b9f8047e git log 03bbef5e1f40..4854b9f8047e --date=short --no-merges --format='%ad %ae %s' 2019-09-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 230cc8f7..5cbf4ebd (698466:698593) 2019-09-20 mellem@webrtc.org Change DatagramTransportInterface methods to pure virtual. 2019-09-20 mellem@webrtc.org Change DataChannelTransportInterface/Sink methods to pure virtual. 2019-09-20 mellem@webrtc.org Cleanup deprecated monitoring of MediaTransport state. 2019-09-20 phoglund@webrtc.org Cap h264 fuzzer input to 200k. Created with: gclient setdep -r src/third_party/webrtc@4854b9f8047e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1005853 Change-Id: I9d3859dba96d911263caa7414a379c88d1d7d14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815895Reviewed-by:
-
inglorion authored
crrev.com/c/1785680 caused us to lower how many linker invocations we run concurrently when doing ThinLTO builds for Windows. This causes the ToTWinOfficial and ToTWinThinLTO64 bots to time out. This change configures those bots to instruct the linker to use more internal parallelism, which should shorten build times (as tested locally). Bug: 1002306 Change-Id: I9f59dd09ab2c7e98c462ba28667bef10f3f3e8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817186Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#698704}
-
Erik Chen authored
The previous version of the test lived in render_widget_unittest.cc and did not have the full context [e.g. RenderViewImpl, etc.]. This caused the test to fail for upcoming improvements to emulation. The updated version of the test now checks production logic and event sequences, rather than test-only paths. By doing so, this CL removes a lot of boiler-plate mocks from RenderWidgetUnittest. Change-Id: I3e102f997d9e42bdd7db55af79a72219bccc83b9 Bug: 1006052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816733 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The applicable scope of a exotic blend mode is defined by the containing effect node, so non-composited exotic blend mode can be handled by PaintChunkToCcLayers just fine, if the scope contains only one other layer and no other reason prevent the blend layer from being merged into that layer. This avoids excessive composited layers of CAP than pre-CAP for blend mode. Composited blend mode not working still needs to be fixed. Some of the remaining failures of the bug may be because of that. Bug: 979369 Change-Id: I52a478bcebd9ba9fc59b9de0aaa1a2f25ee33642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814859 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Lambros Lambrou authored
This replaces the unsigned launchd script with a signed script inside the ME2ME host bundle. This is needed so that we can make changes to the script without having the user re-authorize the host in System Preferences -> Security & Privacy. This also helps with Catalina signing/notarization, because it is expected that Apple's notarization service and/or Gatekeeper will reject an unsigned script. Changes: * org.chromium.chromoting.me2me.sh removed from the installer package. * New script added to the host bundle (with very minor changes needed for it to work). New script is without ".sh" extension, making it language-agnostic (in future, we could convert to a binary). * New script is signed by do_signing.sh - this is required in order to sign the overall host bundle. * Launchd agent plist updated to point to the new script. * Upgrade will preserve the old script and plist, so that users don't have to re-authorize. New installs will use the new script. This is achieved by backing up the old script+plist in preflight and restoring them in postflight. * Updated ME2ME native-messaging host setup to point to the new script. * Permission prompt updated with new name (instead of the ugly string org.chromium.chromoting.me2me.sh). * Uninstaller removes the old script if it exists. Bug: 996989 Change-Id: Id3d7a0a9f666178b6871458b96f0af8177beb301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815977Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#698701}
-
Jan Krcal authored
This CL shows a border around toolbar buttons that have non-empty labels (with a nice fade-in / fade-out while animating the label). This is only enabled when the avatar animation feature is enabled. Bug: 967317 Change-Id: I06668d3548f83d9e646d5f52eb995fb93875a55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771405 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/942d69fa9d5f..bd67d0035a80 git log 942d69fa9d5f..bd67d0035a80 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@bd67d0035a80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ib5c28815c653d81ea7620e5070987ce1eb2afa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817279Reviewed-by:
-
Ella Ge authored
\o/ Doc: https://docs.google.com/document/d/1KrlQ0m5Ty9RKE1IorjEXDldYFJvUV_Ww10lnjh-TRN0/ Bug: 1000682 Change-Id: Ia77af76fd530be740d7d7c64706f47a48c248387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786591 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698698}
-
Steven Bennetts authored
This adds CrosNetworkConfig.ForgetNetwork and uses it in the Internet Settings WebUI. Bug: 1001598 Change-Id: Ic9952b9024b0f8bb7ce42955f8f7d00afdc7ac55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808497 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Dana Fried authored
This prevents us from having to put our layout interpolation code in LayoutManagerBase where it really doesn't belong. Bug: 898632 Change-Id: I837b14ff05eee9f5ea9b2659955d787bde23958e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815665Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#698696}
-
Taylor Bergquist authored
Bug: 1000184 Change-Id: I913d52e05dde3daa18543bf3c684344973a0c341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798174 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#698695}
-
