GitLab

Unfortunately, a side-effect of the capture code we're currently using
is that it triggers an instantaneous loss and then regaining of mouse
hover over the current controls; this results in capture starting and
stopping again in a tight loop.

This change allows existing capture to continue until the first time a
result comes in and either (a) the page is done loading [which is
existing behavior] or (b) we've stopped observing the thumbnail. It
prevents a momentary shakeup in whehter the thumbnail is being observed
from locking the browser into the tight loop described above.

We still want to follow up and determine *why* (and on what platforms -
it might just be Windows) starting capture causes mouse hover to be lost;
if we can't fix the signal we may have to debounce it in the hover card
system to prevent unintended visual results.

Bug: 1019303
Change-Id: Iec0cba64398891d589d3cbe6d7abeab0e1e230b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891142
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711008}

With this, you can make the compiler ensure, statically, that
the methods of your class always run on the same sequence.
This is vastly safer than runtime checks like SequenceChecker
since it will fail to compile if you violate the requirement.

(It wouldn't be C++ if there weren't hacky ways around this, but
any attempt to trick the compiler into allowing a sequence
violation should look pretty obvious to reviewers.)

To use this, declare a struct that inherits from StaticSequence.
This struct will automatically declare a Key class that can only
be constructed inside the StaticSequence's PostTask function. To
force users to go through that StaticSequence's PostTask() to
call your method, simply declare a reference to the Key object
as the last parameter to the method.

This also includes a wrapper template called Sequenced, similar
to base::SequenceBound, but with the TaskRunner known at compile
time rather than runtime. This can be used to add an extra level
of safety over runtime checks like
DCHECK_CALLED_ON_VALID_SEQUENCE or
TaskRunner::RunsTasksInCurrentThread. This wrapper ensures the
wrapped object is destroyed on the correct sequence, essentially
turning any sequence-affine object to a thread-safe object.

This will be made even more useful once base::PostTask() returns
a base::Promise, as it will work with methods that return values
as well as void methods.

Bug: None
Test: cast_base_unittests
Change-Id: Ic408e343bc084c19c4c6f9e983b343b98502daf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863549Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711007}

This workaround was added for Linux set-top boxes with Mali-400.
However, the workaround is not needed on Android devices with Mali-400
(probably due to using a completely different driver).

The disable_gl_rgb_format code path is poorly tested and had at least
one bug, so reduce the workaround to only apply to Linux.

Bug: 1018528, 449150
Change-Id: Ic2f5248a8ff943edab90c24577ea94601693a32e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891139Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711006}

the flaky unittest.

Here we simplify unittests, especially "TestIncognito" by only checking
return value of OnDeviceHeadProvider::IsOnDeviceHeadProviderAllowed.
This unittest in the previous change was too heavy that it fired
mulitple async calls and might eventually caused data race in
ScopedFeatureList on some platforms: http://screenshot/8x1yJO66CjU.

Non test cc files are the same as previous CL.

Bug: 925072
Change-Id: I1e4c1666ceb7c24a599f5539d0ace90f0fc98b29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888691
Commit-Queue: Ce Chen <cch@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711005}

Move FrameMsg_DidUpdateOrigin to a RemoteFrame mojo
interface.

Addded DecodeURLEscapeSequences to the mojo deserialization
of a url.mojom.Origin when converting to a blink::SecurityOrigin.
Change https://crrev.com/5f709c23e66 added a change to the legacy
IPC path but the relevant change wasn't in the mojo path. So adjusting
this message to go through mojo causes the test case to fail so fix
the decoding appropriately to match the legacy path.

BUG=1008432

Change-Id: I63b4a47e37e5740a4712f921c87292dcb15ca8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874197Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711004}

https://chromium.googlesource.com/angle/angle.git/+log/924dad3b22c2..5da6f444eff6

git log 924dad3b22c2..5da6f444eff6 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 jmadill@chromium.org Fix error string commas.

Created with:
  gclient setdep -r src/third_party/angle@5da6f444eff6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I522c66f5a999fbc378734b447eb5653ab57fc950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890594Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711003}

Adds ChromeVox jump commands to go to the next or previous paragraph.

Bug: 1002101
Change-Id: I9bfd6462cb2875a9867c6b0939f0700a277148ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850756Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711002}

On Android Mali-400 devices (and probably Linux Mali-400 devices, for
which this workaround was originally added), the alpha channel
(allocated due to disable_gl_rgb_format) was not cleared in
CreateColorBuffer. This caused flickering of any WebGL backbuffer with
{alpha:false,premultipliedAlpha:false}.

Bug: 1018528
Change-Id: I35b9cf24c6a5e46cf902dd815b942d56b62c1c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891137Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711001}

Typos (missing "]" bracket)  were introduced at r709022 and r709160.

Bug: 1019576
Change-Id: I0950c8f466f5a1a825cb92435ba969585bedce71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890502
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711000}

Ran locally w/o retry 20 times for each of these tests and
did not see any issue.

This also removes WaitForIdleSync calls by replacing them
with CriteriaHelpers to hope avoid a constant source of flakes.

This also switches to opening about:blank instead of the NTP
on launch since it is much faster to load.

BUG=147960

Change-Id: Ia6f0cd0cdb1b872bbbcda5572a15bc183844edc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890982Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710999}

https://skia.googlesource.com/skia.git/+log/a9ac8a51fdb3..c7a8df8b1cdb

git log a9ac8a51fdb3..c7a8df8b1cdb --date=short --no-merges --format='%ad %ae %s'
2019-10-30 herb@google.com Swap SkPackedGlyphID bitfields around
2019-10-30 benjaminwagner@google.com [docs] Add skolo-builder to swarmingbots.md
2019-10-30 mtklein@google.com quick switch to disable SkVM JIT
2019-10-30 mtklein@google.com assume no color filters in SkVMBlitter
2019-10-30 mtklein@google.com clean up unorm8 helpers
2019-10-30 herb@google.com Faster remote glyph cache
2019-10-30 brianosman@google.com YUV Cleanup: Trim comments, derive Cr/Cb from Kr/Kb
2019-10-30 herb@google.com Use shifts for all fields in SkPackedGlyphID
2019-10-30 csmartdalton@google.com Rename sampleVariablesSupport() to sampleMaskSupport()

Created with:
  gclient setdep -r src/third_party/skia@c7a8df8b1cdb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:881505
Change-Id: Ibf34217fae3cca1d2c996982243b53552a5df0ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890595Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710998}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3abb07fb77e6..0e8fabd71826

git log 3abb07fb77e6..0e8fabd71826 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 vapier@chromium.org config_stages_unittest: use a tempdir for chromite

Created with:
  gclient setdep -r src/third_party/chromite@0e8fabd71826

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ib1c0603fe83adfc4493a76ba0d97f76730d790d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891378Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710997}

This prevents double-counting the size contribution of symbols
with aliases: rather than each of N aliases having size S, they
will each have PSS S/N.

Bug: 1011921
Change-Id: I3add28981d543a5b56dd2e77f1bbeb3ee44ddd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891141
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710996}

Only the following properties apply to a ::marker pseudo-element:
  - all font properties
  - `color`
  - `text-combine-upright`, `unicode-bidi`, and `direction`
  - `content`

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

BUG=457718

TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html

The test has 2 failures because font-synthesis and font-variant-position
have not been implemented yet.

Change-Id: I9f82e13bdd14a06a84ee55e352cd5a2c64d6fb97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891310Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710995}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e15140656112..6a18fa927208


Created with:
  gclient setdep -r src-internal@6a18fa927208

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:990387
Change-Id: Iedd9d752195e39f910b4088b360b0e94158cfe4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891376Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710994}

Bug: 1019719
Change-Id: I389a5e8c355ecd3343cfeb3efa6aeef245aa7a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890980
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710993}

This reverts commit 04962c50.

Reason for revert: Unfortunately this seems to have caused a build failure: https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/6760

Original change's description:
> [Android][Signin] Fix bookmark signin promo dismiss tests
> 
> This CL fixes the bookmark signin promo tests when the promo is
> dismissed in different scenarios.
> 
> Bug: 789531
> Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Alice Wang <aliceywang@chromium.org>
> Auto-Submit: Alice Wang <aliceywang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710784}

TBR=twellington@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org

Change-Id: I40ad228bbccd446455106c5278392cbde11834b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890456Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710992}

Adds a pref for Supervised Users to determine whether the user is
allowed to grant permissions to extensions (and, by extension, whether
the user is allowed to install extensions with parental approval).

The pref is controlled by Sync settings for the supervised user,
ultimately determined by the custodian checking the "Allow sites and
apps to ask for permissions" checkbox in the Chrome family dashboard.

For now, we will rely on the fact that this checkbox also sets the
GeolocationDisabled setting. In the future, the Kids Management server
should send a separate setting for extension permissions; that will give
us flexibility in the future to break the checkbox into multiple
settings.

Bug: 1018956
Change-Id: Ifda14018dc7f4a018b493159c6e80b00c2e18b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885216Reviewed-by: Dan S <danan@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710991}

Now we support physical tests under virtual directories after
crrev.com/c/1873504, and no longer need PhysicalTestSuites.

The only two PhysicalTestSuites are converted to VirtualTestSuites:
- hdr -> virtual/hdr
- fast/text -> virtual/text-antialias
  --enable-direct-write is removed because it's not a valid flag

fast/text-autoresize is rebaselined. It was accidentally run with
--enable-font-antialiasing because we matched the physical test suite
base with startswith.

Bug: 1014162
Change-Id: I3319268d8c53abf9cbda31a07794d8d56fd93d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888124
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710990}

- Move generator-related sections from referrer-policy/README.md
  to common/security-features/README.md
- Add mixed-content/README.md to mention about the generator.
- Update some sections, namely how to remove generated tests, etc.

Bug: 906850
Change-Id: I03f5483435dd9a59b923303d693d7a2cf4717e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785899
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710989}

This required adding new API to ChromeEarlGrey to fetch the current
fullscreen viewport insets.

Bug: 987646
Change-Id: I18a897a558074025da81262b17429e09417fe61a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889112Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710988}

The ModuleBlacklistCacheUpdater currently doesn't support a module first
loading into a process where injection is allowed then loading into one
where it should be blocked.

This DCHECK ensures this limitation will be addressed before adding
another supported process type.

Bug: 662084
Change-Id: Id49f323ee2e9a53bdafcd8f7391495e26d5d8cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879948
Auto-Submit: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710987}

This CL accomplishes the following things:

(1) Designate the previous/next focusable widget for navigation widget,
hotseat widget and status area widget. It prevents the accessibility
ring from being trapped in one widget.

(2) Ensures that the hotseat is shown when the shelf app icon gets
the accessibility focus.

(3) Implements the test api to facilitate browser tests to access
the shelf widget code.

Bug: 1010219
Change-Id: I86dd5cc464430f0a91c8c8a043fcb9fb437d58a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873386Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710986}

Value::GetList() will soon stop returning references to the underlying
vector. Instead it will return a thin wrapper that only allows iteration
and member access. This change prepares //components/sync* for this
switch.

Bug: 646113
Change-Id: I65cfed19643ddebd1db2dfb159493ab0c039b4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887695
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710985}

Convert the remaining bits referencing the mojom::DeviceFactory
mojo interface using the old APIs to the new mojo types.

Bug: 955171
Change-Id: If7079f11822446582fffafabddfcea737da982c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879459
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710984}

Fixes the positioning of the open-in-tab icon in the new layout.

BUG=1016976

Change-Id: I8d632200063ba35076af140321d8e14d9be53a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888400
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710983}

When the user toggles the switch for FIDO authentication, the pref is set to
true and the offer dialog is shown. This CL ensures to reset the pref to false
if the user declines the offer immediately.

Bug: 949269
Change-Id: Idd5424f3972e7785eda672a82fa48753ec98c709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884312Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#710982}

Thanks to earlier refactoring work, this is super easy!

Bug: 1011921
Change-Id: I67e8f68ef0b87092c36e1176b3e8d033e8597db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891133
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710981}

The MockCdmFactory just creates the MockCdm and should not expect what
calls will be made on the MockCdm. Hence, replace StrictMock with
NiceMock. Test cases that expect calls on MockCdm should get the MockCdm
via MockCdmFactory::GetCreatedCdm() and explicitly specify expectations
using EXPECT_CALL.

This is also consistent with googlemock guidelines [1]:
"""
Our general recommendation is to use nice mocks (not yet the default)
most of the time, use naggy mocks (the current default) when developing
or debugging tests, and use strict mocks only as the last resort.
"""

[1] https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#the-nice-the-strict-and-the-naggy-nicestrictnaggy

Bug: 1018854
Test: Update test helper classes. No functionality change.
Change-Id: I197f83b221296beccd05b82d2b6ae030381178e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890970
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710980}

Fixed: 1019798
Change-Id: Idfd2502fa32dfa44ad19b105f5d4bc9a54eb15e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891147Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710979}

Currently, there is no way to set expectetions on SetDelegate function
Replaces with MOCK_METHOD1 and moving current function body to
ON_CALL().WillByDefault()

Bug: internal b/132811177

Change-Id: I58ba51d5a0d3dcead895045009de2821271ccfd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885453Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Steven Zhu <jz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710978}

Migrate Supervised User preferences to use PrefServiceBridge generic
methods, making use of the prefs.h enums.

Replace duplicated Java constants for SupervisedUserURLFilter::
FilteringBehavior C++ enum with a generated Java enum.

Bug: 1016957
Change-Id: Id0eb0b19464fb6bc487cb7924b68de6f753fba60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885505
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710977}

Currently, OnOverviewModeWillStart is called both before and after
ending any pending overview exit animations - we should call this only
once, after existing animations have ended.

Bug: None
Change-Id: I87997a79693de59dbafb572d99799a4c3bb42513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891390Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710976}

This CL moves `test_case_name` and `test_js` into test HTML templates,

- To merge code from indiviual projects into common/, and
- To prepare for merging multiple scenarios into a single HTML file.

This CL keeps generated test files unchanged.

Bug: 906850
Change-Id: Iad2dd874492b8824f4c97d76a78b09bf8e2ab94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889476
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710975}

ThumbnailTabHelper now captures the entire contents of a web page
(within the bounds of the window) as the raw thumbnail instead of an
image specifically cropped for tab hover cards.

The image is scaled down to a size that can be used by both the touch-
only tabstrip and hover cards, even when it must be cropped. Observers
can now specify a size hint for uncompressed images; so that when the
image is received by the observer it is pre-cropped appropriately.

We use this new system to ensure that tab hover cards are still getting
appropriately-sized thumbnails, but the touch-only tabstrip gets the
entire compressed image of the webpage, at approximately the original
aspect ratio.

Bug: 1013646
Change-Id: If63dc7e13f8ddef09e991fcb20f5bef8cacad302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887734
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710974}

Explicitly show soft input keypboard on omnibox focus for search. Fixes
an issue with Duet, where the keyboard could be dismissed by the Back
or keyboard Action buttons, after which re-clicking the Search button
would focus the omnibox, but would not re-open the keyboard by default.

Bug: 981682
Change-Id: I1fe14edae4493dd57afe79250ad7fdbc806adcc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869530Reviewed-by: Ender <ender@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710973}

Using wpt-import in Chromium b29385ff.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
creis@chromium.org, lukasza@chromium.org:
  external/wpt/fetch/corb
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I355970b520a49141c9fc9ca40353ad7fb3f1ac5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891071Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710972}

Migrate Password Manager preferences to use PrefServiceBridge generic
methods, making use of the prefs.h enums.

Bug: 1016957
Change-Id: If35d6e14448dff0883bb66e836f67dbe631ae0f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885502Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710971}

This patch updates the code to simplify the if condition. This should a no-op change
since the override is considered when getting the intrinsic content logical height.

This also adds a test that fails if that if condition is not present, and passes
otherwise. The test sizes the flex box based on the unstretched size when the
item itself is stretched.

R=cbiesinger@chromium.org, chrishtr@chromium.org

Bug: 1018395
Change-Id: I16ff62d887110a9b93704160e93f2fbcc764c509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891012Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710970}

Includes a refactor of TabDragController and TabDragContext to allow dragging of TabSlotViews and not just Tabs. This required renaming many things, but thankfully not many functionality changes.

Notable functionality changes:
- in tab_strip: Logic is added in MaybeStartDrag() to handle selecting which views to drag.
- in tab_strip: Logic is added in GetInsertionIndexFrom() for finding the right insertion index.
- in tab_drag_controller: Logic is added in Attach() for dragging headers into new windows.
- in tab_drag_controller: Logic is added in CompleteDrag() to deselect the dragged views.
- in tab_drag_controller: Gates are added to prevent calling UpdateGroupForDraggedTabs().

Bug: 1004953
Change-Id: Ia334e5c424f9fbba704160239b19e4ca9f13eb9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866058Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710969}