GitLab

BUG=395172
R=miu@chromium.org, thestig@chromium.org
TBR=miu@chromium.org, thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/408483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284133 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/399353007/)

Reason for revert:
Not the issue... re-landing.

Original issue's description:
> Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/396023003/)
> 
> Reason for revert:
> Very speculative revert for current XP bots failures (all 3 bots are failing with obscure errors and this is our last suspect in the list...).
> 
> I'll reland if that's not it.
> 
> Thanks for your understanding!
> 
> Original issue's description:
> > Change SPACEPARITY in the Windows serial api implementation to ODDPARITY.
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000
> 
> TBR=rockot@chromium.org,sammc@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284087

TBR=rockot@chromium.org,sammc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/404823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284132 0039d316-1c4b-4281-b951-d872f2087c98

Applications targeting this or a later release will get these new changes
in behavior:
  - AlertDialog might not have a default background if the theme does not
    specify one.

BUG=393019
TBR=stgao@chromium.org,blundell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/402613008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395169
R=rouslan@chromium.org, thestig@chromium.org
TBR=rouslan@chromium.org, thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/408483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284130 0039d316-1c4b-4281-b951-d872f2087c98

Make DeriveFont() fall back to "sans" if it doesn't find an
SkTypeface matching the requested family, as
InitFromDetails() already did.

Also make InitFromDetails() pass through the requested
style.

BUG=394860

Review URL: https://codereview.chromium.org/399113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284125 0039d316-1c4b-4281-b951-d872f2087c98

It simply forwards the flag from v8::FunctionCallbackInfo and allows
the function handler that accept gin::Arguments argument to distinguish
between normal function invocation and call as an object construction.

BUG=

Review URL: https://codereview.chromium.org/401823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284123 0039d316-1c4b-4281-b951-d872f2087c98

TimeSource represents the canonical source of time and will eventually
replace the time-updating callback from AudioRenderer and VideoRenderer.

A wall-clock based implementation is also provided for media pipelines
that do not contain any audio.

BUG=370634

Review URL: https://codereview.chromium.org/379343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284122 0039d316-1c4b-4281-b951-d872f2087c98

Use GtkSettings's gtk-xft-dpi property to convert Pango font
descriptions from points to pixels. Previously
PangoContext's default resolution, which is sometimes
(always?) unset, was used, resulting in 96 DPI being used
for conversions regardless of the value reported by X.

BUG=375824

Review URL: https://codereview.chromium.org/406493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284121 0039d316-1c4b-4281-b951-d872f2087c98

Removed "disable-saml-signin" flag and non-SAML auth extension manifest.
Now SAML is always enabled for both desktop and Chrome OS.
Plus:
* Prevented potential races during extension initialization.
* Made "manifest_keyboard.json" up to date with "manifest.json".

BUG=394342
TEST=none
TBR=jochen (c/b/browser_resources.grd)

Review URL: https://codereview.chromium.org/384003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284120 0039d316-1c4b-4281-b951-d872f2087c98

Introduced SnapToPixelLayoutManager and used where it makes sense.
WorkspaceLayoutManager uses WindowState, so it's the property is manually set there.


This depends on the following CL:
https://codereview.chromium.org/375693006/

BUG=391822

Review URL: https://codereview.chromium.org/357063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284119 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284118 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Breaks android compile looks like: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/61939

FAILED: /b/build/goma/gomacc /b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,noexecstack -fPIC -fuse-ld=gold -nostdlib -Wl,--no-undefined -Wl,--exclude-libs=ALL --sysroot=/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -Wl,--icf=safe -L/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/libs/armeabi-v7a -Bdynamic -Wl,--gc-sections -Wl,-z,nocopyreloc -pie -rdynamic /b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/lib/crtbegin_dynamic.o -Wl,--warn-shared-textrel -Wl,-O1 -Wl,--as-needed -o breakpad_unittests -Wl,--start-group obj/breakpad/src/client/linux/handler/breakpad_unittests.exception_handler_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.cpu_set_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.directory_reader_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.line_reader_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.linux_core_dumper_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.linux_ptrace_dumper_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.minidump_writer_unittest.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.minidump_writer_unittest_utils.o obj/breakpad/src/client/linux/minidump_writer/breakpad_unittests.proc_cpuinfo_reader_unittest.o obj/breakpad/src/common/linux/breakpad_unittests.elf_core_dump_unittest.o obj/breakpad/src/common/linux/breakpad_unittests.file_id_unittest.o obj/breakpad/src/common/linux/breakpad_unittests.linux_libc_support_unittest.o obj/breakpad/src/common/linux/breakpad_unittests.synth_elf.o obj/breakpad/src/common/linux/tests/breakpad_unittests.crash_generator.o obj/breakpad/src/common/breakpad_unittests.memory_unittest.o obj/breakpad/src/common/breakpad_unittests.simple_string_dictionary_unittest.o obj/breakpad/src/common/breakpad_unittests.test_assembler.o obj/breakpad/src/common/tests/breakpad_unittests.file_utils.o obj/breakpad/src/tools/linux/md2core/breakpad_unittests.minidump_memory_range_unittest.o obj/breakpad/src/common/android/breakpad_unittests.breakpad_getcontext_unittest.o obj/testing/libgtest.a obj/testing/libgtest_main.a obj/testing/libgmock.a obj/breakpad/libbreakpad_client.a obj/breakpad/libbreakpad_processor_support.a -Wl,--end-group  -llog -lstlport_static /b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.8/libgcc.a -lc -ldl -lm /b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/lib/crtend_android.o
obj/breakpad/libbreakpad_client.a(obj/breakpad/src/client/linux/minidump_writer/breakpad_client.minidump_writer.o):minidump_writer.cc:function google_breakpad::TypedMDRVA<MDRawDirectory>::CopyIndex(unsigned int, MDRawDirectory*):error: undefined reference to 'google_breakpad::MinidumpFileWriter::Copy(unsigned int, void const*, int)'
obj/breakpad/libbreakpad_client.a(obj/breakpad/src/client/linux/minidump_writer/breakpad_client.minidump_writer.o):minidump_writer.cc:function google_breakpad::TypedMDRVA<unsigned int>::~TypedMDRVA():error: undefined reference to 'google_breakpad::MinidumpFileWriter::Copy(unsigned int, void const*, int)'
obj/breakpad/libbreakpad_client.a(obj/breakpad/src/client/linux/minidump_writer/breakpad_client.minidump_writer.o):minidump_writer.cc:function google_breakpad::TypedMDRVA<MDRawContextARM>::~TypedMDRVA():error: undefined reference to 'google_breakpad::MinidumpFileWriter::Copy(unsigned int, void const*, int)'
obj/breakpad/libbreakpad_client.a(obj/breakpad/src/client/linux/minidump_writer/breakpad_client.minidump_writer.o):minidump_writer.cc:function google_breakpad::TypedMDRVA<unsigned int>::CopyIndexAfterObject(unsigned int, void const*, unsigned int):error: undefined reference to 'google_breakpad::MinidumpFileWriter::Copy(unsigned int, void const*, int)'
collect2:error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Original issue's description:
> Roll Breakpad from 1345 to 1351.
> 
> This pulls in the following CLs:
>  - r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
>  - r1347 Stringify minidump stream_type constants in minidump_dump output
>  - r1348 Ensure C:/Dumps/ exists in crash_generation_app
>  - r1349 Change some ELF utils to return the length as a size_t
>  - r1350 Add frame pointer recovery to the AMD64 Stackwalker.
>  - r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
> WriteOSInformation.
> 
> BUG=394841,393903
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284101

TBR=mark@chromium.org,rmcilroy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394841,393903

Review URL: https://codereview.chromium.org/401853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284117 0039d316-1c4b-4281-b951-d872f2087c98

I'm starting with this one to make sure everything works ok.

BUG=383609
TEST=none
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/385483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284116 0039d316-1c4b-4281-b951-d872f2087c98

First step in transitioning HardwareDisplayController to take in buffers rather
than surfaces. ScanoutBuffer defines the minimal interface required by HDC for
modesetting and page-flipping.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/399213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284115 0039d316-1c4b-4281-b951-d872f2087c98

It did pass two runs, but is consistently failing now. So I'm not sure
whether this is a regression or flake. Since the test is so new, it seems
safest to just disable this page until it shakes out.

If this isn't a flake, the regression range is r283974-284019.

BUG=394756
TBR=wiltzius@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/400823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284114 0039d316-1c4b-4281-b951-d872f2087c98

This patch is reland of https://codereview.chromium.org/393283003/ with some fixes.
The corresponding Blink work is at https://codereview.chromium.org/400153002/.

BUG=301515

Review URL: https://codereview.chromium.org/399653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284113 0039d316-1c4b-4281-b951-d872f2087c98

- Replaces ScopedTestNSSDB by ScopedTestNSSChromeOSUser, which is the choice for ChromeOS.
- Removes the deprecated net::NSSCertDatabase::GetInstance() call.
- Changes the build target from brower_test to unit_test, as originally intended.

BUG=329735, 210525

Review URL: https://codereview.chromium.org/407443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284112 0039d316-1c4b-4281-b951-d872f2087c98

  + Fixed indentation.
  + Added early returns.
  + Fixed comments.
  + Removed not needed virtual.

Fixed nit comments from wtc for the following CLs.

  https://codereview.chromium.org/368803003/
  https://codereview.chromium.org/366863002/
  https://codereview.chromium.org/393953011/

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/394053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284109 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284108 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178427:178434&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/404793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284107 0039d316-1c4b-4281-b951-d872f2087c98

- Adds a positive test, where the owner logs-in while in safe mode.
- Fixes the test, where a non-owner tries to login: It failed because the MockOwnerKeyUtil had no key set. Now it fails because the private key cannot be found.
- Removes the ScopedTestNSSDB usage.
- Speeds up the test by factor 10, because of the removed NSS initialization in the test fixture.

BUG=210525

Review URL: https://codereview.chromium.org/398363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284106 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a layer level raster tile perftest to measure how
expensive is it to create a layer raster tile iterator.

Initial run:
[ RUN      ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstructAndIterate
*RESULT layer_raster_tile_iterator_construct_and_iterate: 32_100x100= 389462.09375 runs/s
*RESULT layer_raster_tile_iterator_construct_and_iterate: 32_500x500= 392804.6875 runs/s
*RESULT layer_raster_tile_iterator_construct_and_iterate: 64_100x100= 230574.3125 runs/s
*RESULT layer_raster_tile_iterator_construct_and_iterate: 64_500x500= 230933.953125 runs/s
[       OK ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstructAndIterate (8408 ms)
[ RUN      ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstruct
*RESULT layer_raster_tile_iterator_construct: 0_0_100x100= 2187284 runs/s
*RESULT layer_raster_tile_iterator_construct: 5000_0_100x100= 1882842.125 runs/s
*RESULT layer_raster_tile_iterator_construct: 9999_0_100x100= 2171275 runs/s
[       OK ] PictureLayerImplPerfTest.LayerRasterTileIteratorConstruct (7619 ms)

NOTE TO PERF SHERIFFS
---------------------
This patch replaces layer_raster_tile_iterator test with
layer_raster_tile_iterator_construct_and_iterate test.

R=reveman

Review URL: https://codereview.chromium.org/400753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284105 0039d316-1c4b-4281-b951-d872f2087c98

In order for RenderPass to own allocation of DrawQuads and
SharedQuadState, update surface type converter code in mojo so when
convert to DrawQuad and SharedQuadState, function takes in pointer to RenderPass
as parameter. Also in unittest, create RenderPass to deal with DrawQuad and
SharedQuadState creation.

Follows 398533002.

BUG=344962

Review URL: https://codereview.chromium.org/393103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284104 0039d316-1c4b-4281-b951-d872f2087c98

Make it possible for clients pass in a custom task runner to be used for
posting compositor related work onto the main thread. This will be used
for prioritizing compositor tasks by the Blink scheduler.

Covered by existing tests.

BUG=391005

Review URL: https://codereview.chromium.org/400773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284103 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284102 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following CLs:
 - r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
 - r1347 Stringify minidump stream_type constants in minidump_dump output
 - r1348 Ensure C:/Dumps/ exists in crash_generation_app
 - r1349 Change some ELF utils to return the length as a size_t
 - r1350 Add frame pointer recovery to the AMD64 Stackwalker.
 - r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

BUG=394841,393903

Review URL: https://codereview.chromium.org/400203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284101 0039d316-1c4b-4281-b951-d872f2087c98

Experimentally disable termination on heap corruption in order to measure the contribution of this feature to missing crash reports.

Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.

BUG=394842

Review URL: https://codereview.chromium.org/402723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284100 0039d316-1c4b-4281-b951-d872f2087c98

Port DeleteHistoryAndBookmarks, DeleteHistory and DeleteSearchTerms to use
base::CancelableTaskTracker instead of CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/370533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284099 0039d316-1c4b-4281-b951-d872f2087c98

Added method to allow "copy image" menu tests for elements that
need capturePixels to verify test results.

BUG=392765

Review URL: https://codereview.chromium.org/396953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284098 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new GpuMemoryBuffer type that can be used to create
a GpuMemoryBuffer from an existing X11 pixmap.

This removes Create/DeleteImage IPC and reduces complexity
significantly as it allows the ImageManager to be moved to
the decoder and simply track images.

A new platform dependent GpuMemoryBufferFactory interface
is introduced to allow this new type of buffer to be created
on the GPU service side. To avoid the need for any global
variables, this factory instance is also responsible for
creating GLImage instances.

The old factory interface used by android_webview is renamed
InProcessGpuMemoryBufferFactory until it can be removed in
favor of this new interface.

BUG=368716
TEST=gpu_unittests, gl_tests --gtest_filter=GpuMemoryBufferTest.Lifecycle

Review URL: https://codereview.chromium.org/331723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284097 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that we only created the new profile if we deleted the
active profile, and it was the only existing profile. Since guest mode came
along, we could also delete the only profile when the active profile was
the guest one (which doesn't really count as a profile), so you'd be left in
this borked state of "no profiles in Chrome, oops".

For brownie points, I also added tests for both of these "only existing profile
deleted" scenarios. :)

BUG=393901
TEST=See bug description.

Review URL: https://codereview.chromium.org/396773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284096 0039d316-1c4b-4281-b951-d872f2087c98

On Android we explicitly allow the OS to kill Chrome's background
renderers when under memory pressure and we don't try to control the
number of renderers ourselves.

The process limit logic in content causes process sharing
between unrelated tabs when the number of renderer process hosts
(not the number of actual live processes) is too high. Because on
Android the system adjusts the number of actual live processes for us,
we don't want to limit the number of process hosts or to ever share
renderers between unrelated tabs.

This patch:
- disables the renderer process host limit on Android. If not
  overridden, ShouldTryToUseExistingProcessHost() will always return
  false.
- drops the logic that sets the renderer limit based on the number of
  declared renderer services

BUG=325842

Review URL: https://codereview.chromium.org/356453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284095 0039d316-1c4b-4281-b951-d872f2087c98

bug:
When distilling a page with new WebContents, document.offsetWidth in
domdistiller.js is always 0, because the newly created RenderView doesn't have a
size.

fix:
DistillerPageWebContents extends WebContentsDelegate and implements
GetNewSizeForRenderView() to return the size for the new RenderView.  This size
is the container bounds of the WebContents from where the distillation is
triggered.  The size is plumbed through the pipeline from the following sources
all the way down to DistillerPageWebContents.
1) WebUI: WebContents of chrome:://dom-distiller
3) ReadingList: WebContents currently associated with the extension
2) standalone ContentExtractor: WebContents of content::Shell
As for the reused WebContents (via "Distill page" in wrench menu), it already
has a size, so we just use it.

BUG=368941,367254
TBR=danakj (ui/gfx/size.h)

Review URL: https://codereview.chromium.org/396503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284094 0039d316-1c4b-4281-b951-d872f2087c98

Added reminder message for ash_resources so that we don't forget to remove it when it becomes unnecessary.

BUG=None
R=abodenha@chromium.org

Review URL: https://codereview.chromium.org/402643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284093 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Bypass the favicon_service when importing favicons. (https://codereview.chromium.org/375613002/)

Reason for revert:
There's a better approach.

Original issue's description:
> Bypass the favicon_service when importing favicons.
> 
> BUG=391795
> TBR=gab
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284045

TBR=blundell@chromium.org,jif@google.com,gab@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391795

Review URL: https://codereview.chromium.org/407513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284092 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284091 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/384b0202c040034ba1e8f2e3789a01e4b05a6a2b..19eb3b2f0aa6dce5c0335230a8930e90733e5d5d

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/400543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/400133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284089 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/396023003/)

Reason for revert:
Very speculative revert for current XP bots failures (all 3 bots are failing with obscure errors and this is our last suspect in the list...).

I'll reland if that's not it.

Thanks for your understanding!

Original issue's description:
> Change SPACEPARITY in the Windows serial api implementation to ODDPARITY.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000

TBR=rockot@chromium.org,sammc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/399353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379967

Review URL: https://codereview.chromium.org/392333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284086 0039d316-1c4b-4281-b951-d872f2087c98