- 12 Dec, 2018 32 commits
-
-
Dmitry Gozman authored
- Replaced multiple parameters with a single struct. - Merged LoadHTMLString, CommitNavigation and CommitDataNavigation methods. - Helper constructor turning WebNavigationInfo to WebNavigationParams. - Moved srcdoc handling from FrameLoader to DocumentLoader. Bug: 855189 TBR=tommycli@chromium.org,thestig@chromium.org Change-Id: If009a2da035b223ce50d60c6eb9bf474fd1539d2 Reviewed-on: https://chromium-review.googlesource.com/c/1274609 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615764}
-
Wez authored
FIDL package names consist of multiple dot-delimited segments, to allow scoping of packages to avoid clashes. Our GN generator script was using only the final segment of each package's name, resulting in clashes, e.g. between fuchsia.auth and fuchsia.modular.auth, if both were present in the SDK. We continue to generate targets under the //third_party/fuchsia-sdk/sdk namespace, but use the full name rather than only the final segment, e.g. custom.modular.auth would become custom_modular_auth. We also special-case the top-level "fuchsia" namespace to be ignored, e.g. fuchsia.modular_auth becomes just modular_auth. Bug: 910670 Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 Reviewed-on: https://chromium-review.googlesource.com/c/1372892 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615763}
-
Tony de Luna authored
Changes in this cl: * Split SectionHeaderRowView and subclasses to a new file. * Remove the concept of a "subtitle" in a section header. * MobileHeaderRowView no longer subscribes to network updates directly, toggle status is triggered by NetworkListView. * Display mobile status messages with similar logic as we display WiFi status messages. * Initializes section headers on NetworkListView constructor to simplify logic. * Removes unused headers. Current UI spec no longer has the concept of a "subtitle". It was confusing that mobile status messages were being shown as a "subtitle", while WiFi status messages are a label in NetworkListView. Mobile toggle state and status message logic is complex. Decided to make NetworkListView call MobileHeaderView to get the mobile status message. This way we can re-use existing subtitle selection logic. Change-Id: I46c99d01100db39cc4541910d3b19f670cd1fc50 Reviewed-on: https://chromium-review.googlesource.com/c/1371902 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615762}
-
Robbie McElrath authored
This adds functions to NetworkContext to facilitate copying HttpAuthCache contents from one NetworkContext to another. This copying is needed during ChromeOS sign in to copy any proxy authentication that happened in the login screen into the user's session. We'll need to somehow reference one NetworkContext from another in order to do the copying, which isn't curently possible. We considered 3 approaches to address this: 1. Add an ID to all NetworkContexts, and use the source NetworkContext's ID in the copy call. The network service can then look up the HttpAuthCache for that NetworkContext and copy from it. 2. Create a Mojo struct containing the relevant portions of the HttpAuthCache entries, and add a GetHttpAuthCacheEntries method to NetworkContext that will return a list of all entries. We can then pass that list back to the destination NetworkContext via a SetHttpAuthCacheEntries method. 3. Add a NetworkContext method to save the current HttpAuthCache contents somewhere not associated with that NetworkContext, and return some token/key/id that can be used to reference the saved data in a subsequent call on the destination NetworkContext. Here are my thoughts on each approach: 1. I don't think this features is enough of a justification for adding a NetworkContext ID. NetworkContexts are logically tied to a StoragePartition, and currently access to them is mostly tied to their StoragePartition as well. I think that's the way it should be, and adding a unique ID to them makes it easier to reference them from other places. 2. In order to convert the existing HttpAuthCache entries into a mojo struct, we'd need to add accessors to the vector of entries, as well as path list and nonce of each individual entry. While this is doable, I felt like this was too big of a change to the HttpAuthCache API, and was exposing too much of its implementation. 3. I'm not a huge fan of this API, but it's very simple, doesn't require any changes to net/'s API, and doesn't require serializing the HttpAuthCache and transmitting it twice across processes. This CL implements approach 3, but I'm happy to change it. This also refactors ProfileAuthData to use the new API. ExistingUserController and SigninPartitionManager will also need to be migrated to this new API, but those will be done in followup CLs. Bug: 838942 Change-Id: I47367dcff41f73e86535f487035e20dde5cbb86c Reviewed-on: https://chromium-review.googlesource.com/c/1366877 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615761}
-
Kent Tamura authored
Bug: 843412 Change-Id: I5f5b67cbefe1fa6f591a62cd646b0babacbe4a4f Reviewed-on: https://chromium-review.googlesource.com/c/1371309Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615760}
-
Theresa authored
BUG=594166 Change-Id: Ie5871930e089b8926f31a83854df6e8315d093a9 Reviewed-on: https://chromium-review.googlesource.com/c/1371820 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou (OOO Dec 12 - Dec 31) <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615759}
-
jonross authored
When running with VizDisplayCompositor virtual/user-activation-v2/fast/events/no-fake-mousemove.html was flaking with timeouts. However it was only flaking on one particular bot WebKit Mac10.13 (retina). We suspect that the extra process is leading to increased delay in this test. Marking this test as slow will allow us to confirm that. TEST=virtual/user-activation-v2/fast/events/no-fake-mousemove.html Bug: 912364 Change-Id: Ic04f50efa612782fdf66ecc4cb2ea260defb04a1 Reviewed-on: https://chromium-review.googlesource.com/c/1372470Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#615758}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/1352042 Bug: 880027 Change-Id: I1c289288239749bfd33e20bbdec948e6ab89512f Reviewed-on: https://chromium-review.googlesource.com/c/1371045Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#615757}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a039a0255e18..79ff98db91ae Created with: gclient setdep -r src-internal@79ff98db91ae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icc1f03384c5faff3830abd6c35acf68f972b7fca Reviewed-on: https://chromium-review.googlesource.com/c/1372354Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615756}
-
Giovanni Ortuño Urquidi authored
GetAvailableDevices returns devices we consider to be available i.e. devices we're recently seen, paired devices, and connected devices. Bug: 870192 Change-Id: I0076003ee9b47e9d828c30c4aca6caf6200896ec Reviewed-on: https://chromium-review.googlesource.com/c/1359834Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#615755}
-
Jeffrey Cohen authored
Send Tab to Self is an experimental feature to send Tabs to external devices logged in with the same Gaia ID. These files are loosely based on the reading list sync component, this first CL has stubbed out c files in order to avoid bloating the CL past being easily reviewed. Bug: 910390 Change-Id: I655d40757c43eab0fcf17b618fe8c754cad19b97 Reviewed-on: https://chromium-review.googlesource.com/c/1312991 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615754}
-
Yiming Zhou authored
Bug: 885350 Change-Id: I8c1fed2a1bec2d3a649d12ccf26adc5920e1772a Reviewed-on: https://chromium-review.googlesource.com/c/1372912Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#615753}
-
Steven Bennetts authored
https://crrev.com/c/1366879 fixed small window repositioning for Mash but exposed a bug in ChromeKeyboardBoundsObserver::ShouldEnableInsets. This fixes that issue and includes some cleanup done while debugging. It also updates the filter file tpo remove tests that are now passing! Bug: 906888 Change-Id: I64dcfe8de4a5970d69a76f26646b80be01016a50 Reviewed-on: https://chromium-review.googlesource.com/c/1372319 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615752}
-
Kent Tamura authored
Bug: 843412 Change-Id: I1bd7de018b74d32c17ed36c3cf4b0e56a4b7b467 Reviewed-on: https://chromium-review.googlesource.com/c/1371404 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#615751}
-
Matt Wolenetz authored
Inspection of upstream external/wpt/media-source/mediasource-errors.html and downstream http/tests/media/media-source/mediasource-errors.html shows that upstream is a working, more up to date, superset of the downstream cases. Especially with recent landing of https://chromium-review.googlesource.com/c/chromium/src/+/1371166 which fixed a timing/flakiness regression in upstream, removal of the unfixed, less complete, downstream version of that suite is motivated. BUG=913775, b/35361540 CC=chadduffin@chromium.org R=sandersd@chromium.org Change-Id: Ia2f7af9061d17f5a084cd0dfd2a0a98ec92012ce Reviewed-on: https://chromium-review.googlesource.com/c/1372661Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615750}
-
Yuki Awano authored
- Android receives raw touch events for Android virtual keyboard region. - TouchExplorationController checks whether a touch event is on Android virtual keyboard or not by asking to a WindowTargeter. If it's on Android virtual keyboard, Chrome Touch Exploration is disabled for the region. - ArcA11yHelperBridge monitors Android virtual keyboard visibility change from ArcInputMethodManagerService. They live in browser process. ChromeVox. Bug: b/117589518 Test: Install Android virtual keyboard and confirm that it works with Change-Id: If21bc3b1f01ab5fb26bab0847554574843375e05 Reviewed-on: https://chromium-review.googlesource.com/c/1351200 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615749}
-
Charlie Andrews authored
TBR=crouleau@chromium.org CC=hayato@chromium.org,tkent@chromium.org Bug: 914084 Change-Id: I42a62fdb5bb6b7f74291272b4c3d1fc14bfbdbfa Reviewed-on: https://chromium-review.googlesource.com/c/1372721Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#615748}
-
Saman Sami authored
Migrate from mailboxes to SharedImage to enable importing WebGL's buffer into vulkan. Bug: 882591 Change-Id: Ic99a51c5e52da2b31ed55be746781e2b053fd5bf Reviewed-on: https://chromium-review.googlesource.com/c/1348974 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615747}
-
Marijn Kruisselbrink authored
Bug: none Change-Id: I531e733601114c9674d45d5d25d341545d5ec5a5 Reviewed-on: https://chromium-review.googlesource.com/c/1372566 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615746}
-
Nigel Tao authored
Image processing includes converting to gray (for disabled extensions) and rounding the corners (for bookmark apps). BUG=826982 Change-Id: Ie49a8928678abd884302eacb7bef5f2c21e46a35 Reviewed-on: https://chromium-review.googlesource.com/c/1366462 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#615745}
-
Karan Bhatia authored
Currently the page at https://developer.chrome.com/extensions/declarativeNetRequest doesn't correctly show the API availability. The API is available on beta but is's shown as being available on trunk only. Increment the server version which should hopefully fix the issue. BUG=696822 Change-Id: I60b526691d582ea0a32d14cb043c9c2cc114e5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1371819Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615744}
-
Alice Boxhall authored
This reverts commit 74d46702. Reason for revert: Seems to be causing build breakage: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux Original change's description: > Dawn: use Dawn's temporary test targets for isolates. > > The plan is to move the actual test targets in Dawn to Dawn's > src/test directory. This change makes Chrome temporarily point at > some intermediate proxy targets, so we can move the real ones > without breaking Chrome. > > Bug: dawn:61 > Change-Id: I166c17f1689e2a2e71b1607af44f6f9a8c14b6af > Reviewed-on: https://chromium-review.googlesource.com/c/1372709 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615715} TBR=thakis@chromium.org,senorblanco@chromium.org,cwallez@chromium.org Change-Id: Iec9120066c23710c4b2dbe22a50813a23ad299a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://chromium-review.googlesource.com/c/1372107Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615743}
-
Alice Boxhall authored
This reverts commit 000208cc. Reason for revert: Causing compile failures: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59549 Original change's description: > assistant: replace most thread task runner with sequenced > > Bug: None > Test: locally build and run > Change-Id: I8e77799bcc4f417faf7dff54f9e40ab7a46f3d1f > Reviewed-on: https://chromium-review.googlesource.com/c/1372722 > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615732} TBR=xiaohuic@chromium.org,wutao@chromium.org Change-Id: Icfc0b925491ee96c6945ffca9bd972be174881b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/1372106Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615742}
-
Charlie Andrews authored
TBR=crouleau@chromium.org CC=ssid@chromium.org Bug: 914092 Change-Id: I57095a320bd561551bbd43025688393199ffbacb Reviewed-on: https://chromium-review.googlesource.com/c/1372725Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#615741}
-
Wenzhao Zang authored
We want to show a visual indicator in the status tray when the language toggle is available (in demo mode). It should show the abbreviation of the locale such as "DA". The only caveat is that the IME indicator may also be shown in the same place, so showing two strings with the same format may confuse users. PM confirms that we want to hide the IME indicator as long as the locale indicator is available. Bug: 877749 Change-Id: Ieca21dd46c846b81147bd44798b2deb25d9d57fa Reviewed-on: https://chromium-review.googlesource.com/c/1370886Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#615740}
-
Emircan Uysaler authored
WebRTC currenty passes only the codec selection to the decoders but not the profile info. This has been working fine so far because we only had different profiles under H264 and initializing the decoder with MAIN was enough to cover all of them. However, this became problematic when we introduce VP9.2, as it is a 10-bit codec that decoder needs to know and initialize in advance. This CL changes the decoder creation methods such that webrtc::SdpVideoFormat is passed and parsed for profile information. This will allow us to enabled VP9.2 HW decoder usage. Bug: 908945,webrtc:9376 Change-Id: I6959c85fe4074ca1644e6fb02d58d10df2ff0cff Reviewed-on: https://chromium-review.googlesource.com/c/1363804 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615739}
-
Tobias Sargeant authored
This exposes a support library feature allowing applications to set a WebViewRendererClient object upon which renderer related callbacks are received. Specifically, these callbacks are: onRendererUnresponsive(renderer) - called when the renderer associated with a webview does not ack an input event, or a navigation does not commit within 5 seconds. The callback will continue to be called at 5 second intervals until the renderer is killed or the unresponsiveness resolves. |renderer| may be null if webview is operating in single process mode. onRendererResponsive(renderer) - called once when an unresponsive renderer becomes responsive again. Bug: 907887 Change-Id: Ic5c74160e293791e3efc051a5727448ee061c9e2 Reviewed-on: https://chromium-review.googlesource.com/c/1361242Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615738}
-
Bruce Dawson authored
Recent versions of the 10.0.17763 SDK have rearranged the redist directory where we find the UCRT DLLs. This change updates the copy_cdb_to_output.py script so that it looks in the new (versioned) directory first, and falls back to the old unversioned directory if that doesn't work. Without this change we still soon start seeing build failures when using the locally installed toolchain on clean installs. See also http://crrev.com/c/1370609 for the depot tools packaging version of this change, and http://crrev.com/c/1371017 for the vs_toolchain.py version of this change. Ideally this change would have been made together with the vs_toolchain.py, but the break was found to late. The try bots have now done full builds with the new SDK layout so this should be the last change needed of this type. Change-Id: I4c965c66296d2f0b6adad672a71c295ffb021c66 Reviewed-on: https://chromium-review.googlesource.com/c/1372222Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615737}
-
manuk authored
Using L and F for query and find input boxes in order to be similar to browser shortcuts for focusing the omnibox and find dialog respectively. Using I, D, and P for 'show incomplete results', 'show details', and 'show per provider' display checkboxes respectively. Using C, A, and K for 'lock cursor', 'prevent autocomplete', 'keyword mode' input checkboxes respectively. Using U for 'current page' dropdown. Bug: 891303 Change-Id: Id715fb6c3db5787a8e676f2497578128a2810fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1372243 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#615736}
-
John Delaney authored
Cleanup an unused argument. Make function definition match the declaration. Change-Id: I5361ebcc56e660b4e697f50a866798ea5c89fad6 Reviewed-on: https://chromium-review.googlesource.com/c/1372429 Commit-Queue: John Delaney <johnidel@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#615735}
-
Collin Baker authored
This testing configuration shouldn't have been added until after an experiment in canary and dev has been run. This change removes it. Change-Id: I27546ef7e4b49f6f155678f3db14856bd7f5340f Reviewed-on: https://chromium-review.googlesource.com/c/1372409 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615734}
-
Fabrice de Gans-Riberi authored
Ordinals have been deprecated. This also fixes some minor indentation issues in FIDL files. Change-Id: I687b2d35e11b56401771ce9aeea8465735d7ffb9 Reviewed-on: https://chromium-review.googlesource.com/c/1372659 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615733}
-
- 11 Dec, 2018 8 commits
-
-
Xiaohui Chen authored
Bug: None Test: locally build and run Change-Id: I8e77799bcc4f417faf7dff54f9e40ab7a46f3d1f Reviewed-on: https://chromium-review.googlesource.com/c/1372722Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615732}
-
Collin Baker authored
Bug: 909747 Change-Id: I4f7f9d6a34242d7dec8b343ff38aaa2b05019cec Reviewed-on: https://chromium-review.googlesource.com/c/1362190Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#615731}
-
Dan Sanders authored
These refactorings were removed from https://crrev.com/c/1362005 to reduce the size of the patch. This change also fixes a previously unknown issue in PictureBufferManager whereby show_existing_frame picture buffers could be destroyed while there are still outstanding video frames using the textures. Bug: 906623 Change-Id: I0a243684c9a6d44dec5a5f279cf28f51b79c99c0 Reviewed-on: https://chromium-review.googlesource.com/c/1368780 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615730}
-
John Rummell authored
BUG=611224 TEST=new media_unittest passes Change-Id: I7feadd34ca77bcacd406b61783e43143bb593f7f Reviewed-on: https://chromium-review.googlesource.com/c/1338323 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615729}
-
Dominic Mazzoni authored
It was awkward that BrowserAccessibilityManager and AutomationAXTreeWrapper had to inherit from AXEventGenerator. Now they can each own an AXEventGenerator but also be AXTreeObservers, themselves. TBR=halliwell@chromium.org Bug: none Change-Id: Iac577b5ddcca892e809a9c02ce38d193297ecb80 Reviewed-on: https://chromium-review.googlesource.com/c/1357831Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615728}
-
Kenneth Russell authored
ContextLost_WebGLBlockedAfterJSNavigation ContextLost_WebGLUnblockedAfterUserInitiatedReload Both are flaking due to the same root cause. Tbr: jonross@chromium.org Bug: 900948 No-Try: True Change-Id: Ic527ce1914bacd539222c7a8e8c9265be404aff2 Reviewed-on: https://chromium-review.googlesource.com/c/1372350 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#615727}
-
Dana Fried authored
Current code does not cause a problem with this order of operations, but changes we want to make for the attached bug uncovers a situation where the action is still popped out after its view is removed, which causes an error. Bug: 898632 Change-Id: I73d14a61cddd4b052c9dbf774864f68036a93b4c Reviewed-on: https://chromium-review.googlesource.com/c/1372710Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615726}
-
Jeremy Roman authored
Change-Id: I6f21ff35ef36e908da88356223a52b413e8b93ca Reviewed-on: https://chromium-review.googlesource.com/c/1372717Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615725}
-