GitLab

- The tests now use the testing locale "xx-XX", which marks
  certain words offensive to make this unit test correct.
- Re-enabled the remaining part of the test since the
  suggestions are now sped up.
- Added extra test check to verify spellchecker loaded the
  local correctly, otherwise it defaults to en-US

Bug: 981132, 673424
Change-Id: Idc84ddba5dc40a2bd2b47cc6fa58a622ab30ca2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701958
Commit-Queue: Mohamed Mansour <mmansour@microsoft.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685304}

https://dawn.googlesource.com/dawn.git/+log/bb10a9187623..e9fabf59160b

git log bb10a9187623..e9fabf59160b --date=short --no-merges --format='%ad %ae %s'
2019-08-08 enga@chromium.org Factor PassResourceUsageTracker to its own file

Created with:
  gclient setdep -r src/third_party/dawn@e9fabf59160b

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Iba146542a941ec8048a2f75b6851ddf8aaee1017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744536Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685303}

Current interpolation code assumes that a specified length can always
be converted into a |CSSLengthArray|, which is no longer true if the
length calculation involves comparison functions min/max().

Hence, this patch allows |CSSPrimitiveValue::AccumulateLengthArray| to
to fail, so that interpolation can fail gracefully.

This patch is preparation for min/max implementation. Note that CSS
comparison functions are not implemented yet, so there is no real code
path that fails such interpolation at this moment.

See the all-in-one implementation of min/max for reference:
https://crrev.com/c/1737874

Bug: 991672
Change-Id: I1b5fe2d324f0836b1e21f6ef12abe21e1d7307c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743135Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685302}

In a separate commit, I intend to add a call to chrome::GetChannel() in
all child processes. This was causing crashes on the kitkat bot because
the VersionConstants* classes were not included in the main dex and
causing crashes when trying to call into
VersionConstantsBridge.getChannel().

Bug: 991688
Change-Id: I5cd98f5cb5be17e28d48b4def798d9e7359d6753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744515Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685301}

Largest Contentful Paint compares the text and the image candidate
to decide which is the largest candidate. Currently, LCP generates
a result entry between updating the text candidate and the image
candidate, which produces an intermediate result. It causes
the issue in crbug.com/988115, #c4 explains the mechanism of the bug.

To remove the intermediate state, this CL changes the way
LCP-calculator takes the text candidate and image candidate. Instead
of notifying LCP-calculator of the text candidate's update right after
the update, we wait until both text candidate and image candidate have
been updated to notify LCP-calculator.

Also, LCP-calculator adds the logic of checking whether candidate
has changed, from ImagePaintTimingDetector and TextPaintTimingDetector.
Although it's redundant with |UpdateCandidate| in text and image,
these are necessary because going forwards, the "has_changed" logic in
both detectors would have to be removed along with the LIP and LTP
logic.

This CL also considers the chances where either detector is destroyed,
where it would no longer be able to find the largest candidate. In
this case, perf API would use the last reported candidate as the
candidate to compare with the candidate from another detector, in
order to decide the largest between text and image.

Bug: 982307, 988115

Change-Id: I562c7aeab6037678dd4bd7d6eddacdeb5be8bfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733456
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685300}

BUG=991397

Change-Id: I6fe57a8f8e51200a87c8c7eaeb77b6ea6e7cc68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742807Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685299}

Bug: 924136
Change-Id: I3043866d36065257cac004d529728d3fc7a4dc55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737370
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685298}

Bug: 906847
Bug: v8:8672
Change-Id: I885ab765ebdf6c8dea965092317d73844e9c3809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744524
Auto-Submit: Yury Semikhatsky <yurys@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685297}

Instead of passing in a pointer to |error_html|, PrepareErrorPage now
takes a callback. This is done in preparation to implement
committed interstitials for SSL errors, since SSL error HTML must be
generated asynchronously to account for asynchronous captive portal
detection.

Bug: 987407
Change-Id: Ia50442072e0ff1515a3d941f0f27cf68f411aae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742731Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685296}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rajendrant@chromium.org

Bug: 968047
Change-Id: Ic67b9572e1cf244f3225037562959074d4e46a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739829
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685295}

https://quiche.googlesource.com/quiche.git/+log/092d8219e053..cf6c3e69df4e

$ git log 092d8219e..cf6c3e69d --date=short --no-merges --format='%ad %ae %s'
2019-08-08 bnc Use VersionHasStreamType instead of VersionHasIetfQuicFrames in PendingStream-related QuicSessionTests.
2019-08-08 fayang gfe-relnote: In QUIC, when RTO fires and there is no packet to be RTOed, let connection send data. Protected by gfe2_reloadable_flag_quic_fix_rto_retransmission2 which replaces gfe2_reloadable_flag_quic_fix_rto_retransmission.
2019-08-08 bnc Signal error in HttpDecoder if frames have disallowed extra payload.
2019-08-08 bnc Use QUIC_INVALID_FRAME_DATA in HttpDecoder.
2019-08-08 bnc Call Visitor::OnError() from HttpDecoder::RaiseError().

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I5b32b6b93867af980410e5f6fca8221bbd0fea33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744335
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685294}

This CL corrects the description of the TPMFirmwareUpdateSettings policy.
The auto-update-mode option was expected to be in version 74 but landed in
version 75.

Bug: none
Test: none
Change-Id: I411d5fb7cc61b5713bec5b01a1a68a693360954c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735457Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685293}

This is a native UI performance test that reports the average CPU time
of each step in the pipeline reporter (e.g.
SingleThreadedCompositorLatency.SendBeginMainFrameToCommit), in
microseconds. Note that SendBeginMainFrameToCommit is of particular
interest because the metric contains View::Paint times. In the test,
we hover over each tab in a browser by mousing slowly over the
tab strip from left to right. Hover cards and tooltips are disabled.

Note that the test currently only builds for chromeos. This is because
the DragEventGenerator has the option to use touch events, and these
touch events are only compatible with chromeos currently. If you
want to run the test on Linux or Windows, move the test file and
DragEventGenerator files in the BUILD file such that they build for
the desired platform, and comment out the SendTouchEvent() and
SendTouchEventNotifyWhenDone() from the DragEventGenerator file.

Bug: 974349

Change-Id: Iaf7c5975cca158eb79175927a60ca50ca82d1ba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662970
Commit-Queue: Annie Su <anniesu@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685292}

When data was redacted with context, previously just a unique numeric
identifier was put in place of the data. This wasn't obvious to users of
the logs because sometimes one number was just getting replaced with
another. This is now made clear so that even when we redact with
context, we put a redaction identifier in place of what we removed.

This change also enhances serial number redaction to cover a wider range
of occurrences of serial numbers in logs.

BUG=chromium:940884
TEST=Unit tests pass, manually inspected uploaded feedback report

Change-Id: I57e9a7f612be30eb0823fd0bb9d13ffc16bd3a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740132Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#685291}

Context and behavior implemented + expected before and after the CL
===================================================================

A content::RenderFrameImpl stores |subresource_loader_factories| that
are used for all requests/XHRs/etc initiated by the frame.  We don't
currently swap the RenderFrame when committing another same-process
document (this future work is tracked by https://crbug.com/936696).

The URLLoaderFactory for handling http/https requests contains a
|request_initiator_site_lock| in network::URLLoaderFactoryParams.
This lock limits what network::ResourceRequest::request_initiator may be
used.  The lock is currently used in various, security-sensitive
features like CORB, CORP, Sec-Fetch-Site.  In the future the lock may be
consulted for all requests handled by the NetworkService (see
https://crbug.com/920634 and also https://crbug.com/961614).

When a cross-origin, same-process navigation commits, then:

- The commit IPC carries a bundle of |subresource_loader_factories|.
  The new |subresource_loader_factories| should be used by the newly
  committed document.

- Before committing the new document, the old document's unload
  handler needs to run.  The unload handler needs to use the old
  |subresource_loader_factories| (e.g. because otherwise
  |URLLoaderFactoryParams::request_initiator_site_lock| might
  not match the document origin).


The problematic behavior before this CL
=======================================

Before the CL, content::RenderFrameImpl::CommitNavigationWithParams
would start using the new |subresource_loader_factories| before running
the unload handler of the old document (i.e. before calling
blink::WebNavigationControl::CommitNavigation on |frame_|).

The CL adds WPT tests that fail when the old, incorrect behavior
happens.  The new test initiates a beacon request from a frame's unload
handler and verifies the Sec-Fetch-Site request header associated with
this request.  The header depends on the correct
request_initiator_site_lock / on using the correct URLLoaderFactory.


The fixes in this CL
====================

This CL introduces the |call_before_attaching_new_document| callback
that is taken by blink::WebNavigationControl::CommitNavigation and
called *after* finishing running the old document's unload handler
and *before* the new document can initiate any requests of its own.

This fix is a bit icky.  In the long-term the callback can be avoided if
the |subresource_loader_factories| are stored in a per-document object
(i.e. if we swap RenderFrame on every document change, or if we replace
RenderFrame with a RenderDocument - see https://crbug.com/936696).  The
CL adds a TODO to call this out.

The fix had to refactor BuildServiceWorkerNetworkProviderForNavigation
to make sure that it uses the |new_loader_factories| (even though they
have not yet been passes to SetLoaderFactoryBundle).

The fix also refactored GetLoaderFactoryBundleFromCreator to a separate
method, so that setting the creator-based factories can also be
postponed to |call_before_attaching_new_document|.


Bug: 986577
Change-Id: If0209df61b0305ec43b5179bfdc1b9f8668a88b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716084Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685290}

R=shaseley@chromium.org

Change-Id: Ie4f837610914c63732c8cda2025cf508aefa2f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744414
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Auto-Submit: Alexander Timin <altimin@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685289}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0fe515a8..07b2fa3a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie94fe02e93149e3b789bac99fab2b0e63338d577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744051Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685288}

Also remove all the now unused members of ProfileIOData.

Bug: 908955
Change-Id: I391673049673112feab970d7f24e0a6a2d7b4df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742844
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685287}

There is very little risk to doing this and this causes IsChildOfLeaf to
disappear from the pprof profile. Having to call this during the
creation of the platform object introduced O(n^2) complexity to the
accessibility tree.

Bug: 986295
Change-Id: I9d051fe5a7d3392be6c4500a0382dd7a3812f202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736674Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685286}

SVG foreign objects always have PaintLayers now, since they are
stacking contexts. The filter and clip-path are applied by
PaintLayerPainter.

Therefore we shouldn't try to apply them in SVGForeignObjectPainter,
nor should we early-out if they "fail" to apply.

Bug: 989673

Change-Id: I4a20da8f8ea85d377b25d8376d591f36f172d854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743256
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685285}

Roll ChromeOS orderfile from 77-3849.0-1564392858-benchmark-77.0.3865.16-r1 to 78-3849.0-1565003983-benchmark-78.0.3877.0-r1

The AutoRoll server is located here: https://autoroll.skia.org/r/cros-orderfile-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: I622a3386911a530fbb6fd5d78d0e73b654911489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741305Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685284}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa26b6523911..f51ce3d98c68


Created with:
  gclient setdep -r src-internal@f51ce3d98c68

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:954450,chromium:None
Change-Id: Ia396dc4309eacf0ecb25a7e4cb886e14ea69b307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742900Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685283}

On same-site navigations, the browser reuses the current
RenderFrameHost, even if the current RenderFrameHost is crashed.

Instead of reviving the crashed one, we should get a new RenderFrameHost.

This can be seen as a small step in the direction of RenderDocument, which
intend to get a new RenderFrameHost every time, even if the previous
RenderFrameHost is not crashed.
https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit

Bug: 981339
Change-Id: I17b11abe759906a7f360abeaa45f0bfc77e08768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688957
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685282}

This change introduces utility functions necessary to compute username
hashes for the password leak detection feature.

Bug: 986298
Change-Id: I8ba0ad8d2f085d2385ec1ed76cf64de9d1403e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741969
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685281}

These animation tests too flaky on KitKat bots.

Bug: 991706, 981409, 981341
Change-Id: I7673786f0886abedb2450df9137e856286c667ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743229Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685280}

https://android.googlesource.com/platform/external/perfetto.git/+log/b307d657e8b7..0b1c529c6e47

git log b307d657e8b7..0b1c529c6e47 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 khokhlov@google.com Merge "Trace processor: Export perfetto trace stats to JSON"

Created with:
  gclient setdep -r src/third_party/perfetto@0b1c529c6e47

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I438192290b493178d659bbb26533014cc853e38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742899Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685279}

https://boringssl.googlesource.com/boringssl/+log/4dfd5af70191b068aebe567b8e29ce108cee85ce..81080a729af568f7b5fde92b9170cc17065027c9

Bug: none
Change-Id: I8594a6383f0d0977c8978f316685b1aa17c40f24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743128
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685278}

s/SafeBrowsing/Safe Browsing/gi
s/set to true of left unset/set to true or left unset/

BUG=none

Change-Id: Ie3b3c705a02ee28ff4c9369b879ac7c5b85e89a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738857
Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685277}

Tested: python3 src/build/linux/sysroot_scripts/install-sysroot.py --arch=x86
Bug: 941669
Change-Id: I23ad9c9e9e03df4d54e0961432a1cc11d5cce41a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742194
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685276}

Specifically:
 - Deleting checked-in, settings/test_util.m.js
 - Auto-generate equivalent file at the correct location (one level up)
 - Update chrome://test references
 - Update BUILD.gn deps to depend on the js_modulizer() target, and
   ensure the generated file is available in test bots (via |data| deps)
 - Update test_data_source.cc to also look at gen/chrome/test/data/webui/
   when processing chrome://test requests

Bug: 965770
Change-Id: I6243986b3297fbb949220034fe88622adc320fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742832Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685275}

https://chromium.googlesource.com/catapult.git/+log/8e2aad881bcc..8bd58eb928c3

git log 8e2aad881bcc..8bd58eb928c3 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 rnasri@google.com Update which screenshots are considered in calculating the metric

Created with:
  gclient setdep -r src/third_party/catapult@8bd58eb928c3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:983638
Change-Id: I1455688caf27653968665b909b1225f368ac2bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685274}

Change-Id: Ief54847dc4d06fe1620d9dafb1df29e3104f000d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735458Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685273}

Using wpt-import in Chromium 9f64ec44.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I1d58126b9c4ecac18069d462a2a65ee9ebc0b826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744050Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685272}

Bug: 973482, 973446
Change-Id: I20d801d414f24f6bba4e155a7d6f1c7020a07eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743186Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685271}

Per the latest WebXR spec, XRInputSource.gamepad.id must be the empty
string. Update the browser and layout tests to actually check this.

Also update the browser tests that run on Windows to check the profiles
array contents against expected values for WMR and OpenVR.

Bug: 989114, 942201
Change-Id: I36dff42cff55728d5d90384623623ea871d3a13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742439
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685270}

Remove unused FLAGS_quic_headers_stream_id_in_v99.  Sync values of
flags with update_flags.py.

Change-Id: I807595a7cbe26cf203e722120dbd2afba8fcdd5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742214
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685269}

With network service shipped everywhere these tests should not and
indeed appear to not flake anymore.

Bug: 800898
Change-Id: I2cc59a6a5917e57629f1087e4868e636f2f72d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742733
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685268}

https://chromium.googlesource.com/angle/angle.git/+log/e86a8560f202..4c833efb60a1

git log e86a8560f202..4c833efb60a1 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 tobine@google.com Vulkan: Enable sampler objects
2019-08-08 iannucci@chromium.org [infra/config] Actually set properties_j in the right place.
2019-08-08 tobine@google.com Sampler::syncState now returns angle::Result
2019-08-08 m.maiya@samsung.com Vulkan: Support the vertex_type_2_10_10_10_rev format
2019-08-08 jdarpinian@chromium.org Reenable extra_warnings config for angle_utils

Created with:
  gclient setdep -r src/third_party/angle@4c833efb60a1

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: chromium:973721
Change-Id: Iada1cf88d1a514decd2c0dd060e35d5d2bc27f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744281Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685267}

R=yusufo@chromium.org

Change-Id: Iffd4d640e373c721ade6c4a30417f64629987c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742519Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685266}

- Move trivial initializers to declaration site
- Move Visit* methods to private section
- Remove unused parameter around Persistent APIs

Bug: 982754
Change-Id: Iec4102f1466a8b65251aa69892d041f450ac069e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743636
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685265}