- 22 Sep, 2017 6 commits
-
-
David Tseng authored
Bug: 618099 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I194d9e2ccea2641f7d4685db7d68273e850df53a Reviewed-on: https://chromium-review.googlesource.com/675587 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#503623}
-
Devlin Cronin authored
Add some basic documentation on extension API schemas. Bug: 734198 Change-Id: I4a29787ff489929d5051ca06fca27bbe6dc7111c Reviewed-on: https://chromium-review.googlesource.com/677130 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#503622}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I8a525930611c03c04860d59c9a9e9e5c8f9d1ab3 Reviewed-on: https://chromium-review.googlesource.com/678335Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#503621}
-
Victor Costan authored
Bug: 718360 Change-Id: If0a8b84bf4eb6252f2b64c070f305a9c2685542b Reviewed-on: https://chromium-review.googlesource.com/677738Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#503620}
-
Andrew Moylan authored
This CL removes GeolocationDelegate::UseNetworkLocationProviders. Its responsibility (of optionally disabling network geolocation) is explicitly moved to GeolocationDelegate::CreateAccessTokenStore. Today GeolocationDelegate has UseNetworkLocationProviders (default true) and CreateAccessTokenStore (default nullptr), and these are effectively &&'d together by LocationArbitrator to decide whether to try to use network geolocation. Since AccessTokenStore has other uses, UseNetworkLocationProviders is essentially redundant. I surveyed embedders internal and external to Chromium repo and found no cases of contradictory use of these two signals (i.e. no cases of setting UseNetworkLocationProviders to false but still overriding CreateAccessTokenStore to return a non-nullptr). I also spruced up the LocationArbitrator unit tests with some comments and made them a bit more "injecty" to simplify understanding them. Bug: 748921 Change-Id: I528f6f0a81263df868795be81201141c260aa836 Reviewed-on: https://chromium-review.googlesource.com/670964Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503619}
-
Robert Liao authored
There are no more references to ReadWriteLock in the Chromium codebase. BUG=758721 Change-Id: I2b83afb9c1682fe349f2e389eb75fc0c368497b6 Reviewed-on: https://chromium-review.googlesource.com/676626Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#503618}
-
- 21 Sep, 2017 34 commits
-
-
Adrienne Walker authored
Currently, at raster images are decoded lazily from the PlaybackImageProvider when they are encountered during the raster process. The lock on the raster image is held only for the duration of the op itself. To simplify code and to help with oop serialization, this patch now holds the lock for these images across the entire task. This will potentially increase the memory high watermark for cases where there are a lot of images. In practice, there are very few at raster images, and so this should not be too impactful. A followup to this patch is to assert that no image is encountered that has not been predecoded (either via task or via this at raster synchronous decode) and also to modify PlaybackImageProvider to not do any decoding or uploading. However, these are more risky changes and so have been deferred. Bug: 762732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifec303c16b4d35c789f313445614d7cd59955a61 Reviewed-on: https://chromium-review.googlesource.com/676276Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#503617}
-
Istiaque Ahmed authored
This is a reland of 350845d8 The fix is in Patch set #1 -> #2, by removing dependency on ipc/ipc_message.h from e/c/constants.cc. The include fails on "win_x64_archive" bot but doesn't reproduce on local win 64 build. Since we're using MSG_ROUTING_NONE from ipc_messages.h in event_bindings.cc anyway, move the usage there. Original change's description: > Extension SW: Add filtered event listener support. > > The primary change is to send worker information to > EventRouter::Add/RemoveFilteredEventListener. EventRouter creates > worker specific event listeners when worker information is present > (identified by a base::Optional param). > > The other changes are: > - Added the ability to call MakeLazy() on service worker specific > event listeners. > - Since routing id matching is not done deliberately on service > worker filtered events, added routing id retrieving function > GetRoutingIDForFilteredEvents() to ScriptContext. > > An end-to-end browsertest with webNavigation API to exercise event > filters was also added. > > IPC changes: > This CL adds an optional param to Add/RemoveFilteredListener. The > presence of this param denotes that the listener being added/removed > belongs to an extension service worker. And the value of the param > (ExtensionHostMsg_ServiceWorkerIdentifier) contains the identifying > bits of a service worker. The absence of this param indicates that > the message is for vanilla (non service worker) extension event > listeners. > > Bug: 721147 > Change-Id: I2ff3c26db54ae1e1fd7d10b8afcb277d382e83c2 > Reviewed-on: https://chromium-review.googlesource.com/666222 > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503298} TBR=tsepez@chromium.org Bug: 721147 Change-Id: I53e0ef921eaf3fe318fa3f01c2bdf5dfe2d32994 Reviewed-on: https://chromium-review.googlesource.com/677587 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503616}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/8e9e3d8975ee..09b5ce623fc4 $ git log 8e9e3d897..09b5ce623 --date=short --no-merges --format='%ad %ae %s' 2017-09-22 art-snake Rename CPDF_SyntaxParser::GetObject to GetObjectBody 2017-09-21 dsinclair Move CFX_WeakPtr to WeakPtr 2017-09-21 dsinclair Move CFX_UnownedPtr to UnownedPtr Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Id11a43c4b8a1763ad079a9f477895cc2cd1d433c Reviewed-on: https://chromium-review.googlesource.com/677791 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503615}
-
Evan Stade authored
class. It seems confusing to let Notification become cluttered by extra fields that are type specific. Bug: 763426 Change-Id: I202f10cca7b2637fd696897616cadf1f0c44e93f Reviewed-on: https://chromium-review.googlesource.com/669687 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#503614}
-
Lucas Garron authored
This CL also adds unit tests for .foo preloading and updates two tests that were using http://foo as a test URL. There are still other places in the code that use http[s]://foo as a test domain. If this change causes issues for them down the line, they should be changed to use foo.test or another domain under a test TLD: https://tools.ietf.org/html/rfc2606#section-2 BUG=b/65158868 (Google-internal) Reviewed-on: https://chromium-review.googlesource.com/669396Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502948} Change-Id: I506ff6fa7477501bddb4712576cc225a4debfaeb Reviewed-on: https://chromium-review.googlesource.com/673709 Cr-Commit-Position: refs/heads/master@{#503613}
-
Piotr Swigon authored
This change has been behind a flag for some time, there is no server side component as this flag controls only a UI treatment. Bug: 471623,767297 Change-Id: I216eabddcb017cd4b1bf794d1bdfe5c13f0fe71d Reviewed-on: https://chromium-review.googlesource.com/676690Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#503612}
-
Nate Chapin authored
Bug: Change-Id: I92558b0137e7fc1159f5f7ed3648312645c283f5 Reviewed-on: https://chromium-review.googlesource.com/677493Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#503611}
-
Jiaquan He authored
Enabling answer cards will add a SearchResultContainerView to SearchResultPageView. This will intefere the relevance sorting with SearchResultTileItemListView and SearchResultListView, which then breaks some unit tests. Bug: 766784 Change-Id: I513f006a5d552eb91b20b834b123d2233d5048c2 Reviewed-on: https://chromium-review.googlesource.com/673850 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503610}
-
Scott Graham authored
Adds some deps/data_deps that weren't being included on Fuchsia. Bug: 761182 Change-Id: I5d36d5c6cf7b7cc0527b8e95264d7feb016f6648 Reviewed-on: https://chromium-review.googlesource.com/673805Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#503609}
-
Yuri Wiitala authored
Re-wires the API and internals of GLHelperScaling (and GLHelper::ScalerInterface and GLHelper::YUVReadbackInterface) to allow client code to create fixed-ratio scaling pipelines. Callers can then request scaling of any subset of the output space. This is just like the skia::ImageOperations::Resize() API. This is a prerequisite need for the referenced crbugs (below). Rationale: In the old API, callers had to specify exact source and destination sizes upfront; and fully reconstruct pipelines whenever either changed. In addition, the old API required whole-number source rect coordinates; but this prevented using many scaling ratios (e.g., 3:1) that require sampling from non-whole-numbered source rect coordinates. Much of this change is simply plumbing-throught the API changes everywhere. However, the following were mostly rewritten: 1. [gl_helper_scaling.cc] ScalerImpl now back-computes the source sampling rect based on the requested result rect. It also works backwards through the "ScalerImpl chain" to ensure minimaly-sized intermediate textures are produced. 2. [gl_helper.cc ] YUVReadbackImpl and YUVReadback_MRT were simplified and able to be merged into one class. Bug: 760348, 754872 Change-Id: Iba3ed5cf504eeed69eb115b4c38d031db47bebcc Reviewed-on: https://chromium-review.googlesource.com/669918 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#503608}
-
Eric Stevenson authored
Bug: 765428 Change-Id: Ia3234093b48cc94f2b51fc889063bec62fbb8a85 Reviewed-on: https://chromium-review.googlesource.com/677649 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#503607}
-
Yuke Liao authored
There is a TODO in the help message to make the test file identifiers configurable, however, this doesn't help users in any way, so move it closer to where the variable is defined. Bug: Change-Id: Id6f3fed4b121e115cfa71f6dc89d576529e0acd0 Reviewed-on: https://chromium-review.googlesource.com/677054Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#503606}
-
Matt Wolenetz authored
Modifies PITB::StartPipelineWithMediaSource() to let any PITB::OnEnded() or PITB()::OnError() stop the run loop and let the method return. In cases where OnError (like that triggered if EME is indicated in init segment -> PITB::FailTest()) or OnEnded occur prior to pipeline completing start-up, this avoids one kind of fuzzer timeout. Also includes addition of PITB helpers to assist common "RunUntilIdle" scenarios and refactoring of PITB to use those helpers. Also changes the SRC= PITB::StartInternal() to similarly allow early fuzzer EME callback to quit the run-loop early, possibly mitigating any similar timeouts in SRC= media_pipeline_integration_fuzzer. BUG=766472,766669 Change-Id: I8307db26828eaf04ae92dc1dbee4fa6969c5dd37 Reviewed-on: https://chromium-review.googlesource.com/677774Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#503605}
-
smut authored
Bug: 756270 Change-Id: Ica1ab2cf9c8e57dadfb1693b9beae96f3e2240ae Reviewed-on: https://chromium-review.googlesource.com/677857Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#503604}
-
Dominic Mazzoni authored
Unfortunately a ton of refactoring was required to make this possible, because too much of logic assumed the existence of an Element, and assumed that we only cared about ARIA on AXNodeObject subclasses. I stopped after supporting just 3 properties because this is a large enough change already. Bug: 761901 Change-Id: Ie7148f3d4aaf3308d43089260b761f73e56d995b Reviewed-on: https://chromium-review.googlesource.com/676879Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#503603}
-
Robert Ma authored
Bug: 749879 Change-Id: Ie283642f14d62191d86b57b058f2dd7515fe05b4 Reviewed-on: https://chromium-review.googlesource.com/676658Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#503602}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7c5b115..1fbe1ff2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iba01a92306748a7315c91090ee11e2c78f0b259b Reviewed-on: https://chromium-review.googlesource.com/677647Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#503601}
-
Shenghua Zhang authored
Bug: 766307 Change-Id: Iee410208ebad54d4af7a6e19e252b932607e5ae1 Reviewed-on: https://chromium-review.googlesource.com/677781Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#503600}
-
Stefan Zager authored
With RLS enabled, the LayoutView has additional scrolling and scrolling contents layers. BUG=711468 R=skobes@chromium.org Change-Id: I052b329d82152fa05eeeccdbfd5823794f80eda4 Reviewed-on: https://chromium-review.googlesource.com/677084Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#503599}
-
Stefan Zager authored
This test has the expected layer tree diff, but the extra text in the output caused it to be missed by the bulk updater. BUG=711468 R=skobes@chromium.org Change-Id: I37a5d27d7cbe03f6dd3baf287363f72f2efada2f Reviewed-on: https://chromium-review.googlesource.com/677063 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#503598}
-
Stefan Zager authored
With RLS enabled, there will be additional scrolling and scrolling contents layers on the LayoutView. BUG=711468 R=skobes@chromium.org Change-Id: I861376c505661528491e4a801d7f7f6e39577f63 Reviewed-on: https://chromium-review.googlesource.com/677083Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#503597}
-
Ned Nguyen authored
Bug: 767540 Change-Id: Ic15d4ae39258b4bbd380ea5034e80e9091d2cffa Reviewed-on: https://chromium-review.googlesource.com/677553Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#503596}
-
Peter Wen authored
Android system is crashing due to StrictMode but we need to know the underlying cause in order to understand why it is flaking. Disabling StrictMode just for those code paths as the flakiness is unreliable and hard to reproduce. BUG=767423,767153,767624 Change-Id: I0ddcabd876bab99841487742f039cea920ea433d Reviewed-on: https://chromium-review.googlesource.com/677226 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
ccameron chromium <ccameron@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#503595}
-
Xiaochu Liu authored
It exposes a dbus method call LoadComponent that calls component updater API to install a chrome os component. BUG=chromium:763415 TEST=dbus-send is working on chrome os, component is downloaded. Change-Id: I7d0ba7e7cc3445ba8d4ba1c849df08c3eab19ba6 Reviewed-on: https://chromium-review.googlesource.com/676090Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#503594}
-
Matt Wolenetz authored
Since the kMseBufferByPts feature enabled/disabled state is cached by ChunkDemuxer's ctor (to coherently configure the MSE portion of all of the buffering for that ChunkDemuxer and protect against feature status possibly changing during the lifetime of the ChunkDemuxer), various unit tests that test layers below (not including ChunkDemuxer) no longer need to vary the feature state. They already vary how they configure the system under test directly (like how ChunkDemuxer would). This change removes unnecessary kMseBufferByPts toggling in these lower layer tests: SourceBufferStateTests FrameProcessorTests SourceBufferStreamTests Note: PipelineIntegrationTests and ChunkDemuxerTests must still do feature toggling to retain coverage. BUG=718641 Change-Id: I69e8e59d2b198e38e4f4a7f51ce37b70c862745e Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/676536Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#503593}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/68ce41b9bda2..33d54da00a77 $ git log 68ce41b9b..33d54da00 --date=short --no-merges --format='%ad %ae %s' 2017-09-21 dtu [pinpoint] Send email with bug post upon job completion. 2017-09-21 dtu [pinpoint] Add message in bug when there are no change points. 2017-09-21 simonhatch Dashboard - Link metric docs in bug comment if available. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5aa79af14a60502e4a1c8c4ad0cbf127a7235841 Reviewed-on: https://chromium-review.googlesource.com/677135 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503592}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2fbf1bc8c96f..cfbbcbe52624 $ git log 2fbf1bc8c..cfbbcbe52 --date=short --no-merges --format='%ad %ae %s' 2017-09-21 robertphillips Temporary patch for Mac TSAN bot (with threaded Ganesh mask generation) 2017-09-21 mtklein Fix Android roll. 2017-09-21 mtklein count total non-lowp runs 2017-09-21 robertphillips Guard resource provider path creation methods against abandoned context 2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ 981f0f8f6..1f9d68437 (1 commit) 2017-09-21 mtklein Don't call GrBuffer::map() in createPatternedIndexBuffer. 2017-09-21 kjlubick [WASM] Add POC compile bot for WebAssembly 2017-09-21 mtklein no_sanitize is Clang 3.7+ 2017-09-21 bsalomon Serialize rrect/oval paths as rrects rather than points and verbs. Created with: roll-dep src/third_party/skia BUG=767279 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I959808761fe4975d87e31d7158ae0d06b1593597 Reviewed-on: https://chromium-review.googlesource.com/677480Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503591}
-
Ned Nguyen authored
Bug: 767544 Change-Id: Ie0c22a5f45ffeb3ecf99e6f9f8bb4c6ce21716bc Reviewed-on: https://chromium-review.googlesource.com/677552Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#503590}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3418f710f923..8e9e3d8975ee $ git log 3418f710f..8e9e3d897 --date=short --no-merges --format='%ad %ae %s' 2017-09-21 dsinclair Move CFX_StringPoolTemplate to StringPoolTemplate 2017-09-21 dsinclair Move CFX_StringDataTemplate to StringDataTemplate 2017-09-21 dsinclair Move CFX_SharedCopyOnWrite to SharedCopyOnWrite 2017-09-21 dsinclair Rename CFX_RetainPtr to RetainPtr 2017-09-21 dsinclair Cleanup WidgetMgr ownership 2017-09-21 dsinclair Move CFX_Observable to Observable Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I2281d1e770e9a5f0d593859604f27c7df31fe95f Reviewed-on: https://chromium-review.googlesource.com/677136 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503589}
-
Jinsuk Kim authored
- The test needs to run with ContentJUnit4ClassRunner to initialize command line switch that allows for programmatic media play as expected. - There are SkipChecks that expects CommandLine instance be ready. Called CommandLine.init() with an empty value in ContentJUnit4ClassRunner before skip check process gets started. Bug: 640116 Change-Id: Ic2142a98646ae45d30e37f30633a97267b557b92 Reviewed-on: https://chromium-review.googlesource.com/671167Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#503588}
-
MinChen authored
Bug: 765850 Change-Id: I3dfb05a98be74e60c7fbe840a2de2c811a42d374 Reviewed-on: https://chromium-review.googlesource.com/669914 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503587}
-
Steven Valdez authored
Bug: Change-Id: Ie32677aae5b3d3c7c67618bf9fc32fd6bdfd21df Reviewed-on: https://chromium-review.googlesource.com/677268 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#503586}
-
Victor Costan authored
Bug: 766923 Change-Id: I643cc299cbad988e6b2c709cfcc733bf5a0c589a Reviewed-on: https://chromium-review.googlesource.com/677743Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#503585}
-
edchin authored
This reverts commit 70e88907. Reason for revert: This fails showcase egtests for SCPaymentsPickerTestCase on iPhone 5/5s iOS 9, 10. Most likely due to smaller form factor needing scrolling to find a view. Original change's description: > [Payment Request] Adds a navigation bar to the country picker. > > Video of the fix in action: > https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing > > Bug: 767154 > Change-Id: I1881976b27ba6aade47d5d06879fb65dcf3d24de > Reviewed-on: https://chromium-review.googlesource.com/674667 > Reviewed-by: edchin <edchin@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503521} TBR=macourteau@chromium.org,edchin@chromium.org,mahmadi@chromium.org Change-Id: I4c64e34558c3d5fe57d522f452a2286e40b1dd6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767154 Reviewed-on: https://chromium-review.googlesource.com/677414Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503584}
-