- 21 Aug, 2020 40 commits
-
-
Alex Turner authored
When the script is about to execute, we check whether it was added by ad script. If it was, we tag that script as an ad. In order to track these scripts, which have no URL, we assign them a fake url based on their script id. Bug: 1098530 Change-Id: Id7a3571a47fb9235379b68a3f041a18952aafa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316326 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800582}
-
Alex Turner authored
This digest will be used to understand how identifying locally installed fonts are. To reduce unnecessary computation, we cache the results on the FontGlobalContext and skip computing the hash when an identical font lookup is already saved. Original CL by mmenke@chromium.org Bug: 1081268 Change-Id: If18c04dc8f818a9052066484dc59717a2480d2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341357Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#800581}
-
Alice Wang authored
This CL batches confirm sync data machine tests. Bug: 1120258 Change-Id: I7c85b3997fb2a2754aac030ce210ef19682ab09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367718 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#800580}
-
nancylingwang authored
With multiple monitors, when launch an app unpin on the shelf, and drag the icon for the launched app, the icon is ripped off from the shelf on all monitors, because the icon opacity is set as 0.0f (transparent): https://source.chromium.org/chromium/chromium/src/+/master:ash/shelf/shelf_view.cc;l=2155 However, when release the button to restore the icon back to the Shelf, only the icon on 1 monitor pulled by the mouse is recovered because the opacity for the icon is restored to 1.0, not transparent by the drag view: drag_view_->layer()->SetOpacity(1.0f); Well other icons on other monitors are not recovered. So modify the drag rip off handling to recover other icons on other monitors when release the mouse for the drag icon. BUG=1119698 Change-Id: I49439a7c02c18b0875c53772bd0081a016ab720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367261 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800579}
-
Jarryd authored
Bug: 1117159 Change-Id: I8d8088cb7ca703d579754d880faf2926e483236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363258Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800578}
-
Elly Fong-Jones authored
This change: 1) Introduces WidgetDelegate::SetModalType, by analogy with the existing GetModalType() virtual; 2) Removes many overrides of GetModalType() within Views itself, which allows removing several subclasses of WidgetDelegate that existed solely to override this method; 3) Moves DialogDelegate's constructor to public, since it is now useful standalone (i.e. without subclassing it). Bug: 1075649 Change-Id: I90dd7e1d61e9fb5726b4f148ce5c054b207bbbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363262Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#800577}
-
Guido Urdaneta authored
Also define constants for releases M86-M88. Bug: 1120343 Change-Id: If1eec3093b352928f80c744cb57525b364f1fe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369094Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800576}
-
Side Yilmaz authored
This CL adds getImageFetcher function back to prevent crash causing not profile set before getVisuals function is called. Regular profile is used to create image fetcher when mImageFetcher is null. This is safe since anytime switching to incognito will cause setProfile function is called and image fetcher will be created with incognito profile. Bug: 1119688 Change-Id: I826bde1a36a22ccf59243d0bab194c2ddf0659a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366760 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#800575}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 130501f2. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7882814b56e37260e2ed32a027d3f395fd07350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368996Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800574}
-
prashant.n authored
The dark mode page policy is used for deciding whether to apply dark mode filter to the given LayoutView or not based on values kFilterAll (always process) or kFilterByBackground (process based on background color.) The current code has kFilterByBackground as a default value. But processing based on background of root layout object can lead issues like not applying dark mode to children having light or transparent backgrounds. This patch removes page policy concept and now every layout object gets classified for applying dark mode. All the sites for which page policy kFilterByBackground was added, work properly after removing the page policy concept. This now helps pages from e.g. theverge.com render correctly in dark mode. In these pages, children of dark backgrounds get dark mode applied correctly and look dark. Previously they were getting rendered as if dark mode was not applied. Bug: 1081383 Change-Id: I1e6a941bad22689569f2aec76d5beb88daced9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323441Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#800573}
-
Rouslan Solomakhin authored
Before this patch, paying via secure payment confirmation method would always return {"status": "success"} without invoking WebAuthn. This patch checks that the platform authenticator is user-verifying and invokes WebAuthn with stubbed out options. The autofill::InternalAuthenticator is being used because it provides a cross-platform abstraction that fits neatly into the cross-platform payment apps and factories of Web Payment. After this patch, only devices with user-verifying authenticators would display a payment app and invoking that app will always fail because of the stub credential identifier. Design: https://bit.ly/secure-payment-confirmation Explainer: https://github.com/rsolomakhin/secure-payment-confirmation Bug: 1110320 Change-Id: I8adabf2938ae5a65a6a87c9bc5f6df275b833f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364813Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800572}
-
Justin Cohen authored
This reverts commit 5f4895f5. Reason for revert: First failure here: https://ci.chromium.org/p/chrome/builders/ci/smoke/45194?blamelist=1#blamelist-tab Original change's description: > [ios] Turn on FullscreenControllerBrowserScoped by default > > Bug: 790886 > Change-Id: Ide1eee5634376b90cfa820bb61644c871969ff86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358589 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Auto-Submit: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800354} TBR=sczs@chromium.org,thegreenfrog@chromium.org Change-Id: I2c9c8f5eb609d72d56dcf4f6c69caab301a83ef6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368503Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800571}
-
Dylan Cutler authored
identifiability study. Bug: 973801 Change-Id: I37bbe7f53343f0138303861db6529dd8283854e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364054Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
Make the documentation clearer by replacing "ask about store" with "ask in which store to save". Bug: None Change-Id: I9a5fd3f58b9d000cb6838849feb8844b77450080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368595Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#800569}
-
David Roger authored
- picker minimum size is now defined in C++ and sent to javascript in loadTimeData - the picker native window uses this size as minimum size - in the case of small screens, a smaller native window is still allowed Change-Id: Ib4750bf09d861336d2c66f76a5fdd8bf2ec7c303 Fixed: 1119893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367081 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#800568}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I494bd29308e9f7bf22f678f7dd2e990b2a785c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800567}
-
Mehran Mahmoudi authored
This adds two new UMA histograms: 1.Record whether a paint preview was painted before the associated tab was loaded or not. 2. Record the time it takes from activity initialization to the first paint event. Bug: 1109991 Change-Id: I5757dafbb69289c607d8493acd99314e34538c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364022Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800566}
-
Friedrich Horschig authored
The disabled test flakes for 12h with a high frequency. According to the flakiness dashboard, it affects all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Ffeature-policy%2Fexperimental-features%2Fvertical-scroll-disabled-scrollbar-tentative.html TBR: iclelland@chromium.org Bug: 1120106 Change-Id: Ia4bf0c4ac0428cac22ded67a562b4179ee7b9e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367949 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800565}
-
Hajime Hoshi authored
Bug: 1014174 Change-Id: Id42d841138d0b571f12d6d9e81aa17a236a222e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366533 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800564}
-
Curt Clemens authored
Log a variety of errors and the start/finish of async operations in NearbyShareCertificateManagerImpl and NearbyShareCertificateStorageImpl using the NS_LOG macro. Change-Id: Iadbee4fff8869b23606b990f7635e3f73429dad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364086 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800563}
-
Mike Reed authored
... removing unused enum parameter Amends previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2367441 Change-Id: Id36d21a264a32801dc09253112180bd2d1f6aaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367987Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#800562}
-
Siyu An authored
Introduced the skeleton of the new autofill offer sync bridge. Will add more to it in the following CLs. The offer data and the wallet credit card data now will controlled by the same toggle in the Chrome sync settings page. Therefore the sync logic will be almost same. So reuse the current model type controller. Bug: 1112095 Change-Id: I7464dde02b84f0a020f262c5453e8ac4a067edfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365854Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#800561}
-
Peter Boström authored
The extension icon images are 28x28 to as they contain space for badging the icon with "click to script". They are still visually 16x16 icons. This change adds the same amount of space (but not for badging) around the actually-16x16 settings icon to make icon and text aligned with other items in this menu. Bug: 1050601 Change-Id: I51c9aa81ab05fd53cf3b3702e73c543f257a1960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368927 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#800560}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2c33e3fa098..9d8fd36d3b95 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 2979391e5b0c to e1c7eaa74142 (1 revision) 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a711c594b8cc to b79773a35d52 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ida343d5391e43bc1c974b6659e75db1761c17c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368911Reviewed-by:
-
Thiabaud Engelbrecht authored
Discardable memory Lock()-ing can succeed or fail once it has been Unlock()-ed. For example, Lock() will fail if the memory has already been discarded. This CL is to record the hit rate in UMA. Bug: 1117043 Change-Id: I1c7214365fe7b0b20d3af7e750ff4cfdf3ef4c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344812Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#800558}
-
Christian Dullweber authored
Show cookie settings when the user clicks on "Settings" link. As chrome and weblayer have different ways of creating intents, this happens in the pageinfo delegate. Bug: 1077766 Change-Id: Iefd81c06ce3947eb4e95107db1360c375955ed01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343033 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800557}
-
Arthur Hemery authored
A cross origin isolated page is a page that has set COOP and COEP, eventually unlocking access to powerful APIs such as SharedArrayBuffer. This first patch goal is to introduce cross origin isolated BrowsingInstances that only contain cross origin isolated pages. It modifies the SiteInstance selection process to make sure the invariant holds. In more details: - BrowsingInstances now have a is_coop_coep_cross_origin_isolated boolean, that indicates if all the pages contained into it have been COOP+COEP enabled. Each BrowsingInstance also holds the origin of the top level pages contained in it, unique across all the top level pages in it. - CHECKS and DCHECKS enforce the BrowsingInstance invariant. See the full design doc https://docs.google.com/document/d/1OFaz1Txi4ynFLmRqNTLFF3qd6jm4kK4GkJdmgr5_aZA/edit?usp=sharing for more information. It was based on clamy@ work here: https://chromium-review.googlesource.com/c/chromium/src/+/2066844 and further discussed here: https://chromium-review.googlesource.com/c/chromium/src/+/2119854 BUG=1055779 Change-Id: I4829337f5fd4a4c2cd18f2cfaaf7ef8054eb67a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230632Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#800556}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597967068-f4dc3a01dd1d9ac3893254a5c720534a30d259cc.profdata to chrome-mac-master-1598010867-4aa503022e102f1aa007637f80b234f543663e29.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Ic87539cead5efc07220c201af63008ff2c700268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369153Reviewed-by:
-
Titouan Rigoudy authored
Following Camille's recommendation, this CL moves all mentions of PrivateNetworkRequestPolicy out of components/content_settings and into content/browser. Given that the content setting is now used purely as an escape hatch disabling CORS-RFC1918 checks, a boolean is simpler and clearer. It also removes useless DEPS and BUILD.gn dependencies that were left over from an incorrect rebase operation during crrev.com/c/2282932. Bug: chromium:986744 Change-Id: I5912e2bb091e28dfdcc273342e10fd2e2bbc47ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367074Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800554}
-
Liviu Tinta authored
Pointer lock is acquired and released asynchronously. Remove reliance on timeout from the test by waiting until lock is properly acquired/released during the test steps. Bug: 1025944 Change-Id: Ibd5b1c19efb9c00794f1b900e12a5f5a4edab16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360494Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800553}
-
Roman Sorokin authored
This CL modifies existing behavior in the way that HID Detection screen is always shown on OOBE start if it's needed. It proceeds to the saved in the local state screen (or welcome screen) after that. Also removed CheckIsScreenRequired from the handler. Change-Id: I0253eae1a67c39567aba4f0cc522488c465056a4 Bug: 1105889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339655 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800552}
-
Anna Malova authored
TBR=arthursonzogni@chromium.org Bug: 1119555 Change-Id: I9c83227a0aae954e57d8f15cd7b4fc1cc1970a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368873Reviewed-by:
-
Weilun Shi authored
Temporary disable validate_prefix.py until we split all histograms because this blocks all updates in the current histograms.xml. Bug: 1120228 Change-Id: I5f3a607942098c4aa9341d1f86dda7913d185c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368080 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#800550}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8fa384f..ce9f3a41 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idacdb9154bd2679c28d63ac986dbcce89cbd2823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367495Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800549}
-
Stephen Sigwart authored
Home key changes to first of month, January in month view, and week 1 in week view. End key changes to last of month, December, or last week. For time, home goes to 1, 00, and am while end goes to 12, 59, and pm. Bug: 1062025 Change-Id: I40daebeca55eeb578a3b75d1ab06b6013d9bc540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358476Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Cr-Commit-Position: refs/heads/master@{#800548}
-
kylechar authored
This CL changes how pixel tests are defined in viz_unittests. This is intended to be a refactor only change with no changes to the test logic or what tests run on each platform. Vix pixel tests previously used gtest typed tests, where the RendererType was a template parameter. Typed tests are not particularly extensible and don't work well when the parameter space to be tested isn't directly mapped to existing types. Some hacks to define pseudo types and use type deduction were used to specify things like running SkiaRenderer with different graphics backends (eg. GL vs Vulkan). This CL converts switches viz_unittests to use value parameterized tests to specify different renderer and graphics backend combinations. Value parameterized tests are the most extensible in gtest, and this fits in well with existing value parameterized tests. The key change here is replacing the cc::RendererPixelTest base class with a new VizPixelTest class. It's essentially equivalent except the RendererType is passed a constructor parameter instead of template parameter. An attempt was made to keep the test names stable, however some changes were introduced when changes as tests suites were merged. A follow up CL will use the renderer name instead of an arbitrary number to identify variations of the same test with different renderers, so the test naming is about to change significantly anyways. Bug: 1117587, 1047820 Change-Id: Ib626a081fb7797938a5cd34e96d8af44d7181965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364222 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#800547}
-
Roman Aleksandrov authored
Create all needed Update screen steps, use newly added time left estimation and progress procent. Bug: 1119399 Change-Id: Ia7ff7f76fb21fa683457f71f0bab3f598571e096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364634 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800546}
-
Mohamed Amir Yosef authored
... in CompromisedCredentialsConsumer. This is similar to OnGetCompromisedCredentials(), but also receives the originating PasswordStore as a parameter. Bug: 1108422 Change-Id: Icc4e8135f4181b17f23fbee23666d20ad4f04277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367717 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800545}
-
Harald Alvestrand authored
Rewrite test so that it does not hang (create promise before event that it is waiting for). Bug: chromium:1115080 Change-Id: Ic445bef22561a1d997b4d3657a76e1b0779a1259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367854Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800544}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bfb423d26610..490961030b55 2020-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I26a9e59c62ff3bbc0b82df23bfa6210d0c1abd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368921Reviewed-by:
-
