GitLab

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2608163007
Cr-Commit-Position: refs/heads/master@{#441472}

BUG=677863

Review-Url: https://codereview.chromium.org/2611933003
Cr-Commit-Position: refs/heads/master@{#441471}

https://pdfium.googlesource.com/pdfium.git/+log/6745f96fab41..dc39e377e1a3

$ git log 6745f96fa..dc39e377e --date=short --no-merges --format='%ad %ae %s'
2017-01-04 tsepez Add missing operator<() to CFX_RetainPtr.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2614793002
Cr-Commit-Position: refs/heads/master@{#441470}

Previously, we implement scrollIntoView by scrolling the intersection of the
viewport and the content. However, when the content is not visible in the
viewport, e.g. outside boundary and the viewport's overflow attribute is
hidden, the intersection would be empty and the browser would stop the
scrolling logic. In this case, we presume the webpage wants to scroll the
position of the content but for some reason doesn't want to show it. In this
patch, we scroll the content's position for this special case.

BUG=673396
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2576963002
Cr-Commit-Position: refs/heads/master@{#441469}

BUG=656193

Review-Url: https://codereview.chromium.org/2614783002
Cr-Commit-Position: refs/heads/master@{#441468}

TBR=wjmaclean,rdevlin.cronin
BUG=678267

Review-Url: https://codereview.chromium.org/2616693002
Cr-Commit-Position: refs/heads/master@{#441467}

so AddOwnershipEdge can attribute memory correctly between
URLRequestContexts. See the following doc for more details on why it
is needed.

https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i14/edit

BUG=669108

Review-Url: https://codereview.chromium.org/2560593002
Cr-Commit-Position: refs/heads/master@{#441466}

Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ )

Reason for revert:
fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.

Original issue's description:
> Make run_webkit_tests random order by default for all platforms.
>
> BUG=671805
> R=dpranke@chromium.org,qyearsley@chromium.org
>
> Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
> Cr-Commit-Position: refs/heads/master@{#441424}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671805

Review-Url: https://codereview.chromium.org/2617563002
Cr-Commit-Position: refs/heads/master@{#441465}

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try

Review-Url: https://codereview.chromium.org/2599673005
Cr-Commit-Position: refs/heads/master@{#441464}

BUG=677311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2612673002
Cr-Commit-Position: refs/heads/master@{#441463}

[Presentation API] Resolve PresentationRequest::reconnect() with existing presentation connection if such connection exists

Check if any presentation connection with specific presentationUrl and presentationId exists in current browsing context. If so, resolve reconnect() with existing connection instead of creating a new connection.

BUG=677540

Review-Url: https://codereview.chromium.org/2602523002
Cr-Commit-Position: refs/heads/master@{#441462}

This CL rolls the sysroots after 3b607160.  In addition, it also fixes
a bug in build-and-upload.py which would cause the script to fail if
not run in build/linux/sysroot-scripts.

BUG=668205
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2599763004
Cr-Commit-Position: refs/heads/master@{#441461}

Fix MissingFormatArgumentException in Evaluation test for latest logging
changes.

BUG=678279

Review-Url: https://codereview.chromium.org/2610883003
Cr-Commit-Position: refs/heads/master@{#441460}

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596

Review-Url: https://codereview.chromium.org/2610743002
Cr-Commit-Position: refs/heads/master@{#441459}

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146

Review-Url: https://codereview.chromium.org/2610983002
Cr-Commit-Position: refs/heads/master@{#441458}

Media renderer might get destroyed (due to pipeline being stopped or
suspended) while a video track restart is pending. When that happens
the VideoRendererImpl has a pending flush_cb_ that will get called from
video renderer destructor invoking RendererImpl::RestartVideoRenderer,
so RestartVideoRenderer needs to actually try restarting the video
renderer only if we are still in the playing state.

BUG=668963

Review-Url: https://codereview.chromium.org/2570773002
Cr-Commit-Position: refs/heads/master@{#441457}

bluetooth: bluez: Implement BluetoothRemoteGattCharacteristicBluez::SubscribeToNotifications and UnsubscribeFromNotifications.

BUG=636275

Review-Url: https://codereview.chromium.org/2613473002
Cr-Commit-Position: refs/heads/master@{#441456}

Enforce that the Cronet API classes and methods are never modified or
removed, only added.  Modifying or removing an API class or method
breaks backwards compatibility.  This is enforced by:
1. Keep an updated dump of the Cronet API in components/cronet/android/api.txt
2. When building check that the Cronet API matches that in api.txt
3. Provide a script for updating api.txt; this script also enforces that
   only additions are made to the API.
This change also maintains a version number for the Cronet API.  Cronet
can use this to enforce, for example that the Cronet implementation is at
least as new as the Cronet API being used.

BUG=629299
R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2544043002
Cr-Commit-Position: refs/heads/master@{#441455}

available (e.g. empty), we should use main frame url to search for
previous navigation.

This will help us correctly identify referrer of downloads that
happen in sub-frame.
For example, page A has a link to page B, and page B has a
subframe C, and subframe C links to download D.

A --->  B
        \iframe C -----> D
If we only look at the frame D's in, we can only reach C in
attribution. But in fact it should be D-C-B-A.

BUG=639467

Review-Url: https://codereview.chromium.org/2612663002
Cr-Commit-Position: refs/heads/master@{#441454}

Though clusterfuzz uses ubsan now, which should catch bad casts, using
these macros is still the typical convention for Blink code that needs
to downcast.

BUG=none

Review-Url: https://codereview.chromium.org/2617433002
Cr-Commit-Position: refs/heads/master@{#441453}

This adds the flash plugin path to the chrome://version page, which
allows users to see which flash plugin is loaded. This also allows
chrome://plugins to be removed.

BUG=667826

Review-Url: https://codereview.chromium.org/2607953002
Cr-Commit-Position: refs/heads/master@{#441452}

TBR=mfomitchev@chromium.org
NOTRY=true
BUG=678346

Review-Url: https://codereview.chromium.org/2615713002
Cr-Commit-Position: refs/heads/master@{#441451}

Tweak CryptauthDeviceManager to store fetched BeaconSeed data in Base64URL encoding, and retrieve it as raw data. This is necessary because CryptauthDeviceManager assumed that BeacondSeed data from the server was Base64 encoded, when in reality it was raw.

BUG=678145

Review-Url: https://codereview.chromium.org/2611913002
Cr-Commit-Position: refs/heads/master@{#441450}

Zoom should be preserved on reload. However, this behavior is not currently
reliably covered by tests (there is a layout test that attempts to cover this
behavior, but it is broken and will shortly be removed, as per comment 28 on
crbug.com/673065). This CL adds a proper test of this behavior.

BUG=673065

Review-Url: https://codereview.chromium.org/2608213003
Cr-Commit-Position: refs/heads/master@{#441449}

Download the poster image when it is available and draw remoting
interstial on it. Changes in this CL:
1. Refactored ImageDownloaderImpl and abstracted the core parts that
does the image downloading to ImageDownloaderBase. There should be no
behaviour change for ImageDownloaderImpl.
2. Added SingleImageDownloader which is a one time image downloader
working in Renderer to return a single image, and can be
self-destructed when downloading finishes.
3. RemotingRendererController will initiate the downloading when the
interstitial needs to be shown if poster image URL changes.

BUG=643964

Review-Url: https://codereview.chromium.org/2538853002
Cr-Commit-Position: refs/heads/master@{#441448}

BUG=none

Review-Url: https://codereview.chromium.org/2609893003
Cr-Commit-Position: refs/heads/master@{#441447}

https://pdfium.googlesource.com/pdfium.git/+log/fff400a5df03..6745f96fab41

$ git log fff400a5d..6745f96fa --date=short --no-merges --format='%ad %ae %s'
2017-01-04 tsepez Remove CFX_ArrayTemplate, use unique_ptr in fpdfsdk/pdfwindow

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2612833002
Cr-Commit-Position: refs/heads/master@{#441446}

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2616673002
Cr-Commit-Position: refs/heads/master@{#441445}

BUG=579229

Review-Url: https://codereview.chromium.org/2602553003
Cr-Commit-Position: refs/heads/master@{#441444}

Adds a java Surface to render into for devices that don't support async reprojection.

BUG=674233

Review-Url: https://codereview.chromium.org/2616583002
Cr-Commit-Position: refs/heads/master@{#441443}

Test converted to use testharness and new Audit.

The expected result file is also removed.

BUG=675987
TEST=realtimeanalyser-fft-sizing.html

Review-Url: https://codereview.chromium.org/2603483002
Cr-Commit-Position: refs/heads/master@{#441442}

with elevation values instead.

This is necessary to allow different windows of the same UI or WM window
type to specify different shadow appearances. This also makes more
sense in that active windows aren't the only ones to get big shadows.

Concretely, this is a requirement for updating Toast shadows.

BUG=608852,676223
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2596743002
Cr-Commit-Position: refs/heads/master@{#441441}

1. Remove TimePeriod-related methods from BDR and its tests. Explanation:

TimePeriod represents the deletion options provided in the Chrome UI, and
is used in communication between Chrome UI and BDR, and thus there is no
reason for content/ to know about it. In fact, if BDR was moved to content/
while still containing TimePeriod-related methods, we would have to introduce
a new build target in components/ to make TimePeriod usable in all three of
chrome/, ios/, and content/.

2. Remove the TimeRange class from BDR entirely. Explanation:

TimeRange is a class inside BDR which would move to content/ together with it.
The UI needs a way to convert TimePeriod to TimeRange. Such a conversion cannot
live in content/ (which doesn't know about TimePeriod) nor components/ (which
wouldn't know about TimeRange). It could be detached from BDR to a separate
file in chrome/.

However, the update cost of detaching it to a separate file is the same as
breaking it into a pair of base::Time arguments. Here are reasons why the latter
is better:
-> It reduces the complexity of keeping two confusingly similar TimePeriod and
TimeRange classes
-> Consistency - basically all data storage backends, and also the BDRDelegate,
have an interface with two base::Time arguments rather than base::TimeRange
-> It can be argued that this definition does not logically belong to BDR;
if anyone, it should be base/time/ who defines a class representing
a base::Time interval class

3. Replace Profile with BrowserContext inside BDR (as that's the content/
equivalent).

4. Split the REMOVE_DOWNLOADS section to two parts. The first part (download
history deletion) stays in content/, the second part (download path reset) moves
to the embedder.

5. Add a comment explaining that the |may_delete_history| variable must be honored
in content/ (while deleting download history), but must be provided by the embedder
(from policy or supervised users) through ContentBrowserClient. This is not possible
to fix while BDR is still in chrome/, as chrome/ cannot depend on
ChromeContentBrowserClient.

TBR=jochen@chromium.org
BUG=668114

Review-Url: https://codereview.chromium.org/2578723002
Cr-Commit-Position: refs/heads/master@{#441440}

The positioning of the menu promo in MD History was accidentally broken
in crrev.com/439710 when the layout of the left section of the toolbar
was changed.

BUG=677902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2609933003
Cr-Commit-Position: refs/heads/master@{#441439}

Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2609733002/ )

Reason for revert:
Causes the UI to crash on peach_pit and multiple HWTest failures on the PFQ and the informational builder. See BUG=678296.

Original issue's description:
> Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc.
>
> The following traits are used:
>
> Priority: Inherited (default)
>   The priority is inherited from the calling context (i.e. TaskTraits
>   are initialized with the priority of the current task).
>
> Shutdown behavior: CONTINUE_ON_SHUTDOWN
>   Tasks posted with this mode which have not started executing before
>   shutdown is initiated will never run. Tasks with this mode running at
>   shutdown will be ignored (the worker will not be joined).
>
>   Note: Tasks that were previously posted to base::WorkerPool should
>   use this shutdown behavior because this is how base::WorkerPool
>   handles all its tasks.
>
> May Block:
>   Tasks posted with MayBlock() may block. This includes but is not
>   limited to tasks that wait on synchronous file I/O operations:
>   read or write a file from disk, interact with a pipe or a socket,
>   rename or delete a file, enumerate files in a directory, etc. This
>   trait isn't required for the mere use of locks.
>
> BUG=659191
>
> Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a
> Cr-Commit-Position: refs/heads/master@{#441139}

TBR=dnicoara@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659191

Review-Url: https://codereview.chromium.org/2612853002
Cr-Commit-Position: refs/heads/master@{#441438}

Also, run clang-format to fix up styling.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592143002
Cr-Commit-Position: refs/heads/master@{#441437}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2603163002
Cr-Commit-Position: refs/heads/master@{#441436}

BUG=554289

Review-Url: https://codereview.chromium.org/2606293002
Cr-Commit-Position: refs/heads/master@{#441435}

BUG= internal b/32244773

Review-Url: https://codereview.chromium.org/2429963002
Cr-Commit-Position: refs/heads/master@{#441434}

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2615573002
Cr-Commit-Position: refs/heads/master@{#441433}