- 10 Feb, 2018 40 commits
-
-
Chris Harrelson authored
When ancestors change their paint properties, the LocalBorderBoxProperties of a descendant can update. In SPv175 we need this to cause a repaint, because the descendant's paint chunks depend on the LocalBorderBoxProperties. This is only reproducible in SPv175 with a composited child layer, because otherwise a recursive setNeedsRepaint would apply during style update; that recursive update does not recurse into composited children. In SPv2 mode it should reproduce regardless. Bug: 810684 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic2f7303cde077ff7ae3fdf078d7aac1901a1b25f Reviewed-on: https://chromium-review.googlesource.com/912458Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#535931}
-
Devlin Cronin authored
The externally_connectable entry in the manifest specifies which sites can message a given extension. By default, we require that these sites be listed at a somewhat specific level (we allow subdomains, but not (e)TLD wildcards). Extensions whitelisted for the externally_connectable.all_urls permission (and with that permission present) can use externally_connectable to list all_urls. This is used by the cryptotoken extension in order to allow any arbitrary site to initiate the u2f checks. However, there's no point in allowing an http site to connect to the extension, because https is a requirement for using u2f. As a first step to reducing the u2f extension to only whitelisting https sites, allow extensions whitelisted to specify all_urls in the externally_connectable entry to also be able to specify patterns with empty hosts like https://*/*. Bug: 810553 Change-Id: I3ff34ba8ce0126a777f52648245b0a85052511b1 Reviewed-on: https://chromium-review.googlesource.com/910037Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#535930}
-
Andrey Kosyakov authored
Change-Id: Ib656c9f22d696f516eba9a2ac5b6ea0d98c45e1a Reviewed-on: https://chromium-review.googlesource.com/912670Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#535929}
-
Joshua Bell authored
Bug: 729800 Change-Id: If6cfed3427f778cf990721214240757cb06f320a Reviewed-on: https://chromium-review.googlesource.com/912242 Commit-Queue: Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#535928}
-
Sylvain Defresne authored
The EnableNewClearBrowsingDataUI flag has been disabled for one year, remove the code that can now be considered dead. Bug: 760084 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I22502beef12c2ce121cfcd896f1593829ecc140b Reviewed-on: https://chromium-review.googlesource.com/903245 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#535927}
-
Abhishek Arya authored
This reverts commit 6ed531bd. Reason for revert: Caused multiple security regressions, see bug 810368. Original change's description: > dom: Remove PresentationAttributeCacheCleaner > > PresentationAttributeCacheCleaner was introduced before purging memory > was introduced. > > This CL removes PresentationAttributeCacheCleaner to clear cache soon > instead of delyaing with timers. > > This is part of efforts to replace default timer task runners with > other appropriate task runners in the renderer. > > Bug: 624694, 804694 > Change-Id: I7ed775d4b998be82e35d8eefe1f7bd4e0d0145a2 > Reviewed-on: https://chromium-review.googlesource.com/903942 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535306} TBR=jbroman@chromium.org,hayato@chromium.org,hajimehoshi@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 624694, 804694 Change-Id: I921fea361197deefd45968c07917cb5bc6fae0a4 Reviewed-on: https://chromium-review.googlesource.com/912091Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#535926}
-
Dave Tapuska authored
- Add runtime setting to disable/enable WM_POINTER for touch. Defaults to disabled in this patch. Will be enabled as a followup change. - Fix min/max/exit buttons for touch. For unhandled events do a hit test and check if they are in the client area. If they are mark them as handled as we don't want windows to send us compatibility events if we've already dispatched them from the pointer events. - Set the last_touch_or_pen_message_time for touch events via WM_POINTER. BUG=792892,763223 Change-Id: I4350c7e84f96271b9ec27119815bf37a9461d489 Reviewed-on: https://chromium-review.googlesource.com/911752 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#535925}
-
Simeon Anfinrud authored
This is needed to for the Android implementation of AvSettings. Bug: Internal b/68777468 Test: internal patch that uses this Change-Id: Ia99222e9cfe1deb92639e15ec331e9e5b9fbd568 Reviewed-on: https://chromium-review.googlesource.com/911932Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#535924}
-
https://chromium.googlesource.com/catapult.git/+log/2b59889bc5fe..c60b98d9fa86 $ git log 2b59889bc..c60b98d9f --date=short --no-merges --format='%ad %ae %s' 2018-02-09 dtu [pinpoint] Fixes for results2 handler. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4961a8270d19ded82d2b1fa6d3ef3fc735449c51 Reviewed-on: https://chromium-review.googlesource.com/911877Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#535923}
-
Noel Gordon authored
Patches are no longer a thing. Remove the patch file for alder32 SIMD change since it mostly touched files that are not part of upstream. One upstream file adler32.c was touched but it has feature guards, so we should be good when merging in any upstream changes. Bug: 762564 Change-Id: Iad8e389667189300fa180755bc2ddc0187138bc0 Reviewed-on: https://chromium-review.googlesource.com/910539Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#535922}
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Change-Id: Ic5256c9e50d4f483a140a207ec08b10c9cb29dd2 Reviewed-on: https://chromium-review.googlesource.com/912314Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#535921}
-
bsheedy authored
Fixes VrShellTransitionTest#testEnterVrInOverviewMode being flaky due to trying to call launchInVr with a null pointer for the launch intent. Change-Id: Ic4b661fbf430e65a2a51923c2652a18acf11ac86 Reviewed-on: https://chromium-review.googlesource.com/912610Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#535920}
-
Noel Gordon authored
Patch files are no longer needed per the README.chromium guidelines. Bug: 764431 Change-Id: I7cbfb9e51f74a7499697e6ff541bb02e30572c5b Reviewed-on: https://chromium-review.googlesource.com/910870Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Change-Id: I7b4053e39cc589c96e9b64c991c0226fb1550563 Reviewed-on: https://chromium-review.googlesource.com/911945Reviewed-by:
-
Vladimir Levin authored
This patch makes PaintChunkProperties ctor explicit so that PropertyTreeState cannot be accidentally converted to it, instead requiring explicit construction. R=chrishtr@chromium.org Bug: 810958 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id3637eb7aea213af42f1802fcba907e1806bc3c1 Reviewed-on: https://chromium-review.googlesource.com/912463Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#535917}
-
Jiaquan He authored
This regression was introduced since ec4e7f70. While migration the app list ui to ash, we're showing dialogs in chrome without setting their parent. A nullptr parent will cause a breakage in |GetExtensionAnchorView|. Bug: 810665 Bug: 733662 Change-Id: Ifc8a38ec50a62a12c54e6d4503c3a2561f7ebd67 Reviewed-on: https://chromium-review.googlesource.com/911619Reviewed-by:
-
Avi Drissman authored
While the "hung page" dialog is up, the [X] button has the same effect as the "Wait" button. However, when the hung process goes away, the "hung page" dialog tries to silently close itself with no effect, but calling Close() on itself ends up calling through to the function handling the [X] button, which tries to take an action on a dead process. The "hung page" dialog closes itself, without taking any action, in two cases. The first case was when the render process became responsive again. In that case, internal pointers were nulled out so that no action would be taken when the dialog closed. This is the second case, where the process died for other reasons. In this case too, now, the internal pointers are nulled out to ensure no action (and no crash). BUG=810750 Change-Id: Ifc65c44003457fba87abf1e9977cdfe4218af168 Reviewed-on: https://chromium-review.googlesource.com/911729 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#535915}
-
Klaus Weidner authored
The render time estimate was dropping too low if the completion fence was consistently already signaled at the time we checked. Use the midpoint between the earliest possible completion time and now instead. Change-Id: I843ca21f3b4fe2a9f6b34d90b91bf6212cb05fc1 Reviewed-on: https://chromium-review.googlesource.com/912568Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#535914}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08ca04b2b2bc..13101a6e42d1 $ git log 08ca04b2b..13101a6e4 --date=short --no-merges --format='%ad %ae %s' 2018-02-09 agable Remove similarity support from git-cl 2018-02-07 brucedawson Script to summarize performance of ninja builds Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0bebb1cfd04b65c088fc7eec1e9d94f0f55b2d2b Reviewed-on: https://chromium-review.googlesource.com/912176Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#535913}
-
Steven Bennetts authored
Bug: 809776 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1579b28c0d18c2e462d8aaa9d4c8221cd8bd648e Reviewed-on: https://chromium-review.googlesource.com/910071 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#535912}
-
Kevin Marshall authored
This CL uses SSH reverse port forwarding to dynamically connect the test suites running on Fuchsia to the Python-based test servers running on the controlling machine. Also adds a logging context to the spawning server library, so that the verbosity of its logging output can be independently adjusted. Change-Id: I6099ccc21efdd5e2e6b994e863f8d4b3dadaaae1 Reviewed-on: https://chromium-review.googlesource.com/907633 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#535911}
-
Joel Einbinder authored
Panel.registerShortcuts was mainly used by the sources panel as an alternative to UI.ActionDelegate. It prevents actions from easily being used elsewhere in DevTools, like the command menu or settings screen. Bug: none Change-Id: I2e8810de25b146c0566ea5bf813117d0b2220c54 Reviewed-on: https://chromium-review.googlesource.com/676091 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#535910}
-
Jun Choi authored
Initialize ICU to ICU data file during fuzzing. This is a fix for CHECK failure caused during clusterfuzz testing. Bug: 808412 Change-Id: Ied129095f1650a97a7767b7dde8ea2084b9ceb2f Reviewed-on: https://chromium-review.googlesource.com/902583Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#535909}
-
Sarah Hu authored
1. Create mojo struct for the public session info. 2. Connect LoginDisplayViews with UserSelectionScreen and populate the information in UserSelectionScreen then send it via LoadUsers mojo call. 3. Remove unused user data: initialKeyboardLayout and gaiaId Bug: 732452 Change-Id: Id67b1b29f0f7fad853ad475557099af38a239fce Reviewed-on: https://chromium-review.googlesource.com/907973Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#535908}
-
Kurt Horimoto authored
This is no longer necessary, as the new fullscreen implementation already ignored scrolls originating from fullscreen. Bug: 810896 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6da22780ef46f5866e698e967e6b3c62e4b2148c Reviewed-on: https://chromium-review.googlesource.com/912428 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#535907}
-
Megan Jablonski authored
TBR=pwnall@chromium.org, ricea@chromium.org Bug: 810960, 810963 Change-Id: Ie43af75b96f87bf03af85e368218820e2b5d94ea Reviewed-on: https://chromium-review.googlesource.com/912069Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#535906}
-
John Budorick authored
Bug: 800662 Change-Id: I3907c09c3b8898c0e487348735a8bb582ff9e468 Reviewed-on: https://chromium-review.googlesource.com/881466Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#535905}
-
Megan Jablonski authored
This reverts commit 8965b37f. Reason for revert: TrayAccessibilityTestInstance tests failing on bots https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-dbg https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-dbg/builds/4171 Original change's description: > Add Select-to-Speak to accessibility menu in status tray. > > Includes new icon for Select-to-Speak. > Having STS in the status tray was approved by UX over email, so this is > not behind any flags. > > Bug: 804506 > Change-Id: Icdeda04e2c10db7ba891cfed585db0027dcb97b5 > Reviewed-on: https://chromium-review.googlesource.com/904968 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535813} TBR=jamescook@chromium.org,tbarzic@chromium.org,dmazzoni@chromium.org,isherman@chromium.org,katie@chromium.org Change-Id: Iba6c1fb5b36483bfd75adcde1e67e8036ad0d5a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 804506 Reviewed-on: https://chromium-review.googlesource.com/911884Reviewed-by:
-
Eric Lawrence authored
Update the entries in the HSTS preload list. TBR=palmer@chromium.org Change-Id: Ia74b66f17ee7ff1011ef4c8bf646c34b73770789 Reviewed-on: https://chromium-review.googlesource.com/912107Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#535903}
-
Becky Zhou authored
Adding expandable header to article suggestions section. The header is currently not controlled by a preference and is hard-coded to be always expanded initially. Bug: 803523 Change-Id: I298ce951045fc2f223eaf4c226b570d1d8362e3f Reviewed-on: https://chromium-review.googlesource.com/905789 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#535902}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3a62ddf..68fdc80c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I03b5d843d50d6b10e2a497812e8d77bdd59039a0 Reviewed-on: https://chromium-review.googlesource.com/912330Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#535901}
-
Victor Costan authored
Additionally minor cleanup of upgrade steps in README.chromium. This is a follow-up addressing some feedback received in the reviews for the attached bug. Bug: 807093 Change-Id: Idd5e4fb196aeac6c101c1773ac6a0c364bb73ec3 Reviewed-on: https://chromium-review.googlesource.com/907868Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#535900}
-
Megan Jablonski authored
This reverts commit acbcd628. Reason for revert: Tests failing on Builder: Win10 Debug (NVIDIA) https://uberchromegw.corp.google.com/i/chromium.gpu/builders/Win10%20Debug%20%28NVIDIA%29 Original change's description: > Add VR browser tests to win7_chromium_rel_ng > > Adds the VR browser tests to win7_chromium_rel_ng now that there > is enough capacity to run them on changes that affect VR. > > Bug: 780668 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I3646b04c47b5f6c683ebf59ce2046c881127bd97 > Reviewed-on: https://chromium-review.googlesource.com/907532 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535826} TBR=kbr@chromium.org,bsheedy@chromium.org Change-Id: I55aff7e3b99d1bebe57c9d462bb30ff2fa1d0a1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780668 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/911947Reviewed-by:
-
Pete Williamson authored
Adding a utility method for generating unique filenames for offline page based on title and url of the page. (Re-uploading a change by Romax with fixed merge conflicts) Bug: 757073 Change-Id: I03e8e5cc03a640de2abee8e6e903b6bdce53af24 TBR: dimich@chromium.org, dtrainor@chromium.org Change-Id: I03e8e5cc03a640de2abee8e6e903b6bdce53af24 Reviewed-on: https://chromium-review.googlesource.com/911837Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#535898}
-
Xunran Ding authored
This just updates the internals of CacheStorage. GURL is still used in content/public/browser and storage/browser/quota. so there are still conversions Origin<->GURL conversions on those API boundaries. Bug: 598424 Change-Id: Ib2ada9245c3d77f9be33217380742e4c00a732af Reviewed-on: https://chromium-review.googlesource.com/897231Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#535897}
-
Sylvain Defresne authored
The BVC may have a nil TabModel. Before https://crrev.com/c/867054 the iteration over the TabModel worked (as sending a message to nil is well defined in Objective-C) but after the refactor, this lead to Undefined Behaviour when dereferencing a null pointer. Add an explicit check that TabModel is non-nil, and early return if this is not the case to prevent the crash (the infobar will be presented later to the user in that case). Bug: 808319 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc6e603957da108554525ac218c9afaaabb6a62b Reviewed-on: https://chromium-review.googlesource.com/912508Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#535896}
-
W. James MacLean authored
The code removed in this CL is believed to be the root cause of the crash in the associated bug. The mechanism is this: when events are coalesced, some event types still expect all of the original events to be properly acked, and at present RenderWidgetTargeter doesn't implement this. The crash, in particular, is the result of touch events being acked in a way that the unique ids don't line up with the queue in TouchDispositionGestureFilter::OnTouchEventAck() because some of the ids are missing after being coalesced. At present we will only disable coalescing for touch and gesture events,but that's reasonable since in most cases we only everhit-test the initial TouchStart and everything else in the sequence latches to its target. Further, it's not obvious if there's a significant performance benefit to the coalescing these events, so for now we remove it. In any case, implementing proper acking of these events would result in a patch too big to merge back to M65. Bug: 807507 Change-Id: I50dbef4f16f4b451321564e1e0c9cfb352aafabd Reviewed-on: https://chromium-review.googlesource.com/905459 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#535895}
-
Vasilii Sukhanov authored
When a tab is closed from the renderer via window.close(), the password bubble may still be show. When it closes PasswordFormManager may decided to upload some votes. ChromePasswordManagerClient still exists at this point but ContentAutofillDriverFactory can already be deleted. The code should check this condition. Bug: 807601 Change-Id: If75c1aa5759e07568340d2233b22cc159e8c687e Reviewed-on: https://chromium-review.googlesource.com/911770Reviewed-by:
-
Pete Williamson authored
This change will move the offline page to a public directory and inform the system download manager if any (for instance, on Android) of the location and type of the file. If both steps succeed, the offline page item will be written to the offline page model database. Bug: 758690 Change-Id: Iabba419903849892a947d80bd82c39123e1bc962 Reviewed-on: https://chromium-review.googlesource.com/896555 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#535893}
-
Tom Anderson authored
After bootstrapping gn, build.ninja has a reference that looks something like: command = ../../../../../../../../../../tmp/tmp9Pn0sv/gn --root=../.. -q gen . This reference will be broken when the OS removes the temporary directory. This CL regenerates the build files using the gn executable from the build directory. This on its own will update the reference to plain "gn", however we need the reference to be "./gn", because "gn" might not exist in the PATH, or would point to an old one from depot_tools. BUG=808829 R=dpranke Change-Id: I1b156a6af081a35ded152946af13a117563b8c1a Reviewed-on: https://chromium-review.googlesource.com/905793 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#535892}
-
