- 05 Aug, 2019 40 commits
-
-
James Cook authored
This cuts the cost of an include of login_type.h from 100,000 lines of mojom generated code to < 1000 lines. Bug: none Change-Id: I8897016fb1dade7bdd5fe5e2f60cbbe7880d3ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735950 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#684050}
-
Ben Kelly authored
This is a reland of cca6943d Original change's description: > CacheStorage: Allow reads to be executed in parallel. > > This CL adds the CacheStorageParallelOps feature with the associated > "max_shared_ops" parameter. Enabling the feature and setting the > parameter to greater than one will allow read-only cache_storage > operations to run in parallel. By default parallel operation is > disabled. > > The overall design is to treat each CacheStorageScheduler as if it > has its own read-write-lock. When an operation is scheduled it must > be flagged as either "shared" or "exclusive". Some number of shared > operations (determined by the feature param) may run in parallel. > Exclusive operations always run by themselves without parallelism. > > This CL also includes the ServiceWorkerCache.PeakParallelSharedOps > histogram which will measure how much parallelism we actually see in > practice. The peak is measured across a small time period defined by > when an idle scheduler begins running its first shared op to until it > stops running all shared ops. > > Bug: 985379 > Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680986} TBR=jwd@chromium.org,dmurph@chromium.org,jam@chromium.org,rayankans@chromium.org Bug: 985379 Change-Id: I83d8ce38a647b00e658dc1e2e17828468475cc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737031Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#684049}
-
James Cook authored
Some of them were left in //chromeos/constants/chromeos_switches.h for historical reasons. Fix a few IMYU issues. Bug: none Test: bots Change-Id: I1480c141a76a69c4153d6d1019530e9efcaa80e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731957Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#684048}
-
Gang Wu authored
This reverts commit 7188deb6. Reason for revert: <INSERT REASONING HERE> Original change's description: > Enable interactive uitests on Mac > > Re-enable interactive uitests that were disabled for crbug/823543 > and crbug/824418. These issues are because of crbug/641969 which is > no longer reproduced on MacViews browser. > > BUG=823543, 824418, 641969 > > Change-Id: Id5de29e9d95962f98748d140469f4709fcbd4fb9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699665 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683998} TBR=ellyjones@chromium.org,sky@chromium.org,robliao@chromium.org,jongkwon.lee@navercorp.com Change-Id: I5fa5df976a6ad68618dd43951637e6b15d276eb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823543, 824418, 641969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737095Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#684047}
-
Caitlin Fischer authored
The norm is to have a space between # and COMPONENT. Change-Id: I89ccd42c92f65ee84abcbb8a17074f25d6112961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736699 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#684046}
-
Tommy Li authored
We aren't experimenting with this anymore. Bug: 956102 Change-Id: I93b9d512453ddc156717735b6f2d8d345175b45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733012Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#684045}
-
chrome://settingsAnastasia Helfinstein authored
This is to support the split of OS settings from browser settings. Bug: None Change-Id: I994a8e4c4cb27801fdf979025c291211324bcecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732806 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#684044}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96555343063b..4df3d5340ef3 git log 96555343063b..4df3d5340ef3 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 halcanary@google.com rewrite_includes.py: make it work on windows 2019-08-05 halcanary@google.com experimental/tools/gerrit_percent_encode 2019-08-05 fmalita@chromium.org Add missing GrLumaColorFilterEffect opt flag 2019-08-05 michaelludwig@google.com Update tests to use new image filter factories 2019-08-05 michaelludwig@google.com Fix GMs broken during API porting Created with: gclient setdep -r src/third_party/skia@4df3d5340ef3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: Iac6be37572f7ae820ae6c35e1c37325cc9d05167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684043}
-
Geoff Lang authored
Specifically run it on the FYI waterfall release bots. BUG=982294 BUG=989194 BUG=990368 BUG=angleproject:3766 BUG=angleproject:3768 BUG=angleproject:3769 BUG=angleproject:3770 BUG=angleproject:3771 BUG=angleproject:3772 BUG=angleproject:3774 Change-Id: Ibbc52471256cd8c7af8d0c95d4ebba8f1afb653d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709934 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684042}
-
Nate Fischer authored
No change to NS path, this only removes the legacy path. This removes some cookie code used in the legacy code path. This is mostly deleting files, but also modifies a couple classes to remove legacy-path-only code and reduce some complexity. Bug: 990437 Test: run_webview_instrumentation_test_apk -f CookieManagerTest.* Change-Id: I0418c6f76af19052d5ff597ba54f8ec773ea914d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733847Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684041}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d4105850c66..cdbaeeb73767 git log 8d4105850c66..cdbaeeb73767 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 peah@webrtc.org Aec3:Remove unused legacy code 2019-08-05 sprang@webrtc.org Wire up field trials for some experimental screenshare settings Created with: gclient setdep -r src/third_party/webrtc@cdbaeeb73767 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/132074409 Change-Id: I3b213730cdc3de518304b3fd3284f283219a1f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736170Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: Ice995f86c4e2a7c9389ea118333236ddc794d81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733804Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#684039}
-
Gang Wu authored
TBR=boliu@chromium.org Bug: 990717 Change-Id: I36ae63ecdf38467a48161bbf557f8ad84a5b4901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737088Reviewed-by:
-
Matthew Jones authored
Change-Id: Ie99af92326425521853af82c7bb496098a5590a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736169 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#684037}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=jamesr@chromium.org Change-Id: I4ab402a4a2d79a4e65461ad7ebb00d67a4011899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733492 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#684036}
-
Danton Vu authored
In the new overview layout, scrolling is needed to be able to see each available window past the sixth window. R=sammiequon@chromium.org, xdai@chromium.org Bug: 981174 Change-Id: Idc207bf155e8458231114344650837a5783c8854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709876Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Danton Vu <dantonvu@google.com> Cr-Commit-Position: refs/heads/master@{#684035}
-
Robbie Gibson authored
This CL adds dark mode coloring to the omnibox popup, both pre- and post- House Lannister. One thing it does not do is make changes in autocomplete_match_formatter.mm in incognito. This will come in a later CL Bug: 976662 Change-Id: I497a0a1c9f3ebba7b294b0633e09bdbba6b2eff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719124 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684034}
-
Sanket Joshi authored
Prior to this CL, the new color picker supported the HEX and RGB color formats. Now, users can also view and/or manually change the selected color in the HSL color format. Users can switch between the HEX, RGB and HSL by clicking on the format toggler. To make it easier to translate values from one format to another, additional helper functions like rgbToHSL and hslToHex are being added to the Color class. Update hex format toggle test and add hsl format toggle test. Change-Id: I7a215af1788018c5a895b76c71a02c9aeeb987bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731777Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#684033}
-
Caitlin Fischer authored
The norm is to have a space between # and COMPONENT. Change-Id: I6cf5b9dc74090d6438e9860282bdb29693b86413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736697 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684032}
-
Yuri Wiitala authored
This change ensures a more-complete nil-ing out of the the external references to ServiceWatcher's internally-owned NetServiceBrowserDelegate instance before destroying it. Root cause analysis: ServiceDiscoveryClientMac was destroying an existing ServiceWatcher instance before re-creating a new one (to redo the discovery). When it destroyed the prior one, Mac-specific implementation of the ServiceWatcher was freeing memory without nil'ing out all external references to its owned NetServiceBrowserDelegate. This was causing the Objective-C runtime (objc_storeWeak()) to intermittently crash the whole browser, whenever the routine detected memory corruption: The freed memory was already re-used/changed by the time the runtime looked at it, and so a consistency check failed. Bug: 932337,657495 Change-Id: I109df345c502044ea93fd05ad53a63441473fc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733104 Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Chris Sharp authored
TBR=aboxhall@chromium.org BUG: 990847 Change-Id: I9ac7c2470f77a5b94f4298a0fa5f06e567ea858d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737089Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#684030}
-
Charlene Yan authored
Change-Id: I076b81fe5884590a1dbcb598f89c60276b30fa19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733013Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684029}
-
Greg Thompson authored
The policy settings corresponding to these prefs indicate that they are not per-profile settings. This change moves the pref to which the policies are mapped from Profile into Local State. BUG=958893 Change-Id: Ied34063f83629a896d9a08bfa34af09e834d3577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730156Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#684028}
-
Eugene But authored
Additionally, change appLaunchManagerDidRelaunchApp: API contract to call only when app got relaunched and not call when app got launched for the firts time. This is because +setUpHelper and -resetAppState should not be called unless the app was shut down. Bug: 989743 Change-Id: Id33e5e60a693580269a0f6d5504bfc0427b34c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730954 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#684027}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b8a27c5e6bb1..9031bdd9ba3b git log b8a27c5e6bb1..9031bdd9ba3b --date=short --no-merges --format='%ad %ae %s' 2019-08-05 clemendeng@google.com Use perfect-hash module in gen_builtin_symbols.py Created with: gclient setdep -r src/third_party/angle@9031bdd9ba3b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: None Change-Id: Ic694e3834eef488916f3f1e5dbbfcca9350d9890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736986Reviewed-by:
-
Clark DuVall authored
This is a reland of f37f7fde crrev.com/c/1728889 no longer uses CreateURLLoaderThrottlesOnIO. Original change's description: > Remove unused members of ProfileIOData > > These are no longer used after http://crrev.com/c/1731919 > > Bug: 824840 > Change-Id: I7163336861c227fb7fa7aab9fe297898d92067c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731180 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683474} TBR=jam@chromium.org Bug: 824840 Change-Id: I4d68b7d10ea49bfa220bfd16400f891a06c1fabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735058Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#684025}
-
Maksim Sisov authored
There was a wrong gn arg in the ozone/linux config, which had been removed (ozone_platform = "X11"). Also, ozone_platform_headless has been added to be able to run tests with headless backend. Bug: 700309 Change-Id: I66ba98ab7cc55631a0af1ddfb8a06e38e4b7eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735463Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#684024}
-
James Cook authored
The go/splitsettings project is moving Chrome OS settings to a new WebUI settings surface. Migrate the OS icons into their own file. This reduces the number of <if> conditions in settings/icons.html and makes it clearer these are Chrome OS-only. Use viewBox to avoid having separate os-settings20 and os-settings24 iconsets. I have a request out to UX to re-export the SVGs at 20 pixels so we don't need to use viewBox anymore. Screenshots, just to illustrate that nothing changed: Chrome OS combined: http://screen/ipZ38gvF1S1 SplitSettings OS: http://screen/VXoRW8y16eR SplitSettings browser: http://screen/0nqDyMMt2qg Linux: http://screen/j91ivK0YigV Bug: 990394 Change-Id: Ica5976d5b4650b191ea1746e3f7b41983a2ca45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733465 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#684023}
-
Allen Bauer authored
Change-Id: Ibf08fc766626d6c80ca6dc24d8a56dc1555a5f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737009Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#684022}
-
Chris Sharp authored
TBR=blundell@chromium.org Bug: 990844 Change-Id: Ic5a6ecce26e1ee48e4501a2f89c99ed6d00362bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737010Reviewed-by:
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=jamesr@chromium.org Change-Id: I42fce9f4258109d5d381858f28b8ef60961bc4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733497Reviewed-by:
-
Marc Treib authored
This was only ever enabled in some experiments, and is not intended for launch. Time to clean it up. Bug: 983940 Change-Id: I20e037c2617468793a27f2bb00672156912c5042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722942Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#684019}
-
Mia Glaese authored
Bug: 895542 Change-Id: I892dc63f438e77d865813758303d7f249600f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695968Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#684018}
-
Jesse Schettler authored
See https://crrev.com/c/1704282 for context. Change-Id: I54fd3eae5e96cc6018f6378c9db40025c33000d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735979Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#684017}
-
Rune Lillesveen authored
The placeholder style was removed in [1]. Remove unnecessary SetNeedsStyleRecalc to handle it. [1] https://crrev.com/4f35b999c1e4159ded31f7c16b71ca3e0e7ddfee Change-Id: I04f401e8b080d715b1a2adbcb8751a36bdb86d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735573Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#684016}
-
Chris Sharp authored
TBR=jityao@google.com Bug: 990819 Change-Id: I59a6f048da73dcab633739d77a9770935047c2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735973Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f69a6724..dd07fe70 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22457a126000af20118e304afe9264c0b2368b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736926Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684014}
-
Robbie Gibson authored
These colors are all used in the omnibox popup Bug: 976662 Change-Id: I7b4ed329d069ae341c49a2715f5974cc9f67856b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735370 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d351c688586..8d4105850c66 git log 3d351c688586..8d4105850c66 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 mbonadei@webrtc.org Remove unused rtc_tools/video_analysis.py. 2019-08-05 chxg@google.com Remove the old `ContributingSources` class. Created with: gclient setdep -r src/third_party/webrtc@8d4105850c66 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ibff74229a41e0eb63e42387ca5377f36270831c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736799Reviewed-by:
-
Matt Jones authored
Change-Id: I96d4b52033828c8e9bb62fc184827da20bbe7b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732795Reviewed-by:
-
