- 07 Sep, 2018 40 commits
-
-
Eric Seckler authored
Updates prerender and safe browsing browser tests to initialize the SafeBrowsingDatabaseManager after BrowserThreads were created (but before they are started). This is required for the upcoming move of BrowserThread::PostTask to base/task/post_task.h, as construction of SafeBrowsingDatabaseManager obtains a TaskRunner for the IO thread. In the future, this has to happen after thread initialization. Bug: 878356 Change-Id: I1d4c614690ba3aacf4887fefe57d378c23668706 Reviewed-on: https://chromium-review.googlesource.com/1211735Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#589488}
-
Friedrich Horschig authored
Currently, the DeferredViewStubInflationProvider will accept null as view stub and try to inflate the non-existent stub much later. To prevent this deferred NullPointerException, assert that used stubs are never null. Fix the usage that uncovered that issue. Bug: 876215 Change-Id: I51deb6aaa1ac3d3283e6794c0cae37c536b43aa5 Reviewed-on: https://chromium-review.googlesource.com/1210783Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589487}
-
Elad Alon authored
Add a comment warning against changing WebRtcEventLogManager- related strings which may be relied upon by web-apps. Bug: 775415 Change-Id: I7717d87437c72756ed2a2ecda61d9abb30a6a778 Reviewed-on: https://chromium-review.googlesource.com/1212943Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#589486}
-
yoshiki iguchi authored
This is reland of crrev.com/c/1206551 after fixing the memory leak (crrev.com/c/1208694). The diff is completely same as the previous CL. The previous CL had been reverted due to the ASAN failure (see. crbug.com/880227). [Original description] The feature is not launched on M70. This CL should be merged to M70 branch as well. TBR: yamaguchi@chromium.org TBR: oshima@chromium.org Bug: 880227 Change-Id: Id0ca9b5ee488130d7fb0c414b4a9522117d462dd Reviewed-on: https://chromium-review.googlesource.com/1212902Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589485}
-
Hayato Ito authored
This is in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1205924, so we don't need to do forward declarataion for template definitions in NodeTraversal and any other traversals. Bug: 880052 Change-Id: Ie2decfb0763f4dfe3f85cace21601c893f263563 Reviewed-on: https://chromium-review.googlesource.com/1212374Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589484}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I59392880379432fb8252db79cd8c45e9378c9922 Reviewed-on: https://chromium-review.googlesource.com/1209747Reviewed-by:
-
Dominik Röttsches authored
Provide a new subclass for font unique name lookup for Linux. Connect via WebSandboxSupport to FontLoader which provides the out of process fontconfig calls for us. Tested by content_browsertests with a DevTools based test checking used fonts. This test was previously active on Android and is enabled for Linux in this CL. Bug: 880832 Change-Id: I04d72fc1cfcfa55a01a9877ac8a3a45dbff38771 Reviewed-on: https://chromium-review.googlesource.com/1206337 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589482}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c39dc317. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24207 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I25d5646ff737a843bbbab5f90df76ddaac57cbae Reviewed-on: https://chromium-review.googlesource.com/1212487 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589481}
-
Olli Etuaho authored
The flag is only available on Windows and offers choices to use the OpenGL, D3D9 or D3D11 backend. TEST=manual test on Windows BUG=chromium:693090 Change-Id: Ia9ce5d58a0658af513b070e564014398f35a243e Reviewed-on: https://chromium-review.googlesource.com/1202203 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589480}
-
Alexandre Courbot authored
The codec API specifies that when starting streaming, the OUTPUT queue should start first, followed by the CAPTURE queue. However it can happen in some reset scenarios that CAPTURE buffers are queued ahead of OUTPUT buffers, which results in the CAPTURE queue starting first. Fix this by only allowing the CAPTURE queue to start if the OUTPUT queue is already streaming. BUG=b:111670886 TEST=Checked that VDA unittest was passing on Hana and Cheza. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id27b5202dc6f910880e52099773df26e73a50304 Reviewed-on: https://chromium-review.googlesource.com/1212211 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589479}
-
Hiroshige Hayashizaki authored
Currently, UpgradeInsecureRequest() is called in WorkerFetchContext::PrepareRequest(), which is called after mixed content check. Therefore, insecure requests are blocked as mixed content before upgraded. This CL moves the UpgradeInsecureRequest() call to WorkerFetchContext::PopulateResourceRequest(), which is called before mixed content check. This is also consistent with FrameFetchContext, where insecure request is upgraded in FrameFetchContext::PopulateResourceRequest(). Bug: 880986, 880023, 880015, 880027 Change-Id: I983a40eebda8d04698b70d8c29e3707d4dcdf838 Reviewed-on: https://chromium-review.googlesource.com/1205750Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#589478}
-
Maksim Sisov authored
This CL enables partial swap support in Wayland by enabling SupportsPostSubBuffer. A damage region describes the regions where the pending buffer is different from the current surface contents, and where the surface therefore needs to be repainted. Enabling this needs requires fixing http://crbug.com/339493 as well for Intel drivers. Bug: 880726 Change-Id: I3bb2c7f876e3b5297c0d5595e309e3853772430f Reviewed-on: https://chromium-review.googlesource.com/1206370 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#589477}
-
Rune Lillesveen authored
In preparation for starting those operations from a different root node than the document root, make them separate methods on StyleEngine. Bug: 868810 Change-Id: Ic3c1308835aef9a4e7887822ad7744ae76a7dcbd Reviewed-on: https://chromium-review.googlesource.com/1206910Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#589476}
-
Maksim Sisov authored
This patch makes use of new minigbm APi names, which are aligned with Linux libgbm. Also, it defines certain definitions, which are different between libgbm and minigbm. What is more, it adds USING_MINIGBM for internal usage to be able to distinguish between system linux gbm and minigbm. Last but not least, drmPrimeHandleToFd is used in case of linux system libgbm in order to be able to get mappable fds per each plane, which is neede to add GpuMemoryBuffers support. Bug: 869206, 578890, 820047 Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585 Reviewed-on: https://chromium-review.googlesource.com/1158234 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
Uladzimir Miniailau authored
AddIE7PasswordInfo method and LoginsTable should also be deleted. I will do it in the following changes. Bug: 456119 Change-Id: I581fd88bc1fa9bf35d0484616be9d69e939e69ef Reviewed-on: https://chromium-review.googlesource.com/1174729Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#589474}
-
Daniel Bratell authored
Jumbo is the Chromium implementation of a Unity build system aimed at dramatically lowering the compilation times, especially for those without access to goma. In reference testing, this patch reduces the effort to compile content_shell+chrome+blink_tests by about 9 CPU minutes, 1-2% of the total effort. Earlier patches saved more so the total build effort reduction in //ui is about 41 CPU minutes. There is still some code in ui that doesn't use jumbo. Specifically most of the tests. Bug: 773275 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie59fec4b67fc1e3d6855d04a4b9a1088e0a08768 Reviewed-on: https://chromium-review.googlesource.com/834348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589473}
-
Mihai Sardarescu authored
The feature kRemoveUsageOfDeprecatedGaiaSigninEndpoint was enabled by default in M62. This CL removes the feature flag and all the code that use it. In a subsequent CL we will also remove the GaiaUrls::deprecated_client_login_to_oauth2_url() (here https://cs.chromium.org/chromium/src/google_apis/gaia/gaia_urls.h?rcl=461cbc77709a44135a9c9fce4ac2e4d81a7cb1cb&l=44) as that should no longer be user either. Bug: None Change-Id: I0d5534472e56c7276a1ce57503e992e652068ebc Reviewed-on: https://chromium-review.googlesource.com/1210265 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#589472}
-
Fredrik Söderquist authored
Rather than converting an int argument to a float in the function (that return a FloatRect), pass a float argument and let the caller handle a conversion (if needed.) Bug: 881188 Change-Id: If3083fc19c866f003b0d60e10246b3088463dcdd Reviewed-on: https://chromium-review.googlesource.com/1209923Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589471}
-
Mike West authored
Bug: 787905 Change-Id: I2248173947ed87ff3e8f40dc86a8e9044ed2dd3b Reviewed-on: https://chromium-review.googlesource.com/966442 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589470}
-
Yuki Shiino authored
This reverts commit a11e3884. Reason for revert: Suspicious to have broken viz_browser_tests and webui_polymer2_browser_tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7689 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936081737798843840/+/steps/viz_browser_tests/0/logs/CrSettingsMultideviceFeatureToggleTest.All/0 Original change's description: > [CrOS MultiDevice] Settings UI A11y labels. > > > Bug: 876796 > Change-Id: Ie369384f218fde83ae03f21add99c0573ab97912 > Reviewed-on: https://chromium-review.googlesource.com/1211915 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589397} TBR=hcarmona@chromium.org,jlklein@chromium.org,jordynass@chromium.org Change-Id: Ife1c75063e197a32142604f3f05c964910721079 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876796 Reviewed-on: https://chromium-review.googlesource.com/1212212Reviewed-by:
-
Mark Cogan authored
This CL adds metrics to track: - Use of the new Close All and Undo Close All controls. - Use of interactive tab grid reordering. Bug: 880845 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I822044ea7bd1065a987d50dd03842662fa618a41 Reviewed-on: https://chromium-review.googlesource.com/1206433Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#589468}
-
Maksim Sisov authored
Instead of blindly using a fake presentation feedback result, use the wayland provided one if available. If not, pretend there is a feedback, but provide a faked one. In order to provide feedback, the callback, which comes from the GPU, is stored in the Buffer instance. Although, both frame and presentation feedback are setup, the frame callback always comes first. Thus, we store the result and once the feedback comes, we use the previous swap result and the presentation feedback to let the GPU know the status of the request. Bug: 859012 Change-Id: I4f4628be6101149daa30b6c74f3490254ace0fad Reviewed-on: https://chromium-review.googlesource.com/1193883 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Pin-chih Lin authored
Initial config has both profile and H264 level now, we then apply the configuration by passing to H264 encoder class for VAVEA, and setting up v4l2 controls for V4L2VEA, rather than using fixed profile and level in the past. According to H264 spec, there are limitations for framerate/bitrate/framesize combinations as the requested level, and we may want to fail initization for excessive configuration. For VAVEA, we add the check on H264Encoder::Initialize(). For V4L2VEA, we will let driver judge the legality on configuration. In video_encode_accelerator_unittest, a new property requested_h264_level is added to test_stream to specify requested level, and ForceH264Level test for checking output level meets expectation. BUG=863327 BUG=865302 TEST=build, deploy Chrome, and run video_encoder_accelerator_unittest on Eve TEST=build, deploy Chrome, and run video_encoder_accelerator_unittest on Elm Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I003a4f5c1c8ef149ace3dd2ad18aebd84f60dd0c Reviewed-on: https://chromium-review.googlesource.com/1209883 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589466}
-
Daniel Bratell authored
A commit just introduced a second g_id_map in ui/views/cocoa, which broke jumbo builds. This renames the g_id_map globals to the longer names g_id_to_impl_map and g_id_to_host_impl_map. Bug: 859152 TBR=ccameron@chromium.org,ellyjones@chromium.org Change-Id: Id30d71b67f4bfb7c3ddc3ec8d03c759b5b7df14f Reviewed-on: https://chromium-review.googlesource.com/1212862Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589465}
-
Matthew Cary authored
webkit_layout_tests will fail if there is a non-ascii character in the stack dump. This CL encodes the stack dump to avoid that. Very probably there is some other problem that is causing the stack to contain non-ascii characters, but at this point we can't even tell what's the problem due to the crash (see the bug for details). Bug: 880246 Change-Id: I34c5582cc2d4bd98fb17053336e9084624df52a5 Reviewed-on: https://chromium-review.googlesource.com/1204015Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#589464}
-
Fredrik Söderquist authored
This implements initial values for SVGAnimatedInteger properties (which includes SVGAnimatedIntegerOptionalInteger since it is a reverse proxy for the former.) Bug: 225807 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0563b6cfe4dc22b08ed04ab508faf4fb9491b5b4 Reviewed-on: https://chromium-review.googlesource.com/1209743 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589463}
-
Brandon Wylie authored
Change-Id: I7af13ac123280be7b4b89a3b05918e2b8ea96ce3 Reviewed-on: https://chromium-review.googlesource.com/1208819Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589462}
-
Anders Hartvoll Ruud authored
The most important use case for css-properties-values-api is having typed (and possibly interpolated) custom properties in paint worklets. So naturally, this is the *least* well tested use case in WPT. This CL improves that by adding tests for most of the syntax types. The test works as a kind of "ref" test, which compares the output of CSSStyleValue.parse /parseAll with the value observed inside the worklet. <transform-function> and <transform-list> are not supported yet, so they will come later. Interpolations should also be tested, but that belongs in a separate test. Bug: 641877 Change-Id: I4bd310ecd61a2a8989df9c4a5c818cdc7c179b3a Reviewed-on: https://chromium-review.googlesource.com/1209711 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#589461}
-
Yutaka Hirano authored
This is a reland of 0af66703 Original change's description: > Remove cors:: namespace specifier in the namespace > > Bug: None > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib487fee40beaac941b74c090d31133b12d61ea4a > Reviewed-on: https://chromium-review.googlesource.com/1203517 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589158} Bug: None Change-Id: Ibfeafc088e016153ff3c3b6278107f62f2bdb710 Cq-Include-Trybots: luci.chromium.try:linux_mojo Tbr: toyoshim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1212428Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589460}
-
Clemens Hammacher authored
If a worker terminates while a wasm finisher task is scheduled, we try to cancel that task even though the platform already deleted it. This results in UBSan failures, ASan failures or crashes. The bug itself is fixed on the v8 side in https://crrev.com/c/1209344, but the test needs to be a layout test, thus on the chromium side. R=ahaas@chromium.org Bug: chromium:875579 Change-Id: I98f19869044299801eb521d97f417b403ca356c0 Reviewed-on: https://chromium-review.googlesource.com/1209602Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589459}
-
Kenichi Ishibashi authored
ServiceWorkerNavigationLoader is responsible for setting up LoadTimingInfo which are used to create web-exposed PerformanceResourceTiming. Specifically, the field |send_start| in LoadTimingInfo is populated as `requestStart` in PerformanceResourceTiming. The resource timing spec[1] doesn't state explicitly but according to a spec discussion[2], following ordering would be reasonable: workerStart <= fetchStart <= requestStart Before this CL, ServiceWorkerNavigationLoader recorded `requestStart` before starting a service worker, at the same time `workerStart` is recorded. This doesn't seem a good timing because `requestStart` would be less than `fetchStart`, which is recorded after the service worker is started. This CL moves the timing to record |send_start| (and corresponding |send_end|) to the time the service worker is started. Note that web-exposed `fetchStart` still doesn't follow the above ordering even after this CL, as we have a special case code for `fetchStart` in navigation. A follow-up CL will address `fetchStart` case. The wpt service-workers/service-worker/navigation-timing.https.html should cover this change. [1] https://w3c.github.io/resource-timing/#sec-performanceresourcetiming [2] https://github.com/w3c/resource-timing/issues/119 Bug: 782958 Change-Id: I339d41d8c93a2cbcd053d4348d8e0f51b1134925 Reviewed-on: https://chromium-review.googlesource.com/1212423Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589458}
-
Maksim Sisov authored
Instead of just assuming buffer is committed, use wayland provided frame callbacks. Once the GbmSurfaclessWayland (resides on the GPU process side) requests to swap buffers from Wayland (the connection is established on the browser process side), it sends a ScheduleBufferSwap requests and provides a completion callback, which is then triggered once Wayland sends a frame callback (setup for each new buffer swap). This callback is then used to identify if the swap was successful or not. Bug: 859012 Change-Id: I3264db6bb4456ef610d11945199ecddffbc23024 Reviewed-on: https://chromium-review.googlesource.com/1193882 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL rewrites WebContentsUserData using org.chromium.base.UserData. There should be no functional change. WebContentsUserData is deleted. Bug: 877878 Change-Id: Ib8f5b2267bf9d21f84661d2e747d8a6c9c1d9d66 Reviewed-on: https://chromium-review.googlesource.com/1189584 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589456}
-
Alan Cutter authored
This CL fixes a bug where permission prompts and page info dialogs go off screen when hosted app windows are maximised. This only affects platforms that don't support bubble anchor adjustment (see calls to set_adjust_if_offscreen(false) in BubbleDialogDelegateView::CreateBubble()). These platforms are Linux, Mac and Windows 7 with Aero disabled. This patch fixes the issue by making permission and page info dialogs anchored off the app menu use TOP_RIGHT instead of TOP_LEFT for their arrow position leading the bubble to position itself within the main window's bounds by default. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355950&signed_aid=ziHkOFUJALIjs_7uaUaPtQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355951&signed_aid=9B2p0GLHiuHOMC-Ha-rXBQ==&inline=1 Bug: 877032 Change-Id: I98b1fe1e4fe8018886ae960c8601f5d518c9ea5e Reviewed-on: https://chromium-review.googlesource.com/1201507 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589455}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1220339..104cb056 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6e3006420aa1afdcb60de363d4d5029e7f16750 Reviewed-on: https://chromium-review.googlesource.com/1212745Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589454}
-
Joel Einbinder authored
Change-Id: Ib45039f33313e2fe950967d6ad2b9d2ee956bf81 Reviewed-on: https://chromium-review.googlesource.com/1199966Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#589453}
-
Kuo-Hsin Yang authored
Upload the keyboard property file for keyboard emulator to remove the dependency to /usr/local/autotest/cros/input_playback/keyboard.prop. Bug: chromium:881240 Change-Id: I65daf0326d9237ac5a904f2966be4e95c6f8e210 Reviewed-on: https://chromium-review.googlesource.com/1209135 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589452}
-
Adam Rice authored
The are no unencodable characters in UTF-8, however previously callers to blink::TextCoder::Encode had to pass a dummy UnencodableHandling argument. Add a kNoUnencodables value to the UnencodableHandling which is an explicit no-op. Also add DCHECKs that is is only used for UTF-8 or UTF-16. Convert callers to use kNoUnencodables where the encoding is statically known to be UTF-8. It's still valid to use other values for the UnencodableHandling argument with UTF-8 or UTF-16; kNoUnencodables simply documents that it makes no difference. Change-Id: I5eebe4c76ae4006ee91f3884f94ec3b5e410685b Reviewed-on: https://chromium-review.googlesource.com/1206055Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589451}
-
Findit authored
This reverts commit e7492cbb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 589442 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U3NDkyY2JiM2M4N2MxNWE3YTE3YjlkMjI4YTcyNmE4ZTYxNTEzMWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/40795 Sample Failed Step: compile Original change's description: > CrOS FilesApp: refactor strings to allow reuse in tests > > Created static FileManagerPrivateStrings::GetStrings() which is called > by fileManagerPrivate.getStrings() extension function, and can now also > be called by utility executable to generate strings.js file for > testing rather than having strings duplicated. > > Bug: 813477 > Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2 > Reviewed-on: https://chromium-review.googlesource.com/1208993 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589442} Change-Id: I4b29ee18d2a663e08108aaf796bcae2aa0728d9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 813477 Reviewed-on: https://chromium-review.googlesource.com/1212486 Cr-Commit-Position: refs/heads/master@{#589450}
-
Josh Pratt authored
This allows CrostiniManager to handle states where a VM hasn't finished starting/stopping fully. BUG=880165 Change-Id: Ia94bf4059c4bfbf41c3fe920873fa7c8bc2aea18 Reviewed-on: https://chromium-review.googlesource.com/1212206Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#589449}
-
