GitLab

Change-Id: I32b5e7e37ff1b366a99de9ce5cd627ee5251490b
Reviewed-on: https://chromium-review.googlesource.com/1015900Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551498}

Destroy the MediaEngagementService object later. Should fix the
ToTLinuxUBSanVptr bot on the clang ToT waterfall.

R=beccahughes@chromium.org,mlamouri@chromium.org
BUG=chromium:827609

Change-Id: I9570279416a39d1018f714762d3df871cf2ce07a
Reviewed-on: https://chromium-review.googlesource.com/1015770Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551497}

This patch splits creating box fragments from computing inline
positions, in preparation of supporting text-overflow in
NGInlineLayoutAlgorithm.

No behavior changes in this patch.

Bug: 636993
Change-Id: I0e99a07128031a7085426ad53f91214df9c223a1
Reviewed-on: https://chromium-review.googlesource.com/1013779
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551496}

To support certain use cases the current upgrade strategy
can't be used. This cl changes all upgrades to N-1 strategy.

Bug: 461856
Change-Id: Ic7a7580e6e2e51b65428cddaca1209a3edc0af5b
Reviewed-on: https://chromium-review.googlesource.com/1013222Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: James Meade <mmeade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551495}

CDM_9 support has been shipped in Chomium for multiple releases. All new CDMs
should use CDM_9 and above. Hence removing support for CDM_8.

only cover CDM_9 and CDM_10.

Bug: 737296
Test: Removing support of old interface support. Currently our tests
Change-Id: I22facd6dc6e18933a295d3aece7ba2de1369cb79
Reviewed-on: https://chromium-review.googlesource.com/1015640Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551494}

The new name is kDisplayingNativeErrorForFailedNavigation. This change
is needed to support HTML based error pages which will use
kDisplayingWebErrorForFailedNavigation enum.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id68e8239d9706b8d98bc591a0d264609b13e23c0
Reviewed-on: https://chromium-review.googlesource.com/1015531Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551493}

This reverts commit 6db68698.

Reason for revert: Broke compile on Windows
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130690

FAILED: angle_shader_translator.exe angle_shader_translator.exe.pdb  E:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /OUT:./angle_shader_translator.exe /PDB:./angle_shader_translator.exe.pdb @./angle_shader_translator.exe.rsp translator.lib(OutputVulkanGLSL.obj) : fatal error LNK1236: corrupt or invalid COFF sections

Original change's description:
> Roll src/third_party/angle/ aa8b3982a..aed1b56aa (8 commits)
> 
> https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e
> 
> $ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s'
> 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
> 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
> 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
> 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
> 2018-04-17 jmadill Vulkan: Fix build after roll.
> 2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
> 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
> 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18
> 
> Created with:
>   roll-dep src/third_party/angle
> BUG=chromium:833736
> 
> 
> The AutoRoll server is located here: https://angle-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=jmadill@chromium.org
> 
> Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee
> Reviewed-on: https://chromium-review.googlesource.com/1015624
> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#551461}

TBR=jmadill@chromium.org,angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: Ic8bf0038e7b39a6025ac24b65aa5a38f078f0ede
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:833736
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1015191Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551492}

This change includes the integration of the MacOS KeyboardHook impl in
the RenderWidgetHostViewMac and RenderWidgetHostViewCocoa classes.

RWHVMac handles the lock/unlock calls from RenderWidgetHostImpl and
forwards them to RWHVCocoa which handles the events and input routing.

The RenderWidgetHostViewMac and RenderWidgetHostViewCocoa integration
follows the same pattern I used for RenderWidgetHostViewAura and
RenderWidgetHostViewEventHandler. The main difference between this impl
and the Aura impl is that there is a bridge class between RWHVMac and
RWHVCocoa (RenderWidgetHostViewNsBridgeView).

BUG=680809

Change-Id: I524c98c059ae4883bf597704c326b5a0055f1212
Reviewed-on: https://chromium-review.googlesource.com/989618Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551491}

Nobody will pick them up anyway.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ice7a1f9ee743a1555f0fab00feca0b2eef97125f
Reviewed-on: https://chromium-review.googlesource.com/1012847Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551490}

Add a check that the parent FrameSinkId is registered before creating an
OffscreeCanvasSurfaceImpl, which is really a generic embedded surface
and not just used for offscreen canvas. The IPC channel that controls
the destruction of the parent CompositorFrameSink, and subsequent
invalidation of parent FrameSinkId, is different than the IPC channel
used to create embedded surfaces. We can't rely on ordering of messages
between them. It's possible the parent FrameSinkId is invalidated before
the browser gets the request to create an embedded surface.

If this state is detected then just drop the request for the embedded
surface. This will avoid triggering the DCHECK that the parent
FrameSinkId is registered and avoid doing work for something that is
about to be destroyed.

The experiment to enable UseSurfaceLayerForVideo, which uses
OffscreenCanvasSurfaceImpl, had tests running into this problem and
hitting a DCHECK in HostFrameSinkManager::RegisterFrameSinkHierarchy().

Bug: 830003, 829306
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I4e8cb26548444ecbf941a87a984b21aa4c846580
Reviewed-on: https://chromium-review.googlesource.com/1014330
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551489}

This ports similar (internal) code used on systems not supporting CMA backend.

Bug: internal b/77986368
Test: Running on speakers, observing proper logs.
Change-Id: Ifde45f035e2f52096f82e9682bf5c60b170d2c47
Reviewed-on: https://chromium-review.googlesource.com/1014740Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551488}

This patch enables OOPIF pixel dumps behind a flag. The reason for the
flag is that this isn't working for 100% of cases yet. Specifically,
selection rects and dialogs windows aren't being captured correctly.

As well, there seem to be some pixel differences between existings tests
which will likely need to be rebaselined.

R=lukasza@chromium.org

Bug: 667551
Change-Id: Icfb98958e5b9d007b1bd3a554b32d55d545e04e6
Reviewed-on: https://chromium-review.googlesource.com/994240
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551487}

Fixing nits to improve readibility, also removing unnecessary TODO.

Bug: None
Tets: Build, tests still valid as funcionality remain the same.
Change-Id: Ia0be3efa9ba6e064a520b37ab27552e3af063a03
Reviewed-on: https://chromium-review.googlesource.com/1013287
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551486}

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rvera@chromium.org

Bug: 781352
Change-Id: I5429418614b13b654af86c4764ac1c9066a21f95
Reviewed-on: https://chromium-review.googlesource.com/1014780Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551485}

Bug: 828704
Change-Id: I1263e0bc2520b7b5f110ac2ae0ac92e3db8e2fd9
Reviewed-on: https://chromium-review.googlesource.com/999310Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551484}

Bug: 832728
Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f
Reviewed-on: https://chromium-review.googlesource.com/1012732Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551483}

Bug: 814860
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibe97fb4ccc820b72b67c8311b5ac5749ddb39d8d
Reviewed-on: https://chromium-review.googlesource.com/1014275
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551482}

Currently we create CFString and CFData wrappers for the underlying
std::string in RemotingKeychain. Even though the underlying content
isn't managed or released by the wrapper, we still need to release the
wrapper itself.

Bug: 834021
Change-Id: I47b298dc9a06ce34de68442cddc7ff07e79c0873
Reviewed-on: https://chromium-review.googlesource.com/1015769Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551481}

This cl makes some string changes for Keyboard Shortcuts Viewer based on
TC.

Bug: 833967, b/77166809, b/77861902
Test: manual
Change-Id: Ib28c40c1aea1303151bf2f4a687df7f230760cfa
Reviewed-on: https://chromium-review.googlesource.com/1015601Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551480}

This CL puts the ViewAndroidDelegate in WebContents internal to
makes it accessible using |WebContents.getViewAndroidDelegate|.
It helps replace ContentViewCore with WebContents where CVC is passed
as a way to access WebContents and container view.

The update of container view in VAD is taken care of by embedder
(WebView), so we don't need ContentViewCore API |setContainerView|
any more. It was deleted in this CL.

There are content classes that relied on |setContainerView| to do
some clean-ups (such as hiding popups). Added ViewAndroidDelegate.
ContainerViewObserver for them.

Bug: 598880
Change-Id: Icb824ddefc9707d9ea78cdba55615e47f2d100e7
Reviewed-on: https://chromium-review.googlesource.com/994500
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551479}

The file internal_app_id_constants.h was not added to
ash/public/cpp/build.gn. This cl fixes this.

Bug: 833955
Test: manual
Change-Id: Iff82b5d556ba084580640dbd73f423af67f64899
Reviewed-on: https://chromium-review.googlesource.com/1015527
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551478}

Only parameters encodings.active, encodings.maxBitrate and
encodings.priority are effectively working and connected
to the native layer.

Due to discrepancies between the WebRTC specification and the
native layers, the objects are not passed back from Javascript
and converted to native directly, but instead the relevant fields
are converted and patch the last result from getParameters().
If any read-only field is implemented by the native layer but not
exposed yet to Javascript, they will be left as is and won't cause
any InvalidModificationError.

Bug: 803494
Change-Id: Ia59734e5c3eddb54e5a1448a04fdcefe5a41a279
Reviewed-on: https://chromium-review.googlesource.com/969124Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551477}

Add version of conversion tests with and without premultiplied
alpha.

Bug: 833388
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9d269e5867fee62ed70b2f3579a4c4bf524a7103
Reviewed-on: https://chromium-review.googlesource.com/1014631Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551476}

This CL moves pieces of the OmniboxResultView Layout into the sub-views
(OmniboxSuggestionView elements). The OmniboxSuggestionView now have
functions to layout each style of result: Answer, Entity, TwoLine, and
Split. This CL is part of a refactor of the OmniboxResultView.

Bug: None
Change-Id: I8cd07a4749ab68238956632b45c2bd575fb4dccc
Reviewed-on: https://chromium-review.googlesource.com/1013320Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551475}

This CL implements the initialization flow for the service as well as
the implementation for GetSyncedDevices() and observer callbacks.
Additionally, it tweaks the API for Force{Enrollment,Sync}Now() to
return a boolean of whether the forced action was successfully
handled by the service (it cannot be handled before the service
starts up).

Bug: 824568, 752273
Change-Id: I787c5ac9cb5fe6011e26e0ddb8217910b9c495f0
Reviewed-on: https://chromium-review.googlesource.com/998795
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551474}

All those contorls are rendered with MacViews in M66.

Bug: 832676
Change-Id: I23ba5ad92fc4af46ed2e7adb3ad9607857cab443
Reviewed-on: https://chromium-review.googlesource.com/1014113Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551473}

Rotates Disclosure Accessory 90 degrees CW when showing section contents. Rotates back CCW when collapsing section.

Video: https://drive.google.com/file/d/1TWXnHpHqsfbrK26PsWraC6HTvaC_EGo5/view?usp=sharing

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I84f090bcbd43d0f69d50b8f0b48da35aff7efaf8
Reviewed-on: https://chromium-review.googlesource.com/994233
Commit-Queue: Chris Lu <thegreenfrog@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551472}

This change re-enabled the tests for the BottomSheetObserver. The
BottomSheetTestRule has been modified to create a separate bottom
sheet to test with instead of pulling the one from the activity.

Bug: 805160
Change-Id: I363507d9a42767682dce4935c0b347de320c4b8a
Reviewed-on: https://chromium-review.googlesource.com/1014252Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551471}

This change also converts the minimum necessary amount of C++ code to pass
objects of base::Value by value instead of std::unique_ptr.

Bug: 646113,799482
Change-Id: I86dcd6b4cfbb061942cb73f6ffddcf9e712f355f
Reviewed-on: https://chromium-review.googlesource.com/1012931
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551470}

Bug: 828878
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I76115730b550c8320e05c7c9fc1a20dd129f3626
Reviewed-on: https://chromium-review.googlesource.com/1012748
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551469}

All players/decoders handling encrypted media should implement the logic
to suspend playback when the decryption key is not available, and then
resume playback when a new usable decryption key is added. Hence,
there's a common need for the players/decoders to be notified when such
an event (new usable key) happens.

Since CdmContext is the common interface bridging players/decoders and
the CDM, this CL adds RegisterNewKeyCB() to CdmContext.

To facilitate the implementation of RegisterNewKeyCB() in various CDMs
and CdmProxies, CallbackRegistry is also introduced, which can manage
callback registration, notification and unregistration. Note that
there's base::CallbackList which is similar, but that class is not as
simple and is not thread-safe.

This CL also updates D3D11CdmProxy to use CallbackRegistry to manage
new key callbacks. D3D11VideoDecoderImpl is also updated to be able to
register new key callbacks.

Bug: 821288
Test: Covered by existing tests.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0380f934efb63d3b3c893d909e0d78f5f8e082f4
Reviewed-on: https://chromium-review.googlesource.com/1014245
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551468}

This change marks
RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler
as flaky on Android.

BUG=827318

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I350f16399cf4cd389642a2e1af8a106c6c23495f
Reviewed-on: https://chromium-review.googlesource.com/1015652
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551467}

Cleanup more left-over code from Chrome Home:
 - Don't use BottomSheet for ViewShiftingActionBarDelegate so that
   copy-paste action bar pushes down top toolbar instead
 - Revert changes that disabled hiding the keyboard during find in page
   when there is a bottom sheet

BUG=833606,833608,814528

Change-Id: I9f2a1262c5ffba20902e1b438cb6175a48363680
Reviewed-on: https://chromium-review.googlesource.com/1015283Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551466}

Bug: 829119
Change-Id: Idbc1dd0294174b457989893d11e66237a04c3ea5
Reviewed-on: https://chromium-review.googlesource.com/1005367Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551465}

No more detatchWebContentsIfAny() and similar helpers.
This boils the presentation of WebContents into a simple state
machine compatible with Observables.

This refactor includes covering the business logic of
CastWebContentsSurfaceHelper in unittests. The implementation
details of CastWebContentsView are still not unit-tested, but
are now better isolated from other logic.

Bug: Internal b/36777136
Test: cast_shell_junit_tests
Change-Id: Ia555b4d3ea9ee07607bf54cc339b950fe068d220
Reviewed-on: https://chromium-review.googlesource.com/1003412Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551464}

Change-Id: Id73ec54e7a4e66f75cb7f4c294b923f851f00ae9
Reviewed-on: https://chromium-review.googlesource.com/1014406Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551463}

Bug: 833986
Test: No delays when using copy-and-paste in Crostini.
Change-Id: I6722dbd81548b760db8e1ae9a4e3cd1d4c6bf645
Reviewed-on: https://chromium-review.googlesource.com/1015700Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551462}

https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e

$ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s'
2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
2018-04-17 jmadill Vulkan: Fix build after roll.
2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18

Created with:
  roll-dep src/third_party/angle
BUG=chromium:833736


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee
Reviewed-on: https://chromium-review.googlesource.com/1015624Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551461}

These are used across processes and should be in common.

It also unblocks moving public manifest files to blink/public/common
and later moving manifest implementation to blink.

NOPRESUBMIT=true

Bug: none
TBR: oshima@chromium.org, dtrainor@chromium.org
Change-Id: Ief909ae1d5f42cb6f4cb58c4119b17f79b6682a8
Reviewed-on: https://chromium-review.googlesource.com/1007899
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551460}

Turns out we can have a focused Element that doesn't have a
LayoutObject. Just early out in this case when we try to scroll it into
view.

Bug: 833746
Change-Id: Ia68492bf5cd4cbb538b5e9c53a75433a48ac5463
Reviewed-on: https://chromium-review.googlesource.com/1015533Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551459}