GitLab

Drive-by: put app banner support behind experiment.

BUG=540864

Review URL: https://codereview.chromium.org/1641513003

Cr-Commit-Position: refs/heads/master@{#372026}

https://chromium.googlesource.com/skia.git/+log/62358e77c2b8..4c5f1f611469

$ git log 62358e77c..4c5f1f611 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 fmalita Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1643713003

Cr-Commit-Position: refs/heads/master@{#372025}

Link header preloads were not working when sent over subresources.
This CL fixes that.

BUG=568025

Review URL: https://codereview.chromium.org/1627203002

Cr-Commit-Position: refs/heads/master@{#372024}

Culled inline hittesting was recently fixed [1] which exposed a
bug in LayoutInline::hitTestCulledInline where hit testing checked
for region intersection but returned a value based on region
containment. This bug was partially fixed in [2] for list-based
tests but a bug still existed for point-based tests.

This patch updates LayoutInline::hitTestCulledInline to check for
hit tests using region intersection, and return a value based on
region intersection (not containment). This was done by fixing a FIXME
to implement HitTestRequest::addNodeToListBasedTestResult for regions.

In addition, this patch changes the return value of
HitTestRequest::addNodeToListBasedTestResult to be an enum which
better explains its behavior.

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=193729
[2] https://crrev.com/b489f7917175e2449c8f6d5874ab3ba0b7f31e88

BUG=579412

Review URL: https://codereview.chromium.org/1630793002

Cr-Commit-Position: refs/heads/master@{#372023}

fast/text/justify-ideograph-vertical.html
fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-complex.html

BUG=581974
TBR=kojii@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1649643002

Cr-Commit-Position: refs/heads/master@{#372022}

This CL adds Dr. Fuzz config in mb_config.pyl to support building
tests for Dr. Memory and Dr. Fuzz on Windows.

R=dpranke@chromium.org
BUG=572694

Review URL: https://codereview.chromium.org/1633413002

Cr-Commit-Position: refs/heads/master@{#372021}

BUG=580337

Review URL: https://codereview.chromium.org/1641933002

Cr-Commit-Position: refs/heads/master@{#372020}

Re-enable its TestExpectations for [ Debug Mac10.7 ]

BUG=463358
TBR=hans@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1642763004

Cr-Commit-Position: refs/heads/master@{#372019}

- Tighten up he second argument of moveElementOutOfAncestor();
  ContainerNode -> Element

- Add inDocument() check in makeInsertedContentRoundTrippableWithHTMLTreeBuild().
  crrev.com/371774 fixed one such case. However we still might have such cases.
  Add inDocument() check just in case in order to avoid future crashes.

BUG=537815

Review URL: https://codereview.chromium.org/1649513003

Cr-Commit-Position: refs/heads/master@{#372018}

Using update-w3c-deps in Blink 329450ec.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,cbiesinger@chromium.org
BUG=492664

Review URL: https://codereview.chromium.org/1639343003

Cr-Commit-Position: refs/heads/master@{#372017}

Previously, the notes would be emitted in the iteration order over Fields,
which is an std::map<clang::FieldDecl*, FieldPoint>, which is ordered
by pointer value of FieldDecls. This would cause tests to flakily fail
on the Windows buildbots.

I'm not sure what caused these errors to start appearing right now,
but this should fix it.

BUG=581782

Review URL: https://codereview.chromium.org/1645613003

Cr-Commit-Position: refs/heads/master@{#372016}

Don't try to make VisibleSelection for elements of which content is not
selectable.

This CL has no user-visible behavior changes because
selectionFromContentsOfNode() created a null VisibleSelection before this CL.

BUG=477839
TEST=automated

Review URL: https://codereview.chromium.org/1647833002

Cr-Commit-Position: refs/heads/master@{#372015}

Re-enable the TestExpectations which was commented out for some
reason (no explanatory comment).

TBR=wkorman@chromium.org
BUG=581963,463358
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1643863002

Cr-Commit-Position: refs/heads/master@{#372014}

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.

Review URL: https://codereview.chromium.org/1644813002

Cr-Commit-Position: refs/heads/master@{#372013}

This CL removes a static variable s_isPageBackground which is used to
tell the current tab is in background or foreground. It is because it's
almost impossible to tell this.

For example,  one renderer process of a new tab page is used for
multiple tabs. Another example is that reloading a page will re-use the
process with a new Page object and updating a static variable along with
reloading will be complex.

After this CL, we won't be able to get the number of decompression only
in a background tab. With the new UMA, we can't give a go-sign for
CompressibleString but at least we can give a no-go-sign.

BUG=581266
TEST=n/a

Review URL: https://codereview.chromium.org/1646443002

Cr-Commit-Position: refs/heads/master@{#372012}

The z component of the translate CSS property was ignoring length units
and treating everything as px.
This change fixes this by converting units into their px equivalent.

BUG=581918

Review URL: https://codereview.chromium.org/1640293004

Cr-Commit-Position: refs/heads/master@{#372011}

BUG=525873

Review URL: https://codereview.chromium.org/1637003002

Cr-Commit-Position: refs/heads/master@{#372010}

This CL adds Blink.MemoryCache.RevalidationPolicy.Preload.* that collect stats
of preloading requests, and
makes the existing Blink.MemoryCache.RevalidationPolicy.* to collect stats of
non-preloading requests only.

BUG=579496

Review URL: https://codereview.chromium.org/1642523002

Cr-Commit-Position: refs/heads/master@{#372009}

BUG=none

Review URL: https://codereview.chromium.org/1645733002

Cr-Commit-Position: refs/heads/master@{#372008}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e8c9e565cd60..0085d5c64509

$ git log e8c9e565c..0085d5c64 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1643703003

Cr-Commit-Position: refs/heads/master@{#372007}

WindowManager->WindowManagerDeprecated (i'll nuke this entirely soon)
WindowManagerInternal->WindowManager

I'll move the WindowManager classes into window_manager.mojom once I
nuke WindowManagerDeprecated (I can't now because of a cycle).

BUG=none
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1644773004

Cr-Commit-Position: refs/heads/master@{#372006}

TBR=groby@chromium.org
BUG=581959

Review URL: https://codereview.chromium.org/1644873002

Cr-Commit-Position: refs/heads/master@{#372005}

Revert of Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (patchset #24 id:460001 of https://codereview.chromium.org/1541393003/ )

Reason for revert:
GN asan and tsan are broken, wasn't aware bots are running GYP only. Reverting until we can figure out what to do with GN asan/tsan and probably msan.

Original issue's description:
> Improve performance of Character::isCJKIdeographOrSymbol by using trie tree
>
> This patch is another effort to make Character::isCJKIdeographOrSymbol
> faster.
>
> The previous CL[1] made it faster by ~90% for codepoints below U+2020,
> but codepoints abvoe U+2020 were not as fast. This CL makes all
> codepoints faster, as fast as ICU functions.
>
>       Before  After Improve ICU
> All    2569 => 292    88%   298
> ASCII    68 =>  68     0%   160
> Han    2958 => 263    91%   344
> Hira    258 =>  11    95%    14
> Arabic   37 =>  32    13%    44
> * # of code points and iterations vary by rows.
>
> The previous CL[1] clarified that binary search is not as fast as ICU
> functions such as uscript_getScript(). This patch changes to use
> UTrie2, which is the data structure ICU property functions use.
>
> In addition in this patch:
> * U+2763 and U+2764 are added as requested by drott@.
> * Character::isUprightInMixedVertical() was switched to UTrie2 too.
> * Character::isCJKIdeograph() was removed because it is no longer used.
>
> [1] https://codereview.chromium.org/1545073002
>
> BUG=571943
>
> Committed: https://crrev.com/e6dc3f425137021f39eddbbeb2035273ce36f986
> Cr-Commit-Position: refs/heads/master@{#371917}

TBR=eae@chromium.org,drott@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571943

Review URL: https://codereview.chromium.org/1644893002

Cr-Commit-Position: refs/heads/master@{#372004}

Review URL: https://codereview.chromium.org/1647493003

Cr-Commit-Position: refs/heads/master@{#372003}

Cr-Commit-Position: refs/heads/master@{#372002}

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847

Review URL: https://codereview.chromium.org/1632403003

Cr-Commit-Position: refs/heads/master@{#372001}

https://codereview.chromium.org/1421423005 caused this regression. We never
handled aspect ratio correctly in flexbox (that's bug 249112), but that patch
made our handling worse because we now distort and enlarge images when
a cross axis size is specified that's bigger than the image's intrinsic size.

This was tested by
imported/csswg-test/css-flexbox-1/flex-minimum-height-flex-items-008.xht which
we now pass. I didn't realize the significance of failing that test at the time :(

BUG=581361,581535
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1639723003

Cr-Commit-Position: refs/heads/master@{#372000}

https://chromium.googlesource.com/skia.git/+log/1c971faab7b2..62358e77c2b8

$ git log 1c971faab..62358e77c --date=short --no-merges --format='%ad %ae %s'
2016-01-27 mtklein SkPngFilters: guard with libpng >= 1.5.7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1647823002

Cr-Commit-Position: refs/heads/master@{#371999}

When EGL_ANGLE_keyed_mutex is available, DXVAVideoDecodeAccelerator will create the picture buffer with D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX and use that instead of a fence to synchronize between the decoder context and GPU context. This has saved up to 0.2W in my testing (out of 5W), though the number is not entirely consistent.

Chrome will create the texture itself and share it into ANGLE (rather than vice versa) so it can choose whether or not to use a keyed mutex. This helps in particular with D3D9Ex, which is incompatible with keyed mutexes.

EGL_ANGLE_keyed_mutex is not yet enabled in ANGLE for chrome, so this won't do anything yet.

BUG=337606

Review URL: https://codereview.chromium.org/1553603002

Cr-Commit-Position: refs/heads/master@{#371998}

FileSelectHelper subjects suggested filenames to the safe browsing
white/black lists prior to showing the file picker. However, if the list
of accepted file types passed in to the file picker is not empty, and
the suggested filename doesn't match the accepted file types, the file
picker may append an accpeted file extension to the suggested filename.

In order to prevent this from being abused, this CL causes
FileSelectHelper to also verify that the list of accepted file types is
also safe.

R=sky,nparker,bbudge,holte
BUG=575849

Review URL: https://codereview.chromium.org/1613483003

Cr-Commit-Position: refs/heads/master@{#371997}

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman

Review URL: https://codereview.chromium.org/1641893002

Cr-Commit-Position: refs/heads/master@{#371996}

BUG=580514

Review URL: https://codereview.chromium.org/1640273004

Cr-Commit-Position: refs/heads/master@{#371995}

Regression:[Devtools]Unable to close 'This script is blackboxed..' warning message without closing 'pretty print' infobar.

BUG=581606

Review URL: https://codereview.chromium.org/1641573005

Cr-Commit-Position: refs/heads/master@{#371994}

BUG=546731
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1536553002

Cr-Commit-Position: refs/heads/master@{#371993}

We used to incorrectly allow content settings to be persisted in the guest
profile. This CL prevents them from being persisted and ensures that any
existing settings are deleted.

BUG=578130
TBR=asanka@chromium.org,bzanotti@chromium.org,droger@chromium.org

Review URL: https://codereview.chromium.org/1605453003

Cr-Commit-Position: refs/heads/master@{#371992}

As is, the bots cannot finish running the tests in time.

BUG=581583

Review URL: https://codereview.chromium.org/1647713003

Cr-Commit-Position: refs/heads/master@{#371991}

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1

Review URL: https://codereview.chromium.org/1637203002

Cr-Commit-Position: refs/heads/master@{#371990}

BUG=581793
TEST=Extended GaiaAuthFetcherTest passes
TEST=Tested together https://codereview.chromium.org/1618193003/.
     Auth code is returned for GMS Core client id and is consumed
     at Android.

Review URL: https://codereview.chromium.org/1644713002

Cr-Commit-Position: refs/heads/master@{#371989}

BUG=

Review URL: https://codereview.chromium.org/1645823002

Cr-Commit-Position: refs/heads/master@{#371988}

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503

Review URL: https://codereview.chromium.org/1634353002

Cr-Commit-Position: refs/heads/master@{#371987}