GitLab

Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #10 id:180001 of https://codereview.chromium.org/1393283005/ )

Reason for revert:
One of the buildbots timed out while linking Chrome:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/6251

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
>
> This CL turns on CFI, a security check:
> https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%,
> and should not be an issue.
>
> BUG=chromium:464797
> Intent to Implement thread:
> https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ
>
> Committed: https://crrev.com/9aedd443e02995d017138da7913e97650f889641
> Cr-Commit-Position: refs/heads/master@{#362856}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797

Review URL: https://codereview.chromium.org/1498723002

Cr-Commit-Position: refs/heads/master@{#362973}

Using update-w3c-deps in Blink 7461ceb1.

The directory below is skipped, instead of individual files in the
directory since files with "'" in the file names are added (which our
CQ does not support) and tests in the directory is already skipped.
html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org
BUG=490511

Review URL: https://codereview.chromium.org/1492283002

Cr-Commit-Position: refs/heads/master@{#362972}

BUG=

Review URL: https://codereview.chromium.org/1469813002

Cr-Commit-Position: refs/heads/master@{#362971}

As a step toward componentizing the LocalizedError class for clean
integration on iOS, this CL componentizes error pages strings.

BUG=523362

Review URL: https://codereview.chromium.org/1467193003

Cr-Commit-Position: refs/heads/master@{#362970}

BUG=503585

Review URL: https://codereview.chromium.org/1498813002

Cr-Commit-Position: refs/heads/master@{#362969}

+ chrome://network-errors/ lists all the network errors.
+ chrome://network-error/<err_code>  shows a specific network error.

BUG=

Review URL: https://codereview.chromium.org/1421743002

Cr-Commit-Position: refs/heads/master@{#362968}

Skipping CQ because a builder was malfunctioning and blocking landing.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/35e626cc..02a7a63b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1491013004

Cr-Commit-Position: refs/heads/master@{#362967}

Allow nullptr to be converted to JavaRef, not just JavaParamRef. This
avoids having to declare a ScopedJavaLocalRef just to pass null to a
function that takes JavaRef, and makes C++ "nullptr" and Java "null"
equivalent.

BUG=506850
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/1492703003

Cr-Commit-Position: refs/heads/master@{#362966}

It can be useful during development to have Chrome connect to test GCM
environments instead of production GCM.

BUG=https://b.corp.google.com/23523760

Review URL: https://codereview.chromium.org/1492913002

Cr-Commit-Position: refs/heads/master@{#362965}

Before this CL, CSSPreloadScanner didn't handle <base> element adjusted
relative URLs. This CL adds support for it.

BUG=511935

Review URL: https://codereview.chromium.org/1493253002

Cr-Commit-Position: refs/heads/master@{#362964}

BUG=529891

Review URL: https://codereview.chromium.org/1493023002

Cr-Commit-Position: refs/heads/master@{#362963}

BUG=539355

Review URL: https://codereview.chromium.org/1430273002

Cr-Commit-Position: refs/heads/master@{#362962}

BUG=556939

Review URL: https://codereview.chromium.org/1494833002

Cr-Commit-Position: refs/heads/master@{#362961}

BUG=554289

Review URL: https://codereview.chromium.org/1475553002

Cr-Commit-Position: refs/heads/master@{#362960}

R=mstensho@opera.com

Review URL: https://codereview.chromium.org/1498593004

Cr-Commit-Position: refs/heads/master@{#362959}

This test was already partially disabled on iOS (using the
|supports_non_dotted_domains| parameter).
This CL disables a larger part of the test, to unblock the commit queue.

TBR=ellyjones
BUG=564543

Review URL: https://codereview.chromium.org/1490393003

Cr-Commit-Position: refs/heads/master@{#362958}

Since master@{#358816} we run a second round of the track sizing algorithm
whenever the height of the grid is indefinite in order to properly compute
row sizes. The available space passed to the track sizing algorithm must not
contain neither borders nor paddings, otherwise it will think that it has
more space available than the existing one. We should use the height of the
content box instead.

BUG=560771,562985

Review URL: https://codereview.chromium.org/1490093003

Cr-Commit-Position: refs/heads/master@{#362957}

//components/sessions depends on both //components/keyed_service/core and
//components/variations. GN and GYP were missing the first and the second
respectively.

Review URL: https://codereview.chromium.org/1493293002

Cr-Commit-Position: refs/heads/master@{#362956}

BUG=
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1492053005

Cr-Commit-Position: refs/heads/master@{#362955}

For example if a JS redirect would fail while the original navigation is
still in progress we would call didStopLoading before the original
navigation calls didFinishLoading (breaking the assumption that
didFinishLoading is always called before didStopLoading).

BUG=557100, 298193

Review URL: https://codereview.chromium.org/1440933004

Cr-Commit-Position: refs/heads/master@{#362954}

BUG=562431

Review URL: https://codereview.chromium.org/1494883003

Cr-Commit-Position: refs/heads/master@{#362953}

Adding common_constants.gyp:version_header dependency to setup_lib because
installer_crash_reporter_client.cc includes chrome/common/chrome_version.h.
This fails to compile flakily on Windows.

BUG=558552
TBR=joenotcharles@chromium.org,grt@chromium.org

Review URL: https://codereview.chromium.org/1494933002

Cr-Commit-Position: refs/heads/master@{#362952}

Revert of CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines (patchset #2 id:20001 of https://codereview.chromium.org/1481343002/ )

Reason for revert:
Revert because WebViewTest.CanGoBackAndForward and WebViewTest.NavigationClearsForward started failing.

Original issue's description:
> CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines
>
> In general, we want to enable external animation system for blink here: https://codereview.chromium.org/1308053006/
>
> Make sure that HtmlViewer always uses the new animation system for CC and Blink (cc::AnimationHost).
>
> Eventually, we will delete LayerSettings everywhere.
>
> BUG=394777
>
> Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
> Cr-Commit-Position: refs/heads/master@{#362911}

TBR=sky@chromium.org,loyso@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=394777

Review URL: https://codereview.chromium.org/1500513003

Cr-Commit-Position: refs/heads/master@{#362951}

BUG=562431

Review URL: https://codereview.chromium.org/1497683002

Cr-Commit-Position: refs/heads/master@{#362950}

BUG=562431

Review URL: https://codereview.chromium.org/1493633004

Cr-Commit-Position: refs/heads/master@{#362949}

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771

Review URL: https://codereview.chromium.org/1496513002

Cr-Commit-Position: refs/heads/master@{#362948}

This CL modifies a name to mention only "bookmarks".

BUG=378104
R=noyau@chromium.org

Review URL: https://codereview.chromium.org/1497433003

Cr-Commit-Position: refs/heads/master@{#362947}

This test was already partially disabled on iOS (using the
|supports_non_dotted_domains| parameter).
This CL disables a larger part of the test, to unblock the commit queue.

TBR=ellyjones
BUG=564543

Review URL: https://codereview.chromium.org/1498793002

Cr-Commit-Position: refs/heads/master@{#362946}

This patch removes some Failure expectations for imported tests in
web-platform-tests/html that were fixed in crbug.com/391260.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org
BUG=490511, 542660, 391260

Review URL: https://codereview.chromium.org/1499433003

Cr-Commit-Position: refs/heads/master@{#362945}

Cancelled animations are removed before the update is applied. Regressed
in https://codereview.chromium.org/1402143004

BUG=564354

Review URL: https://codereview.chromium.org/1500443002

Cr-Commit-Position: refs/heads/master@{#362944}

The "deps" and "public_deps" are sorted using the following order:
  1. litteral strings
    a. local targets, e.g. ":a",
    b. relative targets, e.g. "a" or "../a",
    c. absolute targets, e.g. "//a",
  2. other values, e.g. variable reference.

In each group, values are sorted alphabetically.

BUG=554928

Review URL: https://codereview.chromium.org/1496653002

Cr-Commit-Position: refs/heads/master@{#362943}

Review URL: https://codereview.chromium.org/1486603002

Cr-Commit-Position: refs/heads/master@{#362942}

The SVGAnimatedLength constructor takes an additional argument (compared to the
arguments passed to other SVGAnimatedProperty classes) which represents whether
the length may be negative. Although this is stored as a property of
SVGAnimatedLength, the value is determined by the particular SVG attribute that
the SVGAnimatedLength is representing, and does not change.

In order to facilitate the implementation of additive animations for
AnimatedLength, this patch removes this additional argument, and instead
implements a helper function in SVGLength.h to look up the value for a given SVG
attribute.

BUG=530436

Review URL: https://codereview.chromium.org/1491023003

Cr-Commit-Position: refs/heads/master@{#362941}

This allows a number of the authentication policies to be updated
dynamically after the IO thread has been created.

BUG=545534

Review URL: https://codereview.chromium.org/1414313002

Cr-Commit-Position: refs/heads/master@{#362940}

Reland of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1494883004/ )

Reason for revert:
Reverting didn't help.

Original issue's description:
> Revert of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ )
>
> Reason for revert:
> This breaks Codesearch bots.
>
> Original issue's description:
> > Fix downloading LLVM Gold plugin in the case, when Clang is up to date.
> >
> > The script should download LLVM Gold plugin, if it's missing, even if the
> > main Clang toolchain is up to date. This change is to match update.py
> > functionality with the gone update.sh.
> >
> > BUG=464797,494442
> >
> > Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
> > Cr-Commit-Position: refs/heads/master@{#362803}
>
> TBR=thakis@chromium.org,krasin@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=464797,494442
>
> Committed: https://crrev.com/9e37ffbe43c0b100bcc02f9faf648f11d86316c1
> Cr-Commit-Position: refs/heads/master@{#362938}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797,494442

Review URL: https://codereview.chromium.org/1493283002

Cr-Commit-Position: refs/heads/master@{#362939}

Revert of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ )

Reason for revert:
This breaks Codesearch bots.

Original issue's description:
> Fix downloading LLVM Gold plugin in the case, when Clang is up to date.
>
> The script should download LLVM Gold plugin, if it's missing, even if the
> main Clang toolchain is up to date. This change is to match update.py
> functionality with the gone update.sh.
>
> BUG=464797,494442
>
> Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
> Cr-Commit-Position: refs/heads/master@{#362803}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797,494442

Review URL: https://codereview.chromium.org/1494883004

Cr-Commit-Position: refs/heads/master@{#362938}

Introduces a hack to recover the speed performance of
EventTarget.dispatchEvent.  The code looks like close to the one before
http://crrev.com/1417023006 .

BUG=564407, 509936

Review URL: https://codereview.chromium.org/1494803003

Cr-Commit-Position: refs/heads/master@{#362937}

BUG=560769

Review URL: https://codereview.chromium.org/1477133002

Cr-Commit-Position: refs/heads/master@{#362936}

The xdg_shell allows clients to turn a wl_surface into a "real window"
which can be dragged, resized, stacked, and moved around by the
user. This interface is suited towards traditional desktop
environments and is what most wayland clients use today.

This patch adds minimal support for this interface. Requests such
as move and resize will be added by follow up patches.

BUG=549781

Review URL: https://codereview.chromium.org/1411403007

Cr-Commit-Position: refs/heads/master@{#362935}

It's unclear what the purpose of this test is, but it's creating busy
work for folks working on blink features, so I'll disable this while
someone figures this out.

BUG=564765
TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1495793003

Cr-Commit-Position: refs/heads/master@{#362934}