GitLab

BUG=655167

Change-Id: I2b18f52fae92993f1e37852924d8cbaf19872eaf
Reviewed-on: https://chromium-review.googlesource.com/1103395Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568115}

This CL introduces AuthenticatorSheetModelBase, which will serve as a
base class for sheets, and implement the shared behavior used on most
sheets, as well as maintaining a weak pointer to the dialog model.

Also introduce CreateSheetViewForCurrentStepOf, a factory method that
constructs the appropriate SheetView subclass, along with the
appropriate SheetModel subclass.

Bug: 849323
Change-Id: Iaedb3da6aa3f3fdc932b57cc5795143acab7d4c5
Reviewed-on: https://chromium-review.googlesource.com/1104422Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568114}

Flakily timing out.

BUG=853852
TBR=ekaramad
NOTRY=true

Change-Id: I894fe217109a63e86ed5aa2b2be2c801b8f91d76
Reviewed-on: https://chromium-review.googlesource.com/1104977Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568113}

This removes all the remaining disabled tests in the filter file for
base tests on Fuchsia and instead filters each of them individually.

Bug: 738275, 752368, 753490, 810077, 811881, 851734, 851747, 851759, 851760
Change-Id: I375954138d09ebacc05b2ad37afe1e09901e52e2
Reviewed-on: https://chromium-review.googlesource.com/1096483Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568112}

The model properties should be agnostic to the view implementation.
ANDROID_VIEW_VISIBILITY was an int but that was view specific and really
all the mediator needs to interact with is whether or not the
Android View is visible.

Change-Id: I0daa79cc0d5a4a2a1a5c7b2443eee731525baa66
Reviewed-on: https://chromium-review.googlesource.com/1103545
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568111}

Network Service: Add VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromRequestUsingSimpleURLLoader

This CL adds variations http headers browser which uses
SimpleURLLoader.

Bug: 841309
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I16bc257c18b76f0b2ba6b9ba721b87f4e3fb44a7
Reviewed-on: https://chromium-review.googlesource.com/1100106
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568110}

Bug: 828135
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I9ac4b3d671bee44c574f1a75ca357296a34f1cba
Reviewed-on: https://chromium-review.googlesource.com/1098558
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568109}

Since /deep/ is deprecated in shadow DOM v1, track highlights and
search bubbles as they are added to avoid searching recursively to
remove them later.

Bug: 852098
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iac61a1f340ae4029589556c3ad09e567126a1639
Reviewed-on: https://chromium-review.googlesource.com/1100102
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568108}

Add a BOOT_ANIMATION_OVERLAY type for the initial animation happening at
startup.

Add a CORNERS_OVERLAY type for window mask around the display corners.

BUG=b/110092844
TEST=None

Change-Id: Ifde30aeb490171e2f3daf0bb727f9e70e6e6ced4
Reviewed-on: https://chromium-review.googlesource.com/1103301
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568107}

Code was referencing undefined variables.

Bug: 853780
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie50c336424a45f780b854b35074b788be65a9368
Reviewed-on: https://chromium-review.googlesource.com/1104779Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568106}

Add new print preview to the upcoming UI features flag.

Bug: 773928
Change-Id: Ia1fe0883fba0a76b6bbf75b86b932f3b1abf0947
Reviewed-on: https://chromium-review.googlesource.com/1103292Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568105}

This patch sets a flag for using light toolbar drawables when the
visual state is update. This was incorrectly excluded with 227a972f.

Bug: 852682
Change-Id: I77a2e9f742720b48045a9f02ac1ab0a8ebb77429
Reviewed-on: https://chromium-review.googlesource.com/1104708Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568104}

Replace use of QuitCurrent*Deprecated() with use of the QuitClosure of
the //content default main message loop's RunLoop.

Bug: 844016
Change-Id: I14eb18304de9c9ddaabc2860998d12733572e7f7
Reviewed-on: https://chromium-review.googlesource.com/1103787
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568103}

This change enables Dedicated Workers to inherit the Feature Policy of
the context that created the worker.

Bug: 843780
Change-Id: I2afaf7ee8547853a2f1c639961c78260efbd9633
Reviewed-on: https://chromium-review.googlesource.com/1091635
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568102}

Bug: 850719
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I63fb963d90fe8b240fce80b52f8b852d5c77f311
Reviewed-on: https://chromium-review.googlesource.com/1101923
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568101}

Change the testing scheme for k-rate panner to verify that the output
is piecewise constant for a constant source when the automation rate
is set to k-rate. Reduce the duration of the test as well; Just a few
render quanta is enough to verify that the output is piece-wise constant
and different from the a-rate output.

Also updated k-rate-constant-source.html to use the same doTest method
since the special case is supported.

Didn't actually figure out the underlying flakiness of the original
test.

Bug: 841856
Change-Id: I8e9807e530fc3b1452bae521a2660be3fbe104f9
Reviewed-on: https://chromium-review.googlesource.com/1076809Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568100}

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3c25b29dfbb00edbb179003d17cfe061a32ebce3
Reviewed-on: https://chromium-review.googlesource.com/1100086
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568099}

...to standard Chrome icon color.

Bug: 780835
Change-Id: Ie377265d7f50a8598075aca9b7868239750b2c6f
Reviewed-on: https://chromium-review.googlesource.com/1104787
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568098}

Change-Id: I840e7e4c5b02b346e7edab78a4264d6b22bb4a9d
Reviewed-on: https://chromium-review.googlesource.com/1103202
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568097}

This will allow a narrower guestimate at the validity of performance
measurements relating to load events.

Bug: 755840
Change-Id: I7087c5840106102844ef7518c0ad42648f4abe3e
Reviewed-on: https://chromium-review.googlesource.com/1101304
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568096}

Change-Id: I2dcfc3411ba478355a927874cf4b3938276288a5
Reviewed-on: https://chromium-review.googlesource.com/1103154Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568095}

This is flaking on Viz/Windows/Intel. Not clear how to select viz
as a config in the GPU expectations module. Suppress this on the
Windows Intel config for now.

Bug: 853762
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I83bc2699d7b7a904eb68b97886d1c91025307d31
Tbr: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1104783Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568094}

This reverts commit edb91802.

Reason for revert: Suspecting flaky crashes:
Win10 FYI Release (Intel HD 630) vr_browser_test

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/974

Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	(No symbol) [0x6A3B41A0]
	(No symbol) [0x6A3B174E]
	device::OpenVRRenderLoop::SubmitFrameWithTextureHandle [0x052D8C2F+323]
	device::mojom::VRPresentationProviderStubDispatch::Accept [0x0399C195+1089]
	device::mojom::VRPresentationProviderStub<mojo::RawPtrImplRefTraits<device::mojom::VRPresentationProvider> >::Accept [0x052D9963+19]
	mojo::InterfaceEndpointClient::HandleValidatedMessage [0x03562159+541]
	mojo::FilterChain::Accept [0x0441F4F3+131]
	mojo::InterfaceEndpointClient::HandleIncomingMessage [0x03563006+106]
	mojo::internal::MultiplexRouter::ProcessIncomingMessage [0x0356658A+698]
	mojo::internal::MultiplexRouter::Accept [0x03566111+295]
	mojo::FilterChain::Accept [0x0441F4F3+131]
	mojo::Connector::ReadSingleMessage [0x03560830+364]
	mojo::Connector::ReadAllAvailableMessages [0x03560F0D+87]
<snip>

Bug: 853790

Original change's description:
> Add an interface to communicate between the fake openvr and tests
> 
> This change creates a way for tests to control the behavior of
> the fake OpenVR, and allows devices to send information up to
> tests.
> 
> BUG=801034
> 
> Change-Id: Ie0fe035ada9553114c054717f52788d375d5c62f
> Reviewed-on: https://chromium-review.googlesource.com/1100157
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567725}

TBR=jam@chromium.org,bsheedy@chromium.org,billorr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 801034
Change-Id: Ie55238c46b1d9c34d92bee2b6324539912b47846
Reviewed-on: https://chromium-review.googlesource.com/1104837Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568093}

https://android-review.googlesource.com/c/platform/system/connectivity/shill/+/181040
replaced the "HostName" property in the shill Manager interface with a new
"DHCPProperty.Hostname" property. However, the migration was partially done,
which has been fixed by CL:1102152. This CL updates the code on the Chrome side
accordingly.

Bug: 852035
Change-Id: Ib0d7fc7e82f13b9f77cda13324702f610d952f61
Reviewed-on: https://chromium-review.googlesource.com/1104312Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568092}

We would like to start a Finch trial for surface sync on Android soon.
This CL re-enables Android-specific surface invariants violations checks
on Android by removing code in RenderWidgetHostImpl that bypasses those
checks. This CL also ensures that when the background transparency
changes a new LocalSurfaceId is allocated as this matches the behavior
pre-surface-sync.

Bug: 672962, 789259, 801350
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iad2dc6c508770314ea33eb53f05944609f29b0b9
Reviewed-on: https://chromium-review.googlesource.com/1104315Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568091}

NavigationRequest calls ProceedWithResponse if network service
isn't enabled because MojoAsyncResourceHandler depends on this.
Since we want to start using BlobURLLoader before network service
ships, this means BlobURLLoader.ProceedWithResponse can also be
called and thus shouldn't be a NOTREACHED. Replace with an empty
implementation instead since it isn't pausing the response anyway.

Bug: 800901
Change-Id: I7edc6a1b20f5aac2fa312a3a2770424464cf12df
Reviewed-on: https://chromium-review.googlesource.com/1103061
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568090}

While not as common of a pattern as storing base::Time in Prefs, it
does show up in a few places, and is the logical continuation of the
Set/GetTime() methods that we currently have.

Change-Id: Ib38c2f4b431733bc4f40323756ea5fc6f68dfbed
Reviewed-on: https://chromium-review.googlesource.com/1103147
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568089}

Applies a 20% black overlay on a custom background image, uses white font text,
and a white settings icon.

Bug: 850312, 851285
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia6cab65d08bc6e54a42b78732b42b9cd4d8dc549
Reviewed-on: https://chromium-review.googlesource.com/1098557
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568088}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ida6455c2902b342a5f1fb9cfab0a3cb9bf17836c
Reviewed-on: https://chromium-review.googlesource.com/1104894Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568087}

Bug: 852922
Change-Id: I2db33fb3dd5f13dda3420965e72d8aa92695ffe5
Reviewed-on: https://chromium-review.googlesource.com/1103539
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568086}

This patch removes CachedRunSegmenter, introduced in
CL:1053346, because CL:1083914 supercedes this improvement
by LayoutNG not invoking RunSegmenter multiple times.

Other recent changes such as pre-allocating are preserved
as they are still valid.

Bug: 636993, 645035
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I83e74a58b79b856df1f046b7fa90b485609cd85a
Reviewed-on: https://chromium-review.googlesource.com/1087191Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568085}

Instead of this ownership model

  LoginDisplayHost owns ExistingUserController owns LoginDisplay
  LoginDisplayHost owns WebUIScreenLocker owns LoginDisplay

switch to

  LoginDisplayHost owns ExistingUserController, LoginDisplay

This makes it clear that the LoginDisplay instance has one owner, and
that it shares the same lifetime as LoginDisplayHost.

Bug: 851012
Change-Id: I80cb56d8fc244ce5331046ba31defba4cd77c45f
Reviewed-on: https://chromium-review.googlesource.com/1093741Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568084}

Bug: none
Test: manual on device
Change-Id: I93f2ce564ac1c519c0769432822f64ee858f03db
Reviewed-on: https://chromium-review.googlesource.com/1104313Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568083}

This is needed for browser-initiated same-document back-forward
navigations. When the context is created it is unknown that navigation
will be a same document navigation, so the flag should be updated
later.

Bug: 853063
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I93b4a7e2cfb9de56bd211d11298073fed28953ab
Reviewed-on: https://chromium-review.googlesource.com/1102116Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568082}

This CL adds tests that verify that Cross-Origin Read Blocking (CORB)
won't block HTTP responses for requests initiated by plugins that have
been granted universal access (like Flash which has its own CORS-like
mechanism - crossdomain.xml).

In addition to running tryjobs, I've also tested this CL by temporarily
editing CrossSiteDocumentResourceHandler::ShouldBlockBasedOnHeaders to
comment out the exception carved out for plugins (the new
TestTrustedCorbEligibleRequest test expectedly failed with such an edit
both with and without NetworkService).

Bug: 846339
Change-Id: I7b7befff3018ed5a7bd834b2bf0507c2e1f6365b
Reviewed-on: https://chromium-review.googlesource.com/1101300
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568081}

We have introduced maxWidthLandscape and maxWidthPortrait, so maxWidth
can be removed, because:

1. Functionality overlap, and unnecessary complexity when using this
widget.

2. maxWidthLandscape/maxWidthPortrait can force people to notice
the difference between landscape and portrait views.

TBR=twellington@chromium.org

Bug: 852545
Change-Id: I3532701b3886969d8232a348ae36738ea3dc4259
Reviewed-on: https://chromium-review.googlesource.com/1099774
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568080}

These are the params that we have been using in the server-side field trial.

Bug: 760294
Change-Id: I625e8c41b8acc005edaec8515b617198013b775a
Reviewed-on: https://chromium-review.googlesource.com/1104778Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568079}

Also changes some BookmarksTestCase instance methods to class methods to be shared amongst test
cases.

Bug: 853348
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I99f57091ff0a05a9caa90a60074c0da77cf68920
Reviewed-on: https://chromium-review.googlesource.com/1103610
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568078}

Add VLOG for
1) Token status
2) Enrollment process
3) Policy fetch process (not include the one sent after cache loading)
4) Policy cache load request.

The log will be enabled by --vmodule=machine_level_user_cloud_policy_*=1

Bug: 853364
Change-Id: I8fc6a210513bccd55e3b5d4388969ffc713ce27f
Reviewed-on: https://chromium-review.googlesource.com/1103303
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568077}

Bug: 844914
Change-Id: Ie38db098ec0e540b4425a42500c43263ed57119f
Reviewed-on: https://chromium-review.googlesource.com/1102492Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568076}