- 09 Dec, 2020 40 commits
-
-
Xing Liu authored
This CL implements the core code for weekly notification. 1. When chrome starts, if we have unread page and no notification is scheduled, schedule a new one. 2. Before showing the notification, update the unread page count text. And schedule a new one if needed. The code to open bookmark UI from notification is not implemented in this CL. Bug: 1139073 Change-Id: I7b723ac3b6457ca1cd9c4302316806aa22db8e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558960 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#835041}
-
Mei Liang authored
The TabProperties.TAB_CLOSED_LISTENER and TabProperties.TAB_SELECTED_LISTENER properties can be null when Instant Start is enabled. This CL fixes the crash by performing a null check. Bug: 1153604 Change-Id: If1539f457023bff3de18e6a337e97daa53c6fc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580399 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835040}
-
Peng Huang authored
This is a reland of bc24c252 add failed vulkan related test in the filter. Original change's description: > Disable Vulkan for LACROS > > Bug: 1155622 > Change-Id: I8def57cef648ec4881f666aec614200d13eac972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577815 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834507} Bug: 1155622 Change-Id: I9dde50222a5d947eab2c8b63bbcd6c5d8f4409fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578170 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835039}
-
Xianzhu Wang authored
Previously we discard subpixel accumulation for all transform animations in case that the transform animation may apply a transform though which the subpixel accumulation can't be propagated, e.g. scale, rotation. However, for a translation-only animation, this caused different pixel-snapped offset of the element from the pixel-snapped offset before the animation and maybe 1 pixel glitch at start/end of the animation. Now check if the transform animation is translation only, and if yes, allow propagation of the subpixel accumulation. Bug: 1155029 Change-Id: I0cf759721b6c121f22310a445b679c7283973889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578387Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835038}
-
Brian Sheedy authored
Adds a new version of the GPU unexpected pass finder script backed by ResultDB. This allows it to now detect cases of a test expected to be flaky but passing 100% of the time, along with a number of other improvements such as outputting to a more readable HTML file. Bug: 998329 Change-Id: I96dec74a355c075bfd4badc7bc4e5c5107b950d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548644 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#835037}
-
Frank Tang authored
Make IOS smaller https://chromium.googlesource.com/chromium/deps/icu.git/+log/6a33b647c..8bb622 TBR=jshin@chromium.org Bug: 1133219 Change-Id: I7e39dbe68b6ef51b1dadca867e2cfd1c0b1cb0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580108Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835036}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99b0e4a5f4c0..0e323e7bff96 2020-12-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9a01c2d7dc575fc6ab76f0798faef071dc6eb8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835035}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/963b0a6bd915..66f231597428 2020-12-09 miu@chromium.org Remote virtual connections [2/3]: Add Open/CloseRemoteConnection(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib6ae966a41edcf8d556fcef7a7728b627200f04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581065Reviewed-by:
-
WangHui authored
Update AndroidProtocolHandler to use GURL. BUG=783819 Change-Id: I0fc389fe4190b4263562566e35d6525c32837dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578876 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835033}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607417661-b29be925ba4468c1cb5f7aba9df03f08f5d1a452.profdata to chrome-win64-master-1607450253-68d0fa295c41f196aa098d193a0a21605dcba7f2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id43bab467d3d7e9394c320b41a03283baad4b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580579Reviewed-by:
-
Noel Gordon authored
Remove redundant (non-files-ng) file_types.css filter rule. CL:2094516 removed this CSS filter rule use in files-ng for reference. Bug: 1102263 Change-Id: I1160d2a2ac332010164456c20362425d191d1dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581158Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835031}
-
James Vecore authored
The nearby-preview element was missing it's mojo deps html imports. It was passing tests when optimize_webui=true because other files were resolving the dependency in the bundle. Fixed: 1156833 Change-Id: Idf3022f74475c7ca2de021fc15d974104425b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580909 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#835030}
-
Liquan (Max) Gu authored
Motivation: * Context is the low level details that PaymentUiService should not care about, so this CL delegate the context getter to its callers. * Chrome is moving away from unnecessarily depending on ChromeActivity, so this CL replaces some ChromeActivity use cases with Context. Bug: 1154371 Change-Id: I826d2c531b986ec1498435e175b5b0834112de0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580084Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835029}
-
Julie Jeongeun Kim authored
This CL adds checking if PrintCompositeClient exists on PrintViewManagerBase::SetAccessibilityTree() since it could be null with oopif configuration. Bug: 1155909 Change-Id: I15e6b073b60f7a1889ff5b97e4ab27039538a3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574643Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#835028}
-
Joe Mason authored
Eliminate the dependency on content/ by passing a callback to bind the mojo interface instead of looking up the RenderThread. This unblocks the removal of the components/renderer/performance_manager directory. R=bgeffon Change-Id: Id2d8ebe02e1234e30a9befc824927ac4bfc3b57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575604Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#835027}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607450253-17283bab00baae11cd74f4b35406a0ad23f10e88.profdata to chrome-linux-master-1607471901-85f06a8978ebf1d40d9cf80572b77a4ab0bcfbe1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1e52fdfc7a11e5dca6a3e65679a987f49af95c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580051Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607450253-216f09df6b61ffe8dbd79a2c1e7354b5e42173e1.profdata to chrome-mac-master-1607471901-3e959809a33b2895908083a52c31919f2827c11a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idda6bd8435a3153fa753f511161b4dfaf9b2301f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580050Reviewed-by:
-
John Chen authored
This reverts commit a6b685e4. Reason for revert: Bug https://crbug.com/1142286 has been fixed. Original change's description: > [Perf] Disable startup.mobile/cct:coldish:bbc > > Disable failing perf story startup.mobile/cct:coldish:bbc on two > Android platforms: > * https://ci.chromium.org/p/chrome/builders/ci/Android%20Nexus5%20Perf > * https://ci.chromium.org/p/chrome/builders/ci/android-pixel2-perf > > Notry: true > TBR: wenbinzhang@google.com > Bug: 1142286 > Change-Id: Ie742c8570505bcf100b804ed4686285143aebf5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570857 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833188} TBR=johnchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142286 Change-Id: Iaefecf53f849bd9b61b8039088c101a825e67e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578752Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835024}
-
Kunihiko Sakamoto authored
This field is set by the Network Service, for resources loaded from WebBundles. In follow-up CLs, this field will be used by the browser process to determine site isolation / network isolation keys for subframe loading with urn:uuid resources from WebBundles. Bug: 1082020 Change-Id: Ibeb8f9b35649a99d29e117104f7d960b44a305b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576310 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835023}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to https://chromium.googlesource.com/chromium/src.git/+/master/docs/lacros.md#gn-var-and-c_macros-for-lacros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I17c77521ce2902225352e425cc4a6dfb94a939b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536429Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch adds a new structure CounterStyleMap to each tree scope. There is also one map for user rules, and one map to user agent rules. CounterStyleMap indexes all the counter styles defined in the tree scopes, and also has logic for: - Given a tree scope and a name, resolving the tree-scoped reference following proposal [1] - Resolve and update 'extends' and 'fallback' references after active style changes Note that we cannot share CounterStyleMap between tree scopes even if they have the same rule set. This is because the same rule may have its 'extends' and 'fallback' resolved differently when used in different tree scopes. The complicated parts are: - We must resolve references in parent scope before child scopes, but ScopedStyleResolver::AppendActiveStyleSheets() is not called in the tree order - We need to update references when active style changes. Moreover, an active style change in one tree scope may affect references in the child scopes, and it's hard to keep track which tree scopes are affected. So we end up updating all unconditionally - We need to detect cycles in 'extends' Therefore, the reference resolution and update is done for all tree scopes at the end of StyleEngine::UpdateActiveStyleSheets(). [1] https://github.com/w3c/csswg-drafts/issues/5693#issuecomment-736868418 Bug: 687225 Change-Id: Ib907103438c5c996f6abfc81f4ff22fd932a827a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574064 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835021}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607417661-75f85540ed87ef8a12b8b8faecb9dcd6afc972b8.profdata to chrome-win32-master-1607450253-e5743bc31deb2e7a7a12ff155c587ac00d61c43d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37b914a5482894738c9ac5f66c1a8c74647b3b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579829Reviewed-by:
-
Josh Nohle authored
After the user selects a device to send a payload to, but before the payload transfer commences, the sending device initiates the creation of a secure connection to the receiving device via the Nearby Connections library. In this CL, we track whether this attempt to establish a connection succeeds, fails, or is cancelled by the user. For successful attempts, we also track the time needed to set up the connection. Because the sender initiates the connection, these metrics are only logged for outgoing connections. Manually verified for successful, failed, and cancelled attempts. Bug: 1105579 Change-Id: Ife7a5f23e59f657f5c4310a586b004ffe81d1d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580705 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#835019}
-
Mohsen Izadi authored
To be able to report compositor thread event dispatch breakdowns for EventLatency metrics, this CL adds relevant timestamps to cc::EventMetrics. The actual breakdowns will be added to UMAs and UKMs in follow-up CLs. Since we expect all events have non-null timestamps, this CL updates some tests to use non-null timestamps for events they create. Bug: 1054009 Change-Id: I106e535fe12e255055d21edf22295f8e94f5fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554398Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835018}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: I7d5a32b43de29f65478b0b20a8d61052262f8cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578018 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#835017}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf980426002..a737e5f65ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idc7cc66bdff8ad777cccb838bebe7a8148eb7382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580911Reviewed-by:
-
Jason Lin authored
The old implementation is based on an older version of UX mock which shows two notifications (one camera and one mic) in this situation. Bug: b/167491603 Change-Id: I15ace40efec18509b971e7e2d8cb2b1b0c197eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576232 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#835015}
-
Alan Cutter authored
web_app_frame_toolbar_view.cc contains too many classes for comfort (7). This CL puts it (and related classes) under a frame_toolbar/ directory and splits the classes out to the following files: - web_app_content_settings_container.h/cc - web_app_frame_toolbar_utils.h/cc - web_app_navigation_button_container.h/cc - web_app_toolbar_button_container.h/cc This is a code move with no changes to behaviour. Any additional changes are to keep up with current style rules (e.g. using base::ScopedObservation over base::ScopedObserver). Bug: 1155421 Change-Id: I28abd997ff87d9e4e96e1f5a3bea21c029ae3fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576988Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#835014}
-
Miyoung Shin authored
This is a reland of dde99fda with a fix of a flaky failure on the android-marshmallow-x86-rel-non-cq trybot. Original change's description: > [remoteobjects] Add JavaBridgeBasicsTest#testWebViewAfterRenderViewSwapped > > This CL adds JavaBridgeBasicsTest#testWebViewAfterRenderViewSwapped > to recreate the regression scenario described in > https://crbug.com/572053, and to verify that the new code works as > expected. > > Bug: 1105935 > Change-Id: Ie527f0c452a9d3eac7fe0c91797b792eff15c23d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564931 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#832636} Bug: 1105935 Change-Id: Ia92d656122f7dbca2030fd0dc87e366c307945f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571034 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#835013}
-
Leo Lai authored
This issue can be reproduced with enable_nacl = false on top of linux chromos build. BUG=b:172748724 TEST=browser_tests. Change-Id: I27fb8322985dc04fae8b1cb8fb2c5b5ba2b9f510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577393Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#835012}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4997984ca190..e213663d1bc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com,jrw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com,jrw@google.com Change-Id: Ifed282e536f7e3f4491008e338c44248333ebcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835011}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: I070ca9c5be3eebcb093aba2e7237d938745b189f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577725Reviewed-by:
-
Andres Calderon Jaramillo authored
This is a reland of 09825450 No changes are made to the original CL. The original change was reverted because "Cast Audio Linux" was failing to build [1]. It looks like this happened not because of the change but because //media/gpu/chromeos/BUILD.gn was taking effect in Chromecast unintentionally which triggered an assert in one of the dependencies. The root cause was that use_vaapi was getting set to true for Chromecast and this is fixed by [2]. [1] https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/92923/overview [2] https://chromium-review.googlesource.com/c/chromium/src/+/2580449 Original change's description: > media/platform_vf_utils: Handle null GMB factory. > > This CL handles a null GpuMemoryBufferFactory in > AllocateGpuMemoryBufferHandle() so that the caller is not obligated to > pass a valid factory. This is in preparation for follow-ups CLs to > remove the need for video encode accelerators to have access to a > GpuMemoryBufferFactory. > > When the GpuMemoryBufferFactory is null, we just use the render node > directly to allocate a native buffer object and then we wrap it into a > GpuMemoryBufferHandle. > > So, why do we still keep the option to have a non-null > GpuMemoryBufferFactory? This is because that path is still useful in the > decoding case: when a buffer is created with the GpuMemoryBufferFactory, > the corresponding NativePixmap is cached [1]; eventually, a SharedImage > needs to be created and to do so we pass the GpuMemoryBufferHandle > obtained from the factory [2]; when the SharedImage system needs to > create the GLImage for the buffer, it passes the handle to the > factory [3] which in turn uses it to look up the cached > NativePixmap [4]. This saves us from going through a gbm_bo_import() > (which also implies a thread hop to the DRM thread). > > So, in conclusion, for buffers that need to be displayed later, it's > still better to use the GMB factory owned by the GpuServiceImpl. For > encoders this is not the case. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc;l=319;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > [2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/chromeos/mailbox_video_frame_converter.cc;l=355-359;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > [3] https://source.chromium.org/chromium/chromium/src/+/master:gpu/command_buffer/service/shared_image_backing_gl_texture.cc;l=355-356;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > [4] https://source.chromium.org/chromium/chromium/src/+/master:gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc;l=164-172;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > > Bug: b:173167846 > Test: video.EncodeAccel.h264_720p_nv12_dmabuf on elm > Change-Id: I7b730eb843da7503c61bffe30dce7a5ce51dec60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568937 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834608} Bug: b:173167846 Change-Id: I88b4849b01de86e7f2783db22561e8160a1f7a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579646Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835009}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/158089fdd8be..f691b3b5096a 2020-12-08 syoussefi@chromium.org Vulkan: Support PrimitivesGenerated query 2020-12-08 jonahr@google.com GLX: Expose EGL_ANGLE_window_fixed_size 2020-12-08 courtneygo@google.com Vulkan: Add ensureSubmission to queueSubmitOneOff 2020-12-08 kbr@chromium.org Log to stderr for warnings and more severe messages. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132827 Tbr: syoussefi@google.com Change-Id: I2fa979cb278ac952d3cfa6e4eaaaedacdaadb5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579877Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26a24ee9aebf..a737e5f65ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibf090b0d4036f5fc22d9c6a913d48c05a126390f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580582Reviewed-by:
-
Nicholas Hollingum authored
We extend the BorealisWindowManager to track the lifetime of individual windows, apps (as collections of windows) and the session (as collections of apps. This new observer was kept separate from the already-present anonymous observer as the two have limited overlap, and are not used simultaneously by any clients (currently). We also implement a trivial watcher in the BorealisContext which joins the new session-observing behaviour with the ShutdownMonitor. This watcher will only be active while the context exists so we will not accidentally issue shutdown requests while the vm is not running. Bug: b/172006764, b/172979315 Change-Id: Ie58c87acbb14eebe41152986f6b86032a5d8c759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576876 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#835006}
-
Peter Qiu authored
Enable accelerated video decode for Cast devices that supports v4l2 codec. Bug: internal b/174596074 Test: manual on device Change-Id: I650a997309b2edb51721baec94cfd034b13f655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568857Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835005}
-
Amr Aboelkher authored
In case the private set membership is in progress, and RetryStep has been called, the PrivateSetMembershipRetryStep should return true to prevent Hash dance protocol from executing while private set membership is in progress. This CL is preventing that parallel execution from occurring, along with its required regression tests. BUG=chromium:1156119 Change-Id: I06d25b1fd1171d4b680b5d6b0be21bdb2282a518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577216 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Lijin Shen authored
Mock deps to see if dispatcher can suspend and resume correctly. Bug: 1155359 Change-Id: Ib0705da0d15795da0a36b5b2b778808d3feacec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573503Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#835003}
-
Wei Li authored
For MacViews, most of text editing commands are already supported. This CL adds the four scroll commands which also have default key bindings: scrollPageUP, scrollPageDown, scrollToBeginningOfDocument, scrollToEndOfDocument, This CL adds comments about the other three commands with default key bindings that we still don't support yet. Test: Press Ctrl+Up/Down should move cursor to the beginning/end of the page. Press HOME/END should move cursor to the beginning/end of the document. If tested on textfield, it will move to the line's beginning or end instead since textfield only supports single line so far. Bug: 586985 Change-Id: I31dd16fce56fb6d8f4f01a094e80ed35d409baa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575948Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#835002}
-
