GitLab

calculateTransformationToOutermostCoordinateSystem() should stop at the
first composited layer to match its backing resolution. Currently, we
are incorrectly taking the layer transform into account (the stop
condition is off by one).

R=pdr@chromium.org,schenney@chromium.org,senorblanco@chromium.org

BUG=345441

Review URL: https://codereview.chromium.org/196413023

git-svn-id: svn://svn.chromium.org/blink/trunk@169472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Forward positional rules only affect selector matching of siblings when
nodes are added to or removed from the DOM. However, selectors with indirect
adjacent combinators may affect sibling evaluation without node addition or
removal. For instance if a class selector left of an indirect adjacent
combinator is set on an element.

Since the indirect adjacent combinator was considered as a forward
positional rule, we were recalculating sibling styles in the presence of an
nth-selector. We now split indirect adjacent selector matching as a separate
flag to be able to optimize recalc in the presence if nth-selectors and
skip sibling recalc for forward positional rules if no mutations happened.

ElementRareData and ShadowRootRareData do not increase in size since they
were already padded in the relevant parts.

R=ojan
BUG=160212

Review URL: https://codereview.chromium.org/198783003

git-svn-id: svn://svn.chromium.org/blink/trunk@169471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Android builders fail compile

One exampel: http://chromegw.corp.google.com/i/chromium.webkit/builders/Android%20Builder/builds/36609

> Move deferred loading logic from WebMediaPlayerClientImpl to HTMLMediaElement.
> 
> BUG=350571
> TEST=All layout tests still pass.
> 
> Review URL: https://codereview.chromium.org/192013002

TBR=acolwell@chromium.org

Review URL: https://codereview.chromium.org/203213006

git-svn-id: svn://svn.chromium.org/blink/trunk@169470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use them to avoid data races in the SafePointBarrier discovered by TSAN and guarantee that compiler does not move any memory accesses around m_unparkedThreadCount and m_canResume loads.

This change is likely to affect only ARM with its weakly ordered memory model.

BUG=347559

Review URL: https://codereview.chromium.org/199413012

git-svn-id: svn://svn.chromium.org/blink/trunk@169469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added missing null ptr check.

BUG=353248

Review URL: https://codereview.chromium.org/203293005

git-svn-id: svn://svn.chromium.org/blink/trunk@169468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This regression was introduced in r168256. The previous behavior
depended on whether Frame had already been garbage collected after being
removed from the DOM. If it had not been garbage collected yet, then it
would return a Performance object, but if it had, then it would return
null.

This patch adds the now-necessary check that frame is non-null and makes
the behavior consistent whether or not the underlying Frame object has
already been garbage collected, which makes Firefox's behavior.

BUG=350978
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/203053002

git-svn-id: svn://svn.chromium.org/blink/trunk@169467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION() macro that generates better
type helpers for HTML Elements:
- Generates more isHTML*Element() helpers that are consistent with the ones
  in HTMLElementTypeHelpers.h so that there is no different in behavior /
  supported arguments.
- Supports more efficient isHTML*Element() helpers that take an HTMLElement
  in argument and thus don't need to check the namespace URI, only the local
  name.

R=esprehn, adamk
BUG=346095

Review URL: https://codereview.chromium.org/202813005

git-svn-id: svn://svn.chromium.org/blink/trunk@169466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571
TEST=All layout tests still pass.

Review URL: https://codereview.chromium.org/192013002

git-svn-id: svn://svn.chromium.org/blink/trunk@169465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These should be replaced by SkColorType and SkImageInfo.
In many cases, shortcut methods like SkBitmap::allocN32Pixels can be used.

BUG=

Review URL: https://codereview.chromium.org/201213002

git-svn-id: svn://svn.chromium.org/blink/trunk@169464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the same url is revalidated multiple times, the first revalidation may end
up being incorrectly left in an LRU list after it is deleted. This is because
we have an early exit in removeFromLRUList() when the resource's accessCount()
is zero, even though we unconditionally put the resource in an LRU list when
it is added to the cache. We increment accessCount for the new resources case
in add(), but not the successful revalidation case in replace().

(All of these bugs are most likely the same root cause, but it's not absolutely certain)
BUG=353035,352538,352444
TEST=MemoryCacheTest.MultipleReplace

Review URL: https://codereview.chromium.org/202243003

git-svn-id: svn://svn.chromium.org/blink/trunk@169463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

sheets.

Comment on the cases where the raw pointers cannot be removed at this point.

Leave the raw pointers in inspector/ alove. They are safe as they are
now because the inspector leaks all the CSSStyleSheets it is inspecting
via Persistent handles at this point (and used to leak them all via
RefPtrs.)

Review URL: https://codereview.chromium.org/196513007

git-svn-id: svn://svn.chromium.org/blink/trunk@169462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix handling of BDO (bidirectional override) elements by explicitly
checking for bidi override in RenderText and using the specified
direction instead of resolving based on content.

R=leviw@chromium.org
BUG=352160
TEST=fast/text/international/bdo-bidi-width.html

Review URL: https://codereview.chromium.org/197883020

git-svn-id: svn://svn.chromium.org/blink/trunk@169461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to carry out the nullptr assignment to m_workerGlobalScope
before notifying the proxy that the worker thread is going away. 
Otherwise, the main thread could destroy the WorkerThread object 
which owns the m_workerGlobalScope persistent before the assignment 
and that would lead to a use-after-free.

It turns out that there are objects that keep the execution context
alive in order to be able to determine if they are being destructed
on the right thread. Therefore, clearing out the thread member
in WorkerGlobalScope cannot be done before the WorkerGlobalScope
is actually dead. Therefore, the larger change that Sigbjorn did
will not work. (One example of this kind of dependency is
SQLCallbackWrapper.)

We need to just keep the thread member intact and let objects
die normally. The call to detach needs to happen before we
actually kill the worker thread because finalizers need to
be able to access thread local data.

Review URL: https://codereview.chromium.org/203233004

git-svn-id: svn://svn.chromium.org/blink/trunk@169460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This flag has been removed from newer versions of the specification.

BUG=353337

Review URL: https://codereview.chromium.org/200763008

git-svn-id: svn://svn.chromium.org/blink/trunk@169459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a fix for a regression introduced in r161635

BUG=353221
R=pfeldman, lushnikov

Review URL: https://codereview.chromium.org/203183002

git-svn-id: svn://svn.chromium.org/blink/trunk@169458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On Android we can save copying the bitmap if the decoder writes directly
to the discardable memory.

All webkit_unit_tests passed with this change.

BUG=352570

Review URL: https://codereview.chromium.org/198603003

git-svn-id: svn://svn.chromium.org/blink/trunk@169457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Remove spurious check for invalid value.
> 
> The isCSSPrimitiveValue check is likely covering up parser bugs,
> and toCSSPrimitiveValue has the assert to ensure we're not
> doing something bad.
> 
> R=eae,ksakamoto@chromium.org,timloh@chromium.org
> BUG=
> 
> Review URL: https://codereview.chromium.org/184103034

BUG=350509
TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/203583004

git-svn-id: svn://svn.chromium.org/blink/trunk@169456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When allocation stack trace is selected in the allocation view summary view underneath it is populated with information about live heap objects allocated with that stack trace.

BUG=277984
R=alph@chromium.org

Review URL: https://codereview.chromium.org/203403002

git-svn-id: svn://svn.chromium.org/blink/trunk@169451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sergeyv@chromium.org, vsevik@chromium.org, aandrey, sergeyv, vsevik

Review URL: https://codereview.chromium.org/202813004

git-svn-id: svn://svn.chromium.org/blink/trunk@169450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These cleanups should have been included in r169430.

BUG=353087

Review URL: https://codereview.chromium.org/202853003

git-svn-id: svn://svn.chromium.org/blink/trunk@169449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch ensures layers are created for any current animation (an
animation that has yet to play, or is playing) which should also
composite.

Previously layers were only created for animations once they had applied
an effect to the style (opacity, transform, ...), but this is too late
to allow a compositor animation to start when the animation specifies a
delay.

This change appeared to allow several hacks to be cleaned up as it's no
longer necessary to massage the interpolation output for opacity and
transform in order to ensure layer creation. However this is actually
required for transforms[1]. Tests and comments updated to clarify.

[1] http://www.w3.org/TR/css-transforms-1/#none-transform-animation
BUG=321926, 344809

Review URL: https://codereview.chromium.org/189883003

git-svn-id: svn://svn.chromium.org/blink/trunk@169448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderStyle* m_style on FontBuilder doesn't get initialised in the
constructor. The majority of methods on FontBuilder will attempt to deref
it as a garbage raw pointer if they get called before initForStyleResolve()
is called.

Review URL: https://codereview.chromium.org/197883021

git-svn-id: svn://svn.chromium.org/blink/trunk@169447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop Element::isHTMLFrameElementBase() virtual function and have
isHTMLFrameElementBase() helper use the isHTML*Element() helpers instead.
This is more consistent with other HTML Elements and simplifies the code
a little bit.

R=tkent, adamk
BUG=346095

Review URL: https://codereview.chromium.org/197873022

git-svn-id: svn://svn.chromium.org/blink/trunk@169446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- change PlatformInstrumentation events to use "devtools" as category
- change category filter to only include "devtools"

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/180783016

git-svn-id: svn://svn.chromium.org/blink/trunk@169445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Explicit notification and removal of lifecycle observers. (https://codereview.chromium.org/194923007/)

Reason for revert:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/workers/storage/interrupt-database.html,http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dedicated_worker.html,http/tests/xmlhttprequest/workers/referer.html,http/tests/xmlhttprequest/workers/xmlhttprequest-response-type-blob.html

Original issue's description:
> Explicit notification and removal of lifecycle observers.
> 
> To help make disposing of execution contexts cleaner in a setting
> where both a context and its lifetime observers are being finalized
> by a garbage collector, add support for explicitly clearing out
> all lifecycle observers:
> 
> protected:
>   void LifecycleNotifier<T>::removeAndNotifyAllObservers()
> 
> Notifying them that the context has been destroyed while doing so.
> An operation that was previously (only) done by the LifecycleNotifier
> destructor.
> 
> Also provide a convenience method over ExecutionContext for clearing
> out its observers:
> 
>   void ExecutionContext::removeAllLifecycleObservers()
> 
> The operation is used here when shutting down and finalizing a worker
> thread and its global scope -- explicitly severing the connection
> of all observers to its execution context before performing the
> final garbage collection.
> 
> Doing so ensures that all observer objects being finalized during that
> garbage collection will not have access to its execution context object.
> A heap object that may or may not have been finalized by the garbage
> collector already.
> 
> R=haraken@chromium.org,ager@chromium.org,abarth@chromium.org
> BUG=340522
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169435

TBR=oilpan-reviews@chromium.org,abarth@chromium.org,haraken@chromium.org,ager@chromium.org,eseidel@chromium.org,tkent@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=340522

Review URL: https://codereview.chromium.org/203393002

git-svn-id: svn://svn.chromium.org/blink/trunk@169444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: once migrated to document-based stylesheet processing there is no need to track changes to frames.

Review URL: https://codereview.chromium.org/203153002

git-svn-id: svn://svn.chromium.org/blink/trunk@169443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov, pfeldman

Review URL: https://codereview.chromium.org/201293007

git-svn-id: svn://svn.chromium.org/blink/trunk@169442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov
BUG=353016

Review URL: https://codereview.chromium.org/197283031

git-svn-id: svn://svn.chromium.org/blink/trunk@169441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes run-bindings-tests faster by doing more work in
Python, instead of going out to the OS.
Notably: calling Python compiler directly (reusing a compiler object),
instead of launching separate processes, and
avoiding a temporary file for interfaces_info.

(Earlier versions had many refactoring changes,
which improve support for Dart CG and other backends,
which Nils broke off and committed separately.)

R=nbarth

Review URL: https://codereview.chromium.org/169743005

git-svn-id: svn://svn.chromium.org/blink/trunk@169440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Display MathML fallback content when it is specified and take into account inline/display modes for mathematical formulas. This is important for Web authors because Blink does not support MathML yet.

R=ojan@chromium.org,eseidel@chromium.org,jchaffraix@chromium.org
BUG=chromium:324764,chromium:152430

Review URL: https://codereview.chromium.org/138383003

git-svn-id: svn://svn.chromium.org/blink/trunk@169439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

it from being reused as-is from the binary. This changes it to make
the storage more compact by replacing pointers with offsets into a
shared string. Also switching to more compact data types.

The new database will look like:

static const LChar staticEntityStringStorage[] = {
'A', 'E', 'l', 'i', 'g',
';',
'A', 'M', 'P',
';',
'A', 'a', 'c', 'u', 't', 'e',
';',
...

static const HTMLEntityTableEntry staticEntityTable[2231] = {
    { 0x000C6, 0, 0, 5 }, // &AElig
    { 0x000C6, 0, 0, 6 }, // Æ
    { 0x00026, 0, 6, 3 }, // &AMP
    { 0x00026, 0, 6, 4 }, // &
    { 0x000C1, 0, 10, 6 }, // &Aacute
...

The binary will shrink by about 20-35 KB (depending on architecture),
the memory usage should shrink by similar numbers for every
renderer (since the memory now can be shared between renderers) and
there will be a tiny startup time improvement due to
fewer relocation blocks and less to read from disk.

It accomplishes the savings by avoiding pointers in the data (resolving pointers
during startup is expensive), using one string instead of 2000+, not storing the
trailing NUL byte, ordering the members for minimum padding, using minimal size
data types and reusing the same string space for things like "amp;" and "amp".

BUG=352141

R=

Review URL: https://codereview.chromium.org/199103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FontBuilder must be properly initialised before font properties can be
applied to a RenderStyle.

BUG=352505,352506

Review URL: https://codereview.chromium.org/203193002

git-svn-id: svn://svn.chromium.org/blink/trunk@169437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since test return will be aync, introduced function to test query string return value.

This test fixes isuse introduced by fix for bug196640

R=keishi1, tkent
BUG=353066
TEST=Automated

Review URL: https://codereview.chromium.org/200613004

git-svn-id: svn://svn.chromium.org/blink/trunk@169436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To help make disposing of execution contexts cleaner in a setting
where both a context and its lifetime observers are being finalized
by a garbage collector, add support for explicitly clearing out
all lifecycle observers:

protected:
  void LifecycleNotifier<T>::removeAndNotifyAllObservers()

Notifying them that the context has been destroyed while doing so.
An operation that was previously (only) done by the LifecycleNotifier
destructor.

Also provide a convenience method over ExecutionContext for clearing
out its observers:

  void ExecutionContext::removeAllLifecycleObservers()

The operation is used here when shutting down and finalizing a worker
thread and its global scope -- explicitly severing the connection
of all observers to its execution context before performing the
final garbage collection.

Doing so ensures that all observer objects being finalized during that
garbage collection will not have access to its execution context object.
A heap object that may or may not have been finalized by the garbage
collector already.

R=haraken@chromium.org,ager@chromium.org,abarth@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/194923007

git-svn-id: svn://svn.chromium.org/blink/trunk@169435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As --enable-memory-info flag and web preference were removed from Chrome,
remove the corresponding WebSetting.

The internal setting is used by PerfTestRunner, so leave it, but rename to
"preciseMemoryInfoEnabled" for clarity.

BUG=350339

Review URL: https://codereview.chromium.org/196533018

git-svn-id: svn://svn.chromium.org/blink/trunk@169434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org, aandrey, eustas, vsevik

Review URL: https://codereview.chromium.org/202623004

git-svn-id: svn://svn.chromium.org/blink/trunk@169433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Similar to the CPU profiler there are top-down and bottom up allocation profile views. Data structures are renamed to use correponding naming scheme.

BUG=277984
R=alph@chromium.org

Review URL: https://codereview.chromium.org/202953003

git-svn-id: svn://svn.chromium.org/blink/trunk@169432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder should take a const reference to InsertedNodes

This method doesn't modify InsertedNodes object so that it can take a const reference.

BUG=

Review URL: https://codereview.chromium.org/200613003

git-svn-id: svn://svn.chromium.org/blink/trunk@169431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353087

Review URL: https://codereview.chromium.org/201683003

git-svn-id: svn://svn.chromium.org/blink/trunk@169430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There were three problems:

 1. When fullScreenEnabled() was false, HTMLMediaElement's
    enterFullscreen() was used as a fallback, but that function checks
    the setting and does nothing. This has been the case since cleanup
    from April 2013, r149489: https://codereview.chromium.org/14670004

 2. MediaController's hasVideo() returned true if any of the slave
    elements had video, which could show the button for a video element
    with no video.

 3. The fullscreen button didn't do anything for slaved media elements.

The added tests verify that (1) no fullscreen button is shown when the
fullscreen feature is disabled or (2) when there is no video track, and
(3) that clicking the fullscreen button actually enters fullscreen.

BUG=351661

Review URL: https://codereview.chromium.org/196793021

git-svn-id: svn://svn.chromium.org/blink/trunk@169429 bbb929c8-8fbe-4397-9dbb-9b2b20218538