- 18 Dec, 2019 40 commits
-
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: I40969058290445cafbf6159ee1c746f7cebbf620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971922 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#725927}
-
Niels Möller authored
It's an obsolete alias for rtc::PacketTransportInternal. Bug: None Change-Id: I1ca37dcec73a926cefd1a3b4b18e1a7cfb9e5c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960269Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#725926}
-
Rushan Suleymanov authored
There is no behavioural change. IsSyncAllowed was removed from Profile and callers were changed to ProfileSyncServiceFactory. Bug: 1015309 Change-Id: I3dc772fa7c920c2f8fff4369e3b5ffa33f8c7758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972839 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#725925}
-
Anupam Snigdha authored
This is the patch for the EditContext feature. It contains the layout bounds of the EditContext being sent to the text input service such as TSF on Windows. Currently this API is only implemented for TSF on Windows but it can easily be extended for other text input clients on different platforms. EditContext simplifies the process of integrating a web app with advanced text input methods such as IME, VK shape-writing, speech recognition etc. EditContext decouples text input from the HTML DOM view. Rather than having the web platform infer the data required to enable sophisticated text input mechanisms from the HTML DOM, the author will provide that data explicitly through the API surface of the EditContext. Additionally, EditContext communicates events driven from text input UI to JavaScript. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/ master/EditContext/explainer.md Bug: 999184 Change-Id: Ibe8c0e9db154fb316104f1b38de8ba08534464d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906470Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#725924}
-
Mikhail Khokhlov authored
This will help tell artifacts from different test runs. Bug: 1033755 Change-Id: I53107d16f687fd1d527f45cd9e979371aeb4e75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971923Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
-
Theodore Olsauskas-Warren authored
This CL removes reliance on the privacySettingsRedesign flag being enabled for M80 updated privacy settings. This ensures that the default behaviour of privacy settings matches the optional behavior in the M80 branch. This CL will allow the privacySettingsRedesign flag enabled state to clearly represent the additional functionality targeting M81. Code paths which were only present when the privacySettingsRedesign flag was disabled have been removed. Tests which existed exclusively to confirm the movement of settings worked correctly have also been removed. Bug: 1032584 Change-Id: I6a9774a7e4ff7bf418b1caa65fe936a9ae7af677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963858Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#725922}
-
Yifan Luo authored
with others. Bug: 1029742 Change-Id: I066ed32c469f107924af44c081eff79c679a2d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954481 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#725921}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e176740117f..b533f1d74117 Created with: gclient setdep -r src-internal@b533f1d74117 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I18a3a5d1e53a4aeebdc5e10ff2c4440232ba763c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972159Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725920}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f158ae7a0128..2abdc799d974 git log f158ae7a0128..2abdc799d974 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 mathias@chromium.org Restore sorted object property order in expanded view 2019-12-18 mathias@chromium.org Add dark themed radio dot image to BUILD.gn Created with: gclient setdep -r src/third_party/devtools-frontend/src@2abdc799d974 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1008910,chromium:1021175,chromium:989514 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69736639ef524c33ea21dbbb44b38630f65ef8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972163Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725919}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I4cfc7d91927d102727b5a2c91116d59e3e123e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970214 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I2837951706673d4770a7be5ba91844106c78a82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971551Reviewed-by:
-
Jason Lin authored
As a side effect, crostini::ShowCrostiniInstallerView() is replaced by crostini::CrostiniInstaller::ShowDialog(). Bug: 1026199 Change-Id: Iad2fcdd59f6cd43089e82726cc818dc60ee5fd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959186 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#725916}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/069e85f68694..5b3d06c520db git log 069e85f68694..5b3d06c520db --date=short --first-parent --format='%ad %ae %s' 2019-12-18 khokhlov@google.com Merge "trace_processor: Remove PERFETTO_TP_HEAP_GRAPHS build flag" Created with: gclient setdep -r src/third_party/perfetto@5b3d06c520db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib070468a1b4eef272e08c556a84f262676fe3987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972160Reviewed-by:
-
Anatoliy Potapchuk authored
Currently, when were failing to install the Web App in kiosk mode, we would silently try to run the app anyway(by loading the provided url). This could create the illusion for the clients that everything is working properly, this CL adds a text that displays to the user that we failed to obtain app data. Bug: 1034938 Change-Id: Ia263fd520a045f32180a2ef9afb8084469938100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970173 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#725914}
-
Oriol Brufau authored
This patch avoids triplicating the default styles for the ::marker pseudo-element in StyleResolver, LayoutListMarker and LayoutNGListItem. Now they will only be in StyleResolver. When no style has been specified for ::marker, using StyleResolver has some overhead that reduces the the flexbox_with_list_item.html perf test by 2%-5%. But unifying the code for ::marker styles seems worth it, since it will be necessary to avoid some inconsistences like the propagation of text decorations. BUG=457718 Change-Id: I9b30d43321f8076873256e20f97779bc279ec940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971929Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#725913}
-
Anastasiia Nikolaienko authored
Update expiry of OAuth2Login.SessionRestore, OAuth2Login.SessionRestoreTimeToFailure, OAuth2Login.SessionRestoreTimeToSuccess. Bug: 977137 Change-Id: Ie6d77b04f577efddc4d7ea91e9523117754e7330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970556Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#725912}
-
Francois Beaufort authored
This CL checks that infoColor is not null when looking for infrared support. This was causing a crash. Bug: 1033422 Change-Id: Ib8bd43f57088afad472865ecb9f22ce8ef96e8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972836Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#725911}
-
Yifan Luo authored
Following CL will user the new 'destination` enum and move `Sec-Fetch-Dest` into network::SetFetchMetadataHeaders: https://chromium-review.googlesource.com/c/chromium/src/+/1954481 Bug: 1029742 Change-Id: I671dcca4850a09f105c7d15cbe2304964b8f4575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953712 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#725910}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/751e78884a55..e5c2e047eea2 git log 751e78884a55..e5c2e047eea2 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 0c2618b2c31e..9c5719ab7149 (1 commits) Created with: gclient setdep -r src/third_party/angle@e5c2e047eea2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I3a99b53e6ef02ebf346dba803c088cb30421cc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972155Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c9c7b71c881..f158ae7a0128 git log 4c9c7b71c881..f158ae7a0128 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 janscheffler@chromium.org Fix TestRunner.js to print the stack again 2019-12-18 jalyn@microsoft.com Mark Changes drawer as tabpanel 2019-12-17 brgoddar@microsoft.com Datagrid: Update Role to Application and Add aria-labels for Nodes 2019-12-17 jalyn@microsoft.com Improve screen reader labels in Changes 2019-12-17 tvanderlippe@chromium.org Make accessibility/ non-remote 2019-12-17 tvanderlippe@chromium.org Run layout tests with dynamic import 2019-12-17 tvanderlippe@chromium.org Check JSON during upload Created with: gclient setdep -r src/third_party/devtools-frontend/src@f158ae7a0128 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ief0c57109e903c6efb5947af5e83008abd08d1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972154Reviewed-by:
-
Andreas Haas authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. Unfortunately the current implementation cannot deal with huge ArrayBuffers yet. Therefore I reject the incoming ArrayBuffers with a SynthesizeGLError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=kbr@chromium.org Bug: chromium:1008840 Change-Id: I96972b25473f03d0af80fa3d73e62bf41a49ecf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970172 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#725907}
-
Jason Lin authored
This is because CrostiniInstallerView is deprecated. Bug: 1026199 Change-Id: I537931516e93605dfea02290816c093f49a7ec9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958431Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#725906}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I946ac9151787d1b6710c73bbccfcf254c799f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971920 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#725905}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12dccfd4c1c9..2e176740117f Created with: gclient setdep -r src-internal@2e176740117f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1030491 Tbr: jbudorick@google.com Change-Id: Iec1014041ee132792db8e129128ff6f981c56ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972153Reviewed-by:
-
Joel Hockey authored
This matches xdg spec https://specifications.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html In particular, we are seeing that vscode installs with support for 'text/plain', and we want it to be listed as a valid app to open files of type 'text/javascript' from crostini as it does with xdg. Bug: 1032910 Change-Id: Ib2f7f2acba29c68f8f07920e346bfb1a89da0bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972735 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Before this CL, TouchToFill assumed that BottomSheetController::requestShowContent always succeeds. This is not the case if there is a BottomSheetContent currently being shown with higher priority. In practice, this can happen when autofill_assistant (a high-priority bottom sheet content) attempts to log-in on a website. The problem surfaces because TouchToFill prevents the soft keyboard from being shown. Thus, in an autofill_assistant flow, users would tap the login text input on the website, but the keyboard would not appear. After this CL TouchToFill UI is automatically dismissed if BottomSheetController::requestShowContent fails. Bug: b/145278496 Change-Id: Ifede88d513fc95692872ad001e538340f367f55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968993 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#725902}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.0-1576494869-benchmark-81.0.3995.0-r1 to 81-3987.0-1576494869-benchmark-81.0.3999.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I61daaf8dfedad956edc6b7fbcd127093076c3ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972157Reviewed-by:
-
Kent Tamura authored
If a ShadowRoot has delegatesFocus flag, focusing on its shadow host should be delegated to the first focusable element in the flat-tree order. Bug: 1014094 Change-Id: I32a13252ee868760bd4178974257ee7c871db345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961299 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#725900}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script Bug: chromium:878390 Change-Id: Ic9e7e7a25c133981441c2ec4b959a821f6fcf5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971550Reviewed-by:
-
Anton Bikineev authored
This is the result of running performance-trivially-destructible clang-tidy check. The check addresses classes that could be made trivially-destructible, but have out-of-line declared destructors, which prevent that. This is mainly needed for GCed classes, destructors of which are queued to execute later. Bug: 1015427 Change-Id: Ied0017073518193a324e6a105297e976949d346a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971839Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#725898}
-
Christian Dullweber authored
Define aggregation for ThirdPartyCookieBlockingEnabledForSite metric Bug: 967668 Change-Id: Ia39b6e1b9b9db10dd4c8ec7193bc2149fcdac34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967316Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.83-1576492580-benchmark-81.0.3995.0-r1 to 81-3945.83-1576492580-benchmark-81.0.3999.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I41a6861878c917f3fcf0c1ea8fc61b97bb6802e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972156Reviewed-by:
-
Anton Bikineev authored
This leaves more work for concurrent sweeping. Change-Id: Id071434a80ffc2d23b50e5c74130d1faa2f69b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971849Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#725895}
-
Changhao Han authored
CL for DevTools: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971830 Bug: chromium:1027168 Change-Id: Idcf011af66e3bd7ebb66ae9ba93ab96ab93b0687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972142 Commit-Queue: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#725894}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I800abfa73c1b4fa93f475fa295a656c9ca487b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972152Reviewed-by:
-
James Cook authored
Now that we have ModelTypeController::InitModelTypeController() we can eliminate factory Create() methods in: * ArcPackageSyncModelTypeController * OsSyncableServiceModelTypeController This is just cleanup; there are no behavior changes. Bug: 1013466 Test: existing sync_integration_tests Change-Id: Ide1d818470beafbc1f2535ba7504dfa27cc94804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972058Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Polina Bondarenko authored
Bug: b:119914122 Test: ./unit_tests --gtest_filter=ArcPolicyBridgeTest* Test: local device: remove smart card. Change-Id: I056fb9a430cc78dabd5190df15dc5ad608a1d875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967081Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#725891}
-
Francois Beaufort authored
This CL makes sure "NFC is off for this device. Turn it on NFC in Android Settings." warning message is visible when user taps "Site Settings" from Page Info while Web NFC permission has been granted but NFC system level setting is disabled. Screenshot: https://photos.app.goo.gl/yDHJFT8aNi5BY6Pm7 Bug: 1035088, 520391 Change-Id: Ia9d982d428d3dfe9501b34c46db2ea5060bf4794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972830Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#725890}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. If the byte length is larger then a DataError is thrown to avoid problems in passing a wrongly cast size to the underlying stack. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. Bug: chromium:1008840 Change-Id: Ie3319d8bb805cd969c4fbc9f61cdf09d327f5863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964493Reviewed-by:
-
Anqing Zhao authored
ReportGenerator is used to report usage data. As a part of it, ArcAppGenerator should be enabled and set Android application data in the report when current environment is Chrome OS. Bug: 1010213 Change-Id: Ia3640a31cd0fa6ac48595256a4b23b7fd99d5d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968986 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#725888}
-
