- 10 Sep, 2019 40 commits
-
-
Tarun Bansal authored
This reverts commit 62e19745. Reason for revert: Suspicious CL for build errors on chromium.linux/Deterministic Fuchsia (dbg). See https://bugs.chromium.org/p/chromium/issues/detail?id=1002719 Original change's description: > [fuchsia] Implement fuchsia.web.Frame/SetUrlRequestRewriteRules. > > * Implement the fuchsia.web.Frame/SetUrlRequestRewriteRules API. > * Add a mojo interface to provide the renderers with new rules. > * This interface is implemented in the browser in > UrlRequestRewriteRulesManager, which also takes care of validating > and converting the rules from FIDL to Mojo, and providing them to > the WebEngineURLLoaderThrottles in the browser. > * In the renderer, there is one rules receiver per RenderFrame, > implemented in UrlRequestRulesReceiver. They cache the rules and > provide them to the WebEngineURLLoaderThrottles in the renderer. > * Add unit tests and browser tests for the new API. > > Bug: 976975 > Change-Id: I446ea4838d50e65c568e7e2cbcd32c23d64af426 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659677 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695298} TBR=dcheng@chromium.org,wez@chromium.org,rockot@google.com,kmarshall@chromium.org,sergeyu@chromium.org,fdegans@chromium.org Change-Id: I606924bbcd98df82f2e9a8bb4e37dea8055a8571 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797127Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695365}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1cf2cc2..75ba649d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibd6e97ec57772ca3daa0fd709f39b436c820d524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795673Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695364}
-
Meilin Wang authored
A new |RUNNING| state was put into use to indicate the assistant service enabled with UI shown on the screen, while the old |NOT_READY| state is now narrowed down to only represent assistant service runnning without UI showed up. This rule change caused the tests running with UI already shown on screen to fail because we only checked for |NOT_READY| state before. This change fixed the test failure by adapting to the new rule and checking for |RUNNING| state as well. BUG=None. TEST=tast -verbose run DUT_ip ui.AlssistantSimpleQueries ui.AssistantTimeQuery ui.AssistantVolumeQueries Change-Id: I75427b64604217b1dc6a76ec9585b416e491bcbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777107 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#695363}
-
Roger Tawa authored
Bug: 1002517 Change-Id: Ie68223675f5802619ae3c317e0e06fbd8bb4ac9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796043 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#695362}
-
Steven Bennetts authored
Bug: 853953 Change-Id: Iaeebe3b1040379e9488ce9e9855ac194b215e7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796312Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695361}
-
Mehran Mahmoudi authored
This is the first step in a series of CLs for moving the AddToHomescreen component to MVC in Android. This CL renames AddToHomescreenDialog to AddToHomescreenView. It also moves AddToHomescreenView and AddToHomescreenManager to the newly created addtohomescreen folder. Next step CL: crrev.com/c/1793633 Design doc: http://go/a2hs-mvc NOPRESUBMIT=true Bug: 994759 Change-Id: I79e7456328301796dc43da440d6025aaa93235ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795992Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695360}
-
Justin DeWitt authored
This is the next step in unlaunching server suggested tiles on mobile. Note that this launch is approved in crbug.com/920756 Bug: 1002131 Change-Id: Ic0ae10cacd3877bc823b7095b9126e6f3c6aaf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791801 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695359}
-
Adrienne Walker authored
This parallels Storage.Blob.FileReaderLoader.FailureType, but for blobs loaded by url instead. Bug: 1001677 Change-Id: I9fd5a75d71fe03b80acacd55fd82b6569df9c985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788457Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#695358}
-
Mei Liang authored
This CL updates the DragToMerge IPH item to use the dark mode color palette in incognito GTS. Change-Id: Ic7daf73870238385a3a4dde9a1e2da6e36a2e761 Bug: 997879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772062Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695357}
-
Tarun Bansal authored
This reverts commit d3864a14. Reason for revert: Breaks content_unittests and snapshot_unittests See https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/83015 and crbug.com/1002716 Original change's description: > [base] Reduce TaskEnvironment default Run() timeout. > > Reduce the default Run() timeout set by TaskEnvironment from > TestTimeouts::action_max_timeout() to action_timeout(). This typically > reduces the timeout from 30s (45s in Debug) down to 10s. > > Sheriffs! This may result in: > - Failures on slow builds, which are not on CQ. Please consider adding > an #ifdef to restore those builds to action_max_timeout(), rather > than simply reverting. > - Flakiness in tests which are too close to the new timeout. Please > consider whether such tests should really be taking so long, and > whether they can be fixed-forward with a ScopedRunTimeoutForTest > rather than reverting (see ThroughputAnalyzerTest in this CL). > > Bug: 922098 > Change-Id: Icd75af79f6d9d3555c91b33ea2566fe7c56cd2f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548382 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695252} TBR=wez@chromium.org,gab@chromium.org,morlovich@chromium.org Change-Id: Ibc71ddd4780bdeb9afd0d3f5f24fb61fec7637d7 No-Tree-Checks: true Bug: 922098, 1002716 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796528 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Joey Arhar authored
This adds icons to the set-cookie headers in the request headers view to show when a cookie was not stored successfully. Screenshots: https://imgur.com/a/1SLbEmI Bug: 856777 Change-Id: Iec08ddc39999407608d1bb0c8d3511a286b47e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795310 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#695355}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f60522f5a467..619935f7f249 git log f60522f5a467..619935f7f249 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@619935f7f249 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I240ac6bd3c6a3dd909eabad493118bdeb6f03b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695354}
-
Jazz Xu authored
Restrict PiP window aspect ratio when updating PiP window size. Bug: 1000999 Change-Id: I4a729d30cd93195cbd493a14dbdedda9536e4ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788232 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#695353}
-
Hesen Zhang authored
- Return early if icon store input is empty. Avoid calls to protodb. Bug: 963290 Change-Id: Ic037a5853c81afdfc74c95126f86f961f6adbd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793751Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695352}
-
Adithya Srinivasan authored
Bug: 1002686 Change-Id: I4b4da5a83454ebe8cc2924466eac83e1ba80bd24 Tbr: caseq@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795897Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695351}
-
Umesh Patil authored
Bug: b/139671272, b/139691389, b/139693028 Change-Id: Ice36b283cbca06ab7f005b0f6c058716985c8233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796267Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Umesh Patil <upatil@google.com> Cr-Commit-Position: refs/heads/master@{#695350}
-
Ryan Hansberry authored
Only display and activate the HID detection screen for form factors without built in input: Chromebases, Chromebits, and Chromeboxes. Bug: 965765 Change-Id: I9a5b8ac882e8fba74bef1c4d29e2c23dd563213b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758837 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#695349}
-
Theresa Wellington authored
And clean up a bunch of old code from "ntp button" (aka clear tab) experiment. Some homepage MV tile code is still left and will be handled separately in crbug.com/1001542 BUG=971877 Change-Id: Ib111079c015e44ba9ad6eea6766b6780ee0da8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789985Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#695348}
-
Shakti Sahu authored
This CL provides an ephemeral tab implementation using bottom sheet and thin webview. The toolbar UI will be added in a next CL. Bug: 998826 Change-Id: Ic62eaa551ffc2e45fbe5daa1a484685674409152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774977Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695347}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/467073a0c18f..52f7ae7c8988 git log 467073a0c18f..52f7ae7c8988 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 perkj@webrtc.org Make NetworkStateEstimator injectable in RemoteBitrateEstimator Created with: gclient setdep -r src/third_party/webrtc@52f7ae7c8988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ife95fd3daecc0ae70c6e2a9faf1a1d3de96aee9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796882Reviewed-by:
-
rbpotter authored
- Autogenerate Polymer 3 version of cr-link-row and tests - Add to demo page Bug: 965770 Change-Id: Ie375a47e04063909db61c360ced871f521f61985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789977Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695345}
-
Yue Zhang authored
Right now, when the font size is set to largest in Accessibility setting, the dialog content of the drag-and-drop IPH gets a little clipped. This CL fixes this issue. Bug: 1001147 Change-Id: I0d3c8fd30deba85a4cfc87d96a056bb901bc1848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788501Reviewed-by:
-
Evan Stade authored
Uses BubbleDialogDelegateView::set_accept_events and removes BubbleFrameView::set_hit_test_transparent See related https://crbug.com/978985 Change-Id: I659e208f886aea331f18317ada532e0bef7797e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678949Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#695343}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e63cab2e8fb..c0c05047c21b git log 8e63cab2e8fb..c0c05047c21b --date=short --no-merges --format='%ad %ae %s' 2019-09-10 senorblanco@chromium.org Dawn: implement Sampler cache (optimization). 2019-09-10 jvanverth@google.com Wrap MTLEvent code in availability attributes. Created with: gclient setdep -r src/third_party/skia@c0c05047c21b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Id99428929c8b74714c03efe58363a54a7a7c90b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796752Reviewed-by:
-
Sasha McIntosh authored
Once yuv decoding is fixed for JPEGs, |allow_decode_to_yuv_| will be controlled by the DecodeJpeg420ImagesToYUV flag introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1768817 * Remove runtime flag check from deferred image decoder and instead check in the webp_image decoder class. This will simplify the logic and allow JPEG/WebP yuv decoding to be enabled/disabled independently. * Rename |can_decode_to_yuv_| to |allow_decode_to_yuv_| for clarity. This indicates whether yuv decoding is supported by the decoder, not whether or not the image can be decoded to yuv. * Move |allow_decode_to_yuv_| and set to false by default. Update CanDecodeToYUV() to return |allow_decode_to_yuv_|. * Move |image_planes_| to the base image decoder class and disallow overriding SetImagePlanes(). * Remove |decode_to_yuv_for_testing_| and instead directly set |allow_decode_to_yuv_| for testing. Bug: 919627 Change-Id: Ie0693b8ac670aadf59ce94fda7cdc238132f2a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768818Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#695341}
-
Kush Sinha authored
After ARC has just been successfully provisioned, there is no need to push the Primary Account to ARC again, because it will trigger an account check otherwise, and may cause performance issues. Please check the attached bug for details. Bug: 1001518 Test: browser_tests --gtest_filter="*ArcAuthService*Test*" Change-Id: I694f1c56bd27ddfb716db2f7330a2b943a4ad71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796344Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#695340}
-
Antonio Gomes authored
... from std::unique_ptr<content::P2PPortAllocator> to std::unique_ptr<cricket::PortAllocator>. This is a precursor CL that prepares peer_connection_dependency_factory.h to move temporarily to Blink's exposed API (which will have no access to P2PPortAllocator). The full solution is described in the design document [1], phase 5. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Iedf28f1261bbf57d5e8cc556ab0b3b99d55f6d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795667 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#695339}
-
Peter Kasting authored
Bug: 23697 Change-Id: I4d3a21d2393d4f6dd2583e7a25cb985dde2cde7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793947Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695338}
-
Dale Curtis authored
- Expands logging in key failure points. - Enables DumpWithoutCrashing for media browsertests. - Checks pa_context_t state before trying the only blocking method in the linux default device authorization path. BUG=986021 R=tguilbert Change-Id: I4b03313e4431cb847e8a8bd926dd810471fb21ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796311 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695337}
-
Rob Hueber authored
In cast audio devices there are a number of libraries that statically link in libbase, resulting in each library having its own copy of tcmalloc. During static initialization of a library, the tcmalloc in that library is called directly, and tcmalloc can call sbrk() which is not thread safe. By disabling tcmalloc, we avoid the possibility of multiple calls to sbrk() causing crashes on cast audio devices. Bug: 1002281 Test: Build and run cast_shell and chrome Change-Id: Ib5707d0132596ea73cc8dd9ef68fac049334e17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795754 Commit-Queue: Rob Hueber <rhueber@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695336}
-
Ted Meyer authored
For each initialization segment, this will log: init start init complete playback completed Change-Id: I989b67d9a86b484c79bac48e20fed408bd85b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793807 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#695335}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9c1c856c64c..53a5a5042e54 git log d9c1c856c64c..53a5a5042e54 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 dpranke@chromium.org Add a COMPONENT entry to the OWNERS file. Created with: gclient setdep -r src/third_party/depot_tools@53a5a5042e54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I10d063197a47f3648b67bbf693dac4a105c23dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796565Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66d325b6e26e..1e47094cfbc5 Created with: gclient setdep -r src-internal@1e47094cfbc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id164d6bce18f3f9b6d18a9ac3e90b89a0be95164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695333}
-
Xiyuan Xia authored
- Add ShelfLayoutManager::OnWorkAreaInsetsChanged that notifies Shelf when it updates the Shelf insets in WorkAreaInsets; - Add ShelfObserver::OnShelfWorkAreaInsetsChanged that gets called when Shelf gets a OnWorkAreaInsetsChanged call; - AshPopupAlignmentDelegate observes OnShelfWorkAreaInsetsChanged and update its work area instead Shelf visibility or autohide state change; Bug: 1002003 Change-Id: I1239713a1d1dd7c27d84cfe4f81621f4ab638ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795907 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#695332}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/dbus/audio. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=hychao@chromium.org Bug: 891670 Change-Id: I55a04b25e80b979196259ec1c593cad76481163f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786960 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695331}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /url/mojom/url_gurl_mojom_traits_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=kerrnel@chromium.org Bug: 891670 Change-Id: I0432a4253c14c5a160d6716e41af7d61eb1c52a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786812 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695330}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79ad0411911b..0b8eca795349 git log 79ad0411911b..0b8eca795349 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 jmadill@chromium.org Capture/Replay: Fix CaptureShaderSource_string. Created with: gclient setdep -r src/third_party/angle@0b8eca795349 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Id4265b9aef376226664a5f9aa5f24112ea1f5c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796750Reviewed-by:
-
Owen Min authored
Add a log indicates first report remaining time. Bug: 956237 Change-Id: I266c5ae59a52cf11e9e9d4ad340032af43d32dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796763Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695328}
-
Ben Pastene authored
Bug: 1002652 Change-Id: Ib5a8c411a85df3bd9a12c3e9f67e8cdc31b7d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795499 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695327}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/ntp_snippets. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 891670 Change-Id: Ib3206c1a7c5241a2f8f6d515f7f321be5058519f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787205 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695326}
-
