GitLab

The root cause of the Android "core trampler" has been found.  This
reverts the tracker used to record what objects were previously
allocated in the memory block used by the object being overwritten.

While the general "freed_object_tracker" module is generic and could
be re-used should similar tramplers appear, it is best not to leave
code in the build that is not actually being used.  Feel free to
ressurect this code in the future if there is a need for it.

TBR=asvitkine
(on vacation)

Bug: 744734
Change-Id: I4f8224253365ac6c5e08f12401104593bf090588
Reviewed-on: https://chromium-review.googlesource.com/688043
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505371}

This reverts commit 05a16884.

Reason for revert: 
renderer_side_navigation_browser_tests broke after this patch, starting
in https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/18672.

Original change's description:
> Prerender: Add test confirming cookie behavior.
> 
> The behavior of NoStatePrefetch and cookies can be confusing. This adds
> NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates
> that cookies are set on all prefetches.
> 
> Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520
> Reviewed-on: https://chromium-review.googlesource.com/691663
> Commit-Queue: Matthew Cary <mattcary@chromium.org>
> Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505359}

TBR=mattcary@chromium.org,alexilin@chromium.org

Change-Id: Ic5c9c203d0e1508d262ff420a2e27e2d73f831c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/691997Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505370}

Screenshots:
https://folio.googleplex.com/zine/chrome_home_promo

Bug: 769003
Change-Id: I37e452762f6696f53bd7c21ee09a8af5edcf1f03
Reviewed-on: https://chromium-review.googlesource.com/690715Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505369}

This reverts commit a99f67ed.

Reason for revert: https://crbug.com/770193 - IO assert on main thread in browser startup.

Original change's description:
> Move ComBase functions and HSTRING helpers to base/win.
> 
> Bug: 734095
> Change-Id: Ib984cd7094cf4e075863d692acb59722114e3990
> Reviewed-on: https://chromium-review.googlesource.com/649528
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505163}

TBR=dcheng@chromium.org,peter@chromium.org,toyoshim@chromium.org,finnur@chromium.org,robliao@chromium.org,grt@chromium.org

Change-Id: I150e7825b141b21b37e14ee7ff7089150aa50abb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 734095
Reviewed-on: https://chromium-review.googlesource.com/692615Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505368}

Bug: 763303
Change-Id: I0d9734c91fd1de5b16d2ae738b4a414acc55646d
Reviewed-on: https://chromium-review.googlesource.com/657425Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Pavel Kalinnikov <pkalinnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505367}

This reverts commit 05a16884.

Reason for revert: These tests are failing on Mac

NoStatePrefetchBrowserTest/NoStatePrefetchBrowserTest.PrefetchCookie/1
NoStatePrefetchBrowserTest/NoStatePrefetchBrowserTest.PrefetchCookie/0

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/24380

Original change's description:
> Prerender: Add test confirming cookie behavior.
> 
> The behavior of NoStatePrefetch and cookies can be confusing. This adds
> NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates
> that cookies are set on all prefetches.
> 
> Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520
> Reviewed-on: https://chromium-review.googlesource.com/691663
> Commit-Queue: Matthew Cary <mattcary@chromium.org>
> Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505359}

TBR=mattcary@chromium.org,alexilin@chromium.org

Change-Id: Ie724b0f98cead53722bfba66c29759568fa0564a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/692594Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505366}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/11d773db..776de290

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Icba06885aa4f6c93d7b093e6f5fc3c50d16355ea
Reviewed-on: https://chromium-review.googlesource.com/691326Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505365}

Several test classes in scheduler have implemented
AppendToVectorTestTask and this patch gives those unique namespaces
to prevent them from clashing in jumbo builds.

Bug: 745732
Change-Id: I265c5507cbcc0f934f5904cc62033443442163f9
Reviewed-on: https://chromium-review.googlesource.com/692018Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#505364}

Renders the UI of Chrome's VR browser to an offscreen context. The
rendered image is then copied to an SkBitmap. This serves as the
basis for pixel and performance tests.

To execute the test and view the screenshot on Linux run:
  <Configure Linux target in out-linux/Release>
  ninja -C out-linux/Release -j2000 -l50 vr_common_unittests
  out-linux/Release/vr_common_unittests \
    --gtest_filter=UiPixelTest.DrawVrBrowsingMode \
    --num-retries 0


To execute the test on Android and view the screenshot run:
  <configure Android target in out/Release>
  ninja -C out/Release -j2000 -l50 vr_common_unittests
  <Make sure your phone is unlocked>
  out/Release/bin/run_vr_common_unittests \
    --gtest_filter=UiPixelTest.DrawVrBrowsingMode \
    --num-retries 0

Change-Id: Ib04c03ba36d63c9f50cd734b699130cc18cc8df6
Reviewed-on: https://chromium-review.googlesource.com/677556
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505363}

BUG=768883

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idc4989dacd7390d1c5b58d3877cbfbc3a9818802
Reviewed-on: https://chromium-review.googlesource.com/690347Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505362}

This reverts commit f3bd7c65.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Extension content verification: unify "is from store" logic
> 
> Bug: 766806
> Change-Id: I1a210ded77cc9ffdc0039fca097c6fdba7ff0131
> Reviewed-on: https://chromium-review.googlesource.com/677403
> Commit-Queue: proberge <proberge@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505092}

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,proberge@chromium.org

Change-Id: Id440f7f630d62b2a70ebee1774607219141d575c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 766806
Reviewed-on: https://chromium-review.googlesource.com/692075Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505361}

WebState::IsVisible replaces WebStateObserver's WasShown and WasHidden
callbacks.

Bug: None
Change-Id: I9c608377a9d68de53527b27917a45b075d8e0a62
Reviewed-on: https://chromium-review.googlesource.com/685311
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505360}

The behavior of NoStatePrefetch and cookies can be confusing. This adds
NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates
that cookies are set on all prefetches.

Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520
Reviewed-on: https://chromium-review.googlesource.com/691663
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505359}

navigator.credentials.get() may be called from inactive tab. As of
change 665119, showing the snackbar would be just suppressed.

This CL stores PasswordForm, for which notification should be shown
and, once tab is active again, shows the delayed notification.

Also included an Earl Grey test case for this behavior.

Here is a short screen recording from manual testing:
https://drive.google.com/open?id=0B3hBvGfYBfe2Qml1X0pQRkJJQkE

Bug: 435048
Change-Id: I1ff3cf6f3858126d32f17d09ec9117b8c5d1a96e
Reviewed-on: https://chromium-review.googlesource.com/681376
Commit-Queue: Tomasz Garbus <tgarbus@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505358}

CRWWebController is private class from //ios/web and should not be used
in //ios/chrome.

Bug: 620465
Change-Id: I18a9ea2b225e48186b556bc5076f91442c6add8d
Reviewed-on: https://chromium-review.googlesource.com/691038
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505357}

In this CL I added an image view on auto sign-in snackbar, displaying
user's avatar. Until avatar is fetched, a placeholder image is shown.
For network traffic annotation tag, I used this sample:
https://cs.chromium.org/chromium/src/tools/traffic_annotation/sample_traffic_annotation.cc?l=120

Image view size is 24x24pt, fetched image is scaled accordingly.

Screenshot with fetched icon: https://screenshot.googleplex.com/ruQRUXGOLN9.png
Screenshot with placeholder: https://screenshot.googleplex.com/bYUnFR0pFru.png
Screenshot with big (1024x1024) icon: https://screenshot.googleplex.com/4OwJuwCdj3J.png

Bug: 435048
Change-Id: Ib74ef74716d81ab661ee2aa4b7246e27ebab3276
Reviewed-on: https://chromium-review.googlesource.com/681254
Commit-Queue: Tomasz Garbus <tgarbus@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505356}

- All files generated by libfuzzer.
- Contains no code.

BUG=chromium:22532

Change-Id: I4710f81f670b2a0287280ae04bb055c0fdc60093
Reviewed-on: https://chromium-review.googlesource.com/632876
Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505355}

This CL introduces a notification view appearing on the bottom
of the screen when user is automatically logged in. It also
includes an EG test for this behavior.

Here is a screenshot with the notification:
https://screenshot.googleplex.com/267O2QU93YA.png

iPhone X screenshots:
vertical: https://screenshot.googleplex.com/0bitXQFqbR2.png
horizontal: https://screenshot.googleplex.com/v0i7GbVwdBL.png

Bug: 435048
Change-Id: Ic871148a970c36e8ce89922319720637a54cabbc
Reviewed-on: https://chromium-review.googlesource.com/665119
Commit-Queue: Tomasz Garbus <tgarbus@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505354}

BUG=761622

Change-Id: I9428919041a0c5a0779bec18b911b253c82fece3
Reviewed-on: https://chromium-review.googlesource.com/690377
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505353}

Prompt should have labels: "Username" and "Password"
Username and password will be on separate lines.

See screenshots in the bug.

Since both owners are OOO, but the CL should be landed before feature freeze, the CL will be landed only with TBR.

TBR=vasilii@chromium.org

Bug: 769666
Change-Id: I9f43163ff4286e6f7c3ef526572f3ca4ae971fab
Reviewed-on: https://chromium-review.googlesource.com/690344
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505352}

TabbedPane's focus indicator line should have been mirrored in RTL so it was
under the focused tab, but it was not.

Bug: 733115
Change-Id: I25e663300e75aee849aa3804a8e1a5d13f97acf8
Reviewed-on: https://chromium-review.googlesource.com/690796Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505351}

R=skyostil@chromium.org

Change-Id: Ia45c1c39077bbdd451af091d2589e1b11e77c617
Reviewed-on: https://chromium-review.googlesource.com/680796Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505350}

The NTP view cannot use the safeAreaInsets property directly as it is
snapshotted before being inserted in the view hierarchy, and the safe
area is only available for views in the view hierarchy.
This CL introduces a property mirroring the safe area once the view is
in the view hierarchy. But it is also set up with the value used in the
first frame, allowing the snapshot to be done as if the view was in the
view hierarchy.

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/681942
It was reverted because the NTP wasn't working correctly when opening
the recent tabs from the tool menu.

Bug: 767869
Change-Id: Ibf57b84dd6aa4447101c0d0828e5f9af3d76670d
Reviewed-on: https://chromium-review.googlesource.com/691727
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505349}

Change-Id: I03198f177aa936c3ba21dc5aabfc8d27cdfb2c54
Reviewed-on: https://chromium-review.googlesource.com/690156Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Grigoriy Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505348}

This reverts commit 6ad728b1.

Reason for revert:
The revert in https://chromium-review.googlesource.com/c/chromium/src/+/691794 should have fixed
the underlying problem. So we don't need to disable the test. :)

Original change's description:
> sheriff: Disable PasswordsAndFormsBrowserTest.uiTests
> 
> TBR=dpapad@chromium.org
> 
> Bug: 770047
> Change-Id: Iced8b09b937f2a6b202bea47b99dcf6fbe137749
> Reviewed-on: https://chromium-review.googlesource.com/691694
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505329}

TBR=dpapad@chromium.org,ortuno@chromium.org

Change-Id: I60d94fdf0cf77ed04d0b02f4193b54be66e270bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 770047
Reviewed-on: https://chromium-review.googlesource.com/691994Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505347}

Bug: 769754
Change-Id: I909fed33dd12215b30c13b5d5c913337b56ef717
Reviewed-on: https://chromium-review.googlesource.com/690656Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505346}

This was requested in https://chromium-review.googlesource.com/c/chromium/src/+/690346

TBR=agable,dpranke

Bug: 570091
Change-Id: I74ceecb35236cc4c346f47f1b6e9e8755bd2b689
Reviewed-on: https://chromium-review.googlesource.com/691665Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505345}

The navigation selector will now hide immediately when moving the
bottom sheet down from the half state (full state for small screens),
instead of 96dp before the peek position.

Preview: https://drive.google.com/open?id=0B8YGYtFin7saZ2VDNmhnZGZJWTg

Bug: 759130
Change-Id: I326d9baf0f8f837b782a51f6daa84c13fac1074a
Reviewed-on: https://chromium-review.googlesource.com/689999
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505344}

Changes: https://webrtc.googlesource.com/src.git/+log/7e9c614..bbceb76

$ git log 7e9c614..bbceb76 --date=short --no-merges --format=%ad %ae %s
2017-09-28 ehmaldonado@webrtc.org Add support for conditions on DEPS file.
2017-09-28 agable@chromium.org Make Gerrit the default for WebRTC changes
2017-09-27 steveanton@webrtc.org Move clients of WebRtcSession to use PeerConnection
2017-09-28 davidben@webrtc.org Mark methods_stream as const.
2017-09-28 davidben@webrtc.org Switch from SSL_CIPHER_get_rfc_name to SSL_CIPHER_standard_name.
2017-09-28 kwiberg@webrtc.org Convert PayloadUnion from a union to a class, step 2
2017-09-28 jtteh@webrtc.org Fix occassional hang in iOS 11 when calling VTDecompressionSessionInvalidate.
2017-09-28 kwiberg@webrtc.org Convert PayloadUnion from a union to a class, step 1
2017-09-28 sakal@webrtc.org Revert "Use injectable hardware video decoder/encoder in AppRTCMobile."
2017-09-28 ssilkin@webrtc.org Adding test for SingleNalUnit mode
2017-09-28 sakal@webrtc.org Use injectable hardware video decoder/encoder in AppRTCMobile.
2017-09-28 denicija@webrtc.org Fix memory leak in nv12 metal renderer
2017-09-28 brandtr@webrtc.org Detach SequencedTaskChecker in MediaCodecVideoEncoder::Release.
2017-09-28 solenberg@webrtc.org Remove various IDs:
2017-09-28 kthelgason@webrtc.org Add equality method for RTCVideoCodecInfo.
2017-09-27 philipel@webrtc.org Calculate VP9 references to wrap at kPicIdLength instead of 16 bits.
2017-09-28 oprypin@webrtc.org Change DEPS URL for catapult to match Chromium
2017-09-28 ssilkin@webrtc.org Updating OpenH264 to v1.7.0
2017-09-27 danilchap@webrtc.org Trigger rtt and stats update on report block rather than receiver report.
2017-09-25 sakal@webrtc.org Reland "Improve unit testing for HardwareVideoEncoder and fix bugs."
2017-09-28 henrika@webrtc.org Adds WebRTC.Audio.EncodingTaskQueueLatencyMs

TBR=grunell@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: I16d9436bb54c7b8c5da988f6dd7b2d75d23039c8
Reviewed-on: https://chromium-review.googlesource.com/691723Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505343}

Look at the content view dimensions to see if the orientation
change happened as expected.

Bug: 768779
Change-Id: I364f1fb13e1b88bb69542f584204dc295be32677
Reviewed-on: https://chromium-review.googlesource.com/689995
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505342}

This CL has done below ones,
 - Replacing base::MakeUnique|WTF::MakeUnique with std::make_unique
 - Replacing PtrUtil.h with <memory>

Bug: 755727
Change-Id: I78c514e53fa7902172a6f6b5b5c66d74d8efb0d8
Reviewed-on: https://chromium-review.googlesource.com/687374
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505341}

Most tests started passing after script url loader was implemented in
r502227.

Bug: 715640
Change-Id: I38f366923243c764219853a8bf51356e12c38fd8
Reviewed-on: https://chromium-review.googlesource.com/691757Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505340}

According the current coding style guide, function names should start
with capital letters.

- Update ElementTypeHelpers.h.tmpl
- Replace exising calls for isFooElement() with IsFooElement()
- Remove some unnecessary ASSERT_TRUE(isFooElement()) followed by
  toFooElement(), which contains the SECURITY_DCHECK.

Bug: 710278
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4fa5a4fced83a1015816ecdeb0636fde9b832c21
Reviewed-on: https://chromium-review.googlesource.com/689875
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505339}

Several test classes in scheduler have implemented NopTask and
this patch uses unique namespaces to prevent them from clashing
in jumbo builds.

Bug: 745732
Change-Id: I8c3ecc80ab0696fbe4634d330dfe1e942dbcfa8b
Reviewed-on: https://chromium-review.googlesource.com/690345Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#505338}

have any content

Currently only a small subset of 4xx and 5xx HTTP errors show a net error
interstitial when the server responds with no content. This CL adds 
generic messaging for the other cases.

Bug: 632778
Change-Id: If39bf0ba1c89ac5e2b5a27f5973e1accc25dc0fa
Reviewed-on: https://chromium-review.googlesource.com/685674Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505337}

This reverts commit 19e812ea.

Reason for revert:

Starting in https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45183, `AppListTest.PressAppListButtonToShowAndDismiss` has been failing. It
doesn't look like the result of that test should have changed, 
reverting so folks who know what they're doing can have a look. :)

Original change's description:
> ChromeOS: Enable ShelfModel synchronization by default.
> 
> Synchronize two ShelfModels between Ash and Chrome by default.
> Can be disabled for debugging/testing in classic ash:
>   --ash-disable-shelf-model-synchronization
>   "Disable shelf model synchronization" (in about:flags)
> 
> Bug: 557406
> Test: No Chrome OS shelf behavior changes; please file any bugs!
> Change-Id: I47c7c7b6c9d38f9aaa4ea89a1dc8ce333e49f8bd
> Reviewed-on: https://chromium-review.googlesource.com/682340
> Commit-Queue: Michael Wasserman <msw@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505317}

TBR=jamescook@chromium.org,msw@chromium.org

Change-Id: Idcc1058f4b11a2ebc491f4c168e073692cd16910
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 557406, 770138
Reviewed-on: https://chromium-review.googlesource.com/691816
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505336}

This CL:
-Adds a compatibility header to obtain a view's
safeAreaInsets.
-Removes the unnecessary |imageViewContainer_| from the infobar view.
-Takes into account the safeAreaInsets where needed in the infobar view:
   * leftMarginOnFirstLine returns the space from the left edge of the
     screen to where the infobar's text should start.
     It handles 2 cases:
       A) When there's an icon (e.g. a translate icon)
          The old code was using |frameOfIcon|, which now already takes
          into account the safeArea. The logic needed to be changed, and
          it's now: icon.x + icon.width + margin.
       B) When there's no icon
          The safeAreaInset is taken into account.
   * rightMarginOnFirstLine is the space from the right edge of the screen
     to where the infobar's text should start.
     The safeAreaInset is taken into account.
   * heightThatFitsButtonsUnderOtherWidgets does not use
     leftMarginOnFirstLine nor rightMarginOnFirstLine because it handles
     views not on the first line. When not on the first line you have
     more space because the icon and the close button are not in the way.
     This function still needs to have an idea of how much horizontal space
     is available, and thus needs to take into account the horizontal
     safeArea (both left and right).
   * computeRequiredHeightAndLayoutSubviews returns the total height of
     the infobar. We add the safeAreaInset.bottom to the total
     computed height, which makes the infobar taller.
     This allows us to have more white space at the bottom of the
     infobars.
   * frameOfCloseButton is updated so that the close button
     is moved left to be in the safe area.
   * frameOfIcon is updated so that the icon is moved right
     to be in the safe area.

https://drive.google.com/open?id=0Bw-kA2pwDsU-OXlJSUE3VmxMZGc

Bug: 765415
Change-Id: I35c1718ca170ccef245f51f28fa7eed63f1d9042
Reviewed-on: https://chromium-review.googlesource.com/671353Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505335}

This means that ReportStatus is only called in one place
(apart from AppBannerManagerDesktop::ShowBannerUi), making it easier
to verify that it is called the appropriate number of times.

It also removes the need for hacks such as pre-updating the state to COMPLETE
in AppBannerManager::DisplayAppBanner.


Bug: 770016
Change-Id: Iedf93b7a3c6c211b2188032259906bd49bcd4555
Reviewed-on: https://chromium-review.googlesource.com/691494
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505334}

The console spec says that the %o specifier should produce
"optimally useful formatting" as opposed to the %O
"generic JavaScript object formatting". To make this distinction clearer
and align log() to %o and dir() to %O, this CL will format
arrays/objects with previews when using %o.

Please see crbug for screenshot.

Bug: 751850
Change-Id: I927e1c34667f1d11bc13e98a86d38419b7012940
Reviewed-on: https://chromium-review.googlesource.com/607576
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505333}

We generate data URL for ARC intent handler's icon in 16x16 pixel PNG format.
It is not good enough when the device scale factor is bigger than 1.
We should apply the scale factor when generating PNG data.
The source bitmap which is passed from Android system is big enough.
(48x48 pixels for 1x scale factor, and 96x96 pixels for 2x scale factor.)

Bug: 751362
Change-Id: I370bf32b2c0f4e9e19dc267b03965663546a03bf
Reviewed-on: https://chromium-review.googlesource.com/688524
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505332}