- 25 Sep, 2018 40 commits
-
-
John Chen authored
Handle timeouts in session capabilities, according to W3C spec. Bug: chromedriver:1997 Change-Id: Ie0c4bb8add482fa175f3bfe40210cf9fb0077001 Reviewed-on: https://chromium-review.googlesource.com/1243576Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594097}
-
Robert Sesek authored
Bug: 832676 Change-Id: I46fbf0fe83cd2317bf299cf204b39c79cacb1419 Reviewed-on: https://chromium-review.googlesource.com/1243224 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594096}
-
Matt Reynolds authored
The Surface Pro 2017 is a hybrid laptop/tablet device with a detachable keyboard. The keyboard is a composite device that includes several HID devices, some of which are incorrectly recognized as gamepads. This CL modifies the RawInput data fetcher on Windows to filter out devices that match the IDs for the Surface Pro 2017 keyboard. It also adds a check to exclude any PCI HID devices since there are no known PCI gamepads. The problematic devices intended to be filtered by this CL are: \\?\HID#VEN_8086&DEV_9D3E&SUBSYS_00000000&REV_21&Col02#4&f87ce30&0&0004#{4d1e55b2-f16f-11cf-88cb-001111000030} \\?\HID#VEN_8086&DEV_9D3E&SUBSYS_00000000&REV_21&Col05#4&f87ce30&0&0004#{4d1e55b2-f16f-11cf-88cb-001111000030} \\?\HID#VID_045E&PID_0922&Col06#7&36425755&0&0005#{4d1e55b2-f16f-11cf-88cb-001111000030} \\?\HID#VID_045E&PID_0922&Col09#7&36425755&0&0008#{4d1e55b2-f16f-11cf-88cb-001111000030} BUG=881156 Change-Id: I04687ffc94c92c284928eaec28c1edc85d05bf33 Reviewed-on: https://chromium-review.googlesource.com/1211978 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#594095}
-
Xiaoqian Dai authored
When a connected bluetooth mouse is disconnected, and if it was the only external mouse device, the Chrome OS device should enter tablet mode. And when a connected bluetooth keyboard is disconnected, and if it was the only external keyboard device and no internal keyboard device, the virtual keyboard should pop up. However, it's not the case currently. The reason of this issue is ui::InputDeviceEventObserver doesn't have knowledge of Bluetooth device status and then when a Bluetooth device got connected/disconnected, it doesn't send out notification to notify its observers about the change. And there is no map from an InputDevice to a BluetoothDevice, thus it's impossible to know if an InputDevice is a BluetoothDevice and its status. TabletModeController and VirtualKeyboardController are both only ui::InputDeviceEventObserver and thus don't behave correctly when a Bluetooth device status changed. This CL adds a BluetoothDevicesObserver to observe BluetoothDevices change. It's more like a temporary fix, and I *think* the more correct underlying fix is let DeviceDataManager and InputDeviceClient (the classes to manage InputDevices) to send out the correct notification. The device lists that DeviceDataManager maintains comes from DeviceManagerUdev, and DeviceManagerUdev can send out the correct ADD type DeviceEvent when a bluetooth device is connected, but can not send out DeviceEvent when a bluetooth device is disconnected. We probably should make DeviceManagerUdev supports BluetoothDevices change. Bug: 882541 Change-Id: I2e8e6f56fe2f898bcde84f0eea24d9f2a69c9a05 Reviewed-on: https://chromium-review.googlesource.com/1222991Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594094}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fed6e124109f..30dc6aaf878b git log fed6e124109f..30dc6aaf878b --date=short --no-merges --format='%ad %ae %s' 2018-09-25 tsepez@chromium.org Add FxAlignToBoundary<>() template helper function. 2018-09-25 tsepez@chromium.org Introduce CodecModuleIface for progressive decoder modules. Created with: gclient setdep -r src/third_party/pdfium@30dc6aaf878b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I458ae9d3cb71637f5a503876a34b5623d224a648 Reviewed-on: https://chromium-review.googlesource.com/1244119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594093}
-
Weilun Shi authored
Disable Done button on custom link edit dialog when the url is empty or spaces only. Screencast: https://screencast.googleplex.com/cast/NTk2NTU5NzE1ODQwODE5Mnw3OWZhOGVmNi04Mg Bug: 886665 Change-Id: Ic674894e73ff8dc183af740505fdaa906e5241d9 Reviewed-on: https://chromium-review.googlesource.com/1243678 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#594092}
-
Joel Einbinder authored
The border was missing a pixel, and so didn't look like a solid line. https://imgur.com/a/jjEPH9g Change-Id: I647953188d2029670851201cb7b2d43e09cf37d1 Reviewed-on: https://chromium-review.googlesource.com/1244113 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#594091}
-
Fredrik Hubinette authored
When loading many media files, we normally end up having to wait for the first request for ALL media files to load before we can process the second request of the first media file. By limiting the number of parallel preloads, time-to-first frame should improve for all but the last media file. However, this feature is checked in behind a feature flag, so that we can run some expriments on it before turning it on by default. Bug: 884820 Change-Id: Ib0c366325d82fb59e6ad896bf985b1e828143a82 Reviewed-on: https://chromium-review.googlesource.com/1228486 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594090}
-
Simeon Anfinrud authored
This is no longer used. Bug: None Test: build cast_shell_apk, run junit tests Change-Id: I13f98d7b6c3b03d3d76bc5578e7436d854b0153d Reviewed-on: https://chromium-review.googlesource.com/1236281Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594089}
-
Chris Lu authored
[ios] Ensure MDCAppBarViewController's view matches the width of PaymentRequestPickerViewController's view. Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: If17ea9de20fec0463e918aea4f401427c3572bc5 Reviewed-on: https://chromium-review.googlesource.com/1239008Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#594088}
-
Nico Weber authored
We generally should use consistent optimization settings across platforms. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I79cd892056dcfa7338109deb9f689afac2b56072 Reviewed-on: https://chromium-review.googlesource.com/1244021Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594087}
-
Wez authored
Previously this method of creating an SkTypeface was not-implemented under Fuchsia, but that was changed during the refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/1238540 We restore OS_FUCHSIA as a platform on which this method is not- implemented, to avoid the SkFontConfigInterface::RefGlobal() reference breaking our Debug builds. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-fyi-x64-dbg Bug: 816445 Change-Id: Ib14023478e65a8b9c59886a579d60a5be7e00aff Reviewed-on: https://chromium-review.googlesource.com/1243571Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#594086}
-
Scott Graham authored
Bug: None Change-Id: I721c75e75ae0ec95667749f673578221747cbbea Reviewed-on: https://chromium-review.googlesource.com/1244156 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594085}
-
Jonathan Backer authored
When there are multiple windows open with viz, each window has it's own InProcCmdBuffer. If we do a memory dump with multiple windows, we will fail DCHECKs on calls from VizProcessContextProvider::OnMemoryDump because we will have multiple CommandBufferHelpers in the same process with the same ring_buffer_id_. https://cs.chromium.org/chromium/src/gpu/command_buffer/client/cmd_buffer_helper.cc?rcl=9c52bb1d0f58d02879f4373f5db09aa625c590a7&l=365 This CL makes the transfer buffer IDs generated by InProcCmdBuffer unique within a process and avoids the failing check. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I204098af24c6148c1abe71724dbc5b176ee1a29f Reviewed-on: https://chromium-review.googlesource.com/1243672Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594084}
-
Avi Drissman authored
GetParentWidgetAndEvent can fail to find a widget; if so, don't call through a null pointer. BUG=883700 Change-Id: Ifa4430fe7cc7c83da9e21fa478e15b59498138ec Reviewed-on: https://chromium-review.googlesource.com/1244019Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594083}
-
Jani Hautakangas authored
Introduce Ozone Wayland IME integration. Implements Ozone Wayland specific LinuxInputMethodContext and adds possibility to integrate it with various Wayland text input protocols. Patch also introduces new SetSurroundingText function to LinuxInputMethodContext that is internally called by InputMethodAuraLinux on caret bounds change. This CL: - Implements Ozone wayland specific Linux input method context interface and integrates it with zwp_text_input_v1 protocol. - Introduces new runtime flag --enable-wayland-ime to enable this feature (by default false). - Makes Wayland IME working with InputMethodAuraLinux. - Adds surrounding text support (kudos to msisov@igalia.com). Bug: 791920 Change-Id: I168d4a266bff6e62acce69edf943469e05e575ac Reviewed-on: https://chromium-review.googlesource.com/1193872Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Cr-Commit-Position: refs/heads/master@{#594082}
-
Liquan(Max) Gu authored
Initially the events in EventTiming class are pointers, this CL is to change them to references, since reference is safer to use. Bug: 850144 Change-Id: Ia13ef944c143a7bed8096c1faf370163bfa95aaf Reviewed-on: https://chromium-review.googlesource.com/1244102Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594081}
-
Jeremy Roman authored
sheriffing: disable vr_pixeltests:UiPixelTest.DrawVrBrowsingMode,GlTestEnvironmentTest.InitializeAndCleanup in msan builds Bug: 889186 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I673acc7c696802c8c5b29b9e9f4b279c12e0b858 Tbr: acondor@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1244364Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594080}
-
erikchen authored
Switch to an atomic variable to ensure that getter and setter do not have a data race. Bug: 859155 Change-Id: Ib5ab1968cc8e25ab363fb4ed0b3f2e756d9cc984 Reviewed-on: https://chromium-review.googlesource.com/1240634 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#594079}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4396b5dbaad5486719a3a3230858ced6cfdb3642 Reviewed-on: https://chromium-review.googlesource.com/1244096Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594078}
-
yiyix authored
Enabling FrameMetrics caused 5-20% regression on rendering. (ref: https://bugs.chromium.org/p/chromium/issues/detail?id=876709). One of many reasons is that square root calculation took too long. In this cl, I implemented Newton's method to approximate the square root value. I ran perftest on a Nexus 4 device and got the following result: average of running square_root using std::sqrt: 1601-01-01 00:00:23.160 UTC average of running square_root using fastsqrt: 1601-01-01 00:00:10.629 UTC Conclusion: It's 2.3x faster with newton's approximation instead of standard library. I also ran perftests on linux desktop and got 3%-5% improvements. (perftests ref: https://chromium-review.googlesource.com/c/chromium/src/+/1222676) Bug: 881863 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5feebc32053650f338a92a2e1db6f4f67b20f995 Reviewed-on: https://chromium-review.googlesource.com/1225105 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
rbpotter authored
Make pages a dropdown, and only show the custom input if "Custom" page range is selected Bug: None Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c Reviewed-on: https://chromium-review.googlesource.com/1237241 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594076}
-
Ben Pastene authored
Tast is a new suite of tests. It's invoked via "local_test_runner" in the VM. You pass it a set of test names and it'll exercise some test cases. We shouldn't use much more than the browser flavored ones. Bug: 876587 Change-Id: I1d6ae9b6b5a929daadb6c12751cb0cd632a24d95 Reviewed-on: https://chromium-review.googlesource.com/1237673 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#594075}
-
Ian Clelland authored
This CL moves the functionality that previously existed in Frame::IsFeatureEnabled to SecurityContext, and from LocalFrame::ReportFeaturePolicyViolation to Document. The existing Deprecated* methods are changed to defer to these new locations. Bug: 888668 Change-Id: I2b926a88e9ac5c8428d4dc3cd4b3764b11f6d90d Reviewed-on: https://chromium-review.googlesource.com/1241194 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 832676 Change-Id: Iac4e3e7c9e959f65a5f113653af8122b1a212519 Reviewed-on: https://chromium-review.googlesource.com/1244020Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594073}
-
Ryan Hansberry authored
Tether originally initiated host scans from the lock screen, in order to provide a list of hosts once the user unlocked the device. This was changed when it was discovered that Bluetooth issues meant Tether and SmartLock could not scan simultaneously. It was assumed that this restriction would no longer apply one the new MultiDevice APIs were available, but we now never want to allow host scans on the lock screen; this CL implements that logic. Bug: 888815 Change-Id: I392e61e8ad404372df42cf2240c65cac81651608 Reviewed-on: https://chromium-review.googlesource.com/1242214Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594072}
-
Nico Weber authored
Also removes a layering violation between components/ and chrome/. Bug: 832676 Change-Id: Id894be95a9ac589da59b7a8f5587a3f4a09307cf Reviewed-on: https://chromium-review.googlesource.com/1244017 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Robert Ogden authored
Anything less than 1/4 second and I was getting flakes locally. Bug: 885252 Change-Id: Ia61a99abb4ef57686af01a34264b252096e10b36 Reviewed-on: https://chromium-review.googlesource.com/1242683Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#594070}
-
Ahmed Fakhry authored
TBR=sky@chromium.org, bokan@chromium.org BUG=867063 Change-Id: I3f05f571b2d45e0f4cb4b04c401ae83cc63bd214 Reviewed-on: https://chromium-review.googlesource.com/1243574Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594069}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d37570b325e2..8d6aa1a2a00d git log d37570b325e2..8d6aa1a2a00d --date=short --no-merges --format='%ad %ae %s' 2018-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9a20cc9744b3..1aae88c1e046 (1 commits) 2018-09-25 egdaniel@google.com Add support for RGB config to Vulkan. Created with: gclient setdep -r src/third_party/skia@8d6aa1a2a00d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Id2e130af165aad7d787f88a3eb0abfec68306988 Reviewed-on: https://chromium-review.googlesource.com/1244376Reviewed-by:
-
Luna Lu authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I196ed40d3d9d452373a2ad7217b1c2ab75147d2b Reviewed-on: https://chromium-review.googlesource.com/1244357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e64369342f2..c4a7356a469b git log 8e64369342f2..c4a7356a469b --date=short --no-merges --format='%ad %ae %s' 2018-09-25 tandrii@chromium.org git cl: cache also LABELS data on a change. Created with: gclient setdep -r src/third_party/depot_tools@c4a7356a469b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b1c545a29a53356bd55613935296c253d6bd0bd Reviewed-on: https://chromium-review.googlesource.com/1244117Reviewed-by:
-
Aaron Leventhal authored
Fix: Plumb through IME state change use to notify of caret change Bug: 887534 Change-Id: If472661b199afcbc8b30b7cb99e6d83b15114942 Reviewed-on: https://chromium-review.googlesource.com/1236735Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#594065}
-
Lan Wei authored
blink::EventHandler::ScheduleCursorUpdate crashes because we schedule the cursor update on the current frame not the local frame root. The mouse cursor update should be scheduled based on the timer of the page not each frame, because we only have one mouse cursor. Bug: 888905 Change-Id: Ia764985f489f68ab91eda38f5aae3d8014e55632 Reviewed-on: https://chromium-review.googlesource.com/1243568Reviewed-by:
-
Dmitry Gozman authored
These are generic containers which make sense in WTF. Bug: none Change-Id: I7966ba923871fab7481c832eae5a16ecfa03c13c Reviewed-on: https://chromium-review.googlesource.com/1237383Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594063}
-
Eric Seckler authored
Change-Id: I57817c7790153d3838f4d9039f62f04261b48390 Reviewed-on: https://chromium-review.googlesource.com/1243289 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Theresa authored
BUG=827658 Change-Id: Id7981b607b150f8b471c0c67a581c9c2f6c1003c Reviewed-on: https://chromium-review.googlesource.com/1243047Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#594061}
-
Ken MacKay authored
Bug: internal b/116252835 Change-Id: I33854f87c93df1be26c4d61adaf8d894ac680af0 Reviewed-on: https://chromium-review.googlesource.com/1237408Reviewed-by:
-
sebsg authored
This is a pre-requisite for the USS migration of Wallet data/metadata. This CL adds a struct that allows manipulation of the metadata independently from the data. Change-Id: Iad50c7f659fc1bda13a3eab47b746194fd316eb4 Reviewed-on: https://chromium-review.googlesource.com/1241754 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#594059}
-
danakj authored
The SetBackgroundColor IPC has been recently moved from RenderView to RenderWidget, but the RenderWidget still delegates handling of it back to the RenderView. The RenderView then sets the background color on its |frame_widget_| which is a WebFrameWidget attached to it in RenderViewImpl::Initialize() via RenderFrameImpl::CreateMainFrame(). All RenderViewImpls do have a frame_widget_, since RenderViewImpl ends up setting that. So RenderWidget::GetWebWidget() will always return that frame_widget_ once RenderViewImpl::Initialize() has completed. There is a space of time after RenderWidget::Init() but inside RenderViewImpl::Initialize() where it would return a different WebWidget (the WebWidget on the WebViewImpl directly), but SetBackgroundOpaque IPC will not be received and handled during that time. So it is safe to use the frame_widget_ from the RenderViewImpl via RenderWidget::GetWebWidget() directly. And thus RenderWidget can set the background opaque on its WebFrameWidget without going through RenderViewImpl (other than to get the WebWidget). R=avi@chromium.org Bug: 419087 Change-Id: I65bf680a24a6312f1c1d569d2023666cbc53e8f6 Reviewed-on: https://chromium-review.googlesource.com/1239169Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594058}
-
