- 09 Dec, 2020 40 commits
-
-
Ben Pastene authored
crrev.com/i/3457056 allocates the machines for this. Bug: 1140727 Change-Id: I46540e4feee5aa68bcc976f11ff6ff84223fb905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582159Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#835252}
-
Brian Sheedy authored
Adds the textpb file for generating an x86 O AVD and adds it to the list of AVDs to generate on the builder. Bug: 1145728 Change-Id: I3c5b69a5c2ac125b6961e1c36a2980253d671344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580738Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#835251}
-
Boris Sazonov authored
If MobileIdentityConsistency, isSyncingUrlsWithKeystorePassphrase should also check that sync is enabled. Bug: 1157046 Change-Id: Ia396b22a08d77f336ac8874f9940cf840ce60301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579785 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#835250}
-
Natalie Chouinard authored
The exclusions that these exceptions apply to were already removed in: https://crrev.com/c/2551492 so cleaning up the no-op exceptions. Bug: 1151370 Change-Id: Ia9b1e4d230a904f2743125fc61a4384828352f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579713Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#835249}
-
Andre Vincent authored
toggle selected: screenshot/7ZNeh5HNji2mnvk toggle not selected: screenshot/9WzpztqnYxkQL56 Fixed: 1154473 Change-Id: Id99211c5881b952cedf7d1b39b5df7a46fbe3b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577654Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andre Vincent <andrevincent@google.com> Cr-Commit-Position: refs/heads/master@{#835248}
-
Yann Dago authored
Bug: 1155194 Change-Id: I79b8e0fc2689853f4ac4de657b0e8f4498830a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571856 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#835247}
-
Joe Downing authored
Change-Id: I7523f17be2b5e8c3c0bd533b0cec223af49fd555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575976 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#835246}
-
Liquan (Max) Gu authored
This CL combines two invocation of createShippingSectionForPaymentRequestUI() into one and simplify the invocation conditions. Before the CL, the method was called in the following control routes: 1. PRService#updateWith() -> CPRService#continueShow() -> if isPaymentRequestUiAlive() -> invoke 2. PRService#onShowCalledAndAppsQueried() -> CPRService#showOrSkipAppSelector() -> PaymentUiService#buildPaymentRequestUI -> if !isShowWaitingForUpdatedDetails -> invoke Observing the invocation conditions of the two routes, we know that they are invoked under the same conditions because: 1. isShowWaitingForUpdatedDetails == false: satisfied by updateWith() show() called and apps queried: satisfied by isPaymentRequestUiAlive(). 2. isShowWaitingForUpdatedDetails == false: satisfied by the if. show() called and apps queried: satisfied by showOrSkipAppSelector(). Based on the conditions, these invocations is equivalent to one in CPRService#onShowCalledAndAppsQueriedAndDetailsFinalized(). Bug: 1155582 Change-Id: Id2978142bd62f4396bdae3937973631bc9408d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575203 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835245}
-
Rahul Arakeri authored
To repro this corner case, scroll using the scroll wheel and click immediately (i.e before the GSE for the wheel is fired) on the thumb and try to drag it. The user would be unable to drag the thumb. This happens because state on the cc::ScrollbarController would have been destroyed (by calling InputHandlerScrollEnd). The state gets cleared because the mousedown on the scrollbar arrives at the InputHandlerProxy before a GSE for the kWheel gesture device was processed. The fix is to first perform a hit test and process the mousedown only if the pointer is on the scrollbar. Bug: 1151956 Change-Id: If08373ea8bfe0b3d8f150e09303dcc39119e3c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562600Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835244}
-
Tommy Steimel authored
This is a reland of 2cf475dd. This adds the module_header.js file to the modules_resources.grdp file, which fixes the issues when optimize_webui = false. Original change's description: > NTP: Allow modules to instantiate the header > > This CL removes the module header from the wrapper and instead allows > the modules to instantiate it instead. This makes the title and actions > properties of the ModuleDescriptor obsolete, so this CL also removes > those. > > Bug: 1152205, 1152216 > Change-Id: Ib524a59c8c8a7cc69e130b31a8557b903233ab95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570390 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834424} Bug: 1152205 Bug: 1152216 Change-Id: Ibded5b577d31961786b90dc15c664a11702a5b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581004Reviewed-by:
-
Scott Violet authored
The name hasn't been needed for a while. This drops it from the API (but not the aidl). This is an incompatible change to the client library, but is backward compatible as the name hasn't been needed since 84 ( https://chromium-review.googlesource.com/c/chromium/src/+/2324172 ) BUG=1154283 TEST=covered by tests Change-Id: Iabbbd524ecb105b079805fb73e65ec23feda9aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580679Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#835242}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/84b9bb6621c7..eb597ff5b7f6 2020-12-09 sugoi@google.com Make Constants a singleton instead of a global If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I77e9c195aeca7dacbf67a7b84433962b39b90b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581335Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835241}
-
Felipe Andrade authored
Sync settings.KerberosErrorType enum with the ErrorType enum in third_party/cros_system_api/dbus/kerberos/kerberos_service.proto. This missing type will be mapped to a general kerberos error message in kerberos_add_account_dialog.js. Bug: 983041 Change-Id: I9231f3b1bc5b77fd2da8e02f8ee7e25db1e4703b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575032Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#835240}
-
Kramer Ge authored
This reverts commit 631cb004. Reason for revert: bisect shows this CL caused lacros chrome frame updates not taking effect when running on ash above this revision. Original change's description: > Fallback to Linear Modifiers if Preferred Modifiers fail. > > Test-Modeset with preferred modifiers. > If it the test passes, save the preferred modifiers to use for full modeset. > If it fails, try testing with linear modifiers for every controller. > Use empty modifiers list if the platform doesn't support preferred modifiers list. > > This enables us to launch Intel Rendering Buffer Compression. > http://go/cros-intelrbc > > BUG=979736,1082882 > > TEST: RBC enabled on (4K eDP with 4K external) and (4K eDP and 2 external monitors), zork, and nautilus > Change-Id: I7698d2cc9f13e5293eb0f6579dee775314988037 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567263 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Cr-Commit-Position: refs/heads/master@{#834389} TBR=dnicoara@chromium.org,markyacoub@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979736 Bug: 1082882 Change-Id: I7bc53db45dffc9d10799d8cf1dd4fdff5639a4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580860Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#835239}
-
Dylan Cutler authored
GaiaCookieManagerService::ForceOnCookieChangeProcessing. This CL is part of a larger effort to make the generic constructor of CanonicalCookie private. CreateSanitizedCookie is a factory method for creating cookies from attributes for a provided URL. Bug: 1102874 Change-Id: I53476eb4d995e969a6cbc8cfa874e09c93de10b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581226Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces Blacklist with Blocklist in FormSaver and renames related APIs. TBR=eugenebut Bug: 1147799 Change-Id: I2b227b48a2b7fe6eb846c719ac86d7d0d8a7288c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579972 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#835237}
-
yilkal authored
This cl makes minor modifications to align locally hosted buttons in the educoexistence flow. Bug: 1147564 Change-Id: Icb8ef9b82cb0b72f8efb2fb20030a40f87774151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580012Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835236}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34e5f31b2cb0..67f7197d74bc 2020-12-09 peary2@gmail.com Changed to WheelEvent instead of non-standard MouseWheelEvent in screencast 2020-12-09 jacktfranklin@chromium.org Ban "front_end" imports from front_end directory. 2020-12-09 morlovich@chromium.org Add a utility for structured header handling (1/3) 2020-12-09 pfaffe@chromium.org [Wasm debug] rename formatter error 2020-12-09 tvanderlippe@chromium.org Add CSSFormatter tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1024752,chromium:1073909,chromium:1145518,chromium:1148179 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id0bc5e2f0f22c301474d685fafbe3a7217c7d290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581999Reviewed-by:
-
Xiaocheng Hu authored
There are some fundamental difficulties in supporting image symbols in custom counter styles. Hence, this patch moves the support behind a new flag to allow revisiting it later. Note: No browser currently supports image symbols. Bug: 687225 Change-Id: I1a35f4b34e007c53539973532ec0295345b26af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581019Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835234}
-
Aaron Krajeski authored
Part of the greater effort to migrate cc and the paint_op_buffer away from SkMatrix, which is 3x3 and relatively slow, compared to SkM44. Playback parameters in the paint operation buffer currently stores the transformation matrix that was on the canvas at the time of creation (original_ctm). This is necessary so the recording can play nicely with save/restore functions. Playback parameters, like everything with the paint op buffer, used SkMatrix to store transforms. SkMatrix is deprecated for the faster and more capable (i.e. can store 3d and non-affine 2d transforms) SkM44. This CL is a step in the migration away from SkMatrix towards SkM44. Bug: 1155544 Change-Id: I26e7329b62d336d92d42b58966d70c112dac8dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575760Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#835233}
-
Joe Mason authored
A follow-up will use this to fill in results for WebMeasureMemory. Bug: 1085129 Change-Id: If3c4ff777b4e4ae80f7a695c42398ea58f7ef2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557730 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835232}
-
Stephan Hartmann authored
https://chromium-review.googlesource.com/c/chromium/src/+/1687411 renamed ideographicSpaceCharacter to kIdeographicSpaceCharacter. Bug: None Change-Id: I5f74dfa489cdca4927a8132bed209549702ca947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574740Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835231}
-
Marijn Kruisselbrink authored
A significant amount of time is spent doing blob related things in these tests, so including Blob trace events in the recorded traces should make it easier to figure out what is going on with performance regressions. Bug: 1156511 Change-Id: I09d0455561a5a01b71f618d7a1de368ea5fd3cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580520Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#835230}
-
Clark DuVall authored
This creates a new throwaway instance of ChromeTabbedActivity in a background thread to warm up the chrome ClassLoader, and mitigate some of the effects of having chrome/base in separate dex files. This runs right after the context is created in the background to give maximum time for the activity preload, otherwise it would have to wait until SplitPreloader.wait() was called or the UI thread task was run. Pinpoint runs: Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/17167144d20000 -12.2% messageloop_start_time -3.4% first_contentful_paint_time -4.3% navigation_commit_time Android Go: https://pinpoint-dot-chromeperf.appspot.com/job/124ca260d20000 -3.9% messageloop_start_time -0.8% first_contentful_paint_time -1.6% navigation_commit_time Bug: 1150600 Change-Id: I60ee5469c8a67ff5c27854fb09b4eeea80f43047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577627 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
As usual, its callers must be made async as well (except in tests), all the way back up to the nearest PostTask. To avoid too many PostTasks, its methods now accept batches of ids. Bug: 1142591 Change-Id: I53be2948dbe46ab020da1cd096ee59b775ac842c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569779 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835228}
-
Adrian Taylor authored
Change-Id: I7042ac6e24e8ed1ba8a1cedee9da73a2819196c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578750 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#835227}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I33bf48d8b8b692dece0ffc672e0163aec7d04634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580400 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835226}
-
Charlie Hu authored
Bug: 1151954 Change-Id: Id0f261a003367bb43ba149c4aa41a598b0a701ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577010 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835225}
-
Primiano Tucci authored
Also add method signature changes to deal with r.android.com/1517038. https://android.googlesource.com/platform/external/perfetto.git/+log/b5c844554e30..83448c4da727 2020-12-09 lalitm@google.com Merge "tp: fix ub of modifying vector while iterating through it" 2020-12-09 khokhlov@google.com Fix NaCl build 2020-12-09 lalitm@google.com Merge "ui: fix cpu time canned query" 2020-12-09 fmayer@google.com Merge "Wrap path data in quotes before passing to llvm-symbolizer" 2020-12-09 marcinoc@google.com Add SysUI CUJ jank causes to Perfetto UI 2020-12-09 primiano@google.com Merge changes I22de67b3,Ief3ea5d6 Bug: chromium:161781469 Change-Id: I43a2cb360bce49be578862ca907db8d0bd751703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582038 Auto-Submit: Primiano Tucci <primiano@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#835224}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org, rsesek@chromium.org Bug: 1144462 Change-Id: Ib88b2e6ffacf214e5ff1880419cf0ff48ff15aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580583Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835223}
-
Yann Dago authored
Bug: 1149462 Change-Id: I1c2742a29e46cef8f30f02c942ba0ec8a34eff54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561528Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#835222}
-
Javier Ernesto Flores Robles authored
Bug: 1110296 Change-Id: I36f85d4b2c03dfb433ec886aaf5189d9bbb7d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580844Reviewed-by:
-
edchin authored
This was originally created in Dec 2017 in this CL: https://chromium-review.googlesource.com/838303 This metric is no longer being used and has already expired since M77. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: If9050d662980fd38bcf8c89cb77ea95c1b2c74ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580405 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#835220}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2a46c6172edb..ed88fdb2f824 2020-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-09 drinkcat@chromium.org Revert "build api push_image endpoint" 2020-12-09 jackneus@google.com build api push_image endpoint 2020-12-09 vapier@chromium.org sdk: start new dir for holding supplemental sdk files 2020-12-09 vbendeb@google.com trigger_cr50_signing: make it generic for gsc 2020-12-09 boleynsu@google.com image_test.py: fix TestBlockedFileTypes accidentally blocking csh files 2020-12-09 engeg@google.com Freshen API bindings 2020-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-09 bmgordon@chromium.org cros_sdk: Check for mounted chroot image 2020-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-08 mmortensen@google.com GatherSymbolFiles: Specify that file collision handling is not needed. 2020-12-08 vapier@chromium.org lint_unittest: drop Python 2 coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I818064ea9244e27cbe8541c05892836e2dd90819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581998Reviewed-by:
-
Xi Han authored
The bug was caused by setting a null TabProperties.TAB_CLOSED_LISTENER when Instant start is enabled. Bug: 1155682 Change-Id: I95190faaf544bea8e524f2a1b2dbe50d66f68430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575209Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835218}
-
Mason Freed authored
Bug: 966758,937746 Change-Id: Ic1c231091f9f0644594ad7df70c60cac09183f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580820 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#835217}
-
Thiemo Nagel authored
This reverts commit 258f8486. Reason for revert: failure in browser_tests/TabStripTabListTest.All As unlikely as it looks (to me), I've bisected test failure to this CL Builder Linux Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 Original change's description: > IO: Use pre-margin target rect for an empty check for intersection threshold > > This patch ensures that we use a pre-margin version of the target rect > if we are checking whether it was empty. This is to make sure that we > compute a "1" intersection ratio in cases where an ancestor of a > margin-padded target causes it to be empty. > > In this case, we should report 1 intersection, because we are intersecting > and target is an empty rect. However, because we padded the target > with a margin, we ended up doing the wrong check and ultimately compute > 0 intersection in a different conditional branch (before this patch). > > This patch restores correct behavior. > > R=szager@chromium.org, chrishtr@chromium.org > Fixed: 1156815 > > Change-Id: I1697388dd127737a0203d1c3ff15095de4ab41df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580046 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834930} TBR=szager@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idf7927cbd535d91db51da4f3f97280c2359e9b97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582059Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835216}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607471901-d1b17db4d547397f57796df9fcd9057f4117af9e.profdata to chrome-win64-master-1607493425-f89e2101ace78ecc71e64b80849cb2e4ad48ac79.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I49ca1de91d840636e22a293415660b15756943e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581407Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e744acfad58..8670c9887529 2020-12-09 bsalomon@google.com Remove SkImage::MakeFromYUVATexturesCopyToExternal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Ib5c69c877655b8e1e5479140b1954fbc76147d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581881Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/30805557e651..99d6c14a3b34 2020-12-09 cwallez@chromium.org CMake: set DAWN_ENABLE_WGSL to ON by default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I65429f8b7174b593364bf12104db67cbe7d9ca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582000Reviewed-by:
-
