GitLab

When the last sample in a profile happen to be a (garbage collector), the
forEachFrame function failed to close last opened stack frames.

BUG=822909

Change-Id: I5165491e1aa1b92466aec339aa848186c89eb9f9
Reviewed-on: https://chromium-review.googlesource.com/967272
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543880}

This is a fix for the bug where 5 user pauses of an offlining request
fails the request because there is a max of 5 tries per request.
Decreasing the started_attempt_count_ when pausing an offlining request
undos the incrementation of the counter when the request began
offlining.

Bug: 701037
Change-Id: I721b41bd9e9a1c366c9fe7f5896f5627e8d8fb1a
Reviewed-on: https://chromium-review.googlesource.com/957423
Commit-Queue: Candice Sy <cmsy@google.com>
Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543879}

virtualKeyboardPrivate.setMode() lacks 'bounds' parameter to set the
virtual keyboard bounds after changing mode.
The new method will replace setMode() with an ability to set bounds of
the virtual keyboard container after changing mode.
It's needed to prevent flashing when changing virtual keyboard
mode. We want to change the window bounds before starting showing
animation.

Bug: 776260, 802991
Test: Manual.
Change-Id: Iacf9977d06e05ac4dd3c66175cae7ba87d5fa0c6
Reviewed-on: https://chromium-review.googlesource.com/942281Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543878}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5505a4a1..9f6698fc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I122a76454515bfdd2649cf8115f6d794f13376cc
Reviewed-on: https://chromium-review.googlesource.com/967245Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543877}

BUG=822231
TBR=mfoltz@chromium.org

Change-Id: I22d30d5c0c6ba309492697605077a94ba994148c
Reviewed-on: https://chromium-review.googlesource.com/967411
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543876}

Bug: 757933
Change-Id: Id2f2e6603b92c5e96c685832ea7946fdef338f9f
Reviewed-on: https://chromium-review.googlesource.com/966799Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#543875}

c/b/safe_browsing/certificate_reporting_service_test_utils.h: Remove unused members in CertReportJobInterceptor

Change-Id: I037853fcb45f8babf359347241a43f3c22ba9f72
Reviewed-on: https://chromium-review.googlesource.com/967343Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543874}

https://skia.googlesource.com/skia.git/+log/16c1196ea6ba..0a86820f2fe3

$ git log 16c1196ea..0a86820f2 --date=short --no-merges --format='%ad %ae %s'
2018-03-16 stani Revert "fix nextContour bug"
2018-03-16 egdaniel Correctly discard or load RT when doing copies as draws in Vulkan
2018-03-16 benjaminwagner Add GT610 Debug ANGLE jobs.
2018-03-15 herb Apply filterTextFlags so the fonts are the same.
2018-03-16 egdaniel Add DoneProc to Promise Images
2018-03-16 reed handle bad xform in drawTextRSXform
2018-03-16 reed fix overflow in rgnbuilder
2018-03-16 rmistry Revert "Remove Android Framework bot from CQ while server is being upgraded"
2018-03-16 caryclark more imageinfo text and warnings and cleanup
2018-03-16 egdaniel Make sure we do a render pass load if we copied to a surface before hand

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: Ie25a4a0b4b0a918ae290623ddade40066025ee4b
Reviewed-on: https://chromium-review.googlesource.com/967247Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543873}

dial_media_sink_service:
  - Added Register/UnregisterOnSinkQueryUpdatedCallback()
  - Start/StopObservingMediaSinks() takes std::string media_source as parameter

dial_media_sink_service_impl:
  - Do not check app availability for discovery only devices

media_router_desktop:
  - Initialize DialMediaRouteProvider if DialSinkQueryEnabled()

media_router_mojo_impl:
  - Use extension MRP to create/terminate route for DIAL sink

dial_media_route_provider:
  - Register OnSinkQueryUpdatedCallback with dial_media_sink_service

Bug: 779892
Change-Id: Iddc760c4fa035c00210480f28de7db96e42fe61c
Reviewed-on: https://chromium-review.googlesource.com/903419
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543872}

This is a reland of e50412fb

Original change's description:
> cros: Convert switch to feature for new overview ui.
> 
> Convert to feature which is enabled by default.
> 
> Test: manual
> Bug: 821608
> Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616
> Reviewed-on: https://chromium-review.googlesource.com/961721
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543139}

Bug: 821608
Change-Id: Id240ddfa8b5551209c61612e406a4a88d5578d02
Reviewed-on: https://chromium-review.googlesource.com/963585Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543871}

Cause of flake was confirmed by adding a slow unload handler to |popup|. This
fixes it.

Bug: 821596, 822635
Change-Id: I602c98a0fb37f9951cc85fb9d886616bb22e8b42
Reviewed-on: https://chromium-review.googlesource.com/967352Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543870}

This interface was never implemented so it's being removed.

Bug: 814528
Change-Id: I24a7e51ac3d7575d91253ac097a5308e1fb22119
Reviewed-on: https://chromium-review.googlesource.com/956684Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543869}

Bug: 807015
Change-Id: I2fb742bfd6d4745362edec1d43afbfb928787a9e
Reviewed-on: https://chromium-review.googlesource.com/954362
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543868}

BUG=822944
TBR=peter@chromium.org

Change-Id: Ibf81ac125ecd066e6c90e1c21788f3938d8380fc
Reviewed-on: https://chromium-review.googlesource.com/967378Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543867}

Bug: 800978, 806912
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1dc46cb8f28783123555fc4be187724ff41d5b70
Reviewed-on: https://chromium-review.googlesource.com/956414Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543866}

* Use range-based for loops
* Use auto (sparingly) to replace ugly iterator naming
* Trust return value optimization to handle vectors

Change-Id: I14ef9fd8d9904b943b0e2d64188d3be5f63ef23d
Reviewed-on: https://chromium-review.googlesource.com/930163
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543865}

Before this change, URL of custom input view of IMEs, which is loaded
by ChromeKeyboardUI when an user invokes Virtual Keyboard, is stored
in global variables in keyboard_content_util and everyone can override
it accidentally.
This change moves that state into InputMethodManagerImpl and adds some
methods to interact with that state.

Bug: 819018
Test: Related unit tests pass and manual testing with ime menu tray.
Change-Id: Ic6f8e0e108c3706ad1ff2ce90aeeb1388704ff36
Reviewed-on: https://chromium-review.googlesource.com/953023
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543864}

AppList will be available only with Ash.

Some mac machines still have apps shortcut in the dock, and Apple do not
have an API to remove things from the Dock. This commit hard codes the
shim handler into AppShimHandler so that we can clean up AppListService
classes.

This commit:
- moves InitAppsPageLegacyShimHandler for mac out of AppListService;
- removes references to AppListService from mac.

Bug: 733662
Change-Id: I66bca8851bf2427a5cd16f3046680e304d1ee368
Reviewed-on: https://chromium-review.googlesource.com/963684Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#543863}

Bug: none
Change-Id: Ifb24f706c5ba62b529adc8be0c574530f2cb99a5
Reviewed-on: https://chromium-review.googlesource.com/966595Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543862}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3a80b69082f..544b744621b7

$ git log a3a80b690..544b74462 --date=short --no-merges --format='%ad %ae %s'
2018-03-16 sergiyb Add option for printing changes grouped by issue

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I655adf01196aaee07f3180d90238ed9222d6eaeb
Reviewed-on: https://chromium-review.googlesource.com/967240Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543861}

This forms the basis of the WebXR Input system when used in Magic Window
mode.

Bug: 812287
Change-Id: Ibea7df8b173e378c563e011de23ab6bc5448af9f
Reviewed-on: https://chromium-review.googlesource.com/952230
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543860}

This test is flaky on Linux ASAN and Android, sample failure from Android:
```
logging::LogMessage::~LogMessage()
base::internal::WeakReference::Flag::Invalidate()
base::internal::WeakReferenceOwner::~WeakReferenceOwner()
content::SimpleURLLoaderTestHelper::~SimpleURLLoaderTestHelper()
content::(anonymous namespace)::LoadBasicRequestOnIOThread(network::mojom::URLLoaderFactory*, GURL const&)
content::NetworkServiceRestartBrowserTest_BrowserIOSharedFactoryAfterStoragePartitionGone_Test::RunTestOnMainThread()
```

This CL makes sure that |simple_loader_helper.GetCallback()| was
only accessed on UI thread (where |simple_loader_helper| lives).

(I cannot reproduce the flakiness locally, will see if this fixes
the issue.)

Bug: 822585
Change-Id: I74de7dd4708f20dcb2f0145228d6de19ac7f15b3
Reviewed-on: https://chromium-review.googlesource.com/966985
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543859}

Original patch: https://crrev.com/c/962928
Reverted in: https://crrev.com/c/965022
Reason for revert: Broke iOS build.
Reason for reland: Fixed iOS test expectation.

TBR: anthonyvd@chromium.org
Bug: NONE
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia9c4b3f21c7c8682a07e6c3675f2a754350c1fe1
Reviewed-on: https://chromium-review.googlesource.com/966783
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543858}

Majority of the keyboard layouts use "Esc" or "esc" to present
"Escape". This cl adds special handling to display VKEY_ESCAPE
in Keyboard Shortcut Helper (KSV).

Bug: 821841
Test: manually tested.
Change-Id: I3b514325b5cc371c33c64973d0b0e3f9ee9548c6
Reviewed-on: https://chromium-review.googlesource.com/966872Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543857}

This feature is to allow the creation of NSWindows in the app shim
process instead of the Chrome browser process.

AppShim instances will inherit the behavior of whatever Chrome
instance they attach to.

If the Chrome instance has this feature enabled, then it will send
messages to the AppShim telling it to establish connections to
create windows.

Bug: 821651
Change-Id: Ieaef0f8c61fc93e6c187a8c5e4e21c9ff2a740eb
Reviewed-on: https://chromium-review.googlesource.com/965268
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543856}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567

$ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s'
2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.""
2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2]
2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket.
2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob"
2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.
2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob
2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland.
2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds.
2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues.
2018-03-14 ihf chromeos_config: add more arcnext experimental coverage.
2018-03-14 ayatane autotest-pre-cq: Remove this [1/2]
2018-03-14 norvez chromeos_config: remove dead code
2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning.
2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation.
2017-09-14 craigb image_test: Remove check that kernel is not ELF.
2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental"
2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq"
2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config
2018-03-13 achuith cbuildbot: Add missing files to index.
2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion
2018-03-13 dgarrett precq-launcher: Start using Legoland build details page.
2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest.
2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq
2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental
2018-03-12 haddowk [chromite] Make guado_moblab important again
2018-03-13 chrome-bot Update config settings by config-updater.
2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite
2018-03-12 yunlian Enable ThinLTO on all AMD64 boards.
2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON.

Created with:
  roll-dep src/third_party/chromite
BUG=821930,822517,821615,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib6aaddf338307e994865a092ecb322a432148692
Reviewed-on: https://chromium-review.googlesource.com/967273
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543855}

He's already in //ash/OWNERS and this code is mostly delegates/clients
of the ash code.

Bug: none
Change-Id: I9e11ebc25c8aab35073760f7548cceb5325b5303
Reviewed-on: https://chromium-review.googlesource.com/966542Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543854}

Vector graphics will allow to implement scale animation without scaling
the image. This change introduces the animation, but breaks certain
things which will be fixed in follow up CLs:
 - no blue checkmark or red error icons
 - progress bar does not have download track anymore
 - progress bar radius is bigger

Bug: 820178
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3baa17a2a65b113714bee01bc082edae95953573
Reviewed-on: https://chromium-review.googlesource.com/964593
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543853}

https://chromium.googlesource.com/angle/angle.git/+log/6f5444da73ae..dfebe9b2d5d9

$ git log 6f5444da7..dfebe9b2d --date=short --no-merges --format='%ad %ae %s'
2018-03-14 jmadill D3D11: Add dirty bits for Transform Feedback.
2018-03-14 jmadill Vulkan: Enable SimpleVertexShader.
2018-03-16 jmadill Vulkan: Implement depth range correction.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I7ad17405f7e26059e3de67ff53ca5d49cf3edab0
Reviewed-on: https://chromium-review.googlesource.com/967253
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543852}

We should not be sharing files from our private directory, they are not
sharable, and could cause a crash.  This change marks the file as not
sharable (when the P2P sharing flag is turned on) so we avoid the crash.

To tell if the file is in a private directory, we add a new file to the
OfflinePageBridge to get the information from the C++ side.

Previously there were no unit tests for maybeShareOfflinePage().  This
change adds some unit tests for it as a basis for checking the sharing
restriction, then adds more tests for the sharing restriction.


Bug: 817611
Change-Id: Ic0361a6eaf2698562a4998c2e027081c76318bc5
Reviewed-on: https://chromium-review.googlesource.com/961542
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543851}

- sets grid background color
- sets colors for empty state
- switches done and close all buttons for bottom toolbar

Bug: 818198
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaae31633889c8f013c5ea1da59176f75186df434
Reviewed-on: https://chromium-review.googlesource.com/967278Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543850}

Download Manager has the following UI elements:
 - state icon
 - status text (f.e. <File Name> 10 MB)
 - action button (f.e. Download)
 - close button

Status text width is highly variable and often does not fit the UI. So
status text width should be flexible and action button width should be
constant.

This sets setContentCompressionResistancePriority: for status label to
UILayoutPriorityDefaultLow.

Bug: 822768
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9505511e7d3a1a8dbcf22c7df406530cb270c55a
Reviewed-on: https://chromium-review.googlesource.com/966794
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543849}

This CL replaces ApiCompatibilityUtils.objectEquals and it's usages with
ObjectsCompat.equals method from Android support library. It also fixes
VisibleNetworksTest that had VisibleWifi objects in static field, as
it doesn't work well with Robolectric (ObjectsCompat.equals was
triggering a crash in that test, because it uses Build.VERSION.SDK_INT).

Bug: 782824
Change-Id: Ifba3325b2dd0102c3097e9dfcf0676d7a2c75fc6
Reviewed-on: https://chromium-review.googlesource.com/964663Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543848}

Our decoders ignore zero-byte packets, so there's no reason to send
them out of the demuxer. They should just be dropped at the time of
demuxing. Also cleans up weird .get()-> syntax from yesteryear.

BUG=none
TEST=existing test pass.

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I99ddd10d3156cecb3a5edd6f3b940d96530f3184
Reviewed-on: https://chromium-review.googlesource.com/965393
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543847}

All usages of NO_TRAFFIC_ANNOTAITON_BUG_656607 temporary annotation are
replaced with actual annotations and this tag can be removed.

Bug: 656607
Change-Id: If38d15152cbaa3df79d4d9b4d8146d0ca9119a39
Reviewed-on: https://chromium-review.googlesource.com/960083
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543846}

TBR: waffles
Bug: 687231
Change-Id: Id355aa2f6a153ba2c875ae018b0a9965015660b0
Reviewed-on: https://chromium-review.googlesource.com/967243Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543845}

Bug: 821126
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3fcb54a054c66184a0e6f6e54d5139ddd7346441
Reviewed-on: https://chromium-review.googlesource.com/967363Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543844}

Pressing back button should only handle closing of the sheet and not
dismissing Chrome.

Bug: 814528
Change-Id: Iad2cafce82aa982b0645fb794a86b7a0e9d4ce36
Reviewed-on: https://chromium-review.googlesource.com/965275
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543843}

This change switches SmbFileSystem to routing all calls to
SmbProviderClient through an SmbTaskQueue.

Test: verified manually on eve
Bug: chromium:757625
Change-Id: Id3466a5cbd0858070bf7170f1358d88bd8d32334
Reviewed-on: https://chromium-review.googlesource.com/957477
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543842}

The position of a nested sticky layer depends on the position of its
sticky ancestor.  If the ancestor hasn't been positioned, we get the
wrong offset from StickyPositionScrollingConstraints.

PLSA's iteration over the StickyConstraintsMap has unspecified ordering.
Instead, use the recursive tree walk of UpdateLayerPositionRecursive
(but preserve the optimization of skipping non-sticky layers when the
root PLSA is scrolled).

Bug: 821216
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I61ca51a69fdbb857d88713afcdd92f8615930cd1
Reviewed-on: https://chromium-review.googlesource.com/963516Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543841}