- 09 Oct, 2019 40 commits
-
-
Sahir Vellani authored
Remove checks in scrollbar.cc for kScrollbarInjectScrollGestures as it is shipped on-by-default to stable release. Remove the flag and all references to it. Bug: 1010668, 954007 Change-Id: If72137f6e6c1a77247ec354a076826205984fec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842317 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704284}
-
Sigurdur Asgeirsson authored
Bug: 953031 Change-Id: I1f74e20583840d40ab8d2c99c86f44125bad7143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845966 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#704283}
-
Nate Fischer authored
No change to production logic. This fixes a crash in AwBrowserContextTest. The issue was the second test in the suite (regardless of what that test did) would crash as soon as the setup constructs a TestContentClientInitializer. This is because a posted task created a NetworkConnectionTracker, running after TestContentClientInitializer's destructor nulled it out. It's invalid to re-set a NetworkConnectionTracker without first clearing it, triggering a DCHECK. We avoid this by pumping through the UI thread looper during the test teardown, so we're sure the background task has executed prior to destroying TestContentClientInitializer. This also fixes a memory leak in the test setup/teardown (we need to clean up the AwBrowserProcess instance), although this was unrelated to the bug. Bug: 990547 Test: run_android_webview_unittests --num_retries=0 --gtest_filter=AwBrowserContextTest.* Change-Id: I16d03a1cf6d813b7052b8205d2936864397fc21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849174 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704282}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=tdresser@chromium.org Bug: 1007760 Change-Id: I52907b719b57b5adef468b020a6ddce0961c4330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849487 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#704281}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e27a503a0a21..2579de4567d5 git log e27a503a0a21..2579de4567d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 robertphillips@google.com Tighten up creation of the GrProgramDesc and remove some unnecessary checks 2019-10-09 kjlubick@google.com [canvaskit] Update to build with emscripten 1.38.47 2019-10-09 bungeman@google.com Retain hints when subsetting for PDF. Created with: gclient setdep -r src/third_party/skia@2579de4567d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:1010396 Change-Id: Ibaab7478618e595bb635c1742a31defd34b185b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704280}
-
Etienne Bergeron authored
The VR code is using the default font "sans-serif". The Font (and FontList) on that platform is the PlatformFontSkia When creating the font with the literal "sans-serif", there is not matched typeface. The function creating the typeface has a fallback path that try "sans" which is the resulting typeface used. see: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_skia.cc?l=53 This CL avoid to use that fallback logic. Instead, we rely on the FontList behavior to use the default system font with the default constructor. R=alcooper@chromium.org Change-Id: I612502f32d77787b8f0346c0fc23cd65b68e3013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847902Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704279}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b91063d99c88..ce36989ab9e3 Created with: gclient setdep -r src-internal@ce36989ab9e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8c7e4f604307c5350c1629df40369177a905d7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849186Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704278}
-
Brian Sheedy authored
Switches use of PrintResult in services_perftests to PerfResultReporter and whitelists the test suite for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: Ia6640f2ba9c16d28fec876446fc19a0d206d2cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848480Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#704277}
-
Oleh Lamzin authored
Change wilco dtc supportd host origin extension id to the new one. TEST=none BUG=none Change-Id: I2b4237d60699b4b9bab121f1c69d803c569d4d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845761Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#704276}
-
ssid authored
Some Android versions do not fill in virtual size. This metric is not really used in traces. So, remove the dcheck and add dcheck to test if resident size is working. Revert disabling CL: https://chromium-review.googlesource.com/c/chromium/src/+/1642151 Adds functionality to BrowserTestBase to initialize memory-infra. See https://chromium-review.googlesource.com/c/chromium/src/+/1606424 BUG=970058 Change-Id: I018c33c4afd3bc8f4f2b13c13cb8c2f5256edcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691586Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#704275}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mek@chromium.org Bug: 1007760 Change-Id: I6262b22a845af0d8956e7388d36f41feaa12338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849485 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704274}
-
Evan Stade authored
This allows the chrome target to compile on CrOS with the ScopedObserver changes. Bug: 998625 Change-Id: I5907d0d1910c616ba72dfc887e8ee1c0188ca56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842672 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#704273}
-
Stefan Zager authored
BUG=1012596 R=pdr@chromium.org Change-Id: Ia7b38bc868f37bfe9aca4f276187a2543ae42750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849584Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#704272}
-
Mitsuru Oshima authored
1) Update the scale <> dpi table to match CrOS PPI spectrum (https://docs.google.com/spreadsheets/d/1MJsN_HeZDvjAycabULqiatnXckr8r2KAuvSTJy3xEss/edit#gid=0) 2) Remove obsolete hack for b/74845106 Bug: b/74845106 Test: None Change-Id: I245a6ab3f139d64a273e425bbcd952dc47a53f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850273Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#704271}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e09869ed5268..e16a901fb853 git log e09869ed5268..e16a901fb853 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 bryan.bernhart@intel.com D3D12: Move resource into allocation handle. 2019-10-09 enga@chromium.org Skip tests if no adapter is available 2019-10-09 cwallez@chromium.org Make the dynamicOffsets optional in SetBindGroup. 2019-10-09 rharrison@chromium.org Roll ahead to fix and update .gni to unbreak shaderc Created with: gclient setdep -r src/third_party/dawn@e16a901fb853 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: If1ed302990f0efa3c15ef98d7ebb7d0b31b3cc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849588Reviewed-by:
-
Jasper Chapman-Black authored
No-Presubmit: true Bug: 1011921 Change-Id: I7726c1100978d0cbc73e62d2f2ef39f8f1bdf98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849941 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#704269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f86cc6ba6a29..bc88fe8e4a2c git log f86cc6ba6a29..bc88fe8e4a2c --date=short --no-merges --format='%ad %ae %s' 2019-10-09 lamontjones@chromium.org trigger_cr50_signing: use compiled build api. Created with: gclient setdep -r src/third_party/chromite@bc88fe8e4a2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib33ade87bc750b87756dc683c988ae314151f0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849178Reviewed-by:
-
Steve Kobes authored
This partially reverts crrev.com/700726, which removed the threshold, and caused significant perf benchmark regressions (see linked bugs). The test that verified the existence of the threshold is not restored, since we no longer intend to spec this behavior. Bug: 1003893,1009569,1009641,1009801 Change-Id: I284e53ba1f4c4c36cfcb2b54eaf5122758530c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848899Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#704267}
-
Peter Kasting authored
This is hopefully unnecessary now, and causes problems for views that paint to a layer and outlive their windows. Bug: none Change-Id: I211e30550af9923bca821e3d7a65b8e112211185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848911Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1007760 Change-Id: I682335ec1e5b64a1b8523be7b05e551d3b0e56eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849483 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704265}
-
Alexander Timin authored
Delete RenderFrameHostTester::SimulateNavigationStop as all relevant work should be done automatically by NavigationSimulator. R=clamy@chromium.org,ahemery@chromium.org TBR=mmenke@chromium.org,csharrison@chromium.org, BUG=1011770 Change-Id: I48009cc5b1c4e018626121cbf904c63e4af2000e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834150 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#704264}
-
Maks Orlovich authored
Change-Id: I41e011a0fae441369f4ca0474ba1706246803cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849120Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#704263}
-
Sahir Vellani authored
Updated thumb position calculation in GetScrollOffsetForDragPosition to yield 1.0 if the thumb position is calculated to be > 0 and < 1. Added more test cases in mouse-scrolling-on-div-scrollbar to test scroll offset when scrollbar is dragged some portion along the track. Bug: 1009892 Change-Id: I3a649c583dcb025773511619fce7564e71ccd131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833791 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
-
Charlene Yan authored
Also migrated off HoverButton. Bug: 1003911 Change-Id: If60bee2739530094e95fbe06584706a13f979ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846086 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704261}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mek@chromium.org Bug: 1007760 Change-Id: I6bf1a807b55ea0c6075a1fdf6b4a7a5a77f92789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849544 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Bug: 999236 Change-Id: I85ebdf7da06874cb55672fab6ec7071144858418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825958Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704259}
-
chrome://omniboxmanuk authored
Above each response, the debugs page displays result details including: 1) cursor position 2) elapsed time 3) all providers done 4) host 5) has isTypedHost These are updated when inputting into the HTML omnibox, but when inputting into the window omnibox, only (3) is updated correctly. This CL: 1) Updates the 5 fields when inputting from the window omnibox. 2) Adds 'input type' (e.g. URL). 3) Wires in cursor position similar to the other 4 fields from the page handler and removes the hacked cursor position wired in from query inputs. 4) Updates the label for (5) to 'is typed host'. 5) Rearranges related variables to be consistent between files. Bug: 1011632 Change-Id: I830b4af3d01d18faafbdaaeaea8614624a401c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846311Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704258}
-
Will Harris authored
This CL contains no functional changes, but unblocks work on OSCrypt. BUG=1012495 Change-Id: If50354853c4d2fa287acadf45a6937c15a38809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848575Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704257}
-
Justin Cohen authored
This reverts commit 8f80402d. Reason for revert: broken downstream tests Original change's description: > [multiball] Replace AppDelegate's window with Scene's window. > > Adds |window| property to SceneState. It is backed by SceneDelegate's > |window| property and by UIWindowScene's |scenes| property on iOS 13 > with multiwindow; or with an ivar otherwise. When it's an ivar, > SceneController is now responsible for window creation. > Note that the getter for AppDelegate's window remains for iOS 12 compat. > Note that the window is always a ChromeOverlayWindow. > > have tested it manually on my machine and it still works) > > Bug: none > Test: verify that the incognito screenshot blocker works as expected (I > Change-Id: Ic418ece228854e43aa0e4c9d9e503c1b54bca901 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827373 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701569} TBR=marq@chromium.org,stkhapugin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012794 Change-Id: I895ea478396be1db4265b8a092d6b12fed76bc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849432Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704256}
-
Connie Wan authored
Rather than repainting the active tab always, only repaint it in the situations when it's needed: 1) if it's added to a new group (since in some cases the tab will not move, and therefore will not be repainted), and 2) if the group color changes (since again this doesn't cause relayout and may not cause repaint). This significantly reduces the CPU that tab groups uses. With just 1 tab, it was a difference of ~0.3% CPU w/o groups vs. ~1.4% CPU with groups (at least on my machine, with a local build). Now both are comparable at ~0.3%. Bug: 1009138 Change-Id: Iab07698de2711af936e25002ee9deab2f916ac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845825 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#704255}
-
Tibor Goldschwendt authored
We don't forsee that being used. Thus, remove code and reduce maintenance burden. Bug: 1012714 Change-Id: Ia3d93513c39f67e4a1c120e6b0688b4734a0aba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849940 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#704254}
-
David Roger authored
This CL saves the identity pill animation time in a user data attached to the profile, and a histogram that records how long after the animation the button was clicked. This will allow to confirm whether users tend to click more on the button after the animation. This information is also used to show the identity pill only at Chrome startup, as opposed to every window creation. Bug: 1009441 Change-Id: Icbfa9a3175340eca42d1686a93499991e1897a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844988 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#704253}
-
Andrew Grieve authored
Change-Id: Icb892aa6fec0fd5f38582f604bbe8e81bcfccdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849097 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: none Change-Id: I90e76f3c0c441fbbb32449cb7a85c8da774e643a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849122Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#704251}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1007760 Change-Id: Ic923e29d988364e6e5eb31ee37e5bc2c6d77d501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849479 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
large-uniform-buffers.html is now passing after a fix in ANGLE. Bug: 906683 Bug: angleproject:3388 Change-Id: I3cfeb9a3a3aa0290da019077c10032f9f6c3df84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848419Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#704249}
-
Friedrich Horschig authored
This CL adds the TextView showing the origin for PSL matched credentials if there is one. Colors, height and margins are adjusted accordingly. Screenshots (one for eliding, one for a simple label are in the bugs). Bug: 1011833,1012184 Change-Id: Ie6968579557aafc70e9ed0ce1d2cba90e4e3d193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848389 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
1. Switch ScrollbarLayerInterface to ScrollbarLayerBase which is in the layer class inheritance hierarchy, to avoid the need of ScrollingCoordinator::ScrollbarLayerGroup. I think we added ScrollbarLayerInterface when we might have different parent layer class for the different scrollbar layer classes. This is no longer the case. And that won't be the case for crbug.com/1009291. 2. Remove SolidColorScrollbarLayerImpl's is_overlay parameter because it's only for overlay scrollbars in real world. Bug: 1009291 Change-Id: If12422481330b1d778899180c1147d52948fce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845489 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e1092c0bc8b8..955f8fd0477e git log e1092c0bc8b8..955f8fd0477e --date=short --no-merges --format='%ad %ae %s' 2019-10-09 perkj@webrtc.org Add virtual method rtcp::RtcpPacket::SetSenderSsrc 2019-10-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b2d00427..8e1616e4 (703937:704145) 2019-10-09 aleloi@webrtc.org Removing outdated tests. 2019-10-09 peah@webrtc.org AEC3: Send the spectral power estimates for all channels to AecState 2019-10-09 nisse@webrtc.org Delete large up-front allocation in LibvpxVp8Encoder::InitEncode 2019-10-09 gustaf@webrtc.org Run fullband processing at output rate on ARM 2019-10-09 peah@webrtc.org AEC3: Remove redundant class 2019-10-09 eshr@google.com Add Duration field to EventRateCounter 2019-10-09 saza@webrtc.org Delete AecState::EchoPathGain() Created with: gclient setdep -r src/third_party/webrtc@955f8fd0477e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:1012256,chromium:b/130016532 Change-Id: Iff2a55dcd7c672360792f55bb79fb7b6173ea188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849261Reviewed-by:
-
Aaron Colwell authored
- Adds logic to CPSPI::CanCommitOriginAndURL() to verify opaque origin precursor info and documents exceptional cases that need followup work. - Extended URL origin check and "same origin" checks in CPSPI::CanCommitOriginAndURL() to apply to all URLs instead of just "standard" URLs. - Updated RFHI::CanCommitOriginAndURL() origin check for debug URLs to also apply to opaque origin precursors. - Update DocumentLoader::FillNavigationParamsForErrorPage() to force the error page commit origin to be an opaque origin with precursor info that matches the original document's origin. This ensures that the error page origin will be consistent with the process lock of the process that the error page is displayed in. Bug: 991607 Change-Id: Iec661e29880fcaf8e066bb2f1c3e5e6cf292decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837093 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704245}
-
