- 21 Aug, 2019 40 commits
-
-
Vladislav Kuzkokov authored
This reverts commit 75116336. Reason for revert: crbug.com/996271 Original change's description: > [Printing] Don't create unnecessary PrintSettings instances. > > Make |PrintingContext::settings_| null before settings are created or > after ownership is passed to PrinterQuery. > > Bug: 964948 > Change-Id: I0cff0b5b460ecb3424ff0cb07e5849bed3ffe51e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678182 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688541} TBR=thestig@chromium.org,vkuzkokov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964948 Change-Id: If0dfec489dcbb8e38f2fbf3e8510904dc80893f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758237Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#689099}
-
Gabriel Charette authored
As discussed @ https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84 Usage of explicit everywhere also avoids implicit copy construction and is the reason for changes to a few unit tests that previously used operator= to initialize their task environments. TBR=dcheng@chromium.org (for widespread mechanical change) Bug: 992483 Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#689098}
-
Gabriel Charette authored
This is a reland of dd34a877 Rebased on a few more fixes including a local full build of: - Windows + is_chrome_branded - ChromeOS + is_chrome_branded (except for the libassistant portion which is giving weird errors...) Original change's description: > Reland [base] Require task posters to specify an explicit destination > > This patch makes it a requirement for all task traits to specify their > thread affinity. Previously task traits that did not name a specific > thread would implicitly run on the thread pool, which could be > surprising. To make this more obvious, thread pool tasks must now use > the base::ThreadPool() trait. > > This is the final reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1635827 > (will attempt to fix errors that caused original revert before > relanding). > > Bug: 968047 > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688782} Bug: 968047 Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#689097}
-
Dominic Farolino authored
This CL stops referencing the local variable |new_response| after we assign the private |new_response_| to it, for consistency. Bug: N/A Change-Id: Ide27ddae64cc20e870a6d27e71d9636ab41a7f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760578Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#689096}
-
Alison Maher authored
Inline background images are painted after backplates are drawn in forced colors mode. This breaks the ensured level of contrast for such elements. To account for this, background images are ignored for inline elements when forced colors mode is enabled and forced-color-adjust is auto. Bug: 970285 Change-Id: I609eb1779ed3a9d964cb6165e5452b9d2a9666e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757685 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689095}
-
David Bokan authored
Event sender is used only in web_tests. Tests shouldn't ever set this case up but we shouldn't ever crash. Bug: 996071 Change-Id: I4fa1ef12d934b1698ca2f70070bcb509355dd491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763375Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689094}
-
Tricia Crichton authored
All remaining commands that changed in W3C mode, were updated to point to the command_executor version, which uses the correct W3C syntax. Bug: chromedriver:3076 Change-Id: I12234e4bb6462daf5c79b916d9b33bd127892653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763301Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#689093}
-
Mohamed Amir Yosef authored
Change-Id: I63c4f71016101a761e6ecb67233bce79bf922fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741920 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689092}
-
Min Qin authored
This CL treats extension downloads from untrusted sources as regular downloads. That means these downloads will be prompted, show up in downloads page and download shelf as normal downloads. BUG=756825 Change-Id: I515bba2fa0a64198a56a06ce38864ef59ad18c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761374Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689091}
-
George Burgess IV authored
In the linked bug, we discovered that clean Chrome links with ThinLTO enabled consume quite a bit of memory. In my measurements, Chrome OS x64 links take around 49GB, and a standard Linux ThinLTO link takes around 46GB. Build command: $ /usr/bin/time -v ninja chrome [snip] Maximum resident set size (kbytes): 46337504 [snip] $ cat args.gn target_os = "linux" target_cpu = "x64" use_goma = true is_official_build = true is_chrome_branded = true clang_use_default_sample_profile = true use_thin_lto = true (the last two args should be redundant in this case) Measured similarly, Android's build takes 8-9GB on ARM, so it gets to stay at 10GB. Bug: 988364 Change-Id: Ia1bbf6b441dcb9219a37842060e72eebe7ec687e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755189Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#689090}
-
Mohamed Amir Yosef authored
This unblocks upcoming patches that would allow accessing the used fcm_network_handler for testing purposes. Change-Id: Ia940186ba7558a84433950265e80bea4c83d2b85 Bug: 985287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710658 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689089}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/880b6f75..ffe7b037 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7961210558b637f6d4970be5cd0ca4e0f27037d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763873Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689088}
-
Daniel Rubery authored
This CL adds a policy to control the WebProtect feature DownloadDeepScanning. At the moment, the policy is only set to allow an audit only mode, but will be expanded in the future. Bug: 980777 Change-Id: I9f4b2a335c877886c1e95c86eb97bdab9bb9d456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737267Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#689087}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iddce69d9cbab48559833519909656afb0d687cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763199 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689086}
-
Brian Geffon authored
WorkingSetTrim on ChromeOS involved new kernel changes, to avoid potential issues related to experimentation the Catan team may be doing we will disable this feature by default on ChromeOS. TrimWorkingSet on ChromeOS involved a fairly large kernel change, the concern here is that if we made a mistake that causes kernel panics we may not be watching the right metric or aware that it's being exercised. BUG=chromium:973963 Change-Id: I8b0702b61bb92519c077762ebd29297e615e6ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758603Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689085}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/206946fb061b..a15c33510ba9 Created with: gclient setdep -r src-internal@a15c33510ba9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie3cc9e363a305613aaf119d2f277524a7ed7689f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763331Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689084}
-
Brandon Jones authored
Moves the 'immersive-ar' session mode and environmentBlendMode attrib behind this flag. (Was previously behind the WebXRHitTest flag.) Bug: 994830 Change-Id: I3ed8e25ea0cc7abe0e3dc9fe4e3515662333cbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758542 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#689083}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea6c98081e94..ad10df694213 git log ea6c98081e94..ad10df694213 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 12b0343d8960..47820316fcec (1 commits) 2019-08-21 bsalomon@google.com GrSurfaceContext not ref counted. 2019-08-21 reed@google.com improve verts bench 2019-08-21 brianosman@google.com Conservatively consider any path with tiny edges to be concave 2019-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 6655095842ec..12b0343d8960 (1 commits) Created with: gclient setdep -r src/third_party/skia@ad10df694213 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None,chromium:993330,chromium:None Change-Id: I2cbe3c6105a190e12beceeea6e9ba8f12fb00a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689082}
-
Dan Harrington authored
Added a new histogram 'Session.Background.TotalDuration'. This is recorded in every log which contains a background session. When the UMABackgroundSessions feature is enabled, we also attempt to open new UMA logs on foreground/background transitions to segment foreground/background UMA. The primary goal is to learn which whether any given UMA histogram is being reported in the foreground, or the background. Bug: 954310 Change-Id: I7cb5bdbdc9d153e32bc283065f8147d548a82f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650526Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#689081}
-
Tanmoy Mollik authored
As part of making sync manual_start for android the user needs to be aware that the initial setup process was interrupted and sync is in an incofigured state. This should be reflected on the main settings page and the user can either start sync or stop sync from syncAndServicesPreferences page. Either way FirstSetupComplete will be true after user has seen and interacted with it in the syncAndServicesPreferences page. Screenshot: https://crbug.com/991522#c2 Bug: 991522 Change-Id: Id65cccc62933dd6a7446ad577e066b909bf28eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744487Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#689080}
-
Alexei Svitkine authored
Originally landed as: https://chromium-review.googlesource.com/c/chromium/src/+/1746909 This reland has a fix for the bug where core system profile information was being cleared by RecordEnvironment(). In the reland I'm removing the IsTestingID() logic was interfering with a new test I'm adding and that turned out to be unnecessary for any other test. Prior to this change, only an incomplete system profile, notably missing field trials and uma_default_state fields, was stored at this point. So unclean shut downs after this point in time, but before the initial metrics log was saved would not include that info. This change fixes that by running the code that populates all the system profile fields. Since we're now calling ProvideSystemProfileMetrics() twice, the logic in FieldTrialsProvider was no longer correct in tracking the log creation time. Instead, this CL updates the API to have that be passed in. Additionally, Chrome OS an Screen Info providers needed updates since their dependencies are not yet available this early, so they are not able to provide all the information this early. Finally, webview unit tests needed updating to init mojo as they are now exercising the provider code which has a Mojo dependency. Bug: 992538 Change-Id: Id52b63bb4d98b9f6133b3ba202b9253eaa88c195 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746909 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#687000} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758436 Cr-Commit-Position: refs/heads/master@{#689079}
-
Sam Maier authored
This is done with the internal generator script @134450902 with cr/264390460. Bug: 995865 Change-Id: Ia7a485d39bcd80a6ca28e2519ea4e1c716c62354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761443Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#689078}
-
Gabriel Charette authored
This is a precursor to https://chromium-review.googlesource.com/c/chromium/src/+/1761362 which is making destination a mandatory trait. @OWNERS: Please verify that these traits indeed intended to post to the ThreadPool. Bug: 968047 Change-Id: Ia7c9bb718325e5fac727421aa62b6e6034987d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761363 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689077}
-
Nico Weber authored
The build hasn't used gcc for a long time now, and we've been off svn for a while as well. Bug: none Change-Id: I3c90b7395bec146dc29bd86b869d55e1f68550fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763872 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#689076}
-
Ben Mason authored
Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#689075}
-
Joe Mason authored
This is a reland of e5f1b06d It was reverted in https://crrev.com/c/1760644 for causing test failures on CI builders that couldn't be reproduced on other machines. This patch disables the failing tests. A followup will reenable the tests with extra debugging to diagnose the failures on the CI builders. TBR=wfh TBR_REASON=Reland of test-only proto change that was already reviewed. Original change's description: > Implement ProtoChromePromptIPC. > > Bug: 969139 > Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@google.com> > Cr-Commit-Position: refs/heads/master@{#688357} Bug: 969139 Change-Id: Iafdc22cc06fbedd5de73bf8bb7881fc46e01f350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759154Reviewed-by:
Joe Mason <joenotcharles@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689074}
-
Scott Violet authored
This provides mapping in ComputedStyle for box-flex to flex-grow/flex-shrink. It would seem LayoutFlexibleBox gives different behavior than LayoutDeprecatedFlexibleBox in regards to this value. We'll have to decide if we want to match that separately. BUG=993813 TEST=none Change-Id: I3a6b1511c7b313242a12b0a96aa5b9cd41c89c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762929 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#689073}
-
Becca Hughes authored
If there has never been any playback on the page and we enter Picture-in-Picture then there will be no buttons on the window since there is no media session. Therefore, this adds a play button on the window until media session takes over. BUG=996001 Change-Id: I5cbb6d4f4a4b23c2a998c8b1a0cae628ee6a27ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762933Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#689072}
-
Scott Violet authored
This is the start of getting rid of the usage of MostVisitedURL::redirects from TopSites. It turns out the redirects can be *huge*. Redirects are used for only one thing, to optimize deleting a url. That is, when a url is deleted storing the redirects helped to avoid unnecessarily querying history. Given redirects can be huge, and deletion is infrequent, this optimization isn't worth it and I'm going to remove the complexity. This patch removes the optimization and changes TopSites to always query history after removal. Assuming this lands, and sticks, I plan to change around the database side and hopefully completely remove MostVisitedURL::redirects. BUG=995906 TEST=covered by tests Change-Id: Id0ec659e112776b89b69ad916ac5c7f6ab723f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762441 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689071}
-
Vlad Tsyrklevich authored
GWP-ASan [1] is a probabilistic heap memory-error detector meant to be deployed in-the-wild. Add calls to initialize GWP-ASan during WebView initialization (gated by feature flags) and white list the annotations GWP-ASan uses to communicate with the crash handler. [1] https://chromium.googlesource.com/chromium/src/+/master/docs/gwp_asan.md CQ-DEPEND=chromium:1757160 Bug: 973167 Change-Id: Ib950dadc957dc4e4c2356a070fa8c7ec244299f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757430Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#689070}
-
Mohamed Amir Yosef authored
After recent fixes, Sync USS Bookmarks is ready for prime time. Change-Id: I34546e66e12f4b129e592375d3f0bf56654eb539 Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760948 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#689069}
-
Caleb Rouleau authored
1. Fix broken links. 2. Rename Speed Services to Speed Tooling. 3. Delete out of date information. 4. Add various links. 5. Rename speed_services.png to speed_operations.png I think this is better than speed_tooling.png since benchmarking team owns the perf waterfall, and that image contains details on that. 6. Remove Ben Henry from TPM role since Ushesh is doing that now. Bug: 949246 Change-Id: Iab0312ab86619c814c8d95f26dba4a5f2eeb78cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763091Reviewed-by:
Ben Henry <benhenry@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#689068}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed4906f89d3d..1d83e1e8a17e git log ed4906f89d3d..1d83e1e8a17e --date=short --no-merges --format='%ad %ae %s' 2019-08-21 tobine@google.com Vulkan: Handle new validation errors Created with: gclient setdep -r src/third_party/angle@1d83e1e8a17e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: Ia988804c49ca2f3893da3060ba52955b7bb22496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689067}
-
Manu Cornet authored
Change-Id: I31fa43e85afc0cfe7f5d7be1b4c75b2200aa6e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764116 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689066}
-
Sergey Ulanov authored
Now FuchsiaVideoDecoder uses sysmem to allocate output buffers instead of creating raw VMOs. The sysmem collection is shared with the GPU where it's passed to Vulkan. This means that decoded frames are now passed from mediacodec to Vulkan directly, without being touched by the renderer or the GPU process. Bug: 981026 Change-Id: I7dc8b48ceb0621966034e554897efd542af63a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752918Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689065}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a62c380dea04..6a337fb9b12b git log a62c380dea04..6a337fb9b12b --date=short --no-merges --format='%ad %ae %s' 2019-08-21 eseckler@google.com Merge "Improve Perfetto recording page" Created with: gclient setdep -r src/third_party/perfetto@6a337fb9b12b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I34636e88b7a79808a2a33493c7dff1f15bc499b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689064}
-
John Chen authored
testChromeDriverSendLargeData used to use string concatenation to generate a long string, which was slow and can timeout on slow devices. Improving efficiency by using String.repeat() instead, to make it fast enough for Android. Bug: chromedriver:1175 Change-Id: I9b030a43c82cdbe69c374718a307a66f57cf04a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763171Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689063}
-
Fernando Serboncini authored
Bug: 993762 Change-Id: I5dbc59e201b5d89e881da9413018e4982864ee21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762471Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689062}
-
Daniel Cheng authored
Spotted from https://twitter.com/ericlaw/status/1163552434297483265l Change-Id: Ieeff46753eb86ca811b2217d7f943bcd360e5155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763225 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689061}
-
Christopher Thompson authored
After internal discussions, we've decided to hold off on infobar-ing use of SSLKEYLOGFILE for now. We'll add metrics on usage and plan a new rollout strategy later. Bug: 991290 Change-Id: Ie4382dd6cd7cd752199dd55f8841bd4781305be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760866Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#689060}
-