GitLab

LGE's email app runs UI thread methods from InputConnection. As this is
becoming impossible, we need to work around LGE email case. Hopefully this
is the last webview app that does it.

BUG=651706

Review-Url: https://codereview.chromium.org/2392293002
Cr-Commit-Position: refs/heads/master@{#423878}

Buttons respond on mouse up. This is nice because it gives the user a
chance to change their mind by moving the mouse away from the button
before releasing.

This makes notifications behave the same way.

BUG=653862

Review-Url: https://codereview.chromium.org/2400033003
Cr-Commit-Position: refs/heads/master@{#423877}

This will allow users to exclusively run or ignore
all ImportantSite tests at once.

BUG=None

Review-Url: https://codereview.chromium.org/2392303006
Cr-Commit-Position: refs/heads/master@{#423876}

BUG=546385

Review-Url: https://codereview.chromium.org/2399903002
Cr-Commit-Position: refs/heads/master@{#423875}

Changelog since v0.8.21.0:
[2662b3a8a2] SyzyAsan - More careful handling when freeing corrupt blocks.
[745955797d] SyzyAsan - Fix potential race when shutting down the deferred
             free thread.
[c86c6caeae] SyzyAsan - Fix overflow error in ShadowWalker for 4GB 32-bit
             processes.

R=siggi@chromium.org, chrisha@chromium.org

Review-Url: https://codereview.chromium.org/2395263004
Cr-Commit-Position: refs/heads/master@{#423874}

Now session_manager returns an error if the free disk
space is low. Thus, this removes the current disk space
checking in arc_bridge_bootstrap, instead, looking at
the error code on StartArcInstance failure.

BUG=628124, 633258, b/30498714
TEST=Ran on test device. Ran trybots.

Review-Url: https://codereview.chromium.org/2397863003
Cr-Commit-Position: refs/heads/master@{#423873}

The timestamp is available even when there is no response, so this name
makes more sense.

BUG=629194

Review-Url: https://codereview.chromium.org/2401933002
Cr-Commit-Position: refs/heads/master@{#423872}

The database format has changed, this updates the database visualization tool.

BUG=631966

Review-Url: https://codereview.chromium.org/2404453002
Cr-Commit-Position: refs/heads/master@{#423871}

The downstream code now depends on upstream implementation of
AuthenticationService so merge the targets (but leave temporary
targets until downstream code dependencies have been removed).

BUG=653086

Review-Url: https://codereview.chromium.org/2389323004
Cr-Commit-Position: refs/heads/master@{#423870}

The new string better suits the use case when the user signs into Chrome after accepting the promo.

BUG=653123

Review-Url: https://codereview.chromium.org/2396373002
Cr-Commit-Position: refs/heads/master@{#423869}

Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation (patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Review-Url: https://codereview.chromium.org/2396393002
Cr-Commit-Position: refs/heads/master@{#423868}

1. Updated max bitrate to 100Mbps
2. Fixed encoder to update active region for key frames to ensure proper
  top-off

BUG=645656

Review-Url: https://codereview.chromium.org/2398293002
Cr-Commit-Position: refs/heads/master@{#423867}

Same for RootWindowController and WmRootWindowController. I want to
move TestSessionStateDelegate to ash/common, and it uses these.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2393083005
Cr-Commit-Position: refs/heads/master@{#423866}

Replace with Service.

TBR=rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2397353002
Cr-Commit-Position: refs/heads/master@{#423865}

Original issue's description:
> [NTP Client] Spacing and fixes for the sign in promo
>
> - Fixes an exception when only the sign in promo is present on the NTP
> and we attempt to make it peek
>
> - Adds 20dp space between the promo and the status card if present
>
> - Fixes to the bottom space calculation related to the dismissal of
> sibling elements.
>
> Preview: https://goo.gl/photos/94hhXK5rygGamFqt7
>
> BUG=649670,652578
>
> Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
> Cr-Commit-Position: refs/heads/master@{#423525}

Revert link:
> Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7
> Cr-Commit-Position: refs/heads/master@{#423644}
BUG=649670,652578

Review-Url: https://codereview.chromium.org/2397573009
Cr-Commit-Position: refs/heads/master@{#423864}

Original issue's description:
> [NTP Client] Use the separate button style for the NoArticles status
>
> Makes the articles and bookmarks sections use the same style of status
> card when they have no snippets.
>
> the hasMoreButton property of categories now only determines whether
> the action item will be shown when there are suggestions to display.
>
> This patch also lets the SuggestionsCategoryInfo be aware of the
> current category it is describing, and moves various category specific
> behaviours into the SuggestionsCategoryInfo class.
>
> Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7
>
> BUG=649670
>
> Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171
> Cr-Commit-Position: refs/heads/master@{#423517}

> Revert Data:
> Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c
> Cr-Commit-Position: refs/heads/master@{#423573}

BUG=649670

Review-Url: https://codereview.chromium.org/2401643004
Cr-Commit-Position: refs/heads/master@{#423863}

BUG=653182

Review-Url: https://codereview.chromium.org/2398223002
Cr-Commit-Position: refs/heads/master@{#423862}

BUG=

Review-Url: https://codereview.chromium.org/2392943005
Cr-Commit-Position: refs/heads/master@{#423861}

These two accessors, and the HashSet underlying them, could have been
removed earlier; they're unused now, and this CL cleans them up.

R=chasej@chromium.org

Review-Url: https://codereview.chromium.org/2401663002
Cr-Commit-Position: refs/heads/master@{#423860}

This CL migrates video capture IPC messages Start and Resume
from IPC to mojom. It needs 2 EnumTraits (ResolutionChangePolicy
and PowerLineFrequency) in //services/video_capture, and a
StructTraits for VideoCaptureParams in //content.

The conversion of the IPC-related classes VideoCaptureHost and
VideoCaptureImpl is quite straightforward. The bulk of the CL
is unit tests adaptation (and cleanup!) and type renaming.

BUG=651897
TEST=content_unittests, content_browsertests, video_capture_unittests

Review-Url: https://codereview.chromium.org/2395163002
Cr-Commit-Position: refs/heads/master@{#423859}

A crash[1] seems to be caused by events attempting to get data from
the NTP while it is not the current page anymore. This CL adds
a check to ensure the page processing the events is the currently
displayed NTP.

[1]: https://crbug.com/649670#c17

BUG=649670

Review-Url: https://codereview.chromium.org/2400163002
Cr-Commit-Position: refs/heads/master@{#423858}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/52556b8cab59ecb29590679b280b1b7692662132 filter: temporarily disable analyze_report (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=651536

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2394153004
Cr-Commit-Position: refs/heads/master@{#423857}

Right now, if Chrome was hidden (cmd+h) and a notification comes in, the
whole app unhides.

Calling setHidden:YES on the notification window lets it be visible when
Chrome is hidden, and the -[NSWindow order*] methods respect it by not
unhiding the app.

BUG=653266

Review-Url: https://codereview.chromium.org/2399993003
Cr-Commit-Position: refs/heads/master@{#423856}

This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp

BUG=653881

Review-Url: https://codereview.chromium.org/2396183002
Cr-Commit-Position: refs/heads/master@{#423855}

Its size is not affected by the adapter contents so this can be true,
allowing for internal optimizations.

Review-Url: https://codereview.chromium.org/2399983004
Cr-Commit-Position: refs/heads/master@{#423854}

BUG=653808

Review-Url: https://codereview.chromium.org/2393353005
Cr-Commit-Position: refs/heads/master@{#423853}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2fc026e842c926cc8187bdab134c79732030a7e7 V8: Add missing archives for auto-bisect (machenbach@chromium.org)
  https://crrev.com/dbb9217e98b774ae713c45ba0e0395ac87717d3b Revert of Make clusterfuzz_archive include llvm-symbolizer and sancov. (patchset #4 id:60001 of https://codereview.chromium.org/2393293002/ ) (mmoroz@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=636168

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2398753004
Cr-Commit-Position: refs/heads/master@{#423852}

BUG=571056

Review-Url: https://codereview.chromium.org/2396363002
Cr-Commit-Position: refs/heads/master@{#423851}

It's an attribute for ScrollView, and a no-op on RecyclerView.

Review-Url: https://codereview.chromium.org/2389263008
Cr-Commit-Position: refs/heads/master@{#423850}

Before, the LanguageModel returned top languages even if it had only one
data point. Thus the frequencies of top languages could change
drastically in the warm-up phase of the model.

This CL adds a minimum size of the sample set. The model returns empty
list of top languages before this minimal size is reached.

BUG=653058

Review-Url: https://codereview.chromium.org/2391383005
Cr-Commit-Position: refs/heads/master@{#423849}

BUG=653809

Review-Url: https://codereview.chromium.org/2406453002
Cr-Commit-Position: refs/heads/master@{#423848}

Reverting the cl didn't solve the content_browsertest timeouts on win64 official build.

re-landed cl: https://crrev.com/2317253005

TBR=wjmaclean@chromium.org, nasko@chromium.org, tdresser@chromium.org, sky@chromium.org

BUG=650175, 622827

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2393783005
Cr-Commit-Position: refs/heads/master@{#423847}

The simple cache can use too many FDs and crash systems with low FD
limits, like Macs. Longer term we should probably have ways to not
keep so many files open simultaneously, but the quick fix is to raise
the limit on Mac.

R=jkarlin@chromium.org,clamy@chromium.org
BUG=634413

Review-Url: https://codereview.chromium.org/2399073002
Cr-Commit-Position: refs/heads/master@{#423846}

This allows GMCS observers to be notified whenever a logout operation
finished.

BUG=

Review-Url: https://codereview.chromium.org/2397263002
Cr-Commit-Position: refs/heads/master@{#423845}

on Windows due to reliable failure.

TBR=lukasza
BUG=653856

Review-Url: https://codereview.chromium.org/2401003002
Cr-Commit-Position: refs/heads/master@{#423844}

MoveSelectionCommand is no longer in use after r422915. Hence, this
patch removes it from the code base.

BUG=n/a

Review-Url: https://codereview.chromium.org/2403443002
Cr-Commit-Position: refs/heads/master@{#423843}

BUG=650082

Review-Url: https://codereview.chromium.org/2394163005
Cr-Commit-Position: refs/heads/master@{#423842}

This CL has no behaivor changes.

BUG=653859, 508728, 627008, 508725
TBR=kojii@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2399363002
Cr-Commit-Position: refs/heads/master@{#423841}

Use a base::Callback to dispatch a SyncLoad result instead of
IPC::Message, so that we can share most of synchronous load code between
Chrome IPC version and Mojo IPC version.

BUG=603396

Review-Url: https://codereview.chromium.org/2390313002
Cr-Commit-Position: refs/heads/master@{#423840}

After some discussions the CSS WG agreed that stretch should not only
grow items, but also stretch them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in LayoutBox that was only used by Grid Layout.

The tests have been updated according to the new expected behavior.

For images, we'll be stretching on both axis right nos, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

BUG=653433

Review-Url: https://codereview.chromium.org/2398043002
Cr-Commit-Position: refs/heads/master@{#423839}