- 22 May, 2018 40 commits
-
-
Jamie Walch authored
This allows clients to restore the original host desktop size when the relevant option is unchecked, rather than only on disconnect. Change-Id: Ia344223bb1475c3b60fbbdd0510f20be8694203d Reviewed-on: https://chromium-review.googlesource.com/1058675 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#560800}
-
Kenneth Russell authored
This will increase the likelihood that intermittent failures caused by changes in this directory will be caught on the commit queue. Bug: 843290 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie4d230c0290706c956d88f483b82b98f3a62f4bf Reviewed-on: https://chromium-review.googlesource.com/1069598Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560799}
-
Lei Zhang authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4198a7bdd11b350d04436c0048977d13f4f50c88 Reviewed-on: https://chromium-review.googlesource.com/1066323Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#560798}
-
Ryan Landay authored
This CL refactors Stack into an abstract class with two subclasses: OverlappingStack (which maintains the current behavior and apperance), and NonOverlappingStack (to be used for the horizontal tab switcher experiment). The initial version of NonOverlappingStack implements the basic functionality to have the tabs not overlap. Later CLs will make the tabs smaller so you can see the sides of the neighboring tabs, update the scrolling logic, and clean up the animations. Bug: 828224 Change-Id: Ib82d4ef59f5fc70f15afba3cabae89daf261ca29 Reviewed-on: https://chromium-review.googlesource.com/1066936 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#560797}
-
Dave Schuyler authored
This CL shows answer images that are delivered through the alternate json property Bug: 843370 Change-Id: Ic0a2088b16b5f2d00944719c46c5ff1724d7cc90 Reviewed-on: https://chromium-review.googlesource.com/1066973 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#560796}
-
Justin Cohen authored
Bug: 828887 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I121abc634c72e9429a9acdb39377b140143686bd Reviewed-on: https://chromium-review.googlesource.com/1066295Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560795}
-
Brian Osman authored
This uses skcms' ICC parser, and directly uses skcms for color space transformation (rather than going through Skia). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5add97b131f720545c2953a2d8175e607d138d98 Reviewed-on: https://chromium-review.googlesource.com/1052858 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560794}
-
Kyle Horimoto authored
This was a suggestion by dcheng@ on https://chromium-review.googlesource.com/c/chromium/src/+/1063254. This pattern occurred on other classes in this directory, so I also migrated them. Bug: 824568, 752273 Change-Id: I1d8150f0071e931f14211865ff2029f27e16a579 Reviewed-on: https://chromium-review.googlesource.com/1069258Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/994a66b3..44d7d7d6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icbb0a0be8ef2d51c060fa2c1bd2860383dbb399a Reviewed-on: https://chromium-review.googlesource.com/1069171Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#560792}
-
chrome://flagsMustafa Emre Acer authored
This CL adds support for command line flags that are lists of url::Origins. E.g. The value in --flag=value will now be modifyable from the chrome://flags page using a free form textbox, and will be treated as a comma separated list of origins (e.g. http://example1.test,http://example2.test) The string from the textbox is transformed as follows: - Continuous whitespace characters are collapsed into single a space - String is tokenized using space and comma as delimiters - Each token is parsed as a GURL. Invalid URLs or URLs with a scheme other than http and https are discarded. - Remaining URLs are converted to url::Origins, then joined into a single, comma separated string. The CL also adds --unsafely-treat-insecure-origin-as-secure as the first such flag to chrome://flags. Developers will now be able to modify the list of insecure origins treated as secure from the chrome://flags page on all platforms. Bug: 834381 Change-Id: Iad44b5b2724687c7bea1ae45c23ccc910eb5cc9f Reviewed-on: https://chromium-review.googlesource.com/1038152Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#560791}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4813121f9840..2315c9a28bd5 $ git log 4813121f9..2315c9a28 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:b/78191547 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2b35512c3d9cd8780e856a4f67039e15e3a9bf84 Reviewed-on: https://chromium-review.googlesource.com/1069551Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560790}
-
Manuel Rego Casasnovas authored
The patch to fix crbug.com/785212 broke some sites, it was making "contain: layout" elements to behave as containing blocks for absolutely and fixed positioned descendants. To check how many websites are affected by this, we're adding a use counter in this patch. BUG=785212 Change-Id: I35ea1f58a4e7570543c911607c1e6b81bc401ea8 Reviewed-on: https://chromium-review.googlesource.com/1067917 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560789}
-
Kurt Horimoto authored
When the fullscreen browser container experiment is enabled, the web view overlaps with the top safe area inset, causing the content to be automatically pushed down by UIKit due to the content inset adjustment behavior. This was not getting reported properly to FullscreenModel, so scrolls at the top of the page were being ignored since FullscreenModel::ActionForScrollFromOffset() was interpreting them as the "bounce down" animation that occurs when scrolling past the top of the page's rendered content. This CL updates WebScrollViewMainContentUIForwarder to use the adjusted content inset if available, rather than only the contentInset property that is explicitly set. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iae7447cb0e8caf7d5f6b6ba6e4140ed7aa9f44b4 Reviewed-on: https://chromium-review.googlesource.com/1068106Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 833813 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I608d7ef218b9d8149d49df4cc1f3117fc9c23793 Reviewed-on: https://chromium-review.googlesource.com/1068118Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#560787}
-
Kenneth Russell authored
In https://chromium-review.googlesource.com/1067109 a few sharding parameters were changed for these tests: - content_unittests - unit_tests - webview_instrumentation_test_apk Restore the original number of shards for these tests. Additionally, the bot "chromium.memory:Android CFI" wasn't properly specified as an Android bot (os_type=Android), so none of the sharding parameters were being applied to it. Fix this, in particular for content_browsertests. Bug: 845553 Change-Id: Icc819dde7327f93ab845343b64a649258e857e28 Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1069537Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
MD Extensions: move cr-toast up the DOM heirarchy so it is not altered by the styling of other elements Bug: 845073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95b69e097480c38822587cf25430916d3bf81f4d Reviewed-on: https://chromium-review.googlesource.com/1067483Reviewed-by:
-
Zhenyao Mo authored
BUG=839609,839618 TEST=gl_unittests R=kbr@chromium.org NOTRY=true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I45f30195cf09ec973b45c8c0da0eee4a2b8ceec8 Reviewed-on: https://chromium-review.googlesource.com/1069261 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Lei Zhang authored
Consolidate non-trivial, repeated code that creates shared memory regions inside sandboxed environments. Change-Id: I29e0715a9d43fdde030ee0a2286f872b34576c8f Reviewed-on: https://chromium-review.googlesource.com/1056393 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Christopher Grant authored
The old box of quads shows seams on high-res displays. We used this approach because there was no full-screen UI element. BUG=844488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I91d7921b192cf0f963593001af5ad92211d7e6d8 Reviewed-on: https://chromium-review.googlesource.com/1069428Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#560782}
-
Esmael El-Moslimany authored
Bug: 842582 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b64c868ef6a4437116ebb2a363757a77b8674d3 Reviewed-on: https://chromium-review.googlesource.com/1067487Reviewed-by:
-
Justin Cohen authored
Bug: 845186 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: Ia0cd5355286b58c5c41da03ccdd61dbc1f574e22 Reviewed-on: https://chromium-review.googlesource.com/1067464 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Stephen McGruer authored
Bug: 845635 Change-Id: Icba301d9411ebd5d74033c20dcbf8f46108b8342 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Reviewed-on: https://chromium-review.googlesource.com/1067648Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#560779}
-
Miguel Casas authored
This CL follows up on a comment [1] on the CL landing SetEncryptedStream(), ("We could do SetStream(..., const DecryptConfig* decrypt_config) as nullptr is used in other places to indicate that there is no decrypt config."), by removing SetEncryptedStream() and adding instead a default-null argument |decrypt_config| SetStream instead(). SetStream and SetEncryptedStream are so similar from an APi perspective that it doesn't seem to merit a method on its own. Note: SetStream() is fully synchronous and DecrypConfig is a plain vanilla class, so nacked pointer is good enough (we could also consider std::unique_ptr<> instead, down the line). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1024961/8/media/gpu/accelerated_video_decoder.h#35 Bug: 820192 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iec056f33a792965f8bf854d9564e3bff520f4f8d Reviewed-on: https://chromium-review.googlesource.com/1061621Reviewed-by:Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#560778}
-
Siddhartha authored
On Android for trace symbolization the start address of the library cannot be obtained by offsets from memory maps since it is mapped from apk. So, add explicit metadata for each process to mark the start address of the executable. The only library mapped from apk is chrome.so. Change-Id: Ib6f3ec81fd1c34c92974fce7a73debd4f9e8dad5 Reviewed-on: https://chromium-review.googlesource.com/1068239 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#560777}
-
James Cook authored
We removed --enable-features=kMus a few weeks ago while switching to "ws2" window service as a library. Ash never runs in ash::Config::MUS. Remove the WindowManagerService, WindowManager and Shell initialization code paths that supported Config::MUS. There are still a few other places to clean up but they require more inspection. Bug: 841941 Test: bots, chrome --enable-features=Mash still runs Change-Id: Ic6fbe6bf329c6d44a4d652633ed9e2cd946c977e Reviewed-on: https://chromium-review.googlesource.com/1068212Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#560776}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3476a1e6c46..6cc8fb177b33 $ git log f3476a1e6..6cc8fb177 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 dtu [pinpoint] Use /api/job/<job_id> instead of /api/job?job_id=<job_id> 2018-05-22 perezju [soundwave] Fix reading timeseries for summary metrics Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I7701702a1f8cc09259ec6aa427aea6a91f3fbe05 Reviewed-on: https://chromium-review.googlesource.com/1069263Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560775}
-
Chris Hamilton authored
This will be used to encode detailed reasons describing decision taken by the resource_coordinator policy engine. These will drive web UI and UKM reporting. BUG=753486 Change-Id: Iadf7620d75710ed36ce334cc5e4e116cd8ed6c0b Reviewed-on: https://chromium-review.googlesource.com/1064700 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#560774}
-
Ryan Landay authored
For the Android horizontal tab switcher experiment, I need to split up Stack into a base class and two subclasses: OverlappingStack (which will implement the existing behavior) and NonOverlappingStack (which will implement the new behavior). In particular, NonOverlappingStack will get rid of the non-linear warping logic currently implemented in StackTab#screenToScroll() and StackTab#scrollToScreen(). This CL moves these two methods into Stack in preparation for the subclassing refactor. Now, the code in StackAnimation that needs to convert between coordinate spaces can call these methods on the passed-in Stack instance to use the correct version of the logic. As an added benefit, we no longer need to pass the warp size into the animation sets as a parameter. Bug: 828224 Change-Id: Iaf5f57839ba79ebbb46157321dceff4c97ba9fb1 Reviewed-on: https://chromium-review.googlesource.com/1065114Reviewed-by:
-
Rohit Rao authored
Rotating or exiting multitasking while a context menu was visible would result in the Collections tableviews being offset within the bubble. Fixes this bug by forcing the tableview to fill its parent before running the layout pass. BUG=845534 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I72f1ab1d33d2b8ca22a32c9161e6eeaf561c7844 Reviewed-on: https://chromium-review.googlesource.com/1067866Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#560772}
-
Chris Morin authored
ArcProcessTask contains a subset of the members in ArcProcess. It also contains similar logic with regards to determining which processes are killable from the task manager. This change has ArcProcessTask contain an ArcProcess instead of duplicating some of it's members, and delegates the logic of whether a process is killable to the ArcProcess instance. This causes a small change in which processes can be killed in the in the task manager: processes protected by the function ArcProcess::IsArcProtected can no longer be killed. This change is considered an improvement by the author of the IsArcProtected function. BUG=none TEST=Ensure task manager can still kill right processes. Change-Id: Id483b22e3a25f6fe8bbeeee8cddddcf0b5dbe298 Reviewed-on: https://chromium-review.googlesource.com/1068615 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560771}
-
Kevin Bailey authored
Add the other official string - the shortened version of the wider button label - and have the tab switch button use it. Bug: 780835 Change-Id: I51aed2d19a9abd15b613e29becb929b1aa483a07 Reviewed-on: https://chromium-review.googlesource.com/1069255Reviewed-by:
-
Henrique Grandinetti authored
BUG: 823536 Change-Id: Ic538ac64b9e5ffa7ee9cf56ced8174f2a87a1d94 Reviewed-on: https://chromium-review.googlesource.com/1058407 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560769}
-
Ryan Tseng authored
Also just sort the builder list alphabetically. It's easier to manage and sorting by OS doesn't seem to provide much utility. Bug: 840631 Change-Id: I0c2e5c836f6fd896aa560d86c5e3cf17912c09c1 Reviewed-on: https://chromium-review.googlesource.com/1069322Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#560768}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/083eb25f9acb..398fb44e2866 $ git log 083eb25f9..398fb44e2 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 rharrison Print access errors using logging.error 2018-05-21 ehmaldonado roll-dep: Add tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:829134 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idef2edda9678e0be50560b28a5501364ab479a9f Reviewed-on: https://chromium-review.googlesource.com/1069308 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560767}
-
Luke Zielinski authored
In this mode the trigger just listens for certain events and updates metrics, but never sends reports. This is useful to track the frequency of suspicious site hits even if reporting quota is spent for the user. Bug: 817377 Change-Id: Ie524953a438e41a42a63d1e1852f1cfc3093f353 Reviewed-on: https://chromium-review.googlesource.com/1065575 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#560766}
-
Johannes Henkel authored
This avoids issues with initialization (net::Error is an enum) and also it avoids passing net::Error as a modifiable reference. No behavior change is intended, this is meant to be a refactoring for improving the readability. Thanks much for considering. :-) Change-Id: I04965a780fc766d1f666d9cca524505251e10080 Reviewed-on: https://chromium-review.googlesource.com/1062945 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#560765}
-
Christian Biesinger authored
Even when reusing a layout result, we still need to update the shape info. Fixes these tests when fragment caching is enabled: external/wpt/css/css-shapes/shape-outside/shape-image/shape-image-009.html external/wpt/css/css-shapes/shape-outside/shape-image/shape-image-011.html http/tests/css/css-image-valued-shape.html http/tests/security/shape-image-cors-same-origin.html Also, moving the SetMayNeedPaintInvalidation call fixes these additional tests: fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html R=ikilpatrick@chromium.org Bug: 844751 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I412fd2eddd22c40a7b0c5c7b8a8d22612c1b3759 Reviewed-on: https://chromium-review.googlesource.com/1069173Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#560764}
-
Devlin Cronin authored
TBR=sky@chromium.org Bug: 117261 Change-Id: I4a8e646354e97d3ecbbf2e6889ff9c2217f17995 Reviewed-on: https://chromium-review.googlesource.com/1069222 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#560763}
-
Matthew Jones authored
This patch prevents a flash in the toolbar when creating new tabs. The theme color of the toolbar was being set prior to being needed due to an inconsistency in state in ToolbarPhone. Now, the update logic blocks theme color updates while exiting the tab switcher and requests an update once the transition finishes. Bug: 832594 Change-Id: Idf89eb43a8ce4ed155a815cdfe11147801ef40a6 Reviewed-on: https://chromium-review.googlesource.com/1067715Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#560762}
-
enne authored
This reverts commit 0c2124b3. Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts Bug: 845411 Original change's description: > Use thresholds based on RAM size for OOM intervention > > This CL does not change behavior of existing experiment on 512 devices. > 1. Remove low-end device checks while enabling intervention. This can be > filtered in Finch config. > 2. Set threshold based on percentage of RAM instead of absolute number. > 3. Disable intervention if device has more than 512MB RAM and threshold > was set to absolute number. > > BUG=843419 > > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d > Reviewed-on: https://chromium-review.googlesource.com/1066804 > Commit-Queue: Siddhartha S <ssid@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560430} TBR=bashi@chromium.org,ssid@chromium.org Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843419 Reviewed-on: https://chromium-review.googlesource.com/1069567Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#560761}
-
