- 20 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e63bdb69ecd3..a75fd3592a81 Created with: gclient setdep -r src-internal@a75fd3592a81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idcea8d6c96ebddf0ffe57c7fa4dcd18827e2f663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816994Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698630}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dd4a00a06d01..11dc16350cd4 git log dd4a00a06d01..11dc16350cd4 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 aukinros@microsoft.com Add support for generating UWP (Windows Store) projects again Created with: gclient setdep -r src/third_party/angle@11dc16350cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I338729368905d22f1b93c7599a4ff3562c4eb975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698629}
-
Avery Musbach authored
All observers of the AccessibilityController shall be removed before the AccessibilityController is destroyed. Change-Id: I8b4cab4ce71a3bfb53c2f04b940dde218a494124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816301 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#698628}
-
Nick Diego Yamane authored
This CL adds initial IME support to ozone/x11 by reusing libgtkui's LinuxInputMethodContext{Factory} implementation, which uses gtk-immodule as backend. Some logic has been added to be able to support the following scenarios, possible, from now on, in ozone linux platforms: (1) LinuxInputMethodContextFactory is implemented inside ozone backend implementation, it is instantiated set in OzonePlatform::InitializeUI. E.g: ozone/wayland. (2) If the ozone platform initialization have not created/set a LinuxInputMethodContextFactory instance and GtkUi is in place, then it is set as the global instance. E.g: ozone/x11. Even though the logic to support the aforementioned use cases is quite tricky, spread over different layers (e.g: views::LinuxUI, libgtkui::GtkUi, ui::OzonePlatform), using ifdefs, etc; it should be cleaned up and unified once X11 migration to Ozone is completed. It is worth noting that proper IME support for now requires GLib message pump (at least IBus, for example) being used in UI thread (i.e: use_glib=true). Bug: 987939, 789065 Change-Id: I700d39eec02c6bbeaafca29c9405e8e0e1ff6ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798263 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698627}
-
Quinten Yearsley authored
This is an old TODO left from around 2015, and it looks like it's not helpful anymore. This CL also includes minor style clean-up (function rename, comment editing, whitespace). No expected behavior change. Change-Id: Icc6f4e02caa7d7200746f5a3bf76b0df3c6bcb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801750Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#698626}
-
Ted Choc authored
TBR=yusufo@chromium.org BUG= Change-Id: Iec6dc0621a0d0f5c3b8b038c2158fe2ec1bfcacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817181Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#698625}
-
Avery Musbach authored
The present CL addresses the problem that AccessibilityControllerImpl never actually removes itself as an observer of TabletModeController. In the following part of the destructor, the "if" condition is always false because the tablet mode controller is destroyed first: if (Shell::Get()->tablet_mode_controller()) Shell::Get()->tablet_mode_controller()->RemoveObserver(this); Change-Id: Ib35b19751862921691c767520e6803007c763a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816906Reviewed-by: -
chrome://historyLukasz Anforowicz authored
This CL reverts r420600 and r459047 - now that MD history and MD settings have shipped long time ago, there is no need to reset PageState to avoid mixups when restoring MD-disabled PageState into an MD-enabled chrome://settings and vice-versa. This aspect of the CL affects only the following 3 URLs: - chrome://history - chrome://settings - chrome://help Bug: 614758, 700350, 976055 Change-Id: I782664d9940c25406f3cd4a226692b75de6bfc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808089 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#698623}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7edc2d63..aa1b7640 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a090a09078c8c9590b894f5316c663c4b5db848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817078Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698622}
-
Ian Struiksma authored
Disabled captured_update_pass nexon under bug 1006335 Disabled worldmarket under bug 1006322 Disabled north_face, kohls, davidsbridal, verizonwireless under bug 1006308 Updated cargurus, dicks_sporting_goods recipes after cachereplayer fix, which needs the DEPS update for the cipd version Bug: 1006308,1006322,1006335 Change-Id: If112a8c364d5f934c03298d687435800f2813b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816959 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#698621}
-
Gabriel Marin authored
This reverts commit b0c92575. PerfCollector uses a private dbus client bound to the collector sequence, so it's safe to make dbus calls from the collector sequence. BUG=b:141021087 TEST=Verified on a local device that perf collection works and it doesn't crash the browser. Change-Id: If67f297a6cefd537f7fce3a3fe2d7f04dc20681f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811865Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#698620}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ab109212f0f..6b921b7e4add git log 2ab109212f0f..6b921b7e4add --date=short --no-merges --format='%ad %ae %s' 2019-09-20 kjlubick@google.com [canvaskit] add support for SkAnimatedImage 2019-09-20 brianosman@google.com Use makeRenderTargetContextWithFallback when creating devices for layers Created with: gclient setdep -r src/third_party/skia@6b921b7e4add If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ibc24acf33e661a644bb61ecd7572cf7323d39d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816991Reviewed-by:
-
Sam Maier authored
We are minimizing the impact of class verification failures for UrlBar by putting all the failures into their own subclass. Thus, only the subclass will fail. No-Presubmit: true Bug: 999165 Change-Id: I12ea5e29cdfac7973dbec26b44a1f0b7adf21e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803730 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#698618}
-
Tim Judkins authored
This change is to make sure the URL in the Omnibox matches the page content for navigations made through the tabs API, to make sure that pending navigations made through the tabs API are not displayed in the omnibox. This also involves adding a pending URL entry to the tabs object, which exposes the current pending URL that has not yet committed, if there is one. Bug: 981628, 1000489 Change-Id: I649438987ab11c4389dfbc1ff303c661762ef565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737819 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#698617}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b93f7decd493..bf5be75f420c git log b93f7decd493..bf5be75f420c --date=short --no-merges --format='%ad %ae %s' 2019-09-20 thestig@chromium.org Revert "Disable git EOL policy for .in files again." 2019-09-20 thestig@chromium.org Remove unneeded fx_stream.h includes from headers. 2019-09-20 thestig@chromium.org Remove IsArray() checks in CPDF_Array. Created with: gclient setdep -r src/third_party/pdfium@bf5be75f420c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I520c65233c5b26a2fab20fcd0e5d35399d0aa83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815824Reviewed-by:
-
Yue Li authored
Add the Assistant lottie animation resource for OOBE UI. Bug: b/141352784 Test: Manual Test Change-Id: I3afb598e8025439c79ef6c57ee9560b0fb2f1372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816967 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698615}
-
Elly Fong-Jones authored
Bug: 1006022 Change-Id: I54a875d1a4d59a0e4208f5ae76e7dca7addaf048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815701 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698614}
-
Collin Baker authored
Notifying of an audibility change in a WebContents is done by calling NotifyNavigationStateChanged(INVALIDATE_TYPE_TAB). This CL adds INVALIDATE_TYPE_AUDIO and notifies with this more specific flag instead. This is to enable the browser UI side to filter this notification and instead use RecentlyAudibleHelper for this purpose. This is part of a refactor detailed in the attached bug. Bug: 846374 Change-Id: I91b9d27453b2910ba262a4af581ac7662cce803e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815725Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#698613}
-
Daniel Rubery authored
Tokens are passed as string fields in a proto, and therefore should probably be valid UTF-8, but RandBytes won't generate valid UTF-8. There's no immediate concerns here, but we don't want to run into trouble if some system tries to validate the token field. Bug: 980777 Change-Id: Iefe3391eff6325cfea732bc9004bb495754935d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814694 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#698612}
-
John Lee authored
Before: https://i.imgur.com/XfCXuIb.png After: https://i.imgur.com/Nlc9fqi.png Bug: 989131 Change-Id: I2f8a69701fbf48fa5329f98c37e5a5bba08f82fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809802 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#698611}
-
Peter Kasting authored
It made sense to just remove the dwrite namespaces since these headers are only included in the other dwrite files (and will only ever be), and standard Chromium namespace usage is "just one namespace per top-level module" anyway. Bug: 82078 Change-Id: I9f5808da274d649cbfc8fabdf94980caf1de6edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815667Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698610}
-
Anushruth authored
Without this flag, VM image for betty-pi-arc is not downloaded when gclient runhooks is run R=bpastene@chromium.org Bug: 1000513 Change-Id: Ice17757549dd3a4ca506a6eec5e8e5f487425cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815882Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#698609}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44f462b00178..234dcc192464 git log 44f462b00178..234dcc192464 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 nicolascapens@google.com Merge changes Ia7ee9d37,Ia3214243 2019-09-20 sugoi@google.com Enable sampling a depth-stencil format Created with: gclient setdep -r src/third_party/swiftshader@234dcc192464 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I809690bc5b61095d2ddcd791e7201af2c6134afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816866Reviewed-by:
-
Robert Ogden authored
Bug: 1005295 Change-Id: Icc50d85dc809eec07391039c079dfaa89f47a42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811869Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#698607}
-
Sergio Villar Senin authored
It's currently returning a double. As part of the process of rewriting the animation engine we're replacing doubles by base::Time* alternatives. Bug: 737867 Change-Id: I71aa8eb08210f8809ce5d6727c813c238ec1d08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813305Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#698606}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaa195992c388fd18a7d2d3b4d6bf657168e4c997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815823Reviewed-by:
-
Joel Hockey authored
TBR=calamity@chromium.org Bug: 1004692 Change-Id: I7272e4fdf55c109202517ce7b9a078033cdfe07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814582Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#698604}
-
Jasper Chapman-Black authored
Sample output in viewer: https://storage.googleapis.com/chrome-supersize/viewer.html?load_url=oneoffs%2Fsample-relocations2.ndjson&byteunit=B (note the unit is 'bytes' when this is actually instruction count) Using llvm-readelf directly on the above binary gives 392,984 R_ARM_RELATIVE instructions, which differs by a whopping 300 instructions from the 392,689.16 instructions counted by the analysis above. I'm not sure where the difference is coming from (although the floating-point values come from how size is attributed across symbol aliases). I'd be interested in thoughts on this, but accuracy to one part in a thousand is good enough for this use case. Timing information: This post-processing step takes about six seconds on my workstation (in addition to the previous runtime of supersize archive). Doesn't seem worth optimizing. Bug: 981592 Change-Id: I0c8ad5ec5c3e76ef51493ea43800900077f40110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811930 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
chrome://flagsGang Wu authored
Bug:1006041 Change-Id: I4a144c14fa886453e0d6efc3a48f8721c8889376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815737 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#698602}
-
Steven Bennetts authored
This CL: * Converts network_config.js to use the cros_network_config mojo API. * Converts network configuration components to use the mojo API. * Converts all network config elements to use mojo policy behaviors and indicators. (Non mojo policy behaviors and indicators are no longer in use and will be removed in a follow-up). * Moves requesting of ManagedProperties and GlobalPolicy to network_config.js (instead of being passed by dialog wrappers). * Wraps the <internet-dialog> instance in internet_page.html with a dom-if template to avoid unnecessary mojo calls and avoid reuse edge cases. * Adds mojo bindings to internet_config_dialog.cc * Eliminates CrPolicyNetworkBehaviorTest which fails now that internet_page.html no longer pulls in the behavior. A follow-up will remove the behavior entirely. Bug: 1001598 Change-Id: I93167de671b04b1bb9b8171975b76f89d1c0492a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803724 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#698601}
-
Matt Mueller authored
Change-Id: Ide200b9cd0cf7f483381eeb63a8fafbee14df34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814640 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#698600}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7735f52c6d42..410cf3af9982 git log 7735f52c6d42..410cf3af9982 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@410cf3af9982 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ia6622e3a2137ccbbb618f1a1dcc68702a66c00f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815689Reviewed-by:
-
Zhongyi Shi authored
Bug: 999285 Change-Id: I32d677d9eeaaad3225e41a7c1b4c89aa665f26d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776730 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#698598}
-
Alex Turner authored
Crashes have been observed in the wild that may be due to ERR_CACHE_RACE being sent to STATE_DONE_HEADERS_ADD_TO_ENTRY_COMPLETE. These crashes, however, cannot be reproduced and code investigation does not suggest how they might happen. If the crashes stop occurring following this change, we will be sure that this is the cause and will perform more analysis based on that understanding. Bug: 959194 Change-Id: I01649ee31024b598e41c0beda7c7ed54980cb133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814843 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#698597}
-
Ryan Harrison authored
shaderc landed a change to its API, which was a breaking change to Dawn. This CL rolls both dependencies ahead so that the breakage and fix can be landed together. Because these changes are in different repos, the autorollers will never successfully pick up these changes, since it only updates one hash at a time. Roll src/third_party/dawn/ 785ec66b6..38b295de3 (20 commits) https://dawn.googlesource.com/dawn.git/+log/785ec66b66a3..38b295de3851 $ git log 785ec66b6..38b295de3 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 cwallez Fix availability check for MTLCopyAllDevices 2019-09-19 cwallez BUILD.gn: Delete stale generated files in Dawn's gen dir. 2019-09-19 rharrison Rolling 4 dependencies 2019-09-19 bryan.bernhart Check if allocation is valid before deallocating. 2019-09-19 rharrison Roll ahead shaderc API and update API usage as needed 2019-09-18 cwallez BUILD.gn: Add a check generated files are in allowed dirs. 2019-09-18 bryan.bernhart Remove device dependencies from ringbuffer. 2019-09-18 enga Fix leak of ErrorData after Device::ConsumedError 2019-09-18 cwallez Clarify disabled warning for Metal in BUILD.gn 2019-09-18 cwallez Normalize generated file paths to match main tree. 2019-09-18 cwallez Support compilation of Dawn on iOS. 2019-09-18 cwallez generator_lib.py: correctly handle lack of --jinja2-path. 2019-09-17 cwallez Add some missing headers in BUILD.gn files. 2019-09-17 cwallez Add missing include in the Vulkan backend. 2019-09-17 enga Add README.md for the Dawn perf test harness 2019-09-17 enga Support setting bind groups before pipeline for all backends 2019-09-17 natlee OpenGL: clear nonrenderable texture formats 2019-09-17 enga Support ErrorScopes for asynchronous GPU execution 2019-09-17 yunchao.he Fix a typo in viewport validation test 2019-09-17 hao.x.li Revert "Skip some end2end tests for Vulkan validation layers enable on Windows" Roll src/third_party/shaderc/src/ 5903ef1f9..cb8b3fc5c (2 commits) https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/5903ef1f95a0..cb8b3fc5caf9 $ git log 5903ef1f9..cb8b3fc5c --date=short --no-merges --format='%ad %ae %s' 2019-09-19 rharrison Rolling 6 dependencies and update known_failures (#809) 2019-09-18 rharrison Code hygiene work for spvc (#808) Created with: roll-dep src/third_party/dawn src/third_party/shaderc/src BUG=chromium:1006181 Change-Id: Ib2e4d69cbc87eba687025ff78a28c21e2681bd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815982 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#698596}
-
Nate Chapin authored
This reverts commit ad602416. Reason for revert: Compile breaks: https://ci.chromium.org/p/chromium/builders/ci/ChromiumOS%20ASAN%20Release/104250 Original change's description: > media/gpu/BUILD.gn: restrict image_processor, video_frame_mapper to CrOs, Chromecast > > This CL restricts //media/gpu:image_processor and :video_frame_mapper > to ChromeOS and ChromeCast, since they are only implemented for these > platforms. Same for image_processor_test. > > video_frame_file_writer.cc sandwiched some uses of |video_frame_mapper_| > in an OS_LINUX and left others unprotected, which confused OS_WIN > builds. This CL changes those to if defined(OS_CHROMEOS), since I > don't think this file is meant to be compiled nor run on OS_LINUX. > > Change-Id: I8098d55859c50a752b40a63955684e558db3582a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787467 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698566} TBR=deanliao@chromium.org,mcasas@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,yucliu@chromium.org,dstaessens@chromium.org Change-Id: I1f70a99e52b6ca640e4f8c9fcc79ba71dbb7f5f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816972Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#698595}
-
Nate Chapin authored
This reverts commit 266b083e. Reason for revert: Compile break on android-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/113718 Original change's description: > JNI refactor: @NativeMethods conversion for more //chrome classes. > > This CL was partially generated by > //base/android/jni_generator/jni_refactorer.py. > > Two classes converted in this CL: > * UrlUtilities.java > * DevUiModuleProvider.java > > The tests were manually refactored to not use robolectric shadows > for UrlUtilities native methods. > > Bug: 929661 > Change-Id: Id3fbe2f7e53f3c0aa454aa51e1e94a2a6f0f1cb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815344 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698556} TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org Change-Id: I2c9251ec65af0ab7ff5012d218c3860f14214e9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 929661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816970Reviewed-by:
-
Asanka Herath authored
R=mmenke@chromium.org Bug: 927182 Change-Id: I64abb13045c30f500a85fc4ee8d3f37d9e127ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815099 Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#698593}
-
Eric Karl authored
VerifyFitsInBytesInternal would return false if a size/format combo had a size in *bits* that overflowed the requested type, even if the final size in *bytes* fit. Updated the logic to handle this. Additionally, Maybe(Width|Size)InBytes would crash if width overflowed, also fixed and test added. Bug: 1002855 Change-Id: I1fde167f17fdddfbcf4f9269e8a681a062d9ff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803831 Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#698592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4592ef724c8..e63bdb69ecd3 Created with: gclient setdep -r src-internal@e63bdb69ecd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1003454 Change-Id: I3775930d909c9d12036c0c141f1076ca2eab72fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816981Reviewed-by:
-
