GitLab

so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519

Review-Url: https://codereview.chromium.org/2577863002
Cr-Commit-Position: refs/heads/master@{#439374}

This is preparation to split ArcSession running part
from ArcbridgeService.
- Remove friend test declaration, and use public interface only.
- Rework ArcBridgeTest so that we can almost simply rename
  the ArcBridgeServiceImpl.
- Use EXPECT rather than ASSERT.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2581533004
Cr-Commit-Position: refs/heads/master@{#439373}

In some cases, such as sanitizer_coverage_flags=edge,
more than 5 GB of address space is reserved at a startup.
Raising the address space limit to be higher than that.

Unfortunately, Linux has a broken implementation of getrusage,
and the proper way of fixing this (by setting the current usage + 4 GB)
is not trivial / impossible under a sandbox. This is the riskless
change I could make up: increase the address limit, while still
not increasing the amount of memory allocated to avoid issues on
Android.

BUG=674665

Review-Url: https://codereview.chromium.org/2584123002
Cr-Commit-Position: refs/heads/master@{#439372}

Using update-w3c-deps in Chromium 74be73db.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7833

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2586773002
Cr-Commit-Position: refs/heads/master@{#439371}

For historical reasons, older tests are written using the js-test harness.
This harness is deprecated, and should not be used for new tests. So, rewrite
the layout test as following new tests guide[1].

[1] https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md#The-js_test_js-Legacy-Harness

BUG=675437

Review-Url: https://codereview.chromium.org/2588583002
Cr-Commit-Position: refs/heads/master@{#439370}

Cr-Commit-Position: refs/heads/master@{#439369}

A mac-only "Set Up Automatic Updates for All Users" button existed in
the old crome://help page, but was not ported over to the
chrome://md-settings/help page. This CL aims to port that button over.

By Scott Chen <scottchen@chromium.org> (http://crrev.com/2538013002)

BUG=649187
TBR=dpapad@chromium.org (LG'd on other CL)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2583743002
Cr-Commit-Position: refs/heads/master@{#439368}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ad867e93..bde1ec9c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2586753002
Cr-Commit-Position: refs/heads/master@{#439367}

We've seen a bunch of bug reports for flaky build failures
complaining about unused or undeclared arguments; it seems
possible that this CL might be the cause, so I'm speculatively
reverting it and we can see if things get better; reverting the
change makes GN more permissive, so this should be reasonably safe.

This reverts r433944 (f6fd4d74),
i.e. https://codereview.chromium.org/2509333003. This CL leaves
the build files changes that were in that CL because they
are backwards-compatible and improvements regardless.

TBR=brettw@chromium.org
BUG=674213

Review-Url: https://codereview.chromium.org/2586073002
Cr-Commit-Position: refs/heads/master@{#439366}

BUG=675414

Review-Url: https://codereview.chromium.org/2586743002
Cr-Commit-Position: refs/heads/master@{#439365}

Cr-Commit-Position: refs/heads/master@{#439364}

Create an input method and an event handler to dispatch key events on the input
method.

Aura gives us raw key up/down events, but text input requires an input method
("IME"). This also enables the keypress event to be sent to the renderer.

BUG=675413
R=steel@chromium.org

Review-Url: https://codereview.chromium.org/2580733002
Cr-Commit-Position: refs/heads/master@{#439363}

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350

Review-Url: https://codereview.chromium.org/2585953002
Cr-Commit-Position: refs/heads/master@{#439362}

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576833002
Cr-Commit-Position: refs/heads/master@{#439361}

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2575513004
Cr-Commit-Position: refs/heads/master@{#439360}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6da448b4..ad867e93

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2586723002
Cr-Commit-Position: refs/heads/master@{#439359}

BUG=668221

Review-Url: https://codereview.chromium.org/2580013004
Cr-Commit-Position: refs/heads/master@{#439358}

Upstream all code and resources for Chrome on iOS today and share
extensions.

BUG=534433

Review-Url: https://codereview.chromium.org/2586713002
Cr-Commit-Position: refs/heads/master@{#439357}

This patch aims to simplify the existing work flow of OffscreenCanvas commit()
and help OffscreenCanvas transition to the new Display Compositor architecture.
This facilitates the next step of adding resizing functionality of
OffscreenCanvas.

Major changes:
1. OffscreenCanvas now use SurfaceIdAllocator in the renderer/worker, instead
of being in the browser. This is consistent with the new display compositor
architecture.
2. SurfaceLayer for HTMLCanvasElement is only created when Surface is created
in the browser; before that, a dummy SolidColorLayer is put as a placeholder.
3. CanvasSurfaceLayerBridge becomes the client of OffscreenCanvasSurfaceImpl,
so that it can receive IPC messages from browser.
4. FrameSinkId is now generated in renderer/main by CanvasSurfaceLayerBridge,
which remains unchanged throughout the lifecycle of canvas; LocalFrameId is
generated in renderer/worker by OffscreenCanvasFrameDispatcher. At this time it
is only generated once, but will be generated repeatedly when resizing
functionality is added in the future patches.

What is being simplified:
1. Sync IPC GetSurfaceId is removed, reducing overhead in HTMLCanvasElement.
transferControlToOffscreen() API call.
2. When OffscreenCanvas is transferred from main thread to worker thread, there
are now only 2 integers that need to be copied, which constitute the
FrameSinkId. Before this, there were 5 integers that need to be copied. As a
result, there are a lot less attributes that need to be kept by OffscreenCanvas
and CanvasSurfaceLayerBridge.

TBR=avi@chromium.org
BUG=664547, 619138, 662498
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2584643002
Cr-Commit-Position: refs/heads/master@{#439356}

This will allow the prefix to be used as a string constant in code.

BUG=None

Review-Url: https://codereview.chromium.org/2570043002
Cr-Commit-Position: refs/heads/master@{#439355}

After http://crrev.com/2562703003 NGConstraintSpace::ChildSpace became obsolete. Therefore this patch removes it.

BUG=635619

Review-Url: https://codereview.chromium.org/2582913002
Cr-Commit-Position: refs/heads/master@{#439354}

Revert of Temporarily enable PlzNavigate to see perf bot results. (patchset #1 id:1 of https://codereview.chromium.org/2584093003/ )

Reason for revert:
Perf bots have started cycling

Original issue's description:
> Temporarily enable PlzNavigate to see perf bot results.
>
> BUG=368813
> TBR=clamy@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd98556a5beffc0316

TBR=clamy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=368813

Review-Url: https://codereview.chromium.org/2584183003
Cr-Commit-Position: refs/heads/master@{#439353}

Downstream code has been updated to use correct dependencies, so
remove this temporary public_deps.

BUG=None

Review-Url: https://codereview.chromium.org/2575843002
Cr-Commit-Position: refs/heads/master@{#439352}

Revert of Delay Input.dispatchKeyEvent response until after key event ack. (patchset #2 id:20001 of https://codereview.chromium.org/2581153003/ )

Reason for revert:
This patch makes dispatchMouseEvent not respond for anything except mouse moves.
This line is responsible: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/input_router_impl.cc?rcl=1481991563&l=576.
Layout test inspector-protocol/input/dispatchMouseEvent.html times out consistently.

Original issue's description:
> Reland of Delay Input.dispatchKeyEvent response until after key event ack.
>
> This was originally landed in crrev.com/437706, but was reverted in
> crrev.com/437706. This CL contains no changes from the original CL, except that
> I've rebased and fixed some merge conflicts.
>
> BUG=chromedriver:1506
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/94fba022cb393c5016147649b7145d006c10f264
> Cr-Commit-Position: refs/heads/master@{#439224}

TBR=samuong@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromedriver:1506

Review-Url: https://codereview.chromium.org/2584193002
Cr-Commit-Position: refs/heads/master@{#439351}

BUG=368813
TBR=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2584093003 .
Cr-Commit-Position: refs/heads/master@{#439350}

Using update-w3c-deps in Chromium 0e1205a9.

Manual import.

Review-Url: https://codereview.chromium.org/2572333003
Cr-Commit-Position: refs/heads/master@{#439349}

There are lifetime issues due to IconLoader being refcounted for no good reason, so stop doing that.

BUG=674743

Review-Url: https://codereview.chromium.org/2577273002
Cr-Commit-Position: refs/heads/master@{#439348}

ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed
from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they
have not been compiled and executed.
This CL resurrects these entries in BUILD.gn and thus re-enabling these tests.

BUG=655920

Review-Url: https://codereview.chromium.org/2577073004
Cr-Commit-Position: refs/heads/master@{#439347}

Review-Url: https://codereview.chromium.org/2581733002
Cr-Commit-Position: refs/heads/master@{#439346}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/116833c4..6da448b4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582213002
Cr-Commit-Position: refs/heads/master@{#439345}

I updated the aura-mus classes to support mus.

BUG=674575
TEST=none
R=ben@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2577023003
Cr-Commit-Position: refs/heads/master@{#439344}

Startup metrics can be sent only first 7 minutes from system start,
while expected these metrics will be sent only if 7 minutes are passed
from system start.

Since M54 hit stable, drop these metrics.

BUG=634408

R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org

Review-Url: https://codereview.chromium.org/2576983003
Cr-Commit-Position: refs/heads/master@{#439343}

With mus+ash, we host the discardable memory service in the mus process.
For classic chrome, we will run the discardable memory service in the
browser process.

BUG=654678

Review-Url: https://codereview.chromium.org/2548423002
Cr-Commit-Position: refs/heads/master@{#439342}

BUG=666885

Review-Url: https://codereview.chromium.org/2579373002
Cr-Commit-Position: refs/heads/master@{#439341}

https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/4d737af..2d19afd

BUG=675195
TBR=inferno@chromium.org,kcc@chromium.org

Review-Url: https://codereview.chromium.org/2586703002
Cr-Commit-Position: refs/heads/master@{#439340}

HTMLPlugInElement::removedFrom() clears persisted plugin widgets, to
prevent reuse of a widget associated with a destroyed object. However,
when nodes containing connected subframes are removed from a Document,
it is possible to synchronously trigger script after subframes are
detached, but before the nodes themselves are actually removed. This
can cause a FrameView for a detached frame to be incorrectly reused.

BUG=671331

Review-Url: https://codereview.chromium.org/2586633002
Cr-Commit-Position: refs/heads/master@{#439339}

DisplayAndroid::stopAccurateListening() should not call
DisplayAndroidManager::startAccurateListening().

BUG=675344

Review-Url: https://codereview.chromium.org/2581113003
Cr-Commit-Position: refs/heads/master@{#439338}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2582903002
Cr-Commit-Position: refs/heads/master@{#439337}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6272f06e..116833c4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2586673002
Cr-Commit-Position: refs/heads/master@{#439336}

The previous tests only covered a tiny part of the component, which is
the merging logic, but not the actual combinations of events that can
happen during the fetching of tiles from the backends (top sites,
suggestions service, popular sites).

Mocks are used extensively due to the lack of fakes, and because the
interfaces are really big. It's somewhat painful to read, but
alternatives are not better.

The tests surface one bug which is not addressed here, left more a
follow-up patch and represented with a TODO.

Popular Sites fetching is still not covered by these tests, and
another TODO is added for this purpose.

BUG=619584

Review-Url: https://codereview.chromium.org/2579813002
Cr-Commit-Position: refs/heads/master@{#439335}