GitLab

This reverts commit ba52e783.

Reason for revert: This caused flakiness in the TwoClientAutofillProfileSyncTest.ClientsAddSameProfile test.

Original change's description:
> Reland "Fix flaky test ServerAddressConvertsToSameLocalAddress"
> 
> This is a reland of commit b3873b4d.
> 
> The CL fixes a race condition in production code of autofill profile
> sync bridge by modifying merge logic of the datatype. Previously, the
> logic for dealing with duplicate entities was to always prefer the
> remote one and silently delete the local one. This could end up with
> two clients having a different entry each and the sync server having
> both duplicate entries. The new behavior, introduced in this CL is to
> keep the profile with greater GUID, lexicographically.
> 
> This change should also remove flakiness of one integration test (that
> uncovered the actual issue), so the CL reenables the test.
> 
> The original CL caused flakiness in another integration test since GUIDs
> in that test are randomly attributed. In this reland, we fix this by
> making the expectation on the number of sync deletions depend on which
> one of the test GUIDs is bigger.
> 
> Bug: 917498
> Change-Id: I13994ac5bef8fcae41d37350e08ee80ab90f0916
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002571
> Auto-Submit: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733636}

TBR=kolos@chromium.org,jkrcal@chromium.org,mastiz@chromium.org

Change-Id: Ifad46c8c079b24a07c044b9d6a5ffdc77a439617
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 917498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013281Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733910}

error of SharedWorker is |Event| type or |ErrorEvent|.
This CL removes error.message because |Event| doesn't have |message| property.
https://html.spec.whatwg.org/multipage/indices.html#event-error

Bug: 1043634
Change-Id: Id7ff6b4222c56b770457731694f07fd850504681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011621Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733909}

Using wpt-import in Chromium a94bda97.
With Chromium commits locally applied on WPT:
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: I7e39010224ddee171c719d52fbe006c4510bb1b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012796Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733908}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fef76e222696..49d180876100


Created with:
  gclient setdep -r src-internal@49d180876100

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ia10c7d1bdf65399d8201321657bd3cd6a5772baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014301Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733907}

Based on the given |file_type|, GetRecentFiles to ARC media source
should return filtered result.
For instance, if the specified file_type is "Images", we should query
recent files only on "images_root" in the MediaDocumentsProvider.

Bug: 1040049
Test: Ran unit_tests
Change-Id: I1e24d9c8338355b7036fe2a7ad1d129c54d7a2c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012200Reviewed-by: Satoshi Niwa <niwa@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733906}

The image processor's output buffers don't need to follow the decoder's
coded size ; what we are interested in is having a buffer that can
contain just the visible area.

The VDA already (correctly) does this and thus needs no update.

BUG=chromium:982172
BUG=b:141579960
BUG=b:146599071
BUG=b:141965953
TEST=Youtube playing in 240, 360, 480 and 720p on desktop and Android
with Krane and Kevin. No artefact or green line visible.
TEST=GtsMediaTestCases com.google.android.media.gts.MediaPlayerTest
 #testLLAMA_H264_BASELINE_240P_800_DOWNLOADED_V0_SYNC passes on Krane
without a green line.

Change-Id: I35c24ef6c56d1c7fe91e879483698f1f9f5e51d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011785
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733905}

This reverts commit bbbb72b3.

Reason for revert: MediaAppUIBrowserTest failing on linux-chromeos-chrome
Fixed: 1044503

Original change's description:
> Enable chrome.metricsPrivate for the untrusted context of MediaApp so we can use UMA.
> 
> Doc: http://go/backlight-ea-uma-metrics (slightly outdated)
> 
> Bug: 996088, b/128567301
> Change-Id: Ia272a35815ac92de954a6e5c43e1c2d4ea502e0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000440
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Commit-Queue: David Lei <dlei@google.com>
> Cr-Commit-Position: refs/heads/master@{#733884}

TBR=tapted@chromium.org,benwells@chromium.org,dlei@google.com

Change-Id: I7e95b2c95bb5b1abd2f19416e585ae6f7f6f404b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996088, b/128567301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014354Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733904}

I accidentally removed this in crrev.com/c/1973194, and subsequent
attempts to roll the AVD images have failed on larger test suites as a
result.

Bug: 922145
Change-Id: Ie7b55f456dcd27ec1d17b33814ea258345892c43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012790
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733903}

This reverts commit 32a1f8bf.

Reason for revert: LocalNTPJavascriptTest failing on 7 builder(s)
Fixed: 1044497

Original change's description:
> WebApps: Implement unregistering file handlers on Linux.
> 
> This will allow us to disable the file handlers for an app on Linux
> without uninstalling it. This is necessary preparation for the origin
> trial, as we need to be able to disable/enable the file handlers as
> the validity of the app's origin trial changes.
> 
> Bug: 1028448
> Change-Id: I63eb6582852ff75d3d88181ede07f0cbd010df2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010234
> Commit-Queue: Jay Harris <harrisjay@chromium.org>
> Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733859}

TBR=loyso@chromium.org,harrisjay@chromium.org

Change-Id: I67239e88d48df1d70ff1a432863b3be26d5d7bd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014352Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733902}

This reverts commit d17c53b3.

Reason for revert: This makes the GPU process crash on startup on Krane (and probably many other ChromeOS devices).

Original change's description:
> Call PreSandboxStartup after GL initialization in GpuInit
> 
> Fixes "vaInitialize failed: unknown libva error"
> on Wayland with LIBVA_DRIVER_NAME=i965
> 
> VaapiWrapper relies on the GL implementation to decide
> which display to use. If the GL implementation is none,
> then VaapiWrapper is likely to do the wrong guess resulting
> in the above error.
> 
> Bug: 1041229
> Change-Id: I1255a032a5e14b3aaffe3026a886de7e6d9ff0d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011640
> Reviewed-by: Maggie Chen <magchen@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733847}

TBR=kbr@chromium.org,julien.isorce@chromium.org,magchen@chromium.org

Change-Id: Ic536f47506a2e9a3f6db8f946732030295a8d63f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014351Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733901}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by me.

Bug: 1041419
Change-Id: I730b20897134a058e4f98b5279d4dc3409c6cab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012602
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733900}

When importing a buffer, the provided buffer's size may differ from the
size we requested from ProvidePictureBuffersWithVisibleRect(). We
already accounted the width difference, but not the height, which
resulted in green lines being visible when the provided buffer differed
in height, and was single-planar: the image processor would render using
the assumed height, while the GPU would render using the real height,
resulting in the color plane being offset by one or two lines.

Since the VDA and SVDA both need to do this, factorize the actual buffer
size's computation code into a VDA helper, and call it from both.

BUG=chromium:982172
BUG=b:141579960
BUG=b:146599071
BUG=b:141965953
TEST=Youtube playing in 240, 360, 480 and 720p on desktop and Android
with Hana, Krane and Kevin. No artefact or green line visible.

Change-Id: I0e28446805fd382cbe0d3aab30b704c85ca52b72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011784
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733899}

ManifestUpdateManager and ManifestUpdateTask are not used outside of
web_applications and are not isolated components, they should live one
level up while maintaining independence from the BMO/Extension backend.

This CL is in preparation to add a dependency from
ManifestUpdateManager to SystemWebAppManager.

Bug: 1035242
Change-Id: I3a5e8e691079619e5b063ac90653dcae6ee3f76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973441
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733898}

The histogram Search.ContextualSearchQuickActions.Category is
being written with an incorrect upper-bound that is too low.

The values written are in the range 0-5 which matches the enum in
enums.xml.  The problem is that the supplied upper-bound for the value
is being incorrectly supplied as being 3 rather than 6. This has the
effect of lumping all the high values into the third bucket.

Here's what tipped me off: when I viewed the histogram data I could see
there were only 3 buckets and the last had a wonky max value.
Pic here: https://screenshot.googleplex.com/BiZRJPYwSAi.png

This just fixes the supplied upper-bound to be correct, and extends the
histogram out for a year.

Change-Id: I11ba80ac0429468812b92817d85493091e987b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003574Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733897}

Nuances:

- Differently from other conversions, where it is possible to remove
method handlers in RenderFrame and WebLocalFrame levels when
switching away from legacy IPC to mojo, in this particular case,
the method WebLocalFrame::DispatchBeforeUnloadEvent() is still called
directly by other sources [0], hence it can not be removed.

[0] RenderFrameImpl::BeginNavigation().

- Some tests (eg [1] and [2]) used to simulate the receipt of the
FrameHostMsg_BeforeUnload_ACK message, which is being converted to
a mojo completion callback by this CL.
In such cases, TestRenderFrameHost::SendBeforeUnloadACK() was used as
a replacement.

[1] RenderFrameHostManagerTest.CancelPendingProperlyDeletesOrSwaps
[2] WebContentsImplTest.CrossSiteUnloadHandlers

- Some other tests (eg [3]) used to simulate the receipt of the
FrameMsg_BeforeUnload message, also being converted to a mojo message
by this CL.
For such cases, TestRenderFrame class got an extra method
SimulateBeforeUnload(), that calls out the appropriate handling logic.

[3] RenderViewImplTest.DispatchBeforeUnloadCanDetachFrame

- Last, in [4], test used to intercept and ignore the
Msg_BeforeUnload_ACKadParentHang, using a BrowserMessageFilter override
(see DropBeforeUnloadACKFilter). However, since this CL converts this
ACK-like legacy IPC to a mojo closure, the CL mimics the approach used
in  RenderFrameHostFactoryForHistoryBackInterceptor (see [5]).

[4] RenderFrameHostImplBrowserTest.IframeBeforeUnloadParentHang
[5] //content/browser/navigation_browsertest.cc

BUG=1042800
R=avi@chromium.org, dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org

Change-Id: Ia580cfe2c7d58e22e4d790a47387926158508919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010920
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733896}

The previous code supposed that we created PaintOffsetTranslation for
all scrollable elements. This is not true for SVG foreign objects for
which we can't create PaintOffsetTranslation because the offset is in
SVG space which is affected by transform.

Bug: 1030109
Change-Id: I161821c50e091257f77b2f806ac5c00c903198da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012904Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733895}

These are no longer necessary because undefined methods are delegated to
self.underlyingScrollView by default with -forwardInvocation:.

And it makes easier to preserve properties using CRWPropertiesStore by
deleting them.

Bug: 1023250
Change-Id: I3ad9fc7ccc919086dd57a019a721461736fa21f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006843Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733894}

... to HTMLSelectElement

- Early-return for !UsesMenuList().  LayoutListBox doesn't have
  UpdateFromElement() implementation.

- Move LayoutMenuList::option_style_ to HTMLSelectElement.

This CL has no behavior changes.

Bug: 1040828
Change-Id: I5870e228f9ad473844d6a05e7611e59cbcfcd084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014205Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733893}

Rename InitializeHardwareOverlaySupport() to
UpdateHardwareOverlaySupport() and update the code of hardware overlay
cap query in preparation for display change.

Bug: 1042989
Change-Id: Iff36a6a5b4caf49c730736550e11360ee69d6513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013320Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733892}

The current code for updating |this.tasks_| does not account for when
|this.tasks_| is an empty array. Fix this: Only update |this.tasks_| if
there are tasks to update.

Also remove redundant function |getAvailableTasks_|.

Bug: 1038799
Change-Id: Iacf74ad6d620ce5001a7de73bfa762b0ea0f0be7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014206
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733891}

In guest mode, the Drive integration service exists, but it is not
mounted or enabled, meaning some operations on it will lead to a crash.
Use drive::util::GetIntegrationServiceByProfile instead of going through
the factory, as it also checks if drive is mounted.

Bug: 1029477
Change-Id: I5f3e71ee7e788507613f5fe6f158db4e0c4add87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011467
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Auto-Submit: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733890}

This is needed so we can offer an upgrade on the next Crostini start.

Bug: 1024693
Change-Id: I204ab5348330d9a2869e420c1c0f828e55116323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011472Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733889}

It's no longer necessary as we've introduced our own abstraction
layer, arc::ArcClientAdapter. This CL injects a fake ArcClientAdapter
implementation to the test fixture to simplify the test. That allows
us to remove all usage of chromeos:: and login_manager:: from the
test, and the test no longer depends on the internals of the ARC
container.

BUG=b:143175953
TEST=try

Change-Id: Ia39f492a94b5698794df423b181ff935b944eec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008284Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733888}

This brings the LaunchParams dictionary into line with what's discussed
in the explainer:
https://github.com/WICG/file-handling/blob/master/explainer.md

Bug: 829689
Change-Id: I3322099aeb8cdcf558acb8a59076fbbc285467e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012377Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733887}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/564dcf4c071b..28a405e6e578

git log 564dcf4c071b..28a405e6e578 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@28a405e6e578

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5bb1aadf2b46e6a7722af2fd200c0118ae1cbe16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014154Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733886}

The code that calls the bluetooth logging function is in
https://chromium-review.googlesource.com/c/chromium/src/+/1999973.

Bug: 1014839
Change-Id: Ica03b6509df95b389559cb01a8f9dea4dcf15e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011469Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733885}

Doc: http://go/backlight-ea-uma-metrics (slightly outdated)

Bug: 996088, b/128567301
Change-Id: Ia272a35815ac92de954a6e5c43e1c2d4ea502e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000440Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: David Lei <dlei@google.com>
Cr-Commit-Position: refs/heads/master@{#733884}

Bug: chromium:914515
Test: manual
Cq-Depend: chromium:2004185
Change-Id: Iee8645e016f716e48c80fcaeee04d2ec25ce8cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010238
Commit-Queue: David Munro <davidmunro@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#733883}

https://chromium.googlesource.com/angle/angle.git/+log/7f8b6e3fabbd..8c396a9cc4a8

git log 7f8b6e3fabbd..8c396a9cc4a8 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 flibitijibibo@gmail.com Ignore vulkan-loader dependency for GGP
2020-01-21 syoussefi@chromium.org Vulkan: Cleanup device feature query and enabling
2020-01-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 2d6f74c6d431..af8c7e040f93 (11 commits)

Created with:
  gclient setdep -r src/third_party/angle@8c396a9cc4a8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1002945
Tbr: timvp@google.com
Change-Id: I984bce5adbb35693bcdc2245ba5429322944a6c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733882}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d339e36642df..6a5aa6680ce4

git log d339e36642df..6a5aa6680ce4 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 gregorynisbet@google.com export PYTHONDONTWRITEBYTECODE instead of just defining constant

Created with:
  gclient setdep -r src/third_party/depot_tools@6a5aa6680ce4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1040314
Tbr: agable@chromium.org
Change-Id: Ie3c172e16c093dcd648eaa042ae14670c12c9423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014140Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733881}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Idd9762c7fede3326da4f2845f4781d21227a4ecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014150Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733880}

There are a few lower priority differences with the CrOS file
picker so the flexibility to switch is currently still useful.

BUG=None
TEST=trybot

Change-Id: Ib05ee202726ebe460a2684fbbdbe26b79bdb3ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014200Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Auto-Submit: Satoshi Niwa <niwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733879}

FileListNameForWidth() implementations of LayoutTheme and LayoutThemeMac
were almost identical. This CL does:
 - Introduce LayoutTheme::DisplayNameForFile() for the uncommon part
   of FileListNameForWidth() implementations.
 - Move the common part to FileInputType::FileStatusText() and
   LayoutFileUploadControl::FileTextValue().

This CL has no behavior changes.

Bug: 1040828
Change-Id: I1c8a565380304523128a331cad4ef8abcef49e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012371Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733878}

Updating closure externs for Chrome API.
(Required by http://crrev.com/c/1989728)
I got the latest externs by running roll_closure_compiler, but I keep
the compiler jar for now since I got multiple compile errors with the
latest compiler.

Bug: 1044378
Test: Ran compiler
Change-Id: I28d10815253ce67db1de7df4c3f839c8300488ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009600
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733877}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b41dac7d030..fef76e222696


Created with:
  gclient setdep -r src-internal@fef76e222696

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ied184d303c53036a52aae79a96d4337726de815c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014155Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733876}

Both decoders are supposed to do the same thing here, but small
differences in the code design could make the reader believe that they
don't. In particular, the IP is only supposed to be created in IMPORT
mode for both cases.

Make sure both decoders run the same version. We are going to reorganize
and factorize this code, but this little cleanup ensures it is safe to
do so.

BUG=None
TEST=Youtube desktop and Android both play on Hana and Kukui.

Change-Id: Ic572763b519f74337adc31714f6fa738d9bce194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011783Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733875}

The complex rules come from http://crrev.com/eacad605 where the
navigationStart was set after the beforeunload handler. This code no
longer exists and the original conditions can be removed.

BUG=1040954

Change-Id: Ifeb7c430af1ec31498d916a5dc343ac041ba8d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008074Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733874}

Part 2 of many.

With this CL, it should be possible to traverse the tab strip via keyboard and interact with both Tabs and TabGroupHeaders in an expected manner.

See Part 1 (crrev.com/c/1998146) for interactions that are still missing.

Bug: 1039921
Change-Id: I277a6a9cec78b8677e411e248b4ed9adf872e9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999088
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733873}

This CL modernizes clients-matchall-client-types.https.html using ES
features (arrow functions, async/await, etc) for code cleanup. This
doesn't change functional behavior.

Bug: n/a
Change-Id: Iaf35d11f1f90ec8e9cf9d41d585a873d7bcd8695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010758
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733872}

This will allow discovered IP addresses to be transferred to smbfs as an
IP address type (instead of as a string).

Bug: 939235

Change-Id: I725f4b8eef26fb361a06586b454cf8e559374648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012365
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733871}