GitLab

Since Importer has been recently disabled, it was forgotten during refactoring GDATA -> DRIVE. This patch updates the constants' names.

TEST=Check if the importer works.
BUG=None

Review URL: https://codereview.chromium.org/12260038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182441 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182438 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation of the TestRunner library doing all the painting

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/12207175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182435 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=170921

Review URL: https://codereview.chromium.org/12212188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182433 0039d316-1c4b-4281-b951-d872f2087c98

- Fix wrong styles what the presubmit warns.
- Change the order of '@private' and '@constructor' annotations.
- Add/remove blank lines to be better readability.

BUG=175657
TEST=Files.app launches.
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12212187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170921

Review URL: https://codereview.chromium.org/12210082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182431 0039d316-1c4b-4281-b951-d872f2087c98

Don't send vendor/product ids.
Use HTTPS.
Don't open page if screen locked.

BUG=176145
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12262027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182430 0039d316-1c4b-4281-b951-d872f2087c98

This lands server change 42070470.

Review URL: https://codereview.chromium.org/12262002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182429 0039d316-1c4b-4281-b951-d872f2087c98

filemanager: Fix GetDriveConnectionStateFunctionChange to return "offline" when DriveSystemService is unavailable.

Connection-type "offline" is returned with reason "no_service"
Also renamed related variables in JS.

BUG=175522
TEST=Verfify Files app (including "open file", "save file" dialogs) is working if Drive is disblaed, in Incognito window, in Guest mode.

Review URL: https://codereview.chromium.org/12221132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/12253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182425 0039d316-1c4b-4281-b951-d872f2087c98

Adds missing JSdos which Closure linter warns. And removes the unused argument of FileTransferController.isDocumentWideEvent_().

BUG=175657
TEST=Files.app launches.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12258003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182424 0039d316-1c4b-4281-b951-d872f2087c98

JSON schema compiler automatically registers api functions in generated_api.cc files for the JSON files specified as schema_files in api.gyp. JSON schema compiler generates code in specific namespace, function names and file paths as per json files.

BUG=159265
TBR=mirandac@chromium.org
TBR=ben@chromium.org
TBR=kalman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12089062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182423 0039d316-1c4b-4281-b951-d872f2087c98

It has been disabled because of bugs.

TEST=Enter usb drive, right click on the usb drive item in the left nav in Files.app, choose Import media.
BUG=176203

Review URL: https://codereview.chromium.org/12255024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182422 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'EE:0213: Missing type in @param tag.' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12255010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182421 0039d316-1c4b-4281-b951-d872f2087c98

Android retry logic currently changes based on number of
devices.  This means that test runs are more flaky when only
one device is attached.  Change this to always retry 3 times.

BUG=175653
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12207172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182420 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'E:0210: Missing docs for parameter' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12212185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182417 0039d316-1c4b-4281-b951-d872f2087c98

If there exists session sync nodes that use the cache GUID as the ID,
Chrome for Android goes into a deadlock while associating the tabs.

Since SessionModelAssociator::DeleteForeignSession uses its own
syncer::WriteTransaction, we must ensure that we only call that method
without currently holding a syncer::WriteTransaction.

BUG=175782

Review URL: https://chromiumcodereview.appspot.com/12253010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=165557, 162318

Review URL: https://chromiumcodereview.appspot.com/12250028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182415 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182414 0039d316-1c4b-4281-b951-d872f2087c98

type -> templateType
template names -> enum
base -> basic
multiple -> list
timestamp -> eventTime
unreadCount -> gone
buttonOne/Two -> buttons array

BUG=174680


Review URL: https://chromiumcodereview.appspot.com/12212037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182413 0039d316-1c4b-4281-b951-d872f2087c98

Currently all tests for TranslateHelper are implemented as browser tests.
But some small tests can run as unit tests. This change introduce new unittest
file for TranslateHelper, then replace an existing test into it.

BUG=175673
TEST=unit_tests --gtest_filter='TranslateHelperTest.*'

Review URL: https://codereview.chromium.org/12209114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182412 0039d316-1c4b-4281-b951-d872f2087c98

particularly in the case of SSL proxies.

Errors that one is likely to see when trying to talk SSL
to a captive portal now trigger fallback.

The errors are:

ERR_CONNECTION_TIMED_OUT (Portal blackholes SSL)
ERR_PROXY_CERTIFICATE_INVALID (Portal uses self-signed cert)
ERR_SSL_PROTOCOL_ERROR (Portal talks HTTP over port 443)

BUG=176053
Review URL: https://codereview.chromium.org/12252015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182411 0039d316-1c4b-4281-b951-d872f2087c98

> Files.app: add mock namespaces and constructors to mock_chrome.js for test.
> 
> BUG=175657
> TEST=mock Files.app works.
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/12230013

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/12254032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182410 0039d316-1c4b-4281-b951-d872f2087c98

Useful in SPDY 4 development.

This lands server change 42070418.


Review URL: https://chromiumcodereview.appspot.com/12259003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182408 0039d316-1c4b-4281-b951-d872f2087c98

Inspection of stack prepared by caller shows it is indeed copying dword, not qword, for 32-bit arguments on Win64, and the background stack is not zeroed.

Incorrect function result, access violations or worse (not-immediately caught side effect of corrupted memory within process address space) could easily result from current win64 usage of these routines.

One solution, implemented here, is to change the function prototypes for the yasm routines to take ptrdiff_t arguments instead of int args.  The C version of the equivalent code needs matching prototype (due to the choose proc routines), so they are updated too.

Another, probably slightly less performant, solution would be to change the asm routines to conditionally sign-extend when loading int (32-bit) parameters on x64.  None of these routines currently use int passed in directly as register; I  don't know if zero-extension of registers would be required if they did.

Yet another solution would be to switch to VS2012 and redo the yasm routines using compiler intrinsics completely (not supported in VS2010).

Note, some other media_unittests, namely those involving ffmpeg, currently give access violation on Win64.  There is a separate ffmpeg fix in progress https://gerrit.chromium.org/gerrit/#/c/43063/.  With PS1 or PS2 applied along with the ffmpeg fix, Win64 media_unittests pass.

Detail:
The following are sign-extended in prototype:
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertARGBToYUVRow_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertRGBToYUVRow_SSSE3
simd/convert_yuv_to_rgb_mmx.asm:%define SYMBOL ConvertYUVToRGB32Row_MMX
simd/convert_yuv_to_rgb_sse.asm:%define SYMBOL ConvertYUVToRGB32Row_SSE
simd/scale_yuv_to_rgb_mmx.asm:%define SYMBOL ScaleYUVToRGB32Row_MMX
simd/scale_yuv_to_rgb_sse.asm:%define SYMBOL ScaleYUVToRGB32Row_SSE
simd/scale_yuv_to_rgb_sse2_x64.asm:%define SYMBOL ScaleYUVToRGB32Row_SSE2_X64
simd/linear_scale_yuv_to_rgb_mmx.asm:%define SYMBOL LinearScaleYUVToRGB32Row_MMX
simd/linear_scale_yuv_to_rgb_sse.asm:%define SYMBOL LinearScaleYUVToRGB32Row_SSE
simd/linear_scale_yuv_to_rgb_mmx_x64.asm:%define SYMBOL LinearScaleYUVToRGB32Row_MMX_X64

The following C versions and the corresponding typedefs also needed updating to match:
ConvertYUVToRGB32Row_C
ScaleYUVToRGB32Row_C
LinearScaleYUVToRGB32Row_C

The following yasm routines have no C prototype, nor do they appear to be used anywhere.  I updated their comments though to match the same prototype change that would be necessary.
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertARGBToYUVEven_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertARGBToYUVOdd_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertRGBToYUVEven_SSSE3
simd/convert_rgb_to_yuv_ssse3.asm:%define SYMBOL          ConvertRGBToYUVOdd_SSSE3

BUG=174160
TEST=with https://gerrit.chromium.org/gerrit/#/c/43063/ also applied, all win64 media_unittests non-disabled test cases pass
R=hclam@chromium.org
R=dalecurtis@chromium.org
R=rbultje@chromium.org
CC=jschuh@chromium.org
CC=scherkus@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12211067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182407 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182406 0039d316-1c4b-4281-b951-d872f2087c98

> [Cleanup] Files.app: Fill 'TODO' comments to missing descriptions in @param annotation.
> 
> This suppresses 'E:0210: Missing docs for parameter' errors from closure linter.
> 
> All changes are in comment, hence I believe this patch doesn't change any behavior.
> 
> BUG=175657
> TEST=none
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/12261008

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/12255028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182405 0039d316-1c4b-4281-b951-d872f2087c98

This significantly reduces the context switching overhead for
impl-side painting.

Instead of posting reply task to the impl thread after completing
each raster job, post a reply only when worker pool becomes idle
and poll for completed tasks at a 6ms interval.

This doesn't just make rasterization more efficient but also
reduces the number of shallow flushes, which makes async uploads
more efficient.

BUG=173802

Review URL: https://codereview.chromium.org/12217105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182404 0039d316-1c4b-4281-b951-d872f2087c98

When the surface is created from GpuCommandBufferStub, it is
made current for the very first time while
helper_->stub()->decoder()->GetGLContext() returns NULL (see order
in GpuCommandBufferStub::OnInitialize()).

If we then handle drawing and swapping of a frame while
a) the context is still current and we avoid calling
Surface::OnMakeCurrent() again
b) the surface is destroyed right after with the ack pending,
it is possible for context_ to be NULL in BufferPresentedImpl.

With virtual contexts, this patch causes us to hold a reference
to the real GL context instead now, which is fine because we only
need the context to delete the backbuffer texture during destruction.

BUG=169429

Review URL: https://codereview.chromium.org/12252028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182403 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'E:0210: Missing docs for parameter' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12261008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182402 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=sky,bauerb

Review URL: https://chromiumcodereview.appspot.com/12260035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182401 0039d316-1c4b-4281-b951-d872f2087c98

We can't reference-count shared memory regions in the GPU
process, so we dup/map the memory block for each upload.
This doesn't scale for small uploads, both because we can
use too many file descriptors, and use too much address
space when the small upload transfer buffers are contained
in larger shared memory blocks.

This limits the total number of uploads to prevent the
problem, but this should be fixed properly and this limit
removed.

BUG=176002

NOTRY=True
Since it's a CC only change and unit tests have passed.


Review URL: https://chromiumcodereview.appspot.com/12260033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182400 0039d316-1c4b-4281-b951-d872f2087c98

With this API, users of component_updater can trigger an
update or install when deemed important.  E.g., if a
component is not yet installed, but is about to be used.

There is not a guarantee that the item will actually
be updated.  There is only a good chance.  It can
still be preempted by other items that may have an update
available as well, or if multiple components
use this interface one will trump the others.

Use this to kick off a check of PNaCl if flag enabled, but
not yet installed.

Sort of related to:
BUG=107438

Review URL: https://codereview.chromium.org/12054003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182399 0039d316-1c4b-4281-b951-d872f2087c98

Resolutions AsValue did not recognize NON_IDEAL_RESOLUTION

Call rate of PictureLayerTiling::UpdateTilePriorities is very high. Dont trace it.

R=ccameron
BUG=176150

Review URL: https://codereview.chromium.org/12253021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182398 0039d316-1c4b-4281-b951-d872f2087c98

And some cosmetic changes in other Instant files.

BUG=none
R=jered@chromium.org,sky@chromium.org
TEST=none; no change in functionality.


Review URL: https://chromiumcodereview.appspot.com/12256029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=No DCHECK failure on uploading 2GB+ files with Debug build

Review URL: https://codereview.chromium.org/12217165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182394 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dsinclair@chromium.org
BUG=176210
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12212183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12217049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182392 0039d316-1c4b-4281-b951-d872f2087c98

Before, the labels were not properly aligned. This patch aligns them by simplifying the css.

TEST=Enter Files.app, check carefully the headers. Click on the 'select all' checkbox.
BUG=175962

Review URL: https://codereview.chromium.org/12262032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182391 0039d316-1c4b-4281-b951-d872f2087c98