- 11 Dec, 2017 40 commits
-
-
Tibor Goldschwendt authored
Bug: 793389 Change-Id: I82fe6000a5a16b5a44c9c383b041ab602fad2527 Reviewed-on: https://chromium-review.googlesource.com/817958Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523105}
-
Marc Treib authored
This adds a "data_push_epoch" field to the iframe URLs for interactive Doodles, and a "launch_interactive_behavior" field. Bug: none Change-Id: I29f5447dfc5dd6d050d252a1261f6a9896c6cc9b Reviewed-on: https://chromium-review.googlesource.com/819411Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523104}
-
Peter Wen authored
Rather than create the output directory in apkbuilder.py, add it to the gn target's output for gn to create it automatically. Bug: 792534 Change-Id: I3de087be4839e917b4308c38016da3b783668a96 Reviewed-on: https://chromium-review.googlesource.com/815355Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523103}
-
rhalavati@google.com authored
Extends annotations.xml to include incomplete annotations, file paths, and the list of fields in the incomplete annotations. Bug: 656607 Bug: 788035 Change-Id: Ibabbbd91fa8d618571d3fe00dc32fd0aec0277ed Reviewed-on: https://chromium-review.googlesource.com/817749 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523102}
-
Mathieu Perreault authored
Allows the bubble to be dismissed when the web contents is clicked, even if the bubble has not been interacted with. Bug: 793081, 624560 Change-Id: I9597bd8162db2fdc82a821621d28a301165fa7a1 Reviewed-on: https://chromium-review.googlesource.com/816394Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#523101}
-
Dave Tapuska authored
A property was misspelled in a synthetic injection test correct its name. BUG=793765 Change-Id: Iaa41840b0fe27d01b2729d1f46c57d7b6f7c4ac4 Reviewed-on: https://chromium-review.googlesource.com/819490Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#523100}
-
Gauthier Ambard authored
PrerenderTestCase.testTapPrerenderSuggestions was flaky because the suggestions displayed by the omnibox are displayed inside a TableView. The TableView rows are not removed from the view hierarchy when the corresponding suggestions should not be displayed, they are hidden. So the test see multiple elements for the matcher even if only one of them is visible on the screen. This CL fixes it by checking that the suggestion displayed is the first one, which is a prerequisite to have the prerenderer loading it. Bug: 793802 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44f24c4b542ac6d27a6fa0ca0b0b1759c7a7c80a Reviewed-on: https://chromium-review.googlesource.com/819470Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523099}
-
Peter Wen authored
Currently .so and .pak files are parsed and tracked. Group all other files in .other section for now so we at least track them too. Bug: 793014 Change-Id: I7237c0e329e9e6b06ec08ff15d3b5395f56a65e7 Reviewed-on: https://chromium-review.googlesource.com/815357 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Windows headers define a macro named NO_ERROR so it is best to avoid that name. This renames the new NO_ERROR enum value to CBOR_NO_ERROR, similar to GL_NO_ERROR. Bug: 780504 Change-Id: I83aa3b83b9239659c296687a9109f255b272a1ce Reviewed-on: https://chromium-review.googlesource.com/819251Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523097}
-
Mathieu Perreault authored
On Views, there is no arrow draw if the bubble shows up on a user gesture. For consistency, an arrow is now drawn on Mac, pre Material Design. Bug: 793077 Test: visual Change-Id: Ic73856c6b07cdc3b5821fec918d44cd458847d04 Reviewed-on: https://chromium-review.googlesource.com/818154 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This reverts commit 81f70917. Reason for revert: NavigationThrottle can be destructed by JNI call. Original change's description: > Replace Nav.Intercept.WillStart histogram in favor of main/subframe breakouts > > The initial data looks heavily multi-modal, which I suspect is from the > split. > > Bug: 792524 > Change-Id: Icd40c722aa5505f4b3eb69c4283b9aca211c9dc4 > Reviewed-on: https://chromium-review.googlesource.com/814216 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522544} TBR=michaelbai@chromium.org,asvitkine@chromium.org,csharrison@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 792524, 793719 Change-Id: Ib6e4deab8bc20ba96428ea21c0b84acb97084606 Reviewed-on: https://chromium-review.googlesource.com/819330 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#523095}
-
Lalit Maganti authored
This struct is essentially only an implementation detail of the memory instrumentation coordinator and does not need to be exposed in base. Bug: 776726 Change-Id: I67336eb99d5677e9b18ae30213486927d12079d3 Reviewed-on: https://chromium-review.googlesource.com/813836Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523094}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/93e913442275..650a2e1adeb2 $ git log 93e913442..650a2e1ad --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6a8ee7523296e37be69e4842479bae718d8160f4 Reviewed-on: https://chromium-review.googlesource.com/819310Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523093}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/917ba969..b987e09a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3b7efe42ac54b1ce3d9ae023e5695f88b7e983e1 Reviewed-on: https://chromium-review.googlesource.com/818713Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523092}
-
Gauthier Ambard authored
The location bar has a shadow below it. This shadow should only be displayed when the omnibox is contracted. Bug: 793736 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9bea295e3635f29802aa598c76700a753511641b Reviewed-on: https://chromium-review.googlesource.com/817284Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523091}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7f5e61f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7428 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2e490022614e2f0fecb913e0b38accefeb122f00 Reviewed-on: https://chromium-review.googlesource.com/818714 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523090}
-
Yuki Shiino authored
Converts NFC's MessageCallback to callback function type due to NFC spec. As NFC::OnWatch needs special argument construction, i.e. needs to create a JSON object, which is out of scope of Web IDL type conversions, NFC::OnWatch needs a ScriptState of callback function's argument's context. Thus, this patch makes CallbackFunctionBase::CallbackRelevantScriptState() public. CallbackInterfaceBase::CallbackRelevantScriptState() is made public, too, just in order to be symmetric. Bug: 569301, 658073 Change-Id: Ieebbf3c8d317a70b7d5045494fed9360fe41070c Reviewed-on: https://chromium-review.googlesource.com/818867Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#523089}
-
Tobias Sargeant authored
NetworkSecurityPolicy.isCleartextTrafficPermitted can throw an IllegalArgumentException, which is uncaught and returned to native code, causing any WebView application that has declared a network security config to crash. Bug: 792482 Change-Id: Ide2c0293d7cebad68109a4af5bcea127c83ee96c Reviewed-on: https://chromium-review.googlesource.com/810969 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#523088}
-
Maxim Kolosovskiy authored
TBR=robertma@chromium.org Bug: 793792 Change-Id: I213dc2cee10082216585195392273db767804929 Reviewed-on: https://chromium-review.googlesource.com/819210 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#523087}
-
jdoerrie authored
This change introduces a U2F BLE connection abstraction. Given an device address it attempts to connect to the device, checking if expected services and characteristics are present. Furthermore it provides APIs to read from and write to the device. Bug: 763303 Change-Id: I586f0b2150d676959e119b0ce3c775b47a20c003 Reviewed-on: https://chromium-review.googlesource.com/774742 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523086}
-
Alex Clarke authored
For determinism Virtual Time needed to be blocked when the background parser was running on the background thread. That thread no longer exists (it now runs on the main thread) so we can remove the WebScopedVirtualTimePauser. Bug: 777763 Change-Id: I0c5f31fcb8c7dbd45ac922be831951143f1c48a9 Reviewed-on: https://chromium-review.googlesource.com/817747 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/a1d0f2731001..93e913442275 $ git log a1d0f2731..93e913442 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If747242a3af1d414bb2b1d4b7290114e3cfff4b0 Reviewed-on: https://chromium-review.googlesource.com/819030Reviewed-by:
-
Justin Cohen authored
Although the omnibox popup itself honors safe are in the table view, the width of the omnibox pop text can be too wide. This is a second attempt after crrev/d4774195 only accounted for RTL keyboards, not a full RTL layout. Bug: 787164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icd668c45ae32b8ff5520d1e54c85292d66c4c7ee Reviewed-on: https://chromium-review.googlesource.com/817383 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523083}
-
Christian Dullweber authored
Add a test to verify that events logged before sync is active will get stored and are synced later. Also change consent_auditor::ConsentAuditor::ConsentStatus to consent_auditor::ConsentStatus to remove some redundancy. Bug: 785912 Change-Id: I08f4b0f70f765be4391e91f036207d7465ed5830 Reviewed-on: https://chromium-review.googlesource.com/814094Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
-
Elad Alon authored
The function is not used; removing it and its unit-test. Bug: 793273 Change-Id: I9419ce7c25e0d319dd10ae5d2014d7c3da517c3d Reviewed-on: https://chromium-review.googlesource.com/817117Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#523081}
-
Guido Urdaneta authored
Suspect of making WebRTC Linux Tester bot fail almost reliably. First failure: https://build.chromium.org/deprecated/chromium.webrtc/builders/Linux%20Tester/builds/33590 Most recent failure: https://build.chromium.org/deprecated/chromium.webrtc/builders/Linux%20Tester/builds/33669 Will revert if this does not fix the bot. TBR=chfremer@chromium.org Bug: 721812 Change-Id: Ic819219a5b39ad66cce9a1cb9a426a3f2836c541 Reviewed-on: https://chromium-review.googlesource.com/817995Reviewed-by:
-
Christian Dullweber authored
Change the order of run_loop.Run() and run_loop.reset() to make it independent of whether a callback is executed synchronously or asynchronously. Change-Id: I6d9512e8a223c62f6198e57a0e9736f060b33f77 Reviewed-on: https://chromium-review.googlesource.com/785370Reviewed-by:
-
Becca Hughes authored
Add double tap gesture recognition to MediaControlOverlayPlayButton so it can detect double tap gestures on the side and jump accordingly. Adds LayoutTests as a virtual test suite so they are tested with the modern media controls flag on. This includes some updates to media-controls.js to harden the tests which previously failed. TBR=jbroman@chromium.org BUG=779989 Change-Id: Icc0a408993519537f522bcc62eb6893952165006 Reviewed-on: https://chromium-review.googlesource.com/813776 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#523078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aad7b4ad. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7427 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Id30ee1cec529d7d63b0fd6a440b9f053e9e4766c Reviewed-on: https://chromium-review.googlesource.com/818749 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Nicolas Dossou-gbete authored
The feature has been enable by default for months and has no live finch experiment associated. Bug: 786439 Change-Id: I0302b0f642681bf911dc7820e75f5a3a6f2500f7 Reviewed-on: https://chromium-review.googlesource.com/809044Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#523076}
-
Maxim Kolosovskiy authored
Examples of failed build https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65117 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65113 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65111 TBR=mstensho@chromium.org Bug: 788337 Change-Id: Ie848524cd39c333dd96ecc55db0d133791768d1f Reviewed-on: https://chromium-review.googlesource.com/817748 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
Bug: 792394 Change-Id: Ie5d044a4c7847c34223ee8c2f9471d78316f9511 Reviewed-on: https://chromium-review.googlesource.com/814435 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#523074}
-
Gauthier Ambard authored
This CL adds a shadow below the toolbar when the omnibox is full width. Bug: 793727 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I879a74f76d244a59d533196758e829f70004ef81 Reviewed-on: https://chromium-review.googlesource.com/817746Reviewed-by:
-
Gauthier Ambard authored
The escape key should close the recent tabs and the bookmarks modal display. Bug: 793281 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icc8df50f8cd8035b965a598361e1b785b688cc63 Reviewed-on: https://chromium-review.googlesource.com/817434Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523072}
-
Joel Hockey authored
Using a Factory to provide dedicated pipes for ColorChooser and ColorChooserClient. This removes the need for the identifier currently in use for ipcs. ColorChooserEnd messages have been replaced with connection error handlers, and each side can simply close the connection without explicitly sending EndColorChooser msgs. Replaced struct content::ColorSuggestion with content::mojom::ColorSuggestion in content/public/common. Bug: 788960 Change-Id: I436e277738bf0e37eda8bfa0fd7428aede015c43 Reviewed-on: https://chromium-review.googlesource.com/800350Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#523071}
-
Maxim Kolosovskiy authored
This reverts commit 7999f246. Reason for revert: components_unittests failures HistoryQuickProviderTest.DontTrimHttpSchemeIfInputHasScheme HistoryQuickProviderTest.DoTrimHttpsSchemeIfFlag HistoryQuickProviderTest.DontTrimHttpsScheme HistoryQuickProviderTest.DontTrimHttpsSchemeDespiteFlag HistoryQuickProviderTest.DontTrimHttpSchemeIfInputMatches HistoryQuickProviderTest.DoTrimHttpScheme first failed build https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65092 Original change's description: > [omnibox] Handle URL ellision a little more consistently > > When the option hide-suggestion-url-scheme is enabled, Omnibox > suggestions exclude the scheme in some cases where they would > be inconsistent with other suggestions. This change preserves > schemes when the user specified one. > > This change asserts 'preserve_scheme' to GetFormatTypes() now > if alternatively the input, interpretted as a URL, has a scheme. > This changes the treatment of http (and https when certain flags > are set.) Previously it was only asserted if there was a match > in the scheme. > > Added many tests as well. > > Bug: 761505 > Change-Id: I189ececbfad3baf8214e3f289e0c994d3cee9d55 > Reviewed-on: https://chromium-review.googlesource.com/794432 > Commit-Queue: Kevin Bailey <krb@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523003} TBR=mpearson@chromium.org,krb@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 761505 Change-Id: I2f7f3f747c45204bd4d7507f348cbd8141da41aa Reviewed-on: https://chromium-review.googlesource.com/817298Reviewed-by:
-
Rune Lillesveen authored
Anonymous inline wrappers for display:contents were mistakenly assumed to be anonymous table parts. Bug: 792439, 792946, 792550 Change-Id: Ib7017ff67a8658135d2e08c47f93966d5dbfa5bc Reviewed-on: https://chromium-review.googlesource.com/817564 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523069}
-
Mike West authored
Bug: 792412 Change-Id: Id805387dea88e18e71d21ca1e799d1076d0b2c5e Reviewed-on: https://chromium-review.googlesource.com/813835 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523068}
-
Gauthier Ambard authored
When opening a NTP a screenshot of the NTP is animated instead of the real NTP. The screenshot of the NTP is taken outside of the view hierarchy. This creates multiple problems: - The safe area insets have to be passed to the NTP before the snapshot is taken so it can adapt its layout. - The images of the elements in the NTP (Most Visited, suggestions...) are displayed asynchronously, so they are empty on the snapshot. In order to reduce the complexity on iPhone X and to have the images displayed, it is possible to display the real view instead of its snapshot. As side effects, the user can interact with the NTP during the animation and it is possible that it takes more computational ressources. Animation before this CL: https://drive.google.com/file/d/1ma2Q_fGsK3lRSCAL91MZ3mXCD_R_tYEn/view Animation with this CL: https://drive.google.com/file/d/1xHL2ANNPwtYEY0vffqVuCvEfhrVXl_4v/view Bug: 792918 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibeb74f9ca96130db49bcf082356b55e6cf8d4d9a Reviewed-on: https://chromium-review.googlesource.com/814295Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523067}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-webvtt-tc011-blank-lines.html 2. track-webvtt-tc013-settings.html 3. track-webvtt-tc014-alignment.html 4. track-webvtt-tc015-positioning.html Bug: 782555 Change-Id: Ie428584d1447fe22ceab45812ee72618fb92bad4 Reviewed-on: https://chromium-review.googlesource.com/818885Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523066}
-
