- 24 Sep, 2020 40 commits
-
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: If4bdef02e6b91446014916a4ec6ae51f97ae3cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425424Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810358}
-
Mason Freed authored
Quirks mode layout is slower, so change to no-quirks. Note that this goes against the spec [1], which mandates quirks mode for text documents. An issue [2] has been raised to change that, but in the meantime, this seems like a very low (compat) risk change. For now, however, the WPT test will not be changed, and a broken expectation will be committed. [1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#read-text [2] https://github.com/whatwg/html/issues/5939 Bug: 1131185 Change-Id: If7ac8cbe8b4ec277f2cb288d120698b9bacf773c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425109 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#810357}
-
Yury Khmel authored
This adds interface to request new metrics Example of usage: crrev.com/c/2426728 Payload implementation: ag/12668933 BUG=b:169211158 TEST=Locally in prototype Change-Id: If89cb8ba6e136ac0e1bb7f60b3e078b8624b3639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424587Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Auto-Submit: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#810356}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I280e5720d4eefb43ad5d87ac39f0ba21e1384f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810355}
-
Christopher Cameron authored
The new SharedImage path for VTVideoDecodeAccelerator needs to know whether or not it is on the passthrough decoder. Plumb this through. This is prerequisite to enabling SkiaRenderer on macOS. Bug: 1108909 Change-Id: I79d5f936cd5852ab33938e530fb739a5fb3f3045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427212Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#810354}
-
Peng Huang authored
SkiaRenderer SKP mode is not useful anymore, so remove it to make SkiaRenderer cleaner. For supporting SW compositing, we should be able to implement a new SkiaOutputSurface for it. Bug: 1130976 Change-Id: Id2faadfb9949101378da7e226245a6ffd2a640a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422255Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810353}
-
Yuki Shiino authored
base/allocator/allocator_shim_default_dispatch_to_mac_zoned_malloc.h is unused. Removes it. Change-Id: I26e88508c972b3912849269845ca873e838d3425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428289Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#810352}
-
Xianzhu Wang authored
Exclude LayoutText when calculating compositing reasons for SVG children. Bug: 1127611 Change-Id: Ie6564d78765ecf1afe00d9001982b0a839c1fb83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429389Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810351}
-
Siye Liu authored
The change to notify input method about type change in omnibox during CJK TIP[1] causes regression that switching to a new tab will change JPN TIP to English mode instead of Hiragana mode. The reason is that when input method is notified about the text input type change, Windows input service is also notified about the change. Therefore, the input mode is changed from hiragana mode to English mode in JPN TIP. We should only notify input service if the input type is changed to a different value. We should also use the cached input type to find the associated TSF document. [1]: I0266d9617277696ccb8bfa42ad76f9cbc3d802f3 fe7e213c Bug: 1108845 Bug: 1124612 Change-Id: I9ec643c7d2058695e8bc396d764ba598d6235b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392415Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810350}
-
Mason Freed authored
This is a fairly basic test that simply attaches 1000 open and closed declarative shadow roots. Bug: 1042130 Change-Id: I8185b2f7f283d8480647a07971812ef62adee1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422154 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810349}
-
Abigail Klein authored
VoiceOver bug. On MacOS 10.15, there is a Voiceover bug where the webpage reads automatically, even when the “Automatically speak the webpage” checkbox in Voiceover Utility isn’t checked. That checkbox is unchecked by default, so we should make Chrome have the best behavior for the default. VoiceOver in MacOS 11 (expected launch September/October) fixes that bug, but introduces many new bugs in both Chrome and Safari. We would like to fix 10.15 so that users do not need to upgrade to 11 if they do not want to. The fix: Do not fire any AXLoadComplete events in MacOS 10.15 only. For a longer explanation of this change, see this document: https://docs.google.com/document/d/19s6E0hjTyzB9XU44bdCpXNOaQ8c6nbLRnJbR1EsltL4/edit# Bug: 1049320 Change-Id: I48daf81da431d8965163fe99c7c448dc8f9403f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427070Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#810348}
-
Sammie Quon authored
Test: manual Bug: 1120132 Change-Id: I288ba34d7843dde8077a0c998d02d080b11e5412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426466 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810347}
-
Joe Downing authored
This flag is still useful (and relied on for several tests) so we don't want to remove it yet. We are working on a second version of the KeyboardLock spec which will allow callers to specify whether they want to capture system keyboard events. Once that spec is signed off, we plan to implement the feature and remove this flag. Change-Id: Ifd5d07c7643213eea3060deefe59659d3d0bcce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429144 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#810346}
-
David Van Cleve authored
ExpiryInspectingRecordExpiryDelegate uses Trust Tokens signed redemption records' associated token issuance verification keys in order to decide whether a given signed redemption record has expired. This is a little subtle, because signed redemption records *also* have associated public- key signatures, verified by "signed redemption record verification keys," which are distinct from SRRs' associated token issuance verification keys. For the most part, the comments in expiry_inspecting_record_expiry_delegate.{h,cc} go out of their way to make the distinction explicit, but there was a comment that mentioned the SRR's "verification key", rather than its associated token issuance verification key. This patch updates the comment in question to be clearer. Tbr: svaldez@chromium.org Change-Id: I87f45aa411c9c4462bf7fd4ce00a92ca41056daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429304Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#810345}
-
David Bertoni authored
These tests were disabled on on Window and/or Mac for being flaky. They passed 3000 iterations on the bots with no issues. Bug: 122154, 238733 Change-Id: I4aeeeddcee340837651105c6e703f4100790e6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411405Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810344}
-
Sophey Dong authored
This renames the mText field to mTextToShare, and mText is then used as the raw text field. This allows the Sharing Hub to use the shared text by itself. Bug: 1120093, 1130072 Change-Id: Ieb7972a4ec5b427f71ffacab79406d8fc63f86dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415210Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#810343}
-
Joe Downing authored
The existing policies specified a couple of owners but that is a bit fragile. A better way is to use the OWNERS file in the //remoting directory since we need to make sure it is kept up to date. Change-Id: Ia968c9833275e0a131e87b8c1e7d3e79605897f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427140Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#810342}
-
Lei Zhang authored
Give `Uri::Pim::kDefaultPorts` a local scope, by moving it inside Uri::Pim::GetDefaultPorts(). Then it is only initialized on first use instead on process startup. Bug: 537099 Change-Id: I66033ca86eb2182ae670351cd53869d988d04c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427034Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810341}
-
Josh Nohle authored
Returns the correct next expiration time for the stored public certificates. Because the expirations times were being persisted as a map using the certificate ID as the key, they were sorted by the ID and not the expiration time. We now sort by expiration time when retrieving from prefs. Changed the fake certificate IDs in the unit tests so tests will fail if the certificate are not sorted. Change-Id: Idd546c62939bd4bb4c62be405a3f8d9cec79de70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429287 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#810340}
-
Seokho Song authored
The custom scrollbar has been affected by pseudo-class :hover. However that in the internal popup was not affected :hover. In this change, Hover styles will be calculated using temporality declared CustomScrollbar. And that will be appended via AppendOwnerElementPseudoStyles function. Bug: 1076508 Change-Id: Ic57ca5c36b91b221bb3488292bfe2eb53b988ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418527Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Seokho Song <0xdevssh@gmail.com> Cr-Commit-Position: refs/heads/master@{#810339}
-
yjliu authored
Bug: 1116643 Change-Id: Ie50f656ef08645b53c0841b8efb77abe0fa4ba87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425105Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810338}
-
Sahir Vellani authored
Currently, the cursor/hover doesn't update after scroll or layout changes in an OOPIF, unless a subsequent mouse move is sent. Therefore, we should check to see whether the mouse hover state should be updated at BeginMainFrame. Bug: 1126198 Change-Id: I3bea312d0687a3b7f125eb35553ea58d3dda9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406669Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810337}
-
Justin Cohen authored
A bug in older versions of Xcode erroneously marked backgroundTimeRemaining as thread unsafe. This has been fixed in Xcode, so remove the workaround. Change-Id: I54e5cbe45a97e4081812e71ee86f4df0c36e8c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427630Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810336}
-
James Cook authored
We've recently introduced //chromeos/ui for lacros. I'd like to minimize the size of //ui/chromeos (or eliminate it) to reduce confusion. search_box is only used in ash, so move it there. This CL just moves the files, minimizing changes so that git's rename tracking will detect the rename. I'll fix the namespace in a followup. Bug: 1131641 Test: compiles Change-Id: Ic7cfaf06fb8b0d683ca7bd15986a01f0dd1d7733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429432Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#810335}
-
Adrian Taylor authored
Change-Id: I7b49ca07c6366964789fade31114762122b81c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314792Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#810334}
-
Becca Hughes authored
Adds a histogram that records the time it took to fetch the data from the server. BUG=1110373 Change-Id: Ib5a2af78ccd18929bb62571c3fa171c27808af1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425170Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810333}
-
Eric Orth authored
Move from DnsConfig into its own file in /net/dns/public/. Should remove all net-external dependency on DnsConfig. Also, while renaming all the SecureDnsMode references, take the opportunity to rename the values from MACRO_STYLE to kConstStyle as is more recently required by the Google C++ style guide. Bug: 1129993 Change-Id: I1d57bba9cd0e40908c500dcfa9c64365885f27b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418806Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#810332}
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the feature policy browser tests to: - Use the header to deny, rather than implicitly allow features in subframes, when that is the behavior being tested. - Use the allow attribute to explicitly allow feaures in subframes, when that is the behavior being tested. These updates will work both before and after the header behavior change. Bug: 1095641 Change-Id: I366f23d14f623c13cd9cd0ec130be70d034f6527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425004 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810331}
-
Adam Langley authored
Let's Encrypt have announced[1] a transition to new intermediates. This change adds these new intermediates to Tor's pinning set. [1] https://letsencrypt.org/2020/09/17/new-root-and-intermediates.html Change-Id: Ib6df959a4fea407eb0e379c507cb2a860ff943d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427555 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#810330}
-
Dan H authored
This reverts commit 2e94ca8d. Reason for revert: Failures on mac builder crbug.com/1132093 Original change's description: > Add accessibility alert event when DeepScanningDialogViews changes > > This allows a screen reader to read the updated text of the dialog. > > Bug: 1131565 > Change-Id: I73a2df8067ffc96148ebf5d50a9412cf34b67feb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424841 > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810290} TBR=rogerta@chromium.org,domfc@chromium.org Change-Id: I45a93a22d5f443bb254cc4909312aeecc9aee356 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429786Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#810329}
-
Alex Rudenko authored
Implementation for DOMListener::DidRemoveDocument was not consistent with DOMListener::DidAddDocument implementation and it is not actually used. This CL removes DOMListener::DidRemoveDocument for now to avoid confusion. A proper implementation would be needed if the feature is needed in the future. Bug: 1128371 Change-Id: I1a48a26705547e6a86c1c0520da72c549cd66af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416072Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810328}
-
Xiaoqian Dai authored
Bug: 1068018, 1131071 Change-Id: I4261a55eaf5ef4eae3e2ac6ff6402351a278836b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429824Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#810327}
-
Scott Lee authored
Chromium-deriver is a tool that parses the isolate output of a test run, and uploads the test results to ResultDB. Chromium-deriver is currently being used in chromium recipes to upload the test results of Swarming Tasks to ResultDB, and it has a hard-coded path for blink_web_tests. : https://source.chromium.org/chromium/infra/infra/+/master:go/src/go.chromium.org/luci/resultdb/internal/services/deriver/swarming.go;l=190-191 : https://source.chromium.org/chromium/infra/infra/+/master:go/src/go.chromium.org/luci/resultdb/internal/services/deriver/formats/json.go;l=357-359 This CL is to copy the same logic to test_result_sink.py so that run_web_tests.py with `rdb stream` will generate and upload the same test results that chromum-deriver uploads for blink_web_tests. R=robertma@chromium.org CC=chanli@chromium.org,iannucci@chromium.org,nodir@chromium.org Bug: 1108016 Change-Id: Ia31bf3435ca9fab70359c64d8485dcd2397c1c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425750Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810326}
-
Fabio Tirelo authored
The tests already exist on Desktop, but they are not enabled on Android. Adding them to prevent future regressions. Bug: 1131156 Change-Id: I44280eeb2542c0a6303f2bea09995742edd25cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424835Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#810325}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be75fbcca886..68a5baeb5ba0 2020-09-24 jmadill@chromium.org Revert "Vulkan: Implement a SharedResourceUse pool" 2020-09-24 syoussefi@chromium.org Vulkan: Support MSRTT depth/stencil resolve 2020-09-24 geofflang@chromium.org Add a Vulkan feature to compress float32 vertex formats. 2020-09-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ae8b33cdea62 to 8ab1c000aaa0 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I2b55bc6ca304f9df29faeddc97bd69b1215bb0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810324}
-
Kyle Horimoto authored
Bug: 1131819, 1131834 Change-Id: I08e4a82d5d6ec6b6def379888e439f60c2c8f87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428532 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810323}
-
Mike Pinkerton authored
Add cmd-{/} keyboard shortcuts to match Mac desktop, in addition to the commands that are already there. Additionally fix up the directionality to take RTL into account. BUG=988313 Change-Id: I9b8b69c30a85f0dbc9e38a5d8a6b72a97355d06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427422 Auto-Submit: Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810322}
-
Christopher Cameron authored
The ARM DTK does not specify a PCI device ID for the GPU. Do not fail in this configuration. Bug: 1121672 Change-Id: Idf2d35ed7ff15d43c300203160cec6a74a31d5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427567Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#810321}
-
Adam Langley authored
CTAP2 specifies that an authenticator's ECDH key is regenerated after a PIN error. This change makes the virtual authenticator mirror that. It also adds a test to ensure that we can work with a valid PIN after an invalid one is entered. (See linked bug.) BUG=1129713 Change-Id: I2473d674df4a72312f529ebb60826df4282e8392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418808Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#810320}
-
Kyle Williams authored
Populates an Observer List to be triggered by a Pending Service Request DBus Signal from the system CfmServiceContext service, providing access to chromium services and APIs. New mojoms are added for APIs which are tailored to the services that require them such as messaging_layer. Services are added to the primary cfm chromium mojom pending security reviews such as cros_healthd Note: The primary goal of this cl is to establish the correct directory structure for registering new services to the |CfmServiceContext|. Future projects requires dependencies on directories including but not limited to: * //chromium/src/services/video_capture/ * //chrome/browser/policy/messaging_layer/ * //chromeos/services/cros_healthd/ * etc. BUG=chromium:1105567, b:165864612 TEST='autoninja -C out/Default chromeos:chromeos_unittests \ && ./out/Default/chromeos_unittests --dbus-stub \ --single-process-tests --gtest_filter=CfmHotlineClientTest.*' Change-Id: Id0c687a88b126dc10975803020b1ec431af6ebaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419799Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#810319}
-